68052 2011-09-13 20:16:44 -0700 [CMAKE] Change wrong setting variables in FindPango.cmake 2011-09-15 01:06:58 -0700 1 1 1 Unclassified WebKit WebKit EFL 528+ (Nightly build) Unspecified Unspecified RESOLVED INVALID P2 Normal --- 1 gyuyoung.kim webkit-unassigned antognolli+webkit gyuyoung.kim lucas.de.marchi paroga rakuco webkit.review.bot oldest_to_newest 466794 0 gyuyoung.kim 2011-09-13 20:16:44 -0700 I think FindPango.cmake should have Pango_XXX setting variable instead of Freetype_xxx. 466795 1 107277 gyuyoung.kim 2011-09-13 20:17:32 -0700 Created attachment 107277 Proposed Patch 466796 2 107278 gyuyoung.kim 2011-09-13 20:18:53 -0700 Created attachment 107278 Modified Patch 466797 3 gyuyoung.kim 2011-09-13 20:19:34 -0700 CC'ing Patric and Rafael. 466798 4 webkit.review.bot 2011-09-13 20:20:36 -0700 Attachment 107277 did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'ChangeLog', u'Source/cmake/FindPango.cmake']" exit_code: 1 ChangeLog:1: ChangeLog entry has no bug number [changelog/bugnumber] [5] Total errors found: 1 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style. 466799 5 webkit.review.bot 2011-09-13 20:21:44 -0700 Attachment 107278 did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'ChangeLog', u'Source/cmake/FindPango.cmake']" exit_code: 1 ChangeLog:1: ChangeLog entry has no bug number [changelog/bugnumber] [5] Total errors found: 1 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style. 466801 6 107278 ryuan.choi 2011-09-13 20:29:41 -0700 Comment on attachment 107278 Modified Patch View in context: https://bugs.webkit.org/attachment.cgi?id=107278&action=review > ChangeLog:4 > + https://bugs.webkit.org/show_bug.cgi?id=xxxx It's because of xxxx 466829 7 107283 gyuyoung.kim 2011-09-13 21:51:35 -0700 Created attachment 107283 Modified Patch Oops. I fix it. 467004 8 rakuco 2011-09-14 06:59:59 -0700 I don't really understand this patch. Pango depends on Freetype, and line 11 actually looks for Freetype. Where are Pango_INCLUDE_DIRS and Pango_LIBRARIES set? 467702 9 gyuyoung.kim 2011-09-15 01:06:29 -0700 (In reply to comment #8) > I don't really understand this patch. Pango depends on Freetype, and line 11 actually looks for Freetype. Where are Pango_INCLUDE_DIRS and Pango_LIBRARIES set? Ah, I'm really sorry. There was misunderstanding. I will pay careful attention to submit patch further. 107277 2011-09-13 20:17:32 -0700 2011-09-13 20:18:53 -0700 Proposed Patch patch-setting-variable.patch text/plain 1272 gyuyoung.kim ZGlmZiAtLWdpdCBhL0NoYW5nZUxvZyBiL0NoYW5nZUxvZwppbmRleCAzZTJlYzAzLi41MmU5ZTVi IDEwMDY0NAotLS0gYS9DaGFuZ2VMb2cKKysrIGIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTQgQEAK KzIwMTEtMDktMTMgIEd5dXlvdW5nIEtpbSAgPGd5dXlvdW5nLmtpbUBzYW1zdW5nLmNvbT4KKwor ICAgICAgICBbQ01BS0VdIENoYW5nZSB3cm9uZyBzZXR0aW5nIHZhcmlhYmxlcyBpbiBGaW5kUGFu Z28uY21ha2UKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lk PXh4eHgKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBD aGFuZ2UgRnJlZXR5cGUgc2V0dGluZyB2YXJpYWJsZXMgd2l0aCBQYW5nbyBzZXR0aW5nIHZhcmlh YmxlcyBpbiBGaW5kUGFuZ28uY21ha2UuCisKKyAgICAgICAgKiBTb3VyY2UvY21ha2UvRmluZFBh bmdvLmNtYWtlOgorCiAyMDExLTA5LTEzICBFcmljIFNlaWRlbCAgPGVyaWNAd2Via2l0Lm9yZz4K IAogICAgICAgICBSZW1vdmUgRU5BQkxFX1NWR19GT1JFSUdOX09CSkVDVCBhcyBpdCBpcyBhIHJl cXVpcmVkIHBhcnQgb2YgSFRNTDUKZGlmZiAtLWdpdCBhL1NvdXJjZS9jbWFrZS9GaW5kUGFuZ28u Y21ha2UgYi9Tb3VyY2UvY21ha2UvRmluZFBhbmdvLmNtYWtlCmluZGV4IGM3MWYwNDEuLjc3Mjlh ZTEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9jbWFrZS9GaW5kUGFuZ28uY21ha2UKKysrIGIvU291cmNl L2NtYWtlL0ZpbmRQYW5nby5jbWFrZQpAQCAtNDAsNyArNDAsNyBAQCBmaW5kX2xpYnJhcnkoUGFu Z29fQ2Fpcm9fTElCUkFSWQogCiAjIFNldCB0aGUgaW5jbHVkZSBkaXIgdmFyaWFibGVzIGFuZCB0 aGUgbGlicmFyaWVzIGFuZCBsZXQgbGliZmluZF9wcm9jZXNzIGRvIHRoZSByZXN0LgogIyBOT1RF OiBTaW5ndWxhciB2YXJpYWJsZXMgZm9yIHRoaXMgbGlicmFyeSwgcGx1cmFsIGZvciBsaWJyYXJp ZXMgdGhpcyB0aGlzIGxpYiBkZXBlbmRzIG9uLgotc2V0KFBhbmdvX1BST0NFU1NfSU5DTFVERVMg UGFuZ29fSU5DTFVERV9ESVIgRnJlZXR5cGVfSU5DTFVERV9ESVJTKQotc2V0KFBhbmdvX1BST0NF U1NfTElCUyBQYW5nb19MSUJSQVJZIEZyZWV0eXBlX0xJQlJBUklFUykKK3NldChQYW5nb19QUk9D RVNTX0lOQ0xVREVTIFBhbmdvX0lOQ0xVREVfRElSIFBhbmdvX0lOQ0xJREVfRElSUykKK3NldChQ YW5nb19QUk9DRVNTX0xJQlMgUGFuZ29fTElCUkFSWSBQYW5nb19MSUJSQVJJRVMpCiBsaWJmaW5k X3Byb2Nlc3MoUGFuZ28pCiAK 107278 2011-09-13 20:18:53 -0700 2011-09-13 21:51:35 -0700 Modified Patch patch-setting-variable.patch text/plain 1272 gyuyoung.kim ZGlmZiAtLWdpdCBhL0NoYW5nZUxvZyBiL0NoYW5nZUxvZwppbmRleCAzZTJlYzAzLi41MmU5ZTVi IDEwMDY0NAotLS0gYS9DaGFuZ2VMb2cKKysrIGIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTQgQEAK KzIwMTEtMDktMTMgIEd5dXlvdW5nIEtpbSAgPGd5dXlvdW5nLmtpbUBzYW1zdW5nLmNvbT4KKwor ICAgICAgICBbQ01BS0VdIENoYW5nZSB3cm9uZyBzZXR0aW5nIHZhcmlhYmxlcyBpbiBGaW5kUGFu Z28uY21ha2UKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lk PXh4eHgKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBD aGFuZ2UgRnJlZXR5cGUgc2V0dGluZyB2YXJpYWJsZXMgd2l0aCBQYW5nbyBzZXR0aW5nIHZhcmlh YmxlcyBpbiBGaW5kUGFuZ28uY21ha2UuCisKKyAgICAgICAgKiBTb3VyY2UvY21ha2UvRmluZFBh bmdvLmNtYWtlOgorCiAyMDExLTA5LTEzICBFcmljIFNlaWRlbCAgPGVyaWNAd2Via2l0Lm9yZz4K IAogICAgICAgICBSZW1vdmUgRU5BQkxFX1NWR19GT1JFSUdOX09CSkVDVCBhcyBpdCBpcyBhIHJl cXVpcmVkIHBhcnQgb2YgSFRNTDUKZGlmZiAtLWdpdCBhL1NvdXJjZS9jbWFrZS9GaW5kUGFuZ28u Y21ha2UgYi9Tb3VyY2UvY21ha2UvRmluZFBhbmdvLmNtYWtlCmluZGV4IGM3MWYwNDEuLmNjYTQx OWUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9jbWFrZS9GaW5kUGFuZ28uY21ha2UKKysrIGIvU291cmNl L2NtYWtlL0ZpbmRQYW5nby5jbWFrZQpAQCAtNDAsNyArNDAsNyBAQCBmaW5kX2xpYnJhcnkoUGFu Z29fQ2Fpcm9fTElCUkFSWQogCiAjIFNldCB0aGUgaW5jbHVkZSBkaXIgdmFyaWFibGVzIGFuZCB0 aGUgbGlicmFyaWVzIGFuZCBsZXQgbGliZmluZF9wcm9jZXNzIGRvIHRoZSByZXN0LgogIyBOT1RF OiBTaW5ndWxhciB2YXJpYWJsZXMgZm9yIHRoaXMgbGlicmFyeSwgcGx1cmFsIGZvciBsaWJyYXJp ZXMgdGhpcyB0aGlzIGxpYiBkZXBlbmRzIG9uLgotc2V0KFBhbmdvX1BST0NFU1NfSU5DTFVERVMg UGFuZ29fSU5DTFVERV9ESVIgRnJlZXR5cGVfSU5DTFVERV9ESVJTKQotc2V0KFBhbmdvX1BST0NF U1NfTElCUyBQYW5nb19MSUJSQVJZIEZyZWV0eXBlX0xJQlJBUklFUykKK3NldChQYW5nb19QUk9D RVNTX0lOQ0xVREVTIFBhbmdvX0lOQ0xVREVfRElSIFBhbmdvX0lOQ0xVREVfRElSUykKK3NldChQ YW5nb19QUk9DRVNTX0xJQlMgUGFuZ29fTElCUkFSWSBQYW5nb19MSUJSQVJJRVMpCiBsaWJmaW5k X3Byb2Nlc3MoUGFuZ28pCiAK 107283 2011-09-13 21:51:35 -0700 2011-09-15 01:06:58 -0700 Modified Patch patch-setting-variable.patch text/plain 1273 gyuyoung.kim ZGlmZiAtLWdpdCBhL0NoYW5nZUxvZyBiL0NoYW5nZUxvZwppbmRleCAzZTJlYzAzLi44MzE0ODVl IDEwMDY0NAotLS0gYS9DaGFuZ2VMb2cKKysrIGIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTQgQEAK KzIwMTEtMDktMTMgIEd5dXlvdW5nIEtpbSAgPGd5dXlvdW5nLmtpbUBzYW1zdW5nLmNvbT4KKwor ICAgICAgICBbQ01BS0VdIENoYW5nZSB3cm9uZyBzZXR0aW5nIHZhcmlhYmxlcyBpbiBGaW5kUGFu Z28uY21ha2UKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lk PTY4MDUyCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAg Q2hhbmdlIEZyZWV0eXBlIHNldHRpbmcgdmFyaWFibGVzIHdpdGggUGFuZ28gc2V0dGluZyB2YXJp YWJsZXMgaW4gRmluZFBhbmdvLmNtYWtlLgorCisgICAgICAgICogU291cmNlL2NtYWtlL0ZpbmRQ YW5nby5jbWFrZToKKwogMjAxMS0wOS0xMyAgRXJpYyBTZWlkZWwgIDxlcmljQHdlYmtpdC5vcmc+ CiAKICAgICAgICAgUmVtb3ZlIEVOQUJMRV9TVkdfRk9SRUlHTl9PQkpFQ1QgYXMgaXQgaXMgYSBy ZXF1aXJlZCBwYXJ0IG9mIEhUTUw1CmRpZmYgLS1naXQgYS9Tb3VyY2UvY21ha2UvRmluZFBhbmdv LmNtYWtlIGIvU291cmNlL2NtYWtlL0ZpbmRQYW5nby5jbWFrZQppbmRleCBjNzFmMDQxLi5jY2E0 MTllIDEwMDY0NAotLS0gYS9Tb3VyY2UvY21ha2UvRmluZFBhbmdvLmNtYWtlCisrKyBiL1NvdXJj ZS9jbWFrZS9GaW5kUGFuZ28uY21ha2UKQEAgLTQwLDcgKzQwLDcgQEAgZmluZF9saWJyYXJ5KFBh bmdvX0NhaXJvX0xJQlJBUlkKIAogIyBTZXQgdGhlIGluY2x1ZGUgZGlyIHZhcmlhYmxlcyBhbmQg dGhlIGxpYnJhcmllcyBhbmQgbGV0IGxpYmZpbmRfcHJvY2VzcyBkbyB0aGUgcmVzdC4KICMgTk9U RTogU2luZ3VsYXIgdmFyaWFibGVzIGZvciB0aGlzIGxpYnJhcnksIHBsdXJhbCBmb3IgbGlicmFy aWVzIHRoaXMgdGhpcyBsaWIgZGVwZW5kcyBvbi4KLXNldChQYW5nb19QUk9DRVNTX0lOQ0xVREVT IFBhbmdvX0lOQ0xVREVfRElSIEZyZWV0eXBlX0lOQ0xVREVfRElSUykKLXNldChQYW5nb19QUk9D RVNTX0xJQlMgUGFuZ29fTElCUkFSWSBGcmVldHlwZV9MSUJSQVJJRVMpCitzZXQoUGFuZ29fUFJP Q0VTU19JTkNMVURFUyBQYW5nb19JTkNMVURFX0RJUiBQYW5nb19JTkNMVURFX0RJUlMpCitzZXQo UGFuZ29fUFJPQ0VTU19MSUJTIFBhbmdvX0xJQlJBUlkgUGFuZ29fTElCUkFSSUVTKQogbGliZmlu ZF9wcm9jZXNzKFBhbmdvKQogCg==