68024 2011-09-13 13:33:17 -0700 GTK DumpRenderTree uses inefficient idioms to iterate over G[S]Lists 2011-09-13 18:02:56 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 leandro leandro webkit.review.bot oldest_to_newest 466504 0 leandro 2011-09-13 13:33:17 -0700 GTK DumpRenderTree uses inefficient idioms to iterate over G[S]Lists 466515 1 107221 leandro 2011-09-13 13:45:59 -0700 Created attachment 107221 Patch 466657 2 107221 gustavo 2011-09-13 16:25:32 -0700 Comment on attachment 107221 Patch Yes, that was ugly! 466742 3 107221 webkit.review.bot 2011-09-13 18:02:52 -0700 Comment on attachment 107221 Patch Clearing flags on attachment: 107221 Committed r95062: <http://trac.webkit.org/changeset/95062> 466743 4 webkit.review.bot 2011-09-13 18:02:56 -0700 All reviewed patches have been landed. Closing bug. 107221 2011-09-13 13:45:59 -0700 2011-09-13 18:02:52 -0700 Patch bug-68024-20110913174557.patch text/plain 4913 leandro SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDk1MDQwKQorKysgVG9vbHMvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMg KzEsMjMgQEAKKzIwMTEtMDktMTMgIExlYW5kcm8gUGVyZWlyYSAgPGxlYW5kcm9AcHJvZnVzaW9u Lm1vYmk+CisKKyAgICAgICAgR1RLIER1bXBSZW5kZXJUcmVlIHVzZXMgaW5lZmZpY2llbnQgaWRp b21zIHRvIGl0ZXJhdGUgb3ZlciBHW1NdTGlzdHMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtp dC5vcmcvc2hvd19idWcuY2dpP2lkPTY4MDI0CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZ IChPT1BTISkuCisgICAgICAgIAorICAgICAgICBVc2luZyBnX2xpc3RfY291bnQoKSBhbmQgZ19s aXN0X250aF9kYXRhKCkgdG9nZXRoZXIgb24gYSBsb29wIGlzCisgICAgICAgIGlubmVmaWNpZW50 IHNpbmNlIHRoZXkncmUgYm90aCBPKG4pLiBJdGVyYXRlIG92ZXIgbGlzdHMgaW4gYSBzYW5lcgor ICAgICAgICB3YXkuCisKKyAgICAgICAgKiBEdW1wUmVuZGVyVHJlZS9ndGsvRHVtcFJlbmRlclRy ZWUuY3BwOgorICAgICAgICAoZHVtcEhpc3RvcnlJdGVtKTogUmVkdWNlIHRoZSBzY29wZSBmb3Ig dGhlICdraWRzJyB2YXJpYWJsZSwgYW5kCisgICAgICAgIGl0ZXJhdGUgb24gaXQgdXNpbmcgZ19s aXN0X25leHQoKS4gRnJlZSB0aGUgbGlzdCBhZnRlciBkb25lIHdpdGggaXQuCisgICAgICAgIChk dW1wQmFja0ZvcndhcmRMaXN0Rm9yV2ViVmlldyk6IEluc3RlYWQgb2YgYXBwZW5kaW5nICh3aGlj aCBpcworICAgICAgICBleHBlbnNpdmUgaW4gR0xpc3RzKSBoaXN0b3J5IGl0ZW1zIGFuZCB0aGVu IGl0ZXJhdGluZyBmcm9tIHRoZSB0YWlsCisgICAgICAgIG9mIHRoZSBpdGVtc1RvUHJpbnQgbGlz dCwgcHJlcGVuZCBpdGVtcyBhbmQgd2FsayBmb3J3YXJkcyBhcyB1c3VhbC4KKyAgICAgICAgKGR1 bXBCYWNrRm9yd2FyZExpc3RGb3JBbGxXZWJWaWV3cyk6IFdhbGsgdGhlIGxpc3QgaW4gYSBzYW5l ciB3YXksCisgICAgICAgIHJlbW92ZSB0aGUgKHVubmVlZGVkKSB2aWV3TGlzdCB2YXJpYWJsZS4K KwogMjAxMS0wOS0xMyAgRXJpYyBTZWlkZWwgIDxlcmljQHdlYmtpdC5vcmc+CiAKICAgICAgICAg UmVtb3ZlIEVOQUJMRV9TVkdfRk9SRUlHTl9PQkpFQ1QgYXMgaXQgaXMgYSByZXF1aXJlZCBwYXJ0 IG9mIEhUTUw1CkluZGV4OiBUb29scy9EdW1wUmVuZGVyVHJlZS9ndGsvRHVtcFJlbmRlclRyZWUu Y3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT0KLS0tIFRvb2xzL0R1bXBSZW5kZXJUcmVlL2d0ay9EdW1wUmVuZGVyVHJl ZS5jcHAJKHJldmlzaW9uIDk1MDM1KQorKysgVG9vbHMvRHVtcFJlbmRlclRyZWUvZ3RrL0R1bXBS ZW5kZXJUcmVlLmNwcAkod29ya2luZyBjb3B5KQpAQCAtMzMwLDEyICszMzAsMTUgQEAgc3RhdGlj IHZvaWQgZHVtcEhpc3RvcnlJdGVtKFdlYktpdFdlYkhpcwogICAgIGlmICh3ZWJraXRfd2ViX2hp c3RvcnlfaXRlbV9pc190YXJnZXRfaXRlbShpdGVtKSkKICAgICAgICAgcHJpbnRmKCIgICoqbmF2 IHRhcmdldCoqIik7CiAgICAgcHV0Y2hhcignXG4nKTsKLSAgICBHTGlzdCoga2lkcyA9IHdlYmtp dF93ZWJfaGlzdG9yeV9pdGVtX2dldF9jaGlsZHJlbihpdGVtKTsKLSAgICBpZiAoa2lkcykgewor CisgICAgaWYgKEdMaXN0KiBraWRzID0gd2Via2l0X3dlYl9oaXN0b3J5X2l0ZW1fZ2V0X2NoaWxk cmVuKGl0ZW0pKSB7CiAgICAgICAgIC8vIG11c3Qgc29ydCB0byBlbGltaW5hdGUgYXJiaXRyYXJ5 IHJlc3VsdCBvcmRlcmluZyB3aGljaCBkZWZlYXRzIHJlcHJvZHVjaWJsZSB0ZXN0aW5nCi0gICAg ICAgIGtpZHMgPSBnX2xpc3Rfc29ydChraWRzLCAoR0NvbXBhcmVGdW5jKSBjb21wYXJlSGlzdG9y eUl0ZW1zKTsKLSAgICAgICAgZm9yICh1bnNpZ25lZCBpID0gMDsgaSA8IGdfbGlzdF9sZW5ndGgo a2lkcyk7IGkrKykKLSAgICAgICAgICAgIGR1bXBIaXN0b3J5SXRlbShXRUJLSVRfV0VCX0hJU1RP UllfSVRFTShnX2xpc3RfbnRoX2RhdGEoa2lkcywgaSkpLCBpbmRlbnQrNCwgRkFMU0UpOworICAg ICAgICBmb3IgKEdMaXN0KiBraWQgPSBnX2xpc3Rfc29ydChraWRzLCAoR0NvbXBhcmVGdW5jKSBj b21wYXJlSGlzdG9yeUl0ZW1zKTsga2lkOyBraWQgPSBnX2xpc3RfbmV4dChraWQpKSB7CisgICAg ICAgICAgICBXZWJLaXRXZWJIaXN0b3J5SXRlbSogaXRlbSA9IFdFQktJVF9XRUJfSElTVE9SWV9J VEVNKGtpZC0+ZGF0YSk7CisgICAgICAgICAgICBkdW1wSGlzdG9yeUl0ZW0oaXRlbSwgaW5kZW50 ICsgNCwgRkFMU0UpOworICAgICAgICAgICAgZ19vYmplY3RfdW5yZWYoaXRlbSk7CisgICAgICAg IH0KKyAgICAgICAgZ19saXN0X2ZyZWUoa2lkcyk7CiAgICAgfQogICAgIGdfb2JqZWN0X3VucmVm KGl0ZW0pOwogfQpAQCAtMzU0LDI5ICszNTcsMjggQEAgc3RhdGljIHZvaWQgZHVtcEJhY2tGb3J3 YXJkTGlzdEZvcldlYlZpZQogICAgICAgICAvLyBzb21ldGhpbmcgaXMgd3JvbmcgaWYgdGhlIGl0 ZW0gZnJvbSB0aGUgbGFzdCB0ZXN0IGlzIGluIHRoZSBmb3J3YXJkIHBhcnQgb2YgdGhlIGIvZiBs aXN0CiAgICAgICAgIEFTU0VSVChpdGVtICE9IHByZXZUZXN0QkZJdGVtKTsKICAgICAgICAgZ19v YmplY3RfcmVmKGl0ZW0pOwotICAgICAgICBpdGVtc1RvUHJpbnQgPSBnX2xpc3RfYXBwZW5kKGl0 ZW1zVG9QcmludCwgaXRlbSk7CisgICAgICAgIGl0ZW1zVG9QcmludCA9IGdfbGlzdF9wcmVwZW5k KGl0ZW1zVG9QcmludCwgaXRlbSk7CiAgICAgfQogCiAgICAgV2ViS2l0V2ViSGlzdG9yeUl0ZW0q IGN1cnJlbnRJdGVtID0gd2Via2l0X3dlYl9iYWNrX2ZvcndhcmRfbGlzdF9nZXRfY3VycmVudF9p dGVtKGJmTGlzdCk7Ci0KICAgICBnX29iamVjdF9yZWYoY3VycmVudEl0ZW0pOwotICAgIGl0ZW1z VG9QcmludCA9IGdfbGlzdF9hcHBlbmQoaXRlbXNUb1ByaW50LCBjdXJyZW50SXRlbSk7CisgICAg aXRlbXNUb1ByaW50ID0gZ19saXN0X3ByZXBlbmQoaXRlbXNUb1ByaW50LCBjdXJyZW50SXRlbSk7 CiAKLSAgICBnaW50IGN1cnJlbnRJdGVtSW5kZXggPSBnX2xpc3RfbGVuZ3RoKGl0ZW1zVG9Qcmlu dCkgLSAxOwogICAgIGdpbnQgYmFja0xpc3RDb3VudCA9IHdlYmtpdF93ZWJfYmFja19mb3J3YXJk X2xpc3RfZ2V0X2JhY2tfbGVuZ3RoKGJmTGlzdCk7CiAgICAgZm9yIChpbnQgaSA9IC0xOyBpID49 IC0oYmFja0xpc3RDb3VudCk7IGktLSkgewogICAgICAgICBXZWJLaXRXZWJIaXN0b3J5SXRlbSog aXRlbSA9IHdlYmtpdF93ZWJfYmFja19mb3J3YXJkX2xpc3RfZ2V0X250aF9pdGVtKGJmTGlzdCwg aSk7CiAgICAgICAgIGlmIChpdGVtID09IHByZXZUZXN0QkZJdGVtKQogICAgICAgICAgICAgYnJl YWs7CiAgICAgICAgIGdfb2JqZWN0X3JlZihpdGVtKTsKLSAgICAgICAgaXRlbXNUb1ByaW50ID0g Z19saXN0X2FwcGVuZChpdGVtc1RvUHJpbnQsIGl0ZW0pOworICAgICAgICBpdGVtc1RvUHJpbnQg PSBnX2xpc3RfcHJlcGVuZChpdGVtc1RvUHJpbnQsIGl0ZW0pOwogICAgIH0KIAotICAgIGZvciAo aW50IGkgPSBnX2xpc3RfbGVuZ3RoKGl0ZW1zVG9QcmludCkgLSAxOyBpID49IDA7IGktLSkgewot ICAgICAgICBXZWJLaXRXZWJIaXN0b3J5SXRlbSogaXRlbSA9IFdFQktJVF9XRUJfSElTVE9SWV9J VEVNKGdfbGlzdF9udGhfZGF0YShpdGVtc1RvUHJpbnQsIGkpKTsKLSAgICAgICAgZHVtcEhpc3Rv cnlJdGVtKGl0ZW0sIGhpc3RvcnlJdGVtSW5kZW50LCBpID09IGN1cnJlbnRJdGVtSW5kZXgpOwor ICAgIGZvciAoR0xpc3QqIGl0ZW1Ub1ByaW50ID0gaXRlbXNUb1ByaW50OyBpdGVtVG9QcmludDsg aXRlbVRvUHJpbnQgPSBnX2xpc3RfbmV4dChpdGVtVG9QcmludCkpIHsKKyAgICAgICAgV2ViS2l0 V2ViSGlzdG9yeUl0ZW0qIGl0ZW0gPSBXRUJLSVRfV0VCX0hJU1RPUllfSVRFTShpdGVtVG9Qcmlu dC0+ZGF0YSk7CisgICAgICAgIGR1bXBIaXN0b3J5SXRlbShpdGVtLCBoaXN0b3J5SXRlbUluZGVu dCwgaXRlbSA9PSBjdXJyZW50SXRlbSk7CiAgICAgICAgIGdfb2JqZWN0X3VucmVmKGl0ZW0pOwog ICAgIH0KKwogICAgIGdfbGlzdF9mcmVlKGl0ZW1zVG9QcmludCk7CiAgICAgcHJpbnRmKCI9PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PVxuIik7CiB9CkBAIC0z ODcsOSArMzg5LDggQEAgc3RhdGljIHZvaWQgZHVtcEJhY2tGb3J3YXJkTGlzdEZvckFsbFdlYgog ICAgIGR1bXBCYWNrRm9yd2FyZExpc3RGb3JXZWJWaWV3KHdlYlZpZXcpOwogCiAgICAgLy8gVGhl IHZpZXcgbGlzdCBpcyBwcmVwZW5kZWQuIFJldmVyc2UgdGhlIGxpc3Qgc28gd2UgZ2V0IHRoZSBv cmRlciByaWdodC4KLSAgICBHU0xpc3QqIHZpZXdMaXN0ID0gZ19zbGlzdF9yZXZlcnNlKHdlYlZp ZXdMaXN0KTsKLSAgICBmb3IgKHVuc2lnbmVkIGkgPSAwOyBpIDwgZ19zbGlzdF9sZW5ndGgodmll d0xpc3QpOyArK2kpCi0gICAgICAgIGR1bXBCYWNrRm9yd2FyZExpc3RGb3JXZWJWaWV3KFdFQktJ VF9XRUJfVklFVyhnX3NsaXN0X250aF9kYXRhKHZpZXdMaXN0LCBpKSkpOworICAgIGZvciAoR1NM aXN0KiBjdXJyZW50VmlldyA9IGdfc2xpc3RfcmV2ZXJzZSh3ZWJWaWV3TGlzdCk7IGN1cnJlbnRW aWV3OyBjdXJyZW50VmlldyA9IGdfc2xpc3RfbmV4dChjdXJyZW50VmlldykpCisgICAgICAgIGR1 bXBCYWNrRm9yd2FyZExpc3RGb3JXZWJWaWV3KFdFQktJVF9XRUJfVklFVyhjdXJyZW50Vmlldy0+ ZGF0YSkpOwogfQogCiBzdGF0aWMgdm9pZCBpbnZhbGlkYXRlQW55UHJldmlvdXNXYWl0VG9EdW1w V2F0Y2hkb2coKQo=