<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>68012</bug_id>
          
          <creation_ts>2011-09-13 11:23:14 -0700</creation_ts>
          <short_desc>[meta] WebKit has too many #if defines, particularly ENABLE() macro usage</short_desc>
          <delta_ts>2011-10-18 10:21:31 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>WebCore Misc.</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          <dependson>68018</dependson>
    
    <dependson>68019</dependson>
    
    <dependson>68022</dependson>
    
    <dependson>68179</dependson>
    
    <dependson>68182</dependson>
    
    <dependson>68205</dependson>
    
    <dependson>68290</dependson>
    
    <dependson>68292</dependson>
    
    <dependson>68407</dependson>
    
    <dependson>68414</dependson>
    
    <dependson>68759</dependson>
    
    <dependson>68765</dependson>
    
    <dependson>68767</dependson>
    
    <dependson>68771</dependson>
    
    <dependson>68774</dependson>
    
    <dependson>68779</dependson>
    
    <dependson>69729</dependson>
    
    <dependson>70187</dependson>
    
    <dependson>70189</dependson>
    
    <dependson>70191</dependson>
    
    <dependson>70192</dependson>
    
    <dependson>70194</dependson>
    
    <dependson>70216</dependson>
    
    <dependson>70217</dependson>
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Eric Seidel (no email)">eric</reporter>
          <assigned_to name="Nobody">webkit-unassigned</assigned_to>
          <cc>abarth</cc>
    
    <cc>cmarcelo</cc>
    
    <cc>darin</cc>
    
    <cc>dbates</cc>
    
    <cc>dglazkov</cc>
    
    <cc>efidler</cc>
    
    <cc>jchaffraix</cc>
    
    <cc>laszlo.gombos</cc>
    
    <cc>mjs</cc>
    
    <cc>thakis</cc>
    
    <cc>tonikitoo</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>466407</commentid>
    <comment_count>0</comment_count>
    <who name="Eric Seidel (no email)">eric</who>
    <bug_when>2011-09-13 11:23:14 -0700</bug_when>
    <thetext>[meta] WebKit has too many #if defines, particularly ENABLE() macro usage

Here is a google Doc we&apos;ve been using for tracking:
https://docs.google.com/spreadsheet/ccc?key=0AlC4tS7Ao1fIdHFVNUpFSDBudEF5WGM3WDNzQjI3Ync&amp;authkey=CJCDiooK&amp;hl=en_US#gid=0</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>472778</commentid>
    <comment_count>1</comment_count>
    <who name="Adam Barth">abarth</who>
    <bug_when>2011-09-24 10:57:18 -0700</bug_when>
    <thetext>The spreadsheet is a bit hard to manage because it contains every ENABLE macro.  Here is a more focused document about just what we&apos;re planning to change in this round:

https://docs.google.com/document/d/1MVbOTYkZxTj071-ZQI7Lsh7CdZJhS2_1OdU4bjYuaKA/edit?hl=en_US

Everyone should be able to comment.  If you&apos;d like edit access, please let me know.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>486138</commentid>
    <comment_count>2</comment_count>
    <who name="Adam Barth">abarth</who>
    <bug_when>2011-10-18 10:21:31 -0700</bug_when>
    <thetext>Obviously there&apos;s still more we can do here, but we&apos;ve made a lot of progress.  I&apos;ll send a summary email to webkit-dev.</thetext>
  </long_desc>
      
      

    </bug>

</bugzilla>