68004 2011-09-13 07:57:15 -0700 Python version check is confusing in test-webkitpy 2011-09-15 17:38:44 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 webkit.review.bot tomz abarth tomz oldest_to_newest 466293 0 webkit.review.bot 2011-09-13 07:57:15 -0700 Python version check is backwards in test-webkitpy Requested by tomz on #webkit. 466362 1 107189 tomz 2011-09-13 10:12:25 -0700 Created attachment 107189 Patch 466491 2 107189 eric 2011-09-13 13:08:43 -0700 Comment on attachment 107189 Patch Well, we could check both. But it was intentionally written this way. Anytime you run test-webkitpy with 2.6, you might break machines which only have 2.5 (which is the minimum we require). 466502 3 tomz 2011-09-13 13:29:54 -0700 I don't understand. Why would my having 2.6 on my machine and testing with it have any effect on a different machine with 2.5? Are you saying that you'd expect 2.6 to fail and that we actually require *exactly* v2.5? Is the fear that if I did get a failure I might rebaseline with 2.6 and thus break 2.5? 466505 4 abarth 2011-09-13 13:34:20 -0700 We added this check because we often develop with 2.6 and use a feature that doesn't work in 2.5. When we committed the code, we broke 2.5. Ideally, we should run the tests both in 2.5 and in 2.6. In practice, 2.6 is backwards compatibile with 2.5, so testing in 2.5 is usually sufficient. 466568 5 107235 tomz 2011-09-13 14:51:35 -0700 Created attachment 107235 Patch 466574 6 107235 abarth 2011-09-13 14:54:54 -0700 Comment on attachment 107235 Patch Looks great. Thanks! 468180 7 107235 webkit.review.bot 2011-09-15 17:38:40 -0700 Comment on attachment 107235 Patch Clearing flags on attachment: 107235 Committed r95247: <http://trac.webkit.org/changeset/95247> 468181 8 webkit.review.bot 2011-09-15 17:38:44 -0700 All reviewed patches have been landed. Closing bug. 107189 2011-09-13 10:12:25 -0700 2011-09-13 14:51:31 -0700 Patch bug-68004-20110913101224.patch text/plain 1487 tomz U3VidmVyc2lvbiBSZXZpc2lvbjogOTQ5ODYKZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBi L1Rvb2xzL0NoYW5nZUxvZwppbmRleCA0NTE5MzM4YTdiZmIyZDg3MTY3ZThmMGNhNmJiNDE3YzFm OWVlMWIxLi43ZWU3YmQ3MmViOTM5NGZlOTg3NTFlMjJkMmQ1ZWFiYjc1ZGU1YjQ5IDEwMDY0NAot LS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIvVG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTIg QEAKKzIwMTEtMDktMTMgIFRvbSBaYWtyYWpzZWsgIDx0b216QGNvZGVhdXJvcmEub3JnPgorCisg ICAgICAgIFB5dGhvbiB2ZXJzaW9uIGNoZWNrIGlzIGJhY2t3YXJkcyBpbiB0ZXN0LXdlYmtpdHB5 CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD02ODAwNAor CisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogU2NyaXB0 cy90ZXN0LXdlYmtpdHB5OgorCiAyMDExLTA5LTEyICBTaGVyaWZmIEJvdCAgPHdlYmtpdC5yZXZp ZXcuYm90QGdtYWlsLmNvbT4KIAogICAgICAgICBVbnJldmlld2VkLCByb2xsaW5nIG91dCByOTQ5 NzYuCmRpZmYgLS1naXQgYS9Ub29scy9TY3JpcHRzL3Rlc3Qtd2Via2l0cHkgYi9Ub29scy9TY3Jp cHRzL3Rlc3Qtd2Via2l0cHkKaW5kZXggN2MxMWU4NTk5OGQzMmIwMzk1Y2NmODEyOGQxZGExY2Ux ZmQ3ZmViOC4uMTQ3NDEwMzNlNDI2ODc3NjZlOTJmOGM1OTUyODM5MGFkYWQxOTEzYiAxMDA3NTUK LS0tIGEvVG9vbHMvU2NyaXB0cy90ZXN0LXdlYmtpdHB5CisrKyBiL1Rvb2xzL1NjcmlwdHMvdGVz dC13ZWJraXRweQpAQCAtMjE5LDEwICsyMTksMTAgQEAgZGVmIGluaXQoY29tbWFuZF9hcmdzLCBl eHRlcm5hbF9wYWNrYWdlX3BhdGhzKToKICAgICAoY29tcGFyaXNvbiwgY3VycmVudF92ZXJzaW9u LCBtaW5pbXVtX3ZlcnNpb24pID0gXAogICAgICAgICB2ZXJzaW9uaW5nLmNvbXBhcmVfdmVyc2lv bigpCiAKLSAgICBpZiBjb21wYXJpc29uID4gMDoKLSAgICAgICAgIyBUaGVuIHRoZSBjdXJyZW50 IHZlcnNpb24gaXMgbGF0ZXIgdGhhbiB0aGUgbWluaW11bSB2ZXJzaW9uLgorICAgIGlmIGNvbXBh cmlzb24gPCAwOgorICAgICAgICAjIFRoZW4gdGhlIGN1cnJlbnQgdmVyc2lvbiBpcyBvbGRlciB0 aGFuIHRoZSBtaW5pbXVtIHZlcnNpb24uCiAgICAgICAgIG1lc3NhZ2UgPSAoIllvdSBhcmUgdGVz dGluZyB3ZWJraXRweSB3aXRoIGEgUHl0aG9uIHZlcnNpb24gKCVzKSAiCi0gICAgICAgICAgICAg ICAgICAgImhpZ2hlciB0aGFuIHRoZSBtaW5pbXVtIHZlcnNpb24gKCVzKSBpdCB3YXMgbWVhbnQg IgorICAgICAgICAgICAgICAgICAgICJvbGRlciB0aGFuIHRoZSBtaW5pbXVtIHZlcnNpb24gKCVz KSBpdCB3YXMgbWVhbnQgIgogICAgICAgICAgICAgICAgICAgICJ0byBzdXBwb3J0LiIgJSAoY3Vy cmVudF92ZXJzaW9uLCBtaW5pbXVtX3ZlcnNpb24pKQogICAgICAgICBfbG9nLndhcm4obWVzc2Fn ZSkKIAo= 107235 2011-09-13 14:51:35 -0700 2011-09-15 17:38:40 -0700 Patch bug-68004-20110913145133.patch text/plain 1940 tomz U3VidmVyc2lvbiBSZXZpc2lvbjogOTQ5ODYKZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBi L1Rvb2xzL0NoYW5nZUxvZwppbmRleCA0NTE5MzM4YTdiZmIyZDg3MTY3ZThmMGNhNmJiNDE3YzFm OWVlMWIxLi41NTlmNTI2MmRiYmZkYzdiNDg0ZjFkODNmYTEzYmYwOGVhMmFlNjM2IDEwMDY0NAot LS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIvVG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTIg QEAKKzIwMTEtMDktMTMgIFRvbSBaYWtyYWpzZWsgIDx0b216QGNvZGVhdXJvcmEub3JnPgorCisg ICAgICAgIFB5dGhvbiB2ZXJzaW9uIGNoZWNrIGlzIGNvbmZ1c2luZyBpbiB0ZXN0LXdlYmtpdHB5 CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD02ODAwNAor CisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogU2NyaXB0 cy90ZXN0LXdlYmtpdHB5OgorCiAyMDExLTA5LTEyICBTaGVyaWZmIEJvdCAgPHdlYmtpdC5yZXZp ZXcuYm90QGdtYWlsLmNvbT4KIAogICAgICAgICBVbnJldmlld2VkLCByb2xsaW5nIG91dCByOTQ5 NzYuCmRpZmYgLS1naXQgYS9Ub29scy9TY3JpcHRzL3Rlc3Qtd2Via2l0cHkgYi9Ub29scy9TY3Jp cHRzL3Rlc3Qtd2Via2l0cHkKaW5kZXggN2MxMWU4NTk5OGQzMmIwMzk1Y2NmODEyOGQxZGExY2Ux ZmQ3ZmViOC4uMDgzZmI3NzllYzA5MWNiNGZmNzI3ZDMxMGY5NjAyMmIxMGY5Yzk0NSAxMDA3NTUK LS0tIGEvVG9vbHMvU2NyaXB0cy90ZXN0LXdlYmtpdHB5CisrKyBiL1Rvb2xzL1NjcmlwdHMvdGVz dC13ZWJraXRweQpAQCAtMjE2LDE3ICsyMTYsMTYgQEAgZGVmIGluaXQoY29tbWFuZF9hcmdzLCBl eHRlcm5hbF9wYWNrYWdlX3BhdGhzKToKIAogICAgIHZlcnNpb25pbmcuY2hlY2tfdmVyc2lvbihs b2c9X2xvZykKIAotICAgIChjb21wYXJpc29uLCBjdXJyZW50X3ZlcnNpb24sIG1pbmltdW1fdmVy c2lvbikgPSBcCisgICAgKGNvbXBhcmlzb24sIGN1cnJlbnRfdmVyc2lvbiwgZXhwZWN0ZWRfdmVy c2lvbikgPSBcCiAgICAgICAgIHZlcnNpb25pbmcuY29tcGFyZV92ZXJzaW9uKCkKIAotICAgIGlm IGNvbXBhcmlzb24gPiAwOgotICAgICAgICAjIFRoZW4gdGhlIGN1cnJlbnQgdmVyc2lvbiBpcyBs YXRlciB0aGFuIHRoZSBtaW5pbXVtIHZlcnNpb24uCi0gICAgICAgIG1lc3NhZ2UgPSAoIllvdSBh cmUgdGVzdGluZyB3ZWJraXRweSB3aXRoIGEgUHl0aG9uIHZlcnNpb24gKCVzKSAiCi0gICAgICAg ICAgICAgICAgICAgImhpZ2hlciB0aGFuIHRoZSBtaW5pbXVtIHZlcnNpb24gKCVzKSBpdCB3YXMg bWVhbnQgIgotICAgICAgICAgICAgICAgICAgICJ0byBzdXBwb3J0LiIgJSAoY3VycmVudF92ZXJz aW9uLCBtaW5pbXVtX3ZlcnNpb24pKQorICAgIGlmIGNvbXBhcmlzb24gIT0gMDoKKyAgICAgICAg IyBUaGVuIHRoZSBjdXJyZW50IHZlcnNpb24gaXMgbm90IHdoYXQgd2UgZXhwZWN0LgorICAgICAg ICBtZXNzYWdlID0gKCJZb3UgYXJlIHRlc3Rpbmcgd2Via2l0cHkgd2l0aCBQeXRob24gdmVyc2lv biAoJXMpICIKKyAgICAgICAgICAgICAgICAgICAiaW5zdGVhZCBvZiB2ZXJzaW9uICglcykgd2hp Y2ggd2Ugc3VwcG9ydC4gIFBsZWFzZSB2ZXJpZnkgIgorICAgICAgICAgICAgICAgICAgICJjaGFu Z2VzIGFnYWluc3QgdmVyc2lvbiAoJXMpIiAlIChjdXJyZW50X3ZlcnNpb24sIGV4cGVjdGVkX3Zl cnNpb24sIGV4cGVjdGVkX3ZlcnNpb24pKQogICAgICAgICBfbG9nLndhcm4obWVzc2FnZSkKIAot CiBkZWYgX3BhdGhfZnJvbV93ZWJraXRfcm9vdCgqY29tcG9uZW50cyk6CiAgICAgd2Via2l0X3Jv b3QgPSBvcy5wYXRoLmRpcm5hbWUob3MucGF0aC5kaXJuYW1lKG9zLnBhdGguZGlybmFtZShfX2Zp bGVfXykpKQogICAgIHJldHVybiBvcy5wYXRoLmpvaW4od2Via2l0X3Jvb3QsICpjb21wb25lbnRz KQo=