68000 2011-09-13 06:46:58 -0700 WebCore.gypi references moved file FontGtk.cpp 2011-09-13 14:13:22 -0700 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 0 erikwright webkit-unassigned webkit.review.bot oldest_to_newest 466264 0 erikwright 2011-09-13 06:46:58 -0700 While updating a Chromium working directory I encountered the following errors: --------- S:\src\chromium\src>gclient sync ... ________ running 'svn update S:\src\chromium\src\third_party\WebKit\Source --rev ision 94949 --force --ignore-externals' in 'S:\src\chromium' At revision 94949. ... Enabled Psyco JIT. Updating projects from gyp files... Error: Missing input file src\chrome\browser\policy\configuration_policy_store_interface.h Error: Missing input file src\third_party\WebKit\Source\WebCore\WebCore.gyp\..\platform\graphics\gtk\FontGtk.cpp Error: Missing input file src\third_party\WebKit\Source\WebCore\WebCore.gyp\..\platform\graphics\gtk\FontGtk.cpp Error: Missing input file src\third_party\WebKit\Source\WebCore\WebCore.gyp\..\platform\graphics\gtk\FontGtk.cpp Error: Missing input file src\third_party\WebKit\Source\WebCore\WebCore.gyp\..\platform\graphics\gtk\FontGtk.cpp S:\src\chromium\src>gclient sync --------- In revision 94874 the file was renamed: --------- r94874 | commit-queue@webkit.org | 2011-09-09 17:40:04 -0400 (Fri, 09 Sep 2011) | 13 lines Changed paths: M /trunk/Source/WebCore/ChangeLog M /trunk/Source/WebCore/GNUmakefile.list.am D /trunk/Source/WebCore/platform/graphics/gtk/FontGtk.cpp A /trunk/Source/WebCore/platform/graphics/pango/FontPango.cpp (from /trunk/Source/WebCore/platform/graphics/gtk/FontGtk.cpp:94873) Rename FontGtk.cpp to FontPango.cpp --------- But as of now /trunk/Source/WebCore/WebCore.gypi still references the file. It's simple to remove the stale reference but not as clear whether the new file should be added. 466269 1 erikwright 2011-09-13 06:54:50 -0700 The change to GNUMakefiles.list.am adds FontPango.cpp to webcoregtk if Pango is enabled. The other files that depend on Pango are included in WebCore.gypi (in webcore_files list) as are the other files unconditionally included in webcoregtk. Therefore I infer that it is correct that FontPango.cpp be included in the webcore_files list in WebCore.gypi 466287 2 107175 erikwright 2011-09-13 07:40:48 -0700 Created attachment 107175 Patch 466292 3 107177 erikwright 2011-09-13 07:52:02 -0700 Created attachment 107177 Patch 466326 4 107177 webkit.review.bot 2011-09-13 09:22:55 -0700 Comment on attachment 107177 Patch Clearing flags on attachment: 107177 Committed r95029: <http://trac.webkit.org/changeset/95029> 466327 5 webkit.review.bot 2011-09-13 09:22:59 -0700 All reviewed patches have been landed. Closing bug. 107175 2011-09-13 07:40:48 -0700 2011-09-13 07:51:55 -0700 Patch bug-68000-20110913104046.patch text/plain 1825 erikwright SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDk1MDI1KQorKysgU291cmNlL1dlYkNvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTQgQEAKKzIwMTEtMDktMTMgIEVyaWsgV3Jp Z2h0ICA8ZXJpa3dyaWdodEBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgcGxhdGZvcm0vZ3JhcGhp Y3MvZ3RrL0ZvbnRHdGsuY3BwIHdhcyByZW5hbWVkIHRvIHBsYXRmb3JtL2dyYXBoaWNzL3Bhbmdv L0ZvbnRQYW5nby5jcHAgLiBSZWZsZWN0IHRoaXMgY2hhbmdlIGluIFdlYkNvcmUuZ3lwaSB0byBm aXggYSBDaHJvbWl1bSBidWlsZCBicmVha2FnZS4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtp dC5vcmcvc2hvd19idWcuY2dpP2lkPTY4MDAwCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZ IChPT1BTISkuCisKKyAgICAgICAgTm8gY2hhbmdlIGluIGZ1bmN0aW9uYWxpdHksIHRodXMgbm8g bmV3IHRlc3RzLgorCisgICAgICAgICogV2ViQ29yZS5neXBpOgorCiAyMDExLTA5LTEzICBZdXRh IEtpdGFtdXJhICA8eXV0YWtAY2hyb21pdW0ub3JnPgogCiAgICAgICAgIFRocmVhZGFibGVXZWJT b2NrZXRDaGFubmVsQ2xpZW50V3JhcHBlciBzaG91bGRuJ3QgaGF2ZSBhIFN0cmluZyBpbiBpdC4K SW5kZXg6IFNvdXJjZS9XZWJDb3JlL1dlYkNvcmUuZ3lwaQo9PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2Uv V2ViQ29yZS9XZWJDb3JlLmd5cGkJKHJldmlzaW9uIDk1MDI1KQorKysgU291cmNlL1dlYkNvcmUv V2ViQ29yZS5neXBpCSh3b3JraW5nIGNvcHkpCkBAIC0zNjcxLDcgKzM2NzEsNiBAQAogICAgICAg ICAgICAgJ3BsYXRmb3JtL2dyYXBoaWNzL2dzdHJlYW1lci9XZWJLaXRXZWJTb3VyY2VHU3RyZWFt ZXIuY3BwJywKICAgICAgICAgICAgICdwbGF0Zm9ybS9ncmFwaGljcy9nc3RyZWFtZXIvV2ViS2l0 V2ViU291cmNlR1N0cmVhbWVyLmgnLAogICAgICAgICAgICAgJ3BsYXRmb3JtL2dyYXBoaWNzL2d0 ay9Db2xvckd0ay5jcHAnLAotICAgICAgICAgICAgJ3BsYXRmb3JtL2dyYXBoaWNzL2d0ay9Gb250 R3RrLmNwcCcsCiAgICAgICAgICAgICAncGxhdGZvcm0vZ3JhcGhpY3MvZ3RrL0dka0NhaXJvVXRp bGl0aWVzLmNwcCcsCiAgICAgICAgICAgICAncGxhdGZvcm0vZ3JhcGhpY3MvZ3RrL0dka0NhaXJv VXRpbGl0aWVzLmgnLAogICAgICAgICAgICAgJ3BsYXRmb3JtL2dyYXBoaWNzL2d0ay9JY29uR3Rr LmNwcCcsCkBAIC0zNzYxLDYgKzM3NjAsNyBAQAogICAgICAgICAgICAgJ3BsYXRmb3JtL2dyYXBo aWNzL29wZW52Zy9WR1V0aWxzLmgnLAogICAgICAgICAgICAgJ3BsYXRmb3JtL2dyYXBoaWNzL3Bh bmdvL0ZvbnRDYWNoZVBhbmdvLmNwcCcsCiAgICAgICAgICAgICAncGxhdGZvcm0vZ3JhcGhpY3Mv cGFuZ28vRm9udEN1c3RvbVBsYXRmb3JtRGF0YVBhbmdvLmNwcCcsCisgICAgICAgICAgICAncGxh dGZvcm0vZ3JhcGhpY3MvcGFuZ28vRm9udFBhbmdvLmNwcCcsCiAgICAgICAgICAgICAncGxhdGZv cm0vZ3JhcGhpY3MvcGFuZ28vRm9udFBsYXRmb3JtRGF0YS5oJywKICAgICAgICAgICAgICdwbGF0 Zm9ybS9ncmFwaGljcy9wYW5nby9Gb250UGxhdGZvcm1EYXRhUGFuZ28uY3BwJywKICAgICAgICAg ICAgICdwbGF0Zm9ybS9ncmFwaGljcy9wYW5nby9HbHlwaFBhZ2VUcmVlTm9kZVBhbmdvLmNwcCcs Cg== 107177 2011-09-13 07:52:02 -0700 2011-09-13 09:22:55 -0700 Patch bug-68000-20110913105200.patch text/plain 1825 erikwright SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDk1MDI1KQorKysgU291cmNlL1dlYkNvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTQgQEAKKzIwMTEtMDktMTMgIEVyaWsgV3Jp Z2h0ICA8ZXJpa3dyaWdodEBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgcGxhdGZvcm0vZ3JhcGhp Y3MvZ3RrL0ZvbnRHdGsuY3BwIHdhcyByZW5hbWVkIHRvIHBsYXRmb3JtL2dyYXBoaWNzL3Bhbmdv L0ZvbnRQYW5nby5jcHAgLiBSZWZsZWN0IHRoaXMgY2hhbmdlIGluIFdlYkNvcmUuZ3lwaSB0byBm aXggYSBDaHJvbWl1bSBidWlsZCBicmVha2FnZS4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtp dC5vcmcvc2hvd19idWcuY2dpP2lkPTY4MDAwCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZ IChPT1BTISkuCisKKyAgICAgICAgTm8gY2hhbmdlIGluIGZ1bmN0aW9uYWxpdHksIHRodXMgbm8g bmV3IHRlc3RzLgorCisgICAgICAgICogV2ViQ29yZS5neXBpOgorCiAyMDExLTA5LTEzICBZdXRh IEtpdGFtdXJhICA8eXV0YWtAY2hyb21pdW0ub3JnPgogCiAgICAgICAgIFRocmVhZGFibGVXZWJT b2NrZXRDaGFubmVsQ2xpZW50V3JhcHBlciBzaG91bGRuJ3QgaGF2ZSBhIFN0cmluZyBpbiBpdC4K SW5kZXg6IFNvdXJjZS9XZWJDb3JlL1dlYkNvcmUuZ3lwaQo9PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2Uv V2ViQ29yZS9XZWJDb3JlLmd5cGkJKHJldmlzaW9uIDk1MDI1KQorKysgU291cmNlL1dlYkNvcmUv V2ViQ29yZS5neXBpCSh3b3JraW5nIGNvcHkpCkBAIC0zNjcxLDcgKzM2NzEsNiBAQAogICAgICAg ICAgICAgJ3BsYXRmb3JtL2dyYXBoaWNzL2dzdHJlYW1lci9XZWJLaXRXZWJTb3VyY2VHU3RyZWFt ZXIuY3BwJywKICAgICAgICAgICAgICdwbGF0Zm9ybS9ncmFwaGljcy9nc3RyZWFtZXIvV2ViS2l0 V2ViU291cmNlR1N0cmVhbWVyLmgnLAogICAgICAgICAgICAgJ3BsYXRmb3JtL2dyYXBoaWNzL2d0 ay9Db2xvckd0ay5jcHAnLAotICAgICAgICAgICAgJ3BsYXRmb3JtL2dyYXBoaWNzL2d0ay9Gb250 R3RrLmNwcCcsCiAgICAgICAgICAgICAncGxhdGZvcm0vZ3JhcGhpY3MvZ3RrL0dka0NhaXJvVXRp bGl0aWVzLmNwcCcsCiAgICAgICAgICAgICAncGxhdGZvcm0vZ3JhcGhpY3MvZ3RrL0dka0NhaXJv VXRpbGl0aWVzLmgnLAogICAgICAgICAgICAgJ3BsYXRmb3JtL2dyYXBoaWNzL2d0ay9JY29uR3Rr LmNwcCcsCkBAIC0zNzYxLDYgKzM3NjAsNyBAQAogICAgICAgICAgICAgJ3BsYXRmb3JtL2dyYXBo aWNzL29wZW52Zy9WR1V0aWxzLmgnLAogICAgICAgICAgICAgJ3BsYXRmb3JtL2dyYXBoaWNzL3Bh bmdvL0ZvbnRDYWNoZVBhbmdvLmNwcCcsCiAgICAgICAgICAgICAncGxhdGZvcm0vZ3JhcGhpY3Mv cGFuZ28vRm9udEN1c3RvbVBsYXRmb3JtRGF0YVBhbmdvLmNwcCcsCisgICAgICAgICAgICAncGxh dGZvcm0vZ3JhcGhpY3MvcGFuZ28vRm9udFBhbmdvLmNwcCcsCiAgICAgICAgICAgICAncGxhdGZv cm0vZ3JhcGhpY3MvcGFuZ28vRm9udFBsYXRmb3JtRGF0YS5oJywKICAgICAgICAgICAgICdwbGF0 Zm9ybS9ncmFwaGljcy9wYW5nby9Gb250UGxhdGZvcm1EYXRhUGFuZ28uY3BwJywKICAgICAgICAg ICAgICdwbGF0Zm9ybS9ncmFwaGljcy9wYW5nby9HbHlwaFBhZ2VUcmVlTm9kZVBhbmdvLmNwcCcs Cg==