67998 2011-09-13 05:31:32 -0700 [chromium] line gap is added twice in SimpleFontData::platformInit 2012-04-13 15:06:46 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Linux RESOLVED DUPLICATE 83279 P2 Normal --- 0 robin.webkit webkit-unassigned dglazkov efidler evan jamesr robin.webkit oldest_to_newest 466244 0 robin.webkit 2011-09-13 05:31:32 -0700 Line gap can be added twice in certain code path, which causes layout issues for fonts with large line gap values. Please see SimpleFontData::platformInit() in Source/WebCore/platform/graphics/chromium/SimpleFontDataLinux.cpp 466245 1 robin.webkit 2011-09-13 05:33:24 -0700 The patch will look like this: --- a/Source/WebCore/platform/graphics/blackberry/skia/SimpleFontDataBlackBerry.cpp +++ b/Source/WebCore/platform/graphics/blackberry/skia/SimpleFontDataBlackBerry.cpp @@ -85,6 +85,10 @@ void SimpleFontData::platformInit() SkScalar height = -metrics.fAscent + metrics.fDescent + metrics.fLeading; m_fontMetrics.setAscent(SkScalarRound(-metrics.fAscent)); m_fontMetrics.setDescent(SkScalarRound(height) - m_fontMetrics.ascent()); + // leading has been added to ascent/descent, so need to reset it to zero. + // Otherwise, it will be added twice, which causes layout issues for fonts + // with large leading values. + metrics.fLeading = 0; } if (metrics.fXHeight) If this is the right way to go, i'll upload a patch later. 466247 2 robin.webkit 2011-09-13 05:38:47 -0700 CC authors... 602442 3 efidler 2012-04-13 15:06:46 -0700 This issue is extremely complicated, but the proposed method is incorrect. See https://bugs.webkit.org/show_bug.cgi?id=83279 *** This bug has been marked as a duplicate of bug 83279 ***