67975 2011-09-12 17:50:56 -0700 sheriffbot whois should also tell us email addresses 2011-09-13 13:50:25 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 rniwa rniwa eric levin oldest_to_newest 465995 0 rniwa 2011-09-12 17:50:56 -0700 It's useful when I have to beg someone for fixing builds, bots, etc... 465998 1 107117 rniwa 2011-09-12 17:58:19 -0700 Created attachment 107117 fixes the bug 465999 2 107117 abarth 2011-09-12 17:59:59 -0700 Comment on attachment 107117 fixes the bug View in context: https://bugs.webkit.org/attachment.cgi?id=107117&action=review > Tools/Scripts/webkitpy/tool/bot/irc_command.py:194 > + if len(contributor.emails) and search_string not in contributor.emails: Upper vs lower case? 466003 3 107117 rniwa 2011-09-12 18:07:57 -0700 Comment on attachment 107117 fixes the bug View in context: https://bugs.webkit.org/attachment.cgi?id=107117&action=review >> Tools/Scripts/webkitpy/tool/bot/irc_command.py:194 >> + if len(contributor.emails) and search_string not in contributor.emails: > > Upper vs lower case? Good point. will fix. 466007 4 107120 rniwa 2011-09-12 18:14:21 -0700 Created attachment 107120 Updated per abarth's comment 466008 5 rniwa 2011-09-12 18:15:34 -0700 (In reply to comment #4) > Created an attachment (id=107120) [details] > Updated per abarth's comment On second thought, it might be a good idea to report the correct email address. 466009 6 rniwa 2011-09-12 18:15:58 -0700 That could be a follow up I guess. 466179 7 107120 eric 2011-09-13 01:07:47 -0700 Comment on attachment 107120 Updated per abarth's comment I guess I would have just used the default contributor __str__, as that prints out their default email anyway? 466180 8 rniwa 2011-09-13 01:14:17 -0700 (In reply to comment #7) > (From update of attachment 107120 [details]) > I guess I would have just used the default contributor __str__, as that prints out their default email anyway? So I think that'll only print out the default email. 466440 9 107120 eric 2011-09-13 11:54:43 -0700 Comment on attachment 107120 Updated per abarth's comment View in context: https://bugs.webkit.org/attachment.cgi?id=107120&action=review > Tools/Scripts/webkitpy/tool/bot/irc_command.py:194 > + if len(contributor.emails) and search_string.lower() not in map(lambda email: email.lower(), contributor.emails): You can just use contributor.emails, bool([]) is false anyway. Why do you need to check the seach_string? You're trying to avoid printing an email if they gave an email? Won't that be confusing for "darin" since you won't print "darin@apple.com"? 466443 10 107120 levin 2011-09-13 11:56:03 -0700 Comment on attachment 107120 Updated per abarth's comment Seems fine. 466444 11 107120 levin 2011-09-13 11:56:34 -0700 Comment on attachment 107120 Updated per abarth's comment Whoops. Undo'ing due to Eric's comments. 466445 12 rniwa 2011-09-13 11:57:11 -0700 (In reply to comment #9) > You can just use contributor.emails, bool([]) is false anyway. Ok, will do. > Why do you need to check the seach_string? You're trying to avoid printing an email if they gave an email? > > Won't that be confusing for "darin" since you won't print "darin@apple.com"? In that case, we will print darin@apple.com. That's why I manually search through the list of emails. 466451 13 107120 eric 2011-09-13 12:01:07 -0700 Comment on attachment 107120 Updated per abarth's comment With the removal of len(), sure. 466516 14 rniwa 2011-09-13 13:50:25 -0700 Committed r95042: <http://trac.webkit.org/changeset/95042> 107117 2011-09-12 17:58:19 -0700 2011-09-12 18:14:17 -0700 fixes the bug bug-67975-20110912175818.patch text/plain 3252 rniwa SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDk0OTk0KQorKysgVG9vbHMvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMg KzEsMTUgQEAKKzIwMTEtMDktMTIgIFJ5b3N1a2UgTml3YSAgPHJuaXdhQHdlYmtpdC5vcmc+CisK KyAgICAgICAgc2hlcmlmZmJvdCB3aG9pcyBzaG91bGQgYWxzbyB0ZWxsIHVzIGVtYWlsIGFkZHJl c3NlcworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9Njc5 NzUKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBUYXVn aHQgc2hlcmlmZmJvdCBob3cgdG8gdGVsbCB1cyBjb250cmlidXRvcidzIGVtYWlsIGFkZHJlc3Nl cy4KKworICAgICAgICAqIFNjcmlwdHMvd2Via2l0cHkvdG9vbC9ib3QvaXJjX2NvbW1hbmQucHk6 CisgICAgICAgICogU2NyaXB0cy93ZWJraXRweS90b29sL2JvdC9pcmNfY29tbWFuZF91bml0dGVz dC5weToKKwogMjAxMS0wOS0xMiAgRXJpYyBTZWlkZWwgIDxlcmljQHdlYmtpdC5vcmc+CiAKICAg ICAgICAgc2hlcmlmZmJvdCB3aG9pcyBpcyBjYXNlIHNlbnNpdGl2ZQpJbmRleDogVG9vbHMvU2Ny aXB0cy93ZWJraXRweS90b29sL2JvdC9pcmNfY29tbWFuZC5weQo9PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29s cy9TY3JpcHRzL3dlYmtpdHB5L3Rvb2wvYm90L2lyY19jb21tYW5kLnB5CShyZXZpc2lvbiA5NDk5 MykKKysrIFRvb2xzL1NjcmlwdHMvd2Via2l0cHkvdG9vbC9ib3QvaXJjX2NvbW1hbmQucHkJKHdv cmtpbmcgY29weSkKQEAgLTE5MSw3ICsxOTEsMTEgQEAgY2xhc3MgV2hvaXMoSVJDQ29tbWFuZCk6 CiAgICAgICAgICAgICBjb250cmlidXRvciA9IGNvbnRyaWJ1dG9yc1swXQogICAgICAgICAgICAg aWYgbm90IGNvbnRyaWJ1dG9yLmlyY19uaWNrbmFtZToKICAgICAgICAgICAgICAgICByZXR1cm4g IiVzOiAlcyBoYXNuJ3QgdG9sZCBtZSB0aGVpciBuaWNrLiBCb28gaG9vIDotKCIgJSAobmljaywg Y29udHJpYnV0b3IpCi0gICAgICAgICAgICByZXR1cm4gIiVzOiAlcyBpcyAlcy4gV2h5IGRvIHlv dSBhc2s/IiAlIChuaWNrLCBzZWFyY2hfc3RyaW5nLCBjb250cmlidXRvci5pcmNfbmlja25hbWUp CisgICAgICAgICAgICBpZiBsZW4oY29udHJpYnV0b3IuZW1haWxzKSBhbmQgc2VhcmNoX3N0cmlu ZyBub3QgaW4gY29udHJpYnV0b3IuZW1haWxzOgorICAgICAgICAgICAgICAgIGZvcm1hdHRlZEVt YWlscyA9ICcsICcuam9pbihjb250cmlidXRvci5lbWFpbHMpCisgICAgICAgICAgICAgICAgcmV0 dXJuICIlczogJXMgaXMgJXMgKCVzKS4gV2h5IGRvIHlvdSBhc2s/IiAlIChuaWNrLCBzZWFyY2hf c3RyaW5nLCBjb250cmlidXRvci5pcmNfbmlja25hbWUsIGZvcm1hdHRlZEVtYWlscykKKyAgICAg ICAgICAgIGVsc2U6CisgICAgICAgICAgICAgICAgcmV0dXJuICIlczogJXMgaXMgJXMuIFdoeSBk byB5b3UgYXNrPyIgJSAobmljaywgc2VhcmNoX3N0cmluZywgY29udHJpYnV0b3IuaXJjX25pY2tu YW1lKQogICAgICAgICBjb250cmlidXRvcl9uaWNrcyA9IG1hcChzZWxmLl9uaWNrX29yX2Z1bGxf cmVjb3JkLCBjb250cmlidXRvcnMpCiAgICAgICAgIGNvbnRyaWJ1dG9yc19zdHJpbmcgPSBqb2lu X3dpdGhfc2VwYXJhdG9ycyhjb250cmlidXRvcl9uaWNrcywgb25seV90d29fc2VwYXJhdG9yPSIg b3IgIiwgbGFzdF9zZXBhcmF0b3I9Jywgb3IgJykKICAgICAgICAgcmV0dXJuICIlczogSSdtIG5v dCBzdXJlIHdobyB5b3UgbWVhbj8gICVzIGNvdWxkIGJlICclcycuIiAlIChuaWNrLCBjb250cmli dXRvcnNfc3RyaW5nLCBzZWFyY2hfc3RyaW5nKQpJbmRleDogVG9vbHMvU2NyaXB0cy93ZWJraXRw eS90b29sL2JvdC9pcmNfY29tbWFuZF91bml0dGVzdC5weQo9PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9T Y3JpcHRzL3dlYmtpdHB5L3Rvb2wvYm90L2lyY19jb21tYW5kX3VuaXR0ZXN0LnB5CShyZXZpc2lv biA5NDk5MykKKysrIFRvb2xzL1NjcmlwdHMvd2Via2l0cHkvdG9vbC9ib3QvaXJjX2NvbW1hbmRf dW5pdHRlc3QucHkJKHdvcmtpbmcgY29weSkKQEAgLTQ5LDYgKzQ5LDEwIEBAIGNsYXNzIElSQ0Nv bW1hbmRUZXN0KHVuaXR0ZXN0LlRlc3RDYXNlKToKICAgICAgICAgICAgICAgICAgICAgICAgICAg d2hvaXMuZXhlY3V0ZSgidG9tIiwgWyJ1bmtub3duQGV4YW1wbGUuY29tIl0sIE5vbmUsIE5vbmUp KQogICAgICAgICBzZWxmLmFzc2VydEVxdWFscygidG9tOiB0b255Z0BjaHJvbWl1bS5vcmcgaXMg dG9ueWctY3IuIFdoeSBkbyB5b3UgYXNrPyIsCiAgICAgICAgICAgICAgICAgICAgICAgICAgIHdo b2lzLmV4ZWN1dGUoInRvbSIsIFsidG9ueWdAY2hyb21pdW0ub3JnIl0sIE5vbmUsIE5vbmUpKQor ICAgICAgICBzZWxmLmFzc2VydEVxdWFscygidG9tOiBybml3YSBpcyBybml3YSAocm5pd2FAd2Vi a2l0Lm9yZykuIFdoeSBkbyB5b3UgYXNrPyIsCisgICAgICAgICAgICAgICAgICAgICAgICAgIHdo b2lzLmV4ZWN1dGUoInRvbSIsIFsicm5pd2EiXSwgTm9uZSwgTm9uZSkpCisgICAgICAgIHNlbGYu YXNzZXJ0RXF1YWxzKCJ0b206IGxvcGV6IGlzIHhhbiAoeGFuLmxvcGV6QGdtYWlsLmNvbSwgeGFu QGdub21lLm9yZywgeGFuQHdlYmtpdC5vcmcpLiBXaHkgZG8geW91IGFzaz8iLAorICAgICAgICAg ICAgICAgICAgICAgICAgICB3aG9pcy5leGVjdXRlKCJ0b20iLCBbImxvcGV6Il0sIE5vbmUsIE5v bmUpKQogICAgICAgICBzZWxmLmFzc2VydEVxdWFscygndG9tOiAiVmlja2kgTXVybGV5IiA8dmlj a2lAYXBwbGUuY29tPiBoYXNuXCd0IHRvbGQgbWUgdGhlaXIgbmljay4gQm9vIGhvbyA6LSgnLAog ICAgICAgICAgICAgICAgICAgICAgICAgICB3aG9pcy5leGVjdXRlKCJ0b20iLCBbInZpY2tpQGFw cGxlLmNvbSJdLCBOb25lLCBOb25lKSkKICAgICAgICAgc2VsZi5hc3NlcnRFcXVhbHMoJ3RvbTog SVwnbSBub3Qgc3VyZSB3aG8geW91IG1lYW4/ICBlcm9tYW4sIGVyaWN1LCAiRXJpYyBDYXJsc29u IiA8ZXJpYy5jYXJsc29uQGFwcGxlLmNvbT4sIG9yIGVzZWlkZWwgY291bGQgYmUgXCdFcmljXCcu JywK 107120 2011-09-12 18:14:21 -0700 2011-09-13 12:01:07 -0700 Updated per abarth's comment bug-67975-20110912181420.patch text/plain 3462 rniwa SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDk0OTk0KQorKysgVG9vbHMvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMg KzEsMTUgQEAKKzIwMTEtMDktMTIgIFJ5b3N1a2UgTml3YSAgPHJuaXdhQHdlYmtpdC5vcmc+CisK KyAgICAgICAgc2hlcmlmZmJvdCB3aG9pcyBzaG91bGQgYWxzbyB0ZWxsIHVzIGVtYWlsIGFkZHJl c3NlcworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9Njc5 NzUKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBUYXVn aHQgc2hlcmlmZmJvdCBob3cgdG8gdGVsbCB1cyBjb250cmlidXRvcidzIGVtYWlsIGFkZHJlc3Nl cy4KKworICAgICAgICAqIFNjcmlwdHMvd2Via2l0cHkvdG9vbC9ib3QvaXJjX2NvbW1hbmQucHk6 CisgICAgICAgICogU2NyaXB0cy93ZWJraXRweS90b29sL2JvdC9pcmNfY29tbWFuZF91bml0dGVz dC5weToKKwogMjAxMS0wOS0xMiAgRXJpYyBTZWlkZWwgIDxlcmljQHdlYmtpdC5vcmc+CiAKICAg ICAgICAgc2hlcmlmZmJvdCB3aG9pcyBpcyBjYXNlIHNlbnNpdGl2ZQpJbmRleDogVG9vbHMvU2Ny aXB0cy93ZWJraXRweS90b29sL2JvdC9pcmNfY29tbWFuZC5weQo9PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29s cy9TY3JpcHRzL3dlYmtpdHB5L3Rvb2wvYm90L2lyY19jb21tYW5kLnB5CShyZXZpc2lvbiA5NDk5 MykKKysrIFRvb2xzL1NjcmlwdHMvd2Via2l0cHkvdG9vbC9ib3QvaXJjX2NvbW1hbmQucHkJKHdv cmtpbmcgY29weSkKQEAgLTE5MSw3ICsxOTEsMTEgQEAgY2xhc3MgV2hvaXMoSVJDQ29tbWFuZCk6 CiAgICAgICAgICAgICBjb250cmlidXRvciA9IGNvbnRyaWJ1dG9yc1swXQogICAgICAgICAgICAg aWYgbm90IGNvbnRyaWJ1dG9yLmlyY19uaWNrbmFtZToKICAgICAgICAgICAgICAgICByZXR1cm4g IiVzOiAlcyBoYXNuJ3QgdG9sZCBtZSB0aGVpciBuaWNrLiBCb28gaG9vIDotKCIgJSAobmljaywg Y29udHJpYnV0b3IpCi0gICAgICAgICAgICByZXR1cm4gIiVzOiAlcyBpcyAlcy4gV2h5IGRvIHlv dSBhc2s/IiAlIChuaWNrLCBzZWFyY2hfc3RyaW5nLCBjb250cmlidXRvci5pcmNfbmlja25hbWUp CisgICAgICAgICAgICBpZiBsZW4oY29udHJpYnV0b3IuZW1haWxzKSBhbmQgc2VhcmNoX3N0cmlu Zy5sb3dlcigpIG5vdCBpbiBtYXAobGFtYmRhIGVtYWlsOiBlbWFpbC5sb3dlcigpLCBjb250cmli dXRvci5lbWFpbHMpOgorICAgICAgICAgICAgICAgIGZvcm1hdHRlZEVtYWlscyA9ICcsICcuam9p bihjb250cmlidXRvci5lbWFpbHMpCisgICAgICAgICAgICAgICAgcmV0dXJuICIlczogJXMgaXMg JXMgKCVzKS4gV2h5IGRvIHlvdSBhc2s/IiAlIChuaWNrLCBzZWFyY2hfc3RyaW5nLCBjb250cmli dXRvci5pcmNfbmlja25hbWUsIGZvcm1hdHRlZEVtYWlscykKKyAgICAgICAgICAgIGVsc2U6Cisg ICAgICAgICAgICAgICAgcmV0dXJuICIlczogJXMgaXMgJXMuIFdoeSBkbyB5b3UgYXNrPyIgJSAo bmljaywgc2VhcmNoX3N0cmluZywgY29udHJpYnV0b3IuaXJjX25pY2tuYW1lKQogICAgICAgICBj b250cmlidXRvcl9uaWNrcyA9IG1hcChzZWxmLl9uaWNrX29yX2Z1bGxfcmVjb3JkLCBjb250cmli dXRvcnMpCiAgICAgICAgIGNvbnRyaWJ1dG9yc19zdHJpbmcgPSBqb2luX3dpdGhfc2VwYXJhdG9y cyhjb250cmlidXRvcl9uaWNrcywgb25seV90d29fc2VwYXJhdG9yPSIgb3IgIiwgbGFzdF9zZXBh cmF0b3I9Jywgb3IgJykKICAgICAgICAgcmV0dXJuICIlczogSSdtIG5vdCBzdXJlIHdobyB5b3Ug bWVhbj8gICVzIGNvdWxkIGJlICclcycuIiAlIChuaWNrLCBjb250cmlidXRvcnNfc3RyaW5nLCBz ZWFyY2hfc3RyaW5nKQpJbmRleDogVG9vbHMvU2NyaXB0cy93ZWJraXRweS90b29sL2JvdC9pcmNf Y29tbWFuZF91bml0dGVzdC5weQo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9TY3JpcHRzL3dlYmtpdHB5 L3Rvb2wvYm90L2lyY19jb21tYW5kX3VuaXR0ZXN0LnB5CShyZXZpc2lvbiA5NDk5MykKKysrIFRv b2xzL1NjcmlwdHMvd2Via2l0cHkvdG9vbC9ib3QvaXJjX2NvbW1hbmRfdW5pdHRlc3QucHkJKHdv cmtpbmcgY29weSkKQEAgLTQ5LDYgKzQ5LDEyIEBAIGNsYXNzIElSQ0NvbW1hbmRUZXN0KHVuaXR0 ZXN0LlRlc3RDYXNlKToKICAgICAgICAgICAgICAgICAgICAgICAgICAgd2hvaXMuZXhlY3V0ZSgi dG9tIiwgWyJ1bmtub3duQGV4YW1wbGUuY29tIl0sIE5vbmUsIE5vbmUpKQogICAgICAgICBzZWxm LmFzc2VydEVxdWFscygidG9tOiB0b255Z0BjaHJvbWl1bS5vcmcgaXMgdG9ueWctY3IuIFdoeSBk byB5b3UgYXNrPyIsCiAgICAgICAgICAgICAgICAgICAgICAgICAgIHdob2lzLmV4ZWN1dGUoInRv bSIsIFsidG9ueWdAY2hyb21pdW0ub3JnIl0sIE5vbmUsIE5vbmUpKQorICAgICAgICBzZWxmLmFz c2VydEVxdWFscygidG9tOiBUb255R0BDaHJvbWl1bS5vcmcgaXMgdG9ueWctY3IuIFdoeSBkbyB5 b3UgYXNrPyIsCisgICAgICAgICAgICAgICAgICAgICAgICAgIHdob2lzLmV4ZWN1dGUoInRvbSIs IFsiVG9ueUdAQ2hyb21pdW0ub3JnIl0sIE5vbmUsIE5vbmUpKQorICAgICAgICBzZWxmLmFzc2Vy dEVxdWFscygidG9tOiBybml3YSBpcyBybml3YSAocm5pd2FAd2Via2l0Lm9yZykuIFdoeSBkbyB5 b3UgYXNrPyIsCisgICAgICAgICAgICAgICAgICAgICAgICAgIHdob2lzLmV4ZWN1dGUoInRvbSIs IFsicm5pd2EiXSwgTm9uZSwgTm9uZSkpCisgICAgICAgIHNlbGYuYXNzZXJ0RXF1YWxzKCJ0b206 IGxvcGV6IGlzIHhhbiAoeGFuLmxvcGV6QGdtYWlsLmNvbSwgeGFuQGdub21lLm9yZywgeGFuQHdl YmtpdC5vcmcpLiBXaHkgZG8geW91IGFzaz8iLAorICAgICAgICAgICAgICAgICAgICAgICAgICB3 aG9pcy5leGVjdXRlKCJ0b20iLCBbImxvcGV6Il0sIE5vbmUsIE5vbmUpKQogICAgICAgICBzZWxm LmFzc2VydEVxdWFscygndG9tOiAiVmlja2kgTXVybGV5IiA8dmlja2lAYXBwbGUuY29tPiBoYXNu XCd0IHRvbGQgbWUgdGhlaXIgbmljay4gQm9vIGhvbyA6LSgnLAogICAgICAgICAgICAgICAgICAg ICAgICAgICB3aG9pcy5leGVjdXRlKCJ0b20iLCBbInZpY2tpQGFwcGxlLmNvbSJdLCBOb25lLCBO b25lKSkKICAgICAgICAgc2VsZi5hc3NlcnRFcXVhbHMoJ3RvbTogSVwnbSBub3Qgc3VyZSB3aG8g eW91IG1lYW4/ICBlcm9tYW4sIGVyaWN1LCAiRXJpYyBDYXJsc29uIiA8ZXJpYy5jYXJsc29uQGFw cGxlLmNvbT4sIG9yIGVzZWlkZWwgY291bGQgYmUgXCdFcmljXCcuJywK