<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>67965</bug_id>
          
          <creation_ts>2011-09-12 16:03:06 -0700</creation_ts>
          <short_desc>Broken Build for ARM - lshift32() needs TrustedImm32 arg</short_desc>
          <delta_ts>2011-09-12 16:13:37 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>JavaScriptCore</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>Other</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Michael Saboff">msaboff</reporter>
          <assigned_to name="Michael Saboff">msaboff</assigned_to>
          
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>465902</commentid>
    <comment_count>0</comment_count>
    <who name="Michael Saboff">msaboff</who>
    <bug_when>2011-09-12 16:03:06 -0700</bug_when>
    <thetext>The code lshift32(16, ARMRegisters::S1); should be lshift32(TrustedImm32(16), ARMRegisters::S1);</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>465910</commentid>
    <comment_count>1</comment_count>
      <attachid>107101</attachid>
    <who name="Michael Saboff">msaboff</who>
    <bug_when>2011-09-12 16:08:47 -0700</bug_when>
    <thetext>Created attachment 107101
Proposed patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>465915</commentid>
    <comment_count>2</comment_count>
    <who name="Michael Saboff">msaboff</who>
    <bug_when>2011-09-12 16:13:37 -0700</bug_when>
    <thetext>Committed r94987: &lt;http://trac.webkit.org/changeset/94987&gt;</thetext>
  </long_desc>
      
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>107101</attachid>
            <date>2011-09-12 16:08:47 -0700</date>
            <delta_ts>2011-09-12 16:10:01 -0700</delta_ts>
            <desc>Proposed patch</desc>
            <filename>67965.patch</filename>
            <type>text/plain</type>
            <size>1366</size>
            <attacher name="Michael Saboff">msaboff</attacher>
            
              <data encoding="base64">SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291
cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gOTQ5ODYpCisrKyBTb3VyY2Uv
SmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTUgQEAK
KzIwMTEtMDktMTIgIE1pY2hhZWwgU2Fib2ZmICA8bXNhYm9mZkBhcHBsZS5jb20+CisKKyAgICAg
ICAgQnJva2VuIEJ1aWxkIGZvciBBUk0gLSBsc2hpZnQzMigpIG5lZWRzIFRydXN0ZWRJbW0zMiBh
cmcKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTY3OTY1
CisKKyAgICAgICAgQ2hhbmdlIGxzaGlmdDMyKDE2LCBBUk1SZWdpc3RlcnM6OlMxKTsgdG8gbHNo
aWZ0MzIoVHJ1c3RlZEltbTMyKDE2KSwgQVJNUmVnaXN0ZXJzOjpTMSk7CisKKyAgICAgICAgUmV2
aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBhc3NlbWJsZXIvTWFjcm9Bc3Nl
bWJsZXJBUk0uaDoKKyAgICAgICAgKEpTQzo6TWFjcm9Bc3NlbWJsZXJBUk06OmJyYW5jaDE2KToK
KwogMjAxMS0wOS0xMiAgTWljaGFlbCBTYWJvZmYgIDxtc2Fib2ZmQGFwcGxlLmNvbT4KIAogICAg
ICAgICBCcm9rZW4gQVJNIGJ1aWxkIC0gbWlzc2luZyBzZW1pY29sb24gaW4gSmF2YVNjcmlwdENv
cmUvYXNzZW1ibGVyL01hY3JvQXNzZW1ibGVyQVJNLmgKSW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0
Q29yZS9hc3NlbWJsZXIvTWFjcm9Bc3NlbWJsZXJBUk0uaAo9PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2Uv
SmF2YVNjcmlwdENvcmUvYXNzZW1ibGVyL01hY3JvQXNzZW1ibGVyQVJNLmgJKHJldmlzaW9uIDk0
OTg1KQorKysgU291cmNlL0phdmFTY3JpcHRDb3JlL2Fzc2VtYmxlci9NYWNyb0Fzc2VtYmxlckFS
TS5oCSh3b3JraW5nIGNvcHkpCkBAIC00MjYsNyArNDI2LDcgQEAgcHVibGljOgogICAgICAgICBB
U1NFUlQoIShyaWdodC5tX3ZhbHVlICYgMHhGRkZGMDAwMCkpOwogICAgICAgICByaWdodC5tX3Zh
bHVlIDw8PSAxNjsKICAgICAgICAgbV9hc3NlbWJsZXIubW92X3IoQVJNUmVnaXN0ZXJzOjpTMSwg
bGVmdCk7Ci0gICAgICAgIGxzaGlmdDMyKDE2LCBBUk1SZWdpc3RlcnM6OlMxKTsKKyAgICAgICAg
bHNoaWZ0MzIoVHJ1c3RlZEltbTMyKDE2KSwgQVJNUmVnaXN0ZXJzOjpTMSk7CiAgICAgICAgIHJl
dHVybiBicmFuY2gzMihjb25kLCBBUk1SZWdpc3RlcnM6OlMxLCByaWdodCk7CiAgICAgfQogCg==
</data>
<flag name="review"
          id="103716"
          type_id="1"
          status="+"
          setter="andersca"
    />
          </attachment>
      

    </bug>

</bugzilla>