67957 2011-09-12 15:14:09 -0700 Possible ASSERT(!storageTracker) in Lazily Initialized StorageTracker 2011-09-12 21:40:53 -0700 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 joepeck joepeck ap beidson joepeck webkit.review.bot oldest_to_newest 465825 0 joepeck 2011-09-12 15:14:09 -0700 StorageTracker::initializeTracker ASSERTs: ASSERT(!storageTracker); However that global static could have been initialized by a call to StorageTracker::tracker. We should instead ASSERT that the tracker doesn't exist yet (we create it here) or if it does exist that it doesn't yet have a client (which is what initialize is doing). 465942 1 107110 joepeck 2011-09-12 16:37:47 -0700 Created attachment 107110 [PATCH] Proposed Fix 465944 2 joepeck 2011-09-12 16:38:46 -0700 <rdar://problem/10064708> 465949 3 107110 darin 2011-09-12 16:46:19 -0700 Comment on attachment 107110 [PATCH] Proposed Fix Seems fine. 466115 4 107110 webkit.review.bot 2011-09-12 21:40:49 -0700 Comment on attachment 107110 [PATCH] Proposed Fix Clearing flags on attachment: 107110 Committed r95013: <http://trac.webkit.org/changeset/95013> 466116 5 webkit.review.bot 2011-09-12 21:40:53 -0700 All reviewed patches have been landed. Closing bug. 107110 2011-09-12 16:37:47 -0700 2011-09-12 21:40:49 -0700 [PATCH] Proposed Fix proposed-fix.patch text/plain 2210 joepeck Y29tbWl0IGZlMDMyYjYzMmYwNDhkYWJkNmQzNzNjOTUyZWUwNjljM2QwMjA0Y2EKQXV0aG9yOiBK b3NlcGggUGVjb3Jhcm8gPGpvZXBlY2tAd2Via2l0Lm9yZz4KRGF0ZTogICBNb24gU2VwIDEyIDE2 OjE4OjMxIDIwMTEgLTA3MDAKCiAgICA8aHR0cDovL3dlYmtpdC5vcmcvYi82Nzk1Nz4gUG9zc2li bGUgQVNTRVJUKCFzdG9yYWdlVHJhY2tlcikgaW4gTGF6aWx5IEluaXRpYWxpemVkIFN0b3JhZ2VU cmFja2VyCiAgICAKICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgogICAgCiAgICBUaGUg c3RvcmFnZVRyYWNrZXIgc2luZ2xldG9uIG1heSBhbHJlYWR5IGhhdmUgYmVlbiBjcmVhdGVkCiAg ICB0aHJvdWdoIFN0b3JhZ2VUcmFja2VyOjp0cmFja2VyIGJlZm9yZSBpbml0aWFsaXplVHJhY2tl cgogICAgZ2V0cyBjYWxsZWQuIFVwZGF0ZSB0aGUgQVNTRVJUIGluIHRoaXMgY2FzZSB0byBjaGVj ayB0aGF0CiAgICB0aGVyZSBpcyBubyBjbGllbnQgZm9yIHRoZSB0cmFja2VyLgogICAgCiAgICBO byB0ZXN0LCB0aGlzIGRlcGVuZHMgb24gaG93IHRoZSBwb3J0IGluaXRpYWxpemVzIHRoZSB0cmFj a2VyLgogICAgCiAgICAqIHN0b3JhZ2UvU3RvcmFnZVRyYWNrZXIuY3BwOgogICAgKFdlYkNvcmU6 OlN0b3JhZ2VUcmFja2VyOjppbml0aWFsaXplVHJhY2tlcik6CgpkaWZmIC0tZ2l0IGEvU291cmNl L1dlYkNvcmUvQ2hhbmdlTG9nIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCmluZGV4IDk5Njdh ZTIuLjY5YWE4NjcgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZworKysgYi9T b3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwyMCBAQAorMjAxMS0wOS0xMiAgSm9z ZXBoIFBlY29yYXJvICA8am9lcGVja0B3ZWJraXQub3JnPgorCisgICAgICAgIFBvc3NpYmxlIEFT U0VSVCghc3RvcmFnZVRyYWNrZXIpIGluIExhemlseSBJbml0aWFsaXplZCBTdG9yYWdlVHJhY2tl cgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9Njc5NTcK KworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBUaGUgc3Rv cmFnZVRyYWNrZXIgc2luZ2xldG9uIG1heSBhbHJlYWR5IGhhdmUgYmVlbiBjcmVhdGVkCisgICAg ICAgIHRocm91Z2ggU3RvcmFnZVRyYWNrZXI6OnRyYWNrZXIgYmVmb3JlIGluaXRpYWxpemVUcmFj a2VyCisgICAgICAgIGdldHMgY2FsbGVkLiBVcGRhdGUgdGhlIEFTU0VSVCBpbiB0aGlzIGNhc2Ug dG8gY2hlY2sgdGhhdAorICAgICAgICB0aGVyZSBpcyBubyBjbGllbnQgZm9yIHRoZSB0cmFja2Vy LgorCisgICAgICAgIE5vIHRlc3QsIHRoaXMgZGVwZW5kcyBvbiBob3cgdGhlIHBvcnQgaW5pdGlh bGl6ZXMgdGhlIHRyYWNrZXIuCisKKyAgICAgICAgKiBzdG9yYWdlL1N0b3JhZ2VUcmFja2VyLmNw cDoKKyAgICAgICAgKFdlYkNvcmU6OlN0b3JhZ2VUcmFja2VyOjppbml0aWFsaXplVHJhY2tlcik6 CisKIDIwMTEtMDktMTIgIE1pY2hhZWwgU2Fib2ZmICA8bXNhYm9mZkBhcHBsZS5jb20+CiAKICAg ICAgICAgVXBkYXRlIFJlZ0V4cCBhbmQgcmVsYXRlZCBjbGFzc2VzIHRvIHVzZSA4IGJpdCBzdHJp bmdzIHdoZW4gYXZhaWxhYmxlCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9zdG9yYWdlL1N0 b3JhZ2VUcmFja2VyLmNwcCBiL1NvdXJjZS9XZWJDb3JlL3N0b3JhZ2UvU3RvcmFnZVRyYWNrZXIu Y3BwCmluZGV4IGJkN2E2YjcuLmMwY2JlNmIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3N0 b3JhZ2UvU3RvcmFnZVRyYWNrZXIuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3N0b3JhZ2UvU3Rv cmFnZVRyYWNrZXIuY3BwCkBAIC01MSw3ICs1MSw3IEBAIHN0YXRpYyBTdG9yYWdlVHJhY2tlciog c3RvcmFnZVRyYWNrZXIgPSAwOwogdm9pZCBTdG9yYWdlVHJhY2tlcjo6aW5pdGlhbGl6ZVRyYWNr ZXIoY29uc3QgU3RyaW5nJiBzdG9yYWdlUGF0aCwgU3RvcmFnZVRyYWNrZXJDbGllbnQqIGNsaWVu dCkKIHsKICAgICBBU1NFUlQoaXNNYWluVGhyZWFkKCkpOwotICAgIEFTU0VSVCghc3RvcmFnZVRy YWNrZXIpOworICAgIEFTU0VSVCghc3RvcmFnZVRyYWNrZXIgfHwgIXN0b3JhZ2VUcmFja2VyLT5t X2NsaWVudCk7CiAgICAgCiAgICAgaWYgKCFzdG9yYWdlVHJhY2tlcikKICAgICAgICAgc3RvcmFn ZVRyYWNrZXIgPSBuZXcgU3RvcmFnZVRyYWNrZXIoc3RvcmFnZVBhdGgpOwo=