67955 2011-09-12 15:00:49 -0700 [skia] fast/canvas/setWidthResetAfterForcedRender is flaky 2011-09-14 13:11:29 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 jamesr jamesr bsalomon enne kbr nduca reed senorblanco oldest_to_newest 465812 0 jamesr 2011-09-12 15:00:49 -0700 [skia] fast/canvas/setWidthResetAfterForcedRender is flaky 465813 1 107088 jamesr 2011-09-12 15:02:05 -0700 Created attachment 107088 Patch 465817 2 jamesr 2011-09-12 15:04:18 -0700 See http://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=fast%2Fcanvas%2FsetWidthResetAfterForcedRender.html&showExpectations=true&group=%40ToT%20GPU%20Mesa%20-%20chromium.org to see how often this test fails. When running locally, I also saw: [24615:24615:3633584029826:FATAL:gles2_cmd_decoder.cc(4143)] glBindTexture: id not generated by glGenTextures on the console, which lead to this bugfix. The texture in question is allocated by skia and deleted by: gpu::gles2::GLES2Implementation::DeleteTextures() [0x99a171] GLES2DeleteTextures [0x1ea521b] GrGLTexID::~GrGLTexID() [0x1051d9c] SkRefCnt::unref() [0x48d5be] SkSafeUnref<>() [0x1050a0c] GrGLRenderTarget::onRelease() [0x1050933] GrResource::release() [0x1003b88] GrGLRenderTarget::~GrGLRenderTarget() [0x1050b6a] SkRefCnt::unref() [0x48d5be] SkSafeUnref<>() [0x101fbe6] SkGrRenderTargetPixelRef::~SkGrRenderTargetPixelRef() [0x101f99f] SkRefCnt::unref() [0x48d5be] SkBitmap::freePixels() [0x4894b9] SkBitmap::~SkBitmap() [0x4888ba] SkDevice::~SkDevice() [0x4982ac] SkGpuDevice::~SkGpuDevice() [0x1017e86] SkRefCnt::unref() [0x48d5be] DeviceCM::~DeviceCM() [0x494b39] SkCanvas::internalRestore() [0x490051] SkCanvas::~SkCanvas() [0x48f0e7] skia::PlatformCanvas::~PlatformCanvas() [0x4f2c86] WTF::deleteOwnedPtr<>() [0x46ff1a] WTF::OwnPtr<>::~OwnPtr() [0x46e8e5] WebCore::ImageBufferData::~ImageBufferData() [0xf6073a] WebCore::ImageBuffer::~ImageBuffer() [0xf5f6fc] WTF::deleteOwnedPtr<>() [0xaaf70b] WTF::OwnPtr<>::clear() [0xca2862] WebCore::HTMLCanvasElement::setSurfaceSize() [0xca019f] WebCore::HTMLCanvasElement::reset() [0xc9fc5b] WebCore::HTMLCanvasElement::parseMappedAttribute() [0xc9f312] WebCore::StyledElement::attributeChanged() [0x1861e4e] WebCore::Element::setAttribute() [0x17f5e51] WebCore::Element::setAttribute() [0x17f3f38] WebCore::HTMLCanvasElement::setWidth() [0xc9f513] WebCore::HTMLCanvasElementInternal::widthAttrSetter() [0x1b91f72] This might be causing all sorts of other issues in the wild - after landing I propose merging this to m15, just in case. 466248 3 bsalomon 2011-09-13 05:54:01 -0700 Great find. (unofficially) LGTM. 466318 4 107088 senorblanco 2011-09-13 08:49:10 -0700 Comment on attachment 107088 Patch Good catch! BTW, twiz landed a one-liner just below this which might conflict. I'll let you decide whether to update it yourself or try cq+. 466357 5 107188 jamesr 2011-09-13 10:02:15 -0700 Created attachment 107188 Patch 466359 6 jamesr 2011-09-13 10:04:15 -0700 Patch slightly updated - the previous version was actually trying to draw from texture id 0 (erk). 466367 7 jamesr 2011-09-13 10:22:21 -0700 *** Bug 67144 has been marked as a duplicate of this bug. *** 466454 8 107188 senorblanco 2011-09-13 12:05:48 -0700 Comment on attachment 107188 Patch After some discussion offline, we're a little concerned that this might be papering over a deeper problem (outstanding question is, why is the compositor still rendering with this layer after the ImageBuffer has unref'ed it). However, this fix looks safe regardless, so I'll let James decide whether to land this or hold off until after deeper investigation. r=me 467128 9 senorblanco 2011-09-14 10:46:51 -0700 This test seems to have become unflaky. The last failure on the Mesa bots was against WebKit r94962, and it has been green since. I suspect that perhaps twiz's change in r94982 fixed it, although that is quite a few revs from the last failure. James, it is possible that your change in r94964 fixed it? At any rate, I'm going to mark it as passing in test_expectations. 467139 10 jamesr 2011-09-14 10:55:51 -0700 I've noticed that as well, although I'm still getting stderr output locally. Marking the test as passing seems like a fine thing to do, I'll pull up to ToT and see if I am still getting stderr output or not. 467185 11 jamesr 2011-09-14 11:48:06 -0700 It looks like the problem is still happening, although it's not causing the test to fail. For example on this run: http://build.chromium.org/p/chromium.webkit/builders/Webkit%20Linux/builds/13256/steps/webkit_gpu_tests/logs/stdio grep for "output stderr lines" and you see: 2011-09-14 11:40:19,310 31916 single_test_runner.py:221 DEBUG worker/1 fast/canvas/setWidthResetAfterForcedRender.html output stderr lines: [31927:31927:4826333073742:ERROR:gles2_cmd_decoder.cc(4136)] glBindTexture: id not generated by glGenTextures this means we're still binding a texture that has already been deleted because HTMLCanvasElement::setSurfaceSize() is deleting the ImageBuffer (which owns the backing texture for the canvas) but nothing is triggering a compositing tree rebuild. I think I have a better fix in mind, however. Will update soon. 467218 12 jamesr 2011-09-14 12:09:49 -0700 I've changed my mind, I think the original patch is still valid. When a canvas is reset we destroy the ImageBuffer (which in ganesh owns the texture) but we aren't logically changing the compositing requirements of the page, so it makes sense to leave the layer in place. Most of the time we'll recreate the ImageBuffer very soon anyway. 467275 13 jamesr 2011-09-14 13:11:29 -0700 Committed r95114: <http://trac.webkit.org/changeset/95114> 107088 2011-09-12 15:02:05 -0700 2011-09-13 10:02:12 -0700 Patch bug-67955-20110912150204.patch text/plain 1922 jamesr U3VidmVyc2lvbiBSZXZpc2lvbjogOTQ5NzUKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCA0NjRmMmYwZWQxMjdiZTY5 M2E2NmRmM2VkMGE2YTc2MGMwN2I0ZWI0Li5iYTQ3NTJiZDgwNTU3NDcxYTlhMDI1NmJjZGFmNmJi MmFlMTI4MzgxIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvU291 cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDUgKzEsMjEgQEAKIDIwMTEtMDktMTIgIEphbWVz IFJvYmluc29uICA8amFtZXNyQGNocm9taXVtLm9yZz4KIAorICAgICAgICBbc2tpYV0gZmFzdC9j YW52YXMvc2V0V2lkdGhSZXNldEFmdGVyRm9yY2VkUmVuZGVyIGlzIGZsYWt5CisgICAgICAgIGh0 dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD02Nzk1NQorCisgICAgICAgIFJl dmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFdoZW4gZGVzdHJveWluZyBhbiBJ bWFnZUJ1ZmZlciBkdWUgdG8gYSBjYW52YXMgcmVzaXplLCB3ZSB3ZXJlbid0IGNsZWFyaW5nIHRo ZSB0ZXh0dXJlIElEIG9uIHRoZSBsYXllciwKKyAgICAgICAgcmVzdWx0aW5nIGluIGZ1dHVyZSBj b21wb3NpdG9yIGRyYXcgY2FsbHMgYmluZGluZyBhbiBpbnZhbGlkIHRleHR1cmUuICBUaGlzIHJl c3VsdHMgaW4gdGhlIHRlc3QgZmFpbGluZyBhbmQKKyAgICAgICAgcG9zc2libHkgZHJhd2luZyBm cm9tIGEgYmFkIHRleHR1cmUuCisKKyAgICAgICAgQ292ZXJlZCBieSBmYXN0L2NhbnZhcy9zZXRX aWR0aFJlc2V0QWZ0ZXJGb3JjZWRSZW5kZXIuaHRtbCBpbiB0aGUgR1BVIGNvbmZpZ3VyYXRpb24u CisKKyAgICAgICAgKiBwbGF0Zm9ybS9ncmFwaGljcy9za2lhL0ltYWdlQnVmZmVyU2tpYS5jcHA6 CisgICAgICAgIChXZWJDb3JlOjpJbWFnZUJ1ZmZlcjo6fkltYWdlQnVmZmVyKToKKworMjAxMS0w OS0xMiAgSmFtZXMgUm9iaW5zb24gIDxqYW1lc3JAY2hyb21pdW0ub3JnPgorCiAgICAgICAgIFtj aHJvbWl1bV0gTW92ZSBjb250ZW50cyB0ZXh0dXJlIG1hbmFnZXIgZnJvbSBMYXllclJlbmRlcmVy Q2hyb21pdW0gdG8gQ0NMYXllclRyZWVIb3N0CiAgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQu b3JnL3Nob3dfYnVnLmNnaT9pZD02NzQ0MAogCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9w bGF0Zm9ybS9ncmFwaGljcy9za2lhL0ltYWdlQnVmZmVyU2tpYS5jcHAgYi9Tb3VyY2UvV2ViQ29y ZS9wbGF0Zm9ybS9ncmFwaGljcy9za2lhL0ltYWdlQnVmZmVyU2tpYS5jcHAKaW5kZXggZDllNTY0 YTFlOGRjZmEzYmQyNTJjYzFhMGZkZWFhYzE1ZWY0YmU1Yy4uZjNhOTc3N2YyYTIzNjM5Y2RmNmEw MmU0NmEzZGI5NjMwYWI0NmI5MCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0v Z3JhcGhpY3Mvc2tpYS9JbWFnZUJ1ZmZlclNraWEuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3Bs YXRmb3JtL2dyYXBoaWNzL3NraWEvSW1hZ2VCdWZmZXJTa2lhLmNwcApAQCAtMTE2LDYgKzExNiwx MCBAQCBJbWFnZUJ1ZmZlcjo6SW1hZ2VCdWZmZXIoY29uc3QgSW50U2l6ZSYgc2l6ZSwgQ29sb3JT cGFjZSwgUmVuZGVyaW5nTW9kZSByZW5kZXJpbgogCiBJbWFnZUJ1ZmZlcjo6fkltYWdlQnVmZmVy KCkKIHsKKyNpZiBVU0UoQUNDRUxFUkFURURfQ09NUE9TSVRJTkcpCisgICAgaWYgKG1fZGF0YS5t X3BsYXRmb3JtTGF5ZXIpCisgICAgICAgIG1fZGF0YS5tX3BsYXRmb3JtTGF5ZXItPnNldFRleHR1 cmVJZCgwKTsKKyNlbmRpZgogICAgIC8vIFRoaXMgaXMgc28gdGhhdCB0aGUgU2tHcHVEZXZpY2Ug ZGVzdHJ1Y3RvciBoYXMgdGhlIGNvcnJlY3QgY29udGV4dC4KICAgICBtX2NvbnRleHQtPnBsYXRm b3JtQ29udGV4dCgpLT5tYWtlR3JDb250ZXh0Q3VycmVudCgpOwogfQo= 107188 2011-09-13 10:02:15 -0700 2011-09-13 12:05:48 -0700 Patch bug-67955-20110913100214.patch text/plain 3452 jamesr U3VidmVyc2lvbiBSZXZpc2lvbjogOTUwMzAKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL3BsYXRm b3JtL2Nocm9taXVtL3Rlc3RfZXhwZWN0YXRpb25zLnR4dCBiL0xheW91dFRlc3RzL3BsYXRmb3Jt L2Nocm9taXVtL3Rlc3RfZXhwZWN0YXRpb25zLnR4dAppbmRleCA1NjcwODBkMjgwZGJiOWMyZWU3 MTJkMWI2YTU3OGNkZThkMzYyN2YxLi41OTU3OWQxMWZmNDhiMDM1OTFjMzQyNjdiODY3MDg3NTBl ZjZkYmYwIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9jaHJvbWl1bS90ZXN0X2V4 cGVjdGF0aW9ucy50eHQKKysrIGIvTGF5b3V0VGVzdHMvcGxhdGZvcm0vY2hyb21pdW0vdGVzdF9l eHBlY3RhdGlvbnMudHh0CkBAIC0zNjY3LDkgKzM2NjcsNiBAQCBCVUdXSzY3MjA0IDogZmFzdC9t dWx0aWNvbC9pbml0aWFsLWNvbHVtbi12YWx1ZXMuaHRtbCA9IE1JU1NJTkcgRkFJTAogLy8gRmFp bGluZyBhZnRlciByOTM5ODIuCiBCVUdfTEVWSU4gTUFDIDogY2FudmFzL3BoaWxpcC90ZXN0cy8y ZC5wYXRoLnN0cm9rZS5wcnVuZS5hcmMuaHRtbCA9IFRFWFQKIAotLy8gRmFpbGluZyBhZnRlciBy OTM5ODguCi1CVUdXSzY3MTQ0IEdQVSBXSU4gTElOVVggOiBmYXN0L2NhbnZhcy9zZXRXaWR0aFJl c2V0QWZ0ZXJGb3JjZWRSZW5kZXIuaHRtbCA9IElNQUdFCi0KIC8vIEZhaWxpbmcgYWZ0ZXIgcjk0 MDg0LiBUaGlzIGxvb2tzIGxpa2UgaXQgbWF5IGJlIGEgcmVhbCByZWdyZXNzaW9uLgogQlVHX0xF VklOIDogY3NzMi4xL3QwOTAyMDQtZGlzcGxheS1jaGFuZ2UtMDEtYi1hby5odG1sID0gSU1BR0Ur VEVYVAogCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cKaW5kZXggYzFlNjFkMDI3Y2VlZDZkODdlNDZkODIwNzc5MWU4M2ViNzBh MDdiMC4uN2U4NWEzZTIwMGM1NWM0MWY0ODlkMTkxZjE1ZDZiYWY2MmZmODEyYiAxMDA2NDQKLS0t IGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxv ZwpAQCAtMSwzICsxLDIxIEBACisyMDExLTA5LTEzICBKYW1lcyBSb2JpbnNvbiAgPGphbWVzckBj aHJvbWl1bS5vcmc+CisKKyAgICAgICAgW3NraWFdIGZhc3QvY2FudmFzL3NldFdpZHRoUmVzZXRB ZnRlckZvcmNlZFJlbmRlciBpcyBmbGFreQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9y Zy9zaG93X2J1Zy5jZ2k/aWQ9Njc5NTUKKworICAgICAgICBSZXZpZXdlZCBieSBTdGVwaGVuIFdo aXRlLgorCisgICAgICAgIFdoZW4gZGVzdHJveWluZyBhbiBJbWFnZUJ1ZmZlciBkdWUgdG8gYSBj YW52YXMgcmVzaXplLCB3ZSB3ZXJlbid0IGNsZWFyaW5nIHRoZSB0ZXh0dXJlIElEIG9uIHRoZSBs YXllciwKKyAgICAgICAgcmVzdWx0aW5nIGluIGZ1dHVyZSBjb21wb3NpdG9yIGRyYXcgY2FsbHMg YmluZGluZyBhbiBpbnZhbGlkIHRleHR1cmUuICBUaGlzIHJlc3VsdHMgaW4gdGhlIHRlc3QgZmFp bGluZyBhbmQKKyAgICAgICAgcG9zc2libHkgZHJhd2luZyBmcm9tIGEgYmFkIHRleHR1cmUuCisK KyAgICAgICAgQ292ZXJlZCBieSBmYXN0L2NhbnZhcy9zZXRXaWR0aFJlc2V0QWZ0ZXJGb3JjZWRS ZW5kZXIuaHRtbCBpbiB0aGUgR1BVIGNvbmZpZ3VyYXRpb24uCisKKyAgICAgICAgKiBwbGF0Zm9y bS9ncmFwaGljcy9jaHJvbWl1bS9DYW52YXMyRExheWVyQ2hyb21pdW0uY3BwOgorICAgICAgICAo V2ViQ29yZTo6Q2FudmFzMkRMYXllckNocm9taXVtOjpkcmF3c0NvbnRlbnQpCisgICAgICAgICog cGxhdGZvcm0vZ3JhcGhpY3Mvc2tpYS9JbWFnZUJ1ZmZlclNraWEuY3BwOgorICAgICAgICAoV2Vi Q29yZTo6SW1hZ2VCdWZmZXI6On5JbWFnZUJ1ZmZlcik6CisKIDIwMTEtMDktMTMgIFhpYW56aHUg V2FuZyAgPHdhbmd4aWFuemh1QGNocm9taXVtLm9yZz4KIAogICAgICAgICBSZXZpZXdlZCBieSBE YXJpbiBBZGxlci4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNz L2Nocm9taXVtL0NhbnZhczJETGF5ZXJDaHJvbWl1bS5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0 Zm9ybS9ncmFwaGljcy9jaHJvbWl1bS9DYW52YXMyRExheWVyQ2hyb21pdW0uY3BwCmluZGV4IGNh NmQxYTVhZDNiZDQyYzNmOWFiNWEzNWQxYzVmZjNjMjIzNzI2Y2EuLjJmNzBmNjhhMTAwMGFjNmMz ODM1MzZiODliMmQ0YTcyZTBhZmM0NmIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRm b3JtL2dyYXBoaWNzL2Nocm9taXVtL0NhbnZhczJETGF5ZXJDaHJvbWl1bS5jcHAKKysrIGIvU291 cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvY2hyb21pdW0vQ2FudmFzMkRMYXllckNocm9t aXVtLmNwcApAQCAtNjAsNyArNjAsNyBAQCBDYW52YXMyRExheWVyQ2hyb21pdW06On5DYW52YXMy RExheWVyQ2hyb21pdW0oKQogCiBib29sIENhbnZhczJETGF5ZXJDaHJvbWl1bTo6ZHJhd3NDb250 ZW50KCkgY29uc3QKIHsKLSAgICByZXR1cm4gKG1fY29udGV4dAorICAgIHJldHVybiBtX3RleHR1 cmVJZCAmJiAobV9jb250ZXh0CiAgICAgICAgICAgICAmJiAobV9jb250ZXh0LT5nZXRFeHRlbnNp b25zKCktPmdldEdyYXBoaWNzUmVzZXRTdGF0dXNBUkIoKSA9PSBHcmFwaGljc0NvbnRleHQzRDo6 Tk9fRVJST1IpKTsKIH0KIApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3Jh cGhpY3Mvc2tpYS9JbWFnZUJ1ZmZlclNraWEuY3BwIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0v Z3JhcGhpY3Mvc2tpYS9JbWFnZUJ1ZmZlclNraWEuY3BwCmluZGV4IDFjODI2Y2IwMmI0MDFlYjli YmFlODZiNWJhNGY4OTc3ZDUyODZhNWQuLjhiNTM5YzA3NDEzNWE2MGQxNDgyZDBlNjQwN2NkYzk4 MzJkNTQ5ZTggMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL3Nr aWEvSW1hZ2VCdWZmZXJTa2lhLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFw aGljcy9za2lhL0ltYWdlQnVmZmVyU2tpYS5jcHAKQEAgLTExNiw2ICsxMTYsMTAgQEAgSW1hZ2VC dWZmZXI6OkltYWdlQnVmZmVyKGNvbnN0IEludFNpemUmIHNpemUsIENvbG9yU3BhY2UsIFJlbmRl cmluZ01vZGUgcmVuZGVyaW4KIAogSW1hZ2VCdWZmZXI6On5JbWFnZUJ1ZmZlcigpCiB7CisjaWYg VVNFKEFDQ0VMRVJBVEVEX0NPTVBPU0lUSU5HKQorICAgIGlmIChtX2RhdGEubV9wbGF0Zm9ybUxh eWVyKQorICAgICAgICBtX2RhdGEubV9wbGF0Zm9ybUxheWVyLT5zZXRUZXh0dXJlSWQoMCk7Cisj ZW5kaWYKICAgICBpZiAobV9jb250ZXh0ICYmIG1fY29udGV4dC0+cGxhdGZvcm1Db250ZXh0KCkp IHsKICAgICAgICAgLy8gVGhpcyBpcyBzbyB0aGF0IHRoZSBTa0dwdURldmljZSBkZXN0cnVjdG9y IGhhcyB0aGUgY29ycmVjdCBjb250ZXh0LgogICAgICAgICBtX2NvbnRleHQtPnBsYXRmb3JtQ29u dGV4dCgpLT5tYWtlR3JDb250ZXh0Q3VycmVudCgpOwo=