67934 2011-09-12 07:38:28 -0700 Web Inspector: Runtime.callFunctionOn does not accept arguments that evaluate to false. 2011-09-12 08:24:02 -0700 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 0 pfeldman pfeldman apavlov bweinstein joepeck keishi loislo pfeldman pmuellr rik timothy yurys oldest_to_newest 465599 0 pfeldman 2011-09-12 07:38:28 -0700 Neither of null, false, undefined, "" is accepted. 465601 1 107052 pfeldman 2011-09-12 07:51:08 -0700 Created attachment 107052 Patch 465602 2 107052 loislo 2011-09-12 07:54:02 -0700 Comment on attachment 107052 Patch lgtm 465616 3 pfeldman 2011-09-12 08:24:02 -0700 Committed r94958: <http://trac.webkit.org/changeset/94958> 107052 2011-09-12 07:51:08 -0700 2011-09-12 08:06:36 -0700 Patch bug-67934-20110912185106.patch text/plain 6949 pfeldman U3VidmVyc2lvbiBSZXZpc2lvbjogOTQ5NDkKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5n ZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxvZwppbmRleCAwZDRiODc2YjY0OTc5Y2Y5ZTRmNDM0 NjI2YmZiMGVmNzViNGMwY2QyLi5lYzQzNzkyYzllMzczNzY5NGMwYWRiOTBmNTViMjRmOTlkZmRm ZjFkIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKKysrIGIvTGF5b3V0VGVzdHMv Q2hhbmdlTG9nCkBAIC0xLDMgKzEsMTIgQEAKKzIwMTEtMDktMTIgIFBhdmVsIEZlbGRtYW4gIDxw ZmVsZG1hbkBnb29nbGUuY29tPgorCisgICAgICAgIFdlYiBJbnNwZWN0b3I6IFJ1bnRpbWUuY2Fs bEZ1bmN0aW9uT24gZG9lcyBub3QgYWNjZXB0IGFyZ3VtZW50cyB0aGF0IGV2YWx1YXRlIHRvIGZh bHNlLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9Njc5 MzQKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIGlu c3BlY3Rvci9ydW50aW1lL3J1bnRpbWUtc2V0UHJvcGVydHlWYWx1ZS5odG1sOgorCiAyMDExLTA5 LTEyICBGdW1pdG9zaGkgVWthaSAgPHVrYWlAY2hyb21pdW0ub3JnPgogCiAgICAgICAgIFVucmV2 aWV3ZWQsIHVwZGF0ZSBjaHJvbWl1bSB0ZXN0IGV4cGVjdGF0aW9ucy4KZGlmZiAtLWdpdCBhL0xh eW91dFRlc3RzL2luc3BlY3Rvci9ydW50aW1lL3J1bnRpbWUtc2V0UHJvcGVydHlWYWx1ZS1leHBl Y3RlZC50eHQgYi9MYXlvdXRUZXN0cy9pbnNwZWN0b3IvcnVudGltZS9ydW50aW1lLXNldFByb3Bl cnR5VmFsdWUtZXhwZWN0ZWQudHh0CmluZGV4IGZmYmY2YzBkMzA1ODA3ZjQ0OTYyMWQyNzg2N2Jh ZjAzNGExNmI4ZmUuLjFhZGNhMzQxZjJkOTZkNTU5NjI3YmExMDM4MTk4ZDk3MWEyMjQyYmIgMTAw NjQ0Ci0tLSBhL0xheW91dFRlc3RzL2luc3BlY3Rvci9ydW50aW1lL3J1bnRpbWUtc2V0UHJvcGVy dHlWYWx1ZS1leHBlY3RlZC50eHQKKysrIGIvTGF5b3V0VGVzdHMvaW5zcGVjdG9yL3J1bnRpbWUv cnVudGltZS1zZXRQcm9wZXJ0eVZhbHVlLWV4cGVjdGVkLnR4dApAQCAtMSwyMyArMSwyNyBAQAog Q09OU09MRSBNRVNTQUdFOiBsaW5lIDExOiA9PT09PSBJbml0aWFsID09PT09CiBDT05TT0xFIE1F U1NBR0U6IGxpbmUgMTI6IHsiZm9vIjoxfQotQ09OU09MRSBNRVNTQUdFOiBsaW5lIDEzOiB7ImJh ciI6Mn0KLUNPTlNPTEUgTUVTU0FHRTogbGluZSAxNDogCitDT05TT0xFIE1FU1NBR0U6IGxpbmUg MTM6IAogQ09OU09MRSBNRVNTQUdFOiBsaW5lIDExOiA9PT09PSBTZXQgcHJpbWl0aXZlID09PT09 CiBDT05TT0xFIE1FU1NBR0U6IGxpbmUgMTI6IHsiZm9vIjoyfQotQ09OU09MRSBNRVNTQUdFOiBs aW5lIDEzOiB7ImJhciI6Mn0KLUNPTlNPTEUgTUVTU0FHRTogbGluZSAxNDogCitDT05TT0xFIE1F U1NBR0U6IGxpbmUgMTM6IAogQ09OU09MRSBNRVNTQUdFOiBsaW5lIDExOiA9PT09PSBTZXQgaGFu ZGxlID09PT09CiBDT05TT0xFIE1FU1NBR0U6IGxpbmUgMTI6IHsiZm9vIjp7ImJhciI6Mn19Ci1D T05TT0xFIE1FU1NBR0U6IGxpbmUgMTM6IHsiYmFyIjoyfQotQ09OU09MRSBNRVNTQUdFOiBsaW5l IDE0OiAKK0NPTlNPTEUgTUVTU0FHRTogbGluZSAxMzogCiBDT05TT0xFIE1FU1NBR0U6IGxpbmUg MTE6ID09PT09IFNldCB1bmRlZmluZWQgPT09PT0KIENPTlNPTEUgTUVTU0FHRTogbGluZSAxMjog e30KLUNPTlNPTEUgTUVTU0FHRTogbGluZSAxMzogeyJiYXIiOjJ9Ci1DT05TT0xFIE1FU1NBR0U6 IGxpbmUgMTQ6IAorQ09OU09MRSBNRVNTQUdFOiBsaW5lIDEzOiAKK0NPTlNPTEUgTUVTU0FHRTog bGluZSAxMTogPT09PT0gU2V0IHplcm8gPT09PT0KK0NPTlNPTEUgTUVTU0FHRTogbGluZSAxMjog eyJmb28iOjB9CitDT05TT0xFIE1FU1NBR0U6IGxpbmUgMTM6IAorQ09OU09MRSBNRVNTQUdFOiBs aW5lIDExOiA9PT09PSBTZXQgbnVsbCA9PT09PQorQ09OU09MRSBNRVNTQUdFOiBsaW5lIDEyOiB7 ImZvbyI6bnVsbH0KK0NPTlNPTEUgTUVTU0FHRTogbGluZSAxMzogCitDT05TT0xFIE1FU1NBR0U6 IGxpbmUgMTE6ID09PT09IFNldCBlbXB0eSBzdHJpbmcgPT09PT0KK0NPTlNPTEUgTUVTU0FHRTog bGluZSAxMjogeyJmb28iOiIifQorQ09OU09MRSBNRVNTQUdFOiBsaW5lIDEzOiAKIENPTlNPTEUg TUVTU0FHRTogbGluZSAxMTogPT09PT0gU2V0IGV4Y2VwdGlvbiA9PT09PQotQ09OU09MRSBNRVNT QUdFOiBsaW5lIDEyOiB7fQotQ09OU09MRSBNRVNTQUdFOiBsaW5lIDEzOiB7ImJhciI6Mn0KLUNP TlNPTEUgTUVTU0FHRTogbGluZSAxNDogCitDT05TT0xFIE1FU1NBR0U6IGxpbmUgMTI6IHsiZm9v IjoiIn0KK0NPTlNPTEUgTUVTU0FHRTogbGluZSAxMzogCiBUZXN0cyBXZWJJbnNwZWN0b3IuUmVt b3ZlT2JqZWN0LnNldFByb3BlcnR5VmFsdWUgaW1wbGVtZW50YXRpb24uCiAKIApAQCAtMjksNiAr MzMsMTIgQEAgUnVubmluZzogdGVzdFNldEhhbmRsZQogCiBSdW5uaW5nOiB0ZXN0U2V0VW5kZWZp bmVkCiAKK1J1bm5pbmc6IHRlc3RTZXRaZXJvCisKK1J1bm5pbmc6IHRlc3RTZXROdWxsCisKK1J1 bm5pbmc6IHRlc3RTZXRFbXB0eVN0cmluZworCiBSdW5uaW5nOiB0ZXN0U2V0RXhjZXB0aW9uCiB7 CiAgICAgdHlwZSA6ICJzdHJpbmciCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9pbnNwZWN0b3Iv cnVudGltZS9ydW50aW1lLXNldFByb3BlcnR5VmFsdWUuaHRtbCBiL0xheW91dFRlc3RzL2luc3Bl Y3Rvci9ydW50aW1lL3J1bnRpbWUtc2V0UHJvcGVydHlWYWx1ZS5odG1sCmluZGV4IDBlNDQ5NzVj Y2I2NzE3ZTQ4MGU4Njc0M2I4M2Q1ZmVhOTJlZWEzMzIuLmU0ZGE1YzljOGMyYTdlNGMzZTM2NjU0 NTQ3ZGMyMTkzZmQ4M2ZhNjAgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL2luc3BlY3Rvci9ydW50 aW1lL3J1bnRpbWUtc2V0UHJvcGVydHlWYWx1ZS5odG1sCisrKyBiL0xheW91dFRlc3RzL2luc3Bl Y3Rvci9ydW50aW1lL3J1bnRpbWUtc2V0UHJvcGVydHlWYWx1ZS5odG1sCkBAIC02LDExICs2LDEw IEBACiB2YXIgb2JqZWN0MSA9IHsgZm9vOiAxIH07CiB2YXIgb2JqZWN0MiA9IHsgYmFyOiAyIH07 CiAKLWZ1bmN0aW9uIGR1bXBPYmplY3RzKGxhYmVsKQorZnVuY3Rpb24gZHVtcE9iamVjdChsYWJl bCkKIHsKICAgICBjb25zb2xlLmxvZygiPT09PT0gIiArIGxhYmVsICsgIiA9PT09PSIpOwogICAg IGNvbnNvbGUubG9nKEpTT04uc3RyaW5naWZ5KG9iamVjdDEpKTsKLSAgICBjb25zb2xlLmxvZyhK U09OLnN0cmluZ2lmeShvYmplY3QyKSk7CiAgICAgY29uc29sZS5sb2coIiIpOwogfQogCkBAIC0y MSw3ICsyMCw3IEBAIGZ1bmN0aW9uIHRlc3QoKQogICAgIEluc3BlY3RvclRlc3QucnVuVGVzdFN1 aXRlKFsKICAgICAgICAgZnVuY3Rpb24gdGVzdFNldFVwKG5leHQpCiAgICAgICAgIHsKLSAgICAg ICAgICAgIEluc3BlY3RvclRlc3QuZXZhbHVhdGVJblBhZ2UoImR1bXBPYmplY3RzKCdJbml0aWFs JykiLCBzdGVwMCk7CisgICAgICAgICAgICBJbnNwZWN0b3JUZXN0LmV2YWx1YXRlSW5QYWdlKCJk dW1wT2JqZWN0KCdJbml0aWFsJykiLCBzdGVwMCk7CiAKICAgICAgICAgICAgIGZ1bmN0aW9uIHN0 ZXAwKCkKICAgICAgICAgICAgIHsKQEAgLTQ3LDcgKzQ2LDcgQEAgZnVuY3Rpb24gdGVzdCgpCiAK ICAgICAgICAgICAgIGZ1bmN0aW9uIHN0ZXAxKCkKICAgICAgICAgICAgIHsKLSAgICAgICAgICAg ICAgICBJbnNwZWN0b3JUZXN0LmV2YWx1YXRlSW5QYWdlKCJkdW1wT2JqZWN0cygnU2V0IHByaW1p dGl2ZScpIiwgbmV4dCk7CisgICAgICAgICAgICAgICAgSW5zcGVjdG9yVGVzdC5ldmFsdWF0ZUlu UGFnZSgiZHVtcE9iamVjdCgnU2V0IHByaW1pdGl2ZScpIiwgbmV4dCk7CiAgICAgICAgICAgICB9 CiAgICAgICAgIH0sCiAKQEAgLTU3LDcgKzU2LDcgQEAgZnVuY3Rpb24gdGVzdCgpCiAKICAgICAg ICAgICAgIGZ1bmN0aW9uIHN0ZXAxKCkKICAgICAgICAgICAgIHsKLSAgICAgICAgICAgICAgICBJ bnNwZWN0b3JUZXN0LmV2YWx1YXRlSW5QYWdlKCJkdW1wT2JqZWN0cygnU2V0IGhhbmRsZScpIiwg bmV4dCk7CisgICAgICAgICAgICAgICAgSW5zcGVjdG9yVGVzdC5ldmFsdWF0ZUluUGFnZSgiZHVt cE9iamVjdCgnU2V0IGhhbmRsZScpIiwgbmV4dCk7CiAgICAgICAgICAgICB9CiAgICAgICAgIH0s CiAKQEAgLTY3LDcgKzY2LDM3IEBAIGZ1bmN0aW9uIHRlc3QoKQogCiAgICAgICAgICAgICBmdW5j dGlvbiBzdGVwMSgpCiAgICAgICAgICAgICB7Ci0gICAgICAgICAgICAgICAgSW5zcGVjdG9yVGVz dC5ldmFsdWF0ZUluUGFnZSgiZHVtcE9iamVjdHMoJ1NldCB1bmRlZmluZWQnKSIsIG5leHQpOwor ICAgICAgICAgICAgICAgIEluc3BlY3RvclRlc3QuZXZhbHVhdGVJblBhZ2UoImR1bXBPYmplY3Qo J1NldCB1bmRlZmluZWQnKSIsIG5leHQpOworICAgICAgICAgICAgfQorICAgICAgICB9LAorCisg ICAgICAgIGZ1bmN0aW9uIHRlc3RTZXRaZXJvKG5leHQpCisgICAgICAgIHsKKyAgICAgICAgICAg IG9iajEuc2V0UHJvcGVydHlWYWx1ZSgiZm9vIiwgIjAiLCBzdGVwMSk7CisKKyAgICAgICAgICAg IGZ1bmN0aW9uIHN0ZXAxKCkKKyAgICAgICAgICAgIHsKKyAgICAgICAgICAgICAgICBJbnNwZWN0 b3JUZXN0LmV2YWx1YXRlSW5QYWdlKCJkdW1wT2JqZWN0KCdTZXQgemVybycpIiwgbmV4dCk7Cisg ICAgICAgICAgICB9CisgICAgICAgIH0sCisKKyAgICAgICAgZnVuY3Rpb24gdGVzdFNldE51bGwo bmV4dCkKKyAgICAgICAgeworICAgICAgICAgICAgb2JqMS5zZXRQcm9wZXJ0eVZhbHVlKCJmb28i LCAibnVsbCIsIHN0ZXAxKTsKKworICAgICAgICAgICAgZnVuY3Rpb24gc3RlcDEoKQorICAgICAg ICAgICAgeworICAgICAgICAgICAgICAgIEluc3BlY3RvclRlc3QuZXZhbHVhdGVJblBhZ2UoImR1 bXBPYmplY3QoJ1NldCBudWxsJykiLCBuZXh0KTsKKyAgICAgICAgICAgIH0KKyAgICAgICAgfSwK KworICAgICAgICBmdW5jdGlvbiB0ZXN0U2V0RW1wdHlTdHJpbmcobmV4dCkKKyAgICAgICAgewor ICAgICAgICAgICAgb2JqMS5zZXRQcm9wZXJ0eVZhbHVlKCJmb28iLCAiXCJcIiIsIHN0ZXAxKTsK KworICAgICAgICAgICAgZnVuY3Rpb24gc3RlcDEoKQorICAgICAgICAgICAgeworICAgICAgICAg ICAgICAgIEluc3BlY3RvclRlc3QuZXZhbHVhdGVJblBhZ2UoImR1bXBPYmplY3QoJ1NldCBlbXB0 eSBzdHJpbmcnKSIsIG5leHQpOwogICAgICAgICAgICAgfQogICAgICAgICB9LAogCkBAIC03OCw3 ICsxMDcsNyBAQCBmdW5jdGlvbiB0ZXN0KCkKICAgICAgICAgICAgIGZ1bmN0aW9uIHN0ZXAxKGVy cm9yKQogICAgICAgICAgICAgewogICAgICAgICAgICAgICAgIEluc3BlY3RvclRlc3QuZHVtcChl cnJvcik7Ci0gICAgICAgICAgICAgICAgSW5zcGVjdG9yVGVzdC5ldmFsdWF0ZUluUGFnZSgiZHVt cE9iamVjdHMoJ1NldCBleGNlcHRpb24nKSIsIG5leHQpOworICAgICAgICAgICAgICAgIEluc3Bl Y3RvclRlc3QuZXZhbHVhdGVJblBhZ2UoImR1bXBPYmplY3QoJ1NldCBleGNlcHRpb24nKSIsIG5l eHQpOwogICAgICAgICAgICAgfQogICAgICAgICB9CiAgICAgXSk7CmRpZmYgLS1naXQgYS9Tb3Vy Y2UvV2ViQ29yZS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYjE2 N2YzN2MwY2E0Y2JkODRmNjlhNzAyZGMwNjIzYzRmY2JmNjg0OS4uZmI5MjVlZmJjMmM4Zjk4NjFk MGQwZjE4Nzc4Y2I4ODg1YzI5YzhmYiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdl TG9nCisrKyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEyIEBACisyMDEx LTA5LTEyICBQYXZlbCBGZWxkbWFuICA8cGZlbGRtYW5AZ29vZ2xlLmNvbT4KKworICAgICAgICBX ZWIgSW5zcGVjdG9yOiBSdW50aW1lLmNhbGxGdW5jdGlvbk9uIGRvZXMgbm90IGFjY2VwdCBhcmd1 bWVudHMgdGhhdCBldmFsdWF0ZSB0byBmYWxzZS4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtp dC5vcmcvc2hvd19idWcuY2dpP2lkPTY3OTM0CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZ IChPT1BTISkuCisKKyAgICAgICAgKiBpbnNwZWN0b3IvSW5qZWN0ZWRTY3JpcHRTb3VyY2UuanM6 CisKIDIwMTEtMDktMTIgIFNoaW55YSBLYXdhbmFrYSAgPHNoaW55YWtAZ29vZ2xlLmNvbT4KIAog ICAgICAgICBDaGFyYWN0ZXJzIGJleW9uZCBVKzEwMDAwIHNob3VsZCBiZSBkZWxldGVkIGJ5IG9u ZSBwcmVzc2luZyBkZWxldGUga2V5LgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvaW5zcGVj dG9yL0luamVjdGVkU2NyaXB0U291cmNlLmpzIGIvU291cmNlL1dlYkNvcmUvaW5zcGVjdG9yL0lu amVjdGVkU2NyaXB0U291cmNlLmpzCmluZGV4IDExNGFhYjVkMjllNjc4MWZiMzg0ZGM2YzY3Mjc4 MTk3ZTgyMTYxMzIuLmM2Y2E1ZjZiNzI4YTYyODYzODJlZTI4M2JiZjlkNGQ5MzkzMDM0OGMgMTAw NjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9JbmplY3RlZFNjcmlwdFNvdXJjZS5q cworKysgYi9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvSW5qZWN0ZWRTY3JpcHRTb3VyY2UuanMK QEAgLTI3NSw3ICsyNzUsNyBAQCBJbmplY3RlZFNjcmlwdC5wcm90b3R5cGUgPSB7CiAgICAgICAg ICAgICAgICAgICAgICAgICByZXR1cm4gIkNvdWxkIG5vdCBmaW5kIG9iamVjdCB3aXRoIGdpdmVu IGlkIjsKIAogICAgICAgICAgICAgICAgICAgICByZXNvbHZlZEFyZ3MucHVzaChyZXNvbHZlZEFy Zyk7Ci0gICAgICAgICAgICAgICAgfSBlbHNlIGlmIChhcmdzW2ldLnZhbHVlKQorICAgICAgICAg ICAgICAgIH0gZWxzZSBpZiAoInZhbHVlIiBpbiBhcmdzW2ldKQogICAgICAgICAgICAgICAgICAg ICByZXNvbHZlZEFyZ3MucHVzaChhcmdzW2ldLnZhbHVlKTsKICAgICAgICAgICAgICAgICBlbHNl CiAgICAgICAgICAgICAgICAgICAgIHJlc29sdmVkQXJncy5wdXNoKHVuZGVmaW5lZCk7Cg==