67932 2011-09-12 06:32:51 -0700 Web Inspector: event dividers do not update timeline boundaries. 2011-09-12 08:21:42 -0700 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 0 pfeldman pfeldman apavlov bweinstein joepeck keishi loislo pfeldman pmuellr rik timothy yurys oldest_to_newest 465585 0 pfeldman 2011-09-12 06:32:51 -0700 Events (as resources) should update timeline boundaries. 465588 1 107048 pfeldman 2011-09-12 06:34:42 -0700 Created attachment 107048 Patch 465598 2 107048 loislo 2011-09-12 07:33:16 -0700 Comment on attachment 107048 Patch LGTM 465606 3 107048 tonyg 2011-09-12 08:03:59 -0700 Comment on attachment 107048 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=107048&action=review > Source/WebCore/inspector/front-end/NetworkPanel.js:630 > + // Schedule refresh to update boundaries and draw the new line. Up to you, but both of these comments seem a bit gratuitous. They don't convey much more info than the method name. > Source/WebCore/inspector/front-end/NetworkPanel.js:667 > + boundariesChanged = this.calculator.updateBoundariesForEventTime(this._mainResourceDOMContentTime) || boundariesChanged; Cleaner to use |= for these two, right? 465612 4 107048 pfeldman 2011-09-12 08:19:29 -0700 Comment on attachment 107048 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=107048&action=review >> Source/WebCore/inspector/front-end/NetworkPanel.js:667 >> + boundariesChanged = this.calculator.updateBoundariesForEventTime(this._mainResourceDOMContentTime) || boundariesChanged; > > Cleaner to use |= for these two, right? Not really: - |= is bitwise operator - I need boundaries to be updated even when boundariesChanged is true. 465614 5 pfeldman 2011-09-12 08:21:42 -0700 Committed r94957: <http://trac.webkit.org/changeset/94957> 107048 2011-09-12 06:34:42 -0700 2011-09-12 08:19:29 -0700 Patch bug-67932-20110912173439.patch text/plain 3169 pfeldman U3VidmVyc2lvbiBSZXZpc2lvbjogOTQ5NDkKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCBiMTY3ZjM3YzBjYTRjYmQ4 NGY2OWE3MDJkYzA2MjNjNGZjYmY2ODQ5Li45YzE5Y2E5ZmRhMTIyNWQ0Yjc4YmY2ZmVlMmM5M2Y0 OTUzYzY2YWIwIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvU291 cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTQgQEAKKzIwMTEtMDktMTIgIFBhdmVs IEZlbGRtYW4gIDxwZmVsZG1hbkBnb29nbGUuY29tPgorCisgICAgICAgIFdlYiBJbnNwZWN0b3I6 IGV2ZW50IGRpdmlkZXJzIGRvIG5vdCB1cGRhdGUgdGltZWxpbmUgYm91bmRhcmllcy4KKyAgICAg ICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTY3OTMyCisKKyAgICAg ICAgKiBpbnNwZWN0b3IvZnJvbnQtZW5kL05ldHdvcmtQYW5lbC5qczoKKyAgICAgICAgKFdlYklu c3BlY3Rvci5OZXR3b3JrTG9nVmlldy5wcm90b3R5cGUuX29uTG9hZEV2ZW50RmlyZWQpOgorICAg ICAgICAoV2ViSW5zcGVjdG9yLk5ldHdvcmtMb2dWaWV3LnByb3RvdHlwZS5fZG9tQ29udGVudExv YWRlZEV2ZW50RmlyZWQpOgorICAgICAgICAoV2ViSW5zcGVjdG9yLk5ldHdvcmtMb2dWaWV3LnBy b3RvdHlwZS5yZWZyZXNoKToKKyAgICAgICAgKFdlYkluc3BlY3Rvci5OZXR3b3JrVGltZUNhbGN1 bGF0b3IucHJvdG90eXBlLnVwZGF0ZUJvdW5kYXJpZXNGb3JFdmVudFRpbWUpOgorCiAyMDExLTA5 LTEyICBTaGlueWEgS2F3YW5ha2EgIDxzaGlueWFrQGdvb2dsZS5jb20+CiAKICAgICAgICAgQ2hh cmFjdGVycyBiZXlvbmQgVSsxMDAwMCBzaG91bGQgYmUgZGVsZXRlZCBieSBvbmUgcHJlc3Npbmcg ZGVsZXRlIGtleS4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9mcm9udC1l bmQvTmV0d29ya1BhbmVsLmpzIGIvU291cmNlL1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250LWVuZC9O ZXR3b3JrUGFuZWwuanMKaW5kZXggMzFjZDQ4ZjA5ODU1NzMyOTMxMjJkYjcyNDQyMzEzMDMzNzIz MmQwZC4uNTQ2M2QwYmNhMWJhMzJlNzQ5NjE1MTVjMGE4NDU3YmU2YzRmM2E4YSAxMDA2NDQKLS0t IGEvU291cmNlL1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250LWVuZC9OZXR3b3JrUGFuZWwuanMKKysr IGIvU291cmNlL1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250LWVuZC9OZXR3b3JrUGFuZWwuanMKQEAg LTYyNywxNCArNjI3LDE1IEBAIFdlYkluc3BlY3Rvci5OZXR3b3JrTG9nVmlldy5wcm90b3R5cGUg PSB7CiAgICAgX29uTG9hZEV2ZW50RmlyZWQ6IGZ1bmN0aW9uKGV2ZW50KQogICAgIHsKICAgICAg ICAgdGhpcy5fbWFpblJlc291cmNlTG9hZFRpbWUgPSBldmVudC5kYXRhIHx8IC0xOwotICAgICAg ICAvLyBVcGRhdGUgdGhlIGRpdmlkZXJzIHRvIGRyYXcgdGhlIG5ldyBsaW5lCi0gICAgICAgIHRo aXMuX3VwZGF0ZURpdmlkZXJzSWZOZWVkZWQodHJ1ZSk7CisgICAgICAgIC8vIFNjaGVkdWxlIHJl ZnJlc2ggdG8gdXBkYXRlIGJvdW5kYXJpZXMgYW5kIGRyYXcgdGhlIG5ldyBsaW5lLgorICAgICAg ICB0aGlzLl9zY2hlZHVsZVJlZnJlc2godHJ1ZSk7CiAgICAgfSwKIAogICAgIF9kb21Db250ZW50 TG9hZGVkRXZlbnRGaXJlZDogZnVuY3Rpb24oZXZlbnQpCiAgICAgewogICAgICAgICB0aGlzLl9t YWluUmVzb3VyY2VET01Db250ZW50VGltZSA9IGV2ZW50LmRhdGEgfHwgLTE7Ci0gICAgICAgIHRo aXMuX3VwZGF0ZURpdmlkZXJzSWZOZWVkZWQodHJ1ZSk7CisgICAgICAgIC8vIFNjaGVkdWxlIHJl ZnJlc2ggdG8gdXBkYXRlIGJvdW5kYXJpZXMgYW5kIGRyYXcgdGhlIG5ldyBsaW5lLgorICAgICAg ICB0aGlzLl9zY2hlZHVsZVJlZnJlc2godHJ1ZSk7CiAgICAgfSwKIAogICAgIHdhc1Nob3duOiBm dW5jdGlvbigpCkBAIC02NjEsNiArNjYyLDEwIEBAIFdlYkluc3BlY3Rvci5OZXR3b3JrTG9nVmll dy5wcm90b3R5cGUgPSB7CiAgICAgICAgIHZhciB3YXNTY3JvbGxlZFRvTGFzdFJvdyA9IHRoaXMu X2RhdGFHcmlkLmlzU2Nyb2xsZWRUb0xhc3RSb3coKTsKICAgICAgICAgdmFyIHN0YWxlSXRlbXNM ZW5ndGggPSB0aGlzLl9zdGFsZVJlc291cmNlcy5sZW5ndGg7CiAgICAgICAgIHZhciBib3VuZGFy aWVzQ2hhbmdlZCA9IGZhbHNlOworICAgICAgICBpZiAodGhpcy5jYWxjdWxhdG9yLnVwZGF0ZUJv dW5kYXJpZXNGb3JFdmVudFRpbWUpIHsKKyAgICAgICAgICAgIGJvdW5kYXJpZXNDaGFuZ2VkID0g dGhpcy5jYWxjdWxhdG9yLnVwZGF0ZUJvdW5kYXJpZXNGb3JFdmVudFRpbWUodGhpcy5fbWFpblJl c291cmNlTG9hZFRpbWUpIHx8IGJvdW5kYXJpZXNDaGFuZ2VkOworICAgICAgICAgICAgYm91bmRh cmllc0NoYW5nZWQgPSB0aGlzLmNhbGN1bGF0b3IudXBkYXRlQm91bmRhcmllc0ZvckV2ZW50VGlt ZSh0aGlzLl9tYWluUmVzb3VyY2VET01Db250ZW50VGltZSkgfHwgYm91bmRhcmllc0NoYW5nZWQ7 CisgICAgICAgIH0KIAogICAgICAgICBmb3IgKHZhciBpID0gMDsgaSA8IHN0YWxlSXRlbXNMZW5n dGg7ICsraSkgewogICAgICAgICAgICAgdmFyIHJlc291cmNlID0gdGhpcy5fc3RhbGVSZXNvdXJj ZXNbaV07CkBAIC0xNjcwLDYgKzE2NzUsMTggQEAgV2ViSW5zcGVjdG9yLk5ldHdvcmtUaW1lQ2Fs Y3VsYXRvci5wcm90b3R5cGUgPSB7CiAgICAgICAgIHJldHVybiAwOwogICAgIH0sCiAKKyAgICB1 cGRhdGVCb3VuZGFyaWVzRm9yRXZlbnRUaW1lOiBmdW5jdGlvbihldmVudFRpbWUpCisgICAgewor ICAgICAgICBpZiAoZXZlbnRUaW1lID09PSAtMSB8fCB0aGlzLnN0YXJ0QXRaZXJvKQorICAgICAg ICAgICAgcmV0dXJuIGZhbHNlOworCisgICAgICAgIGlmICh0eXBlb2YgdGhpcy5tYXhpbXVtQm91 bmRhcnkgPT09ICJ1bmRlZmluZWQiIHx8IGV2ZW50VGltZSA+IHRoaXMubWF4aW11bUJvdW5kYXJ5 KSB7CisgICAgICAgICAgICB0aGlzLm1heGltdW1Cb3VuZGFyeSA9IGV2ZW50VGltZTsKKyAgICAg ICAgICAgIHJldHVybiB0cnVlOworICAgICAgICB9CisgICAgICAgIHJldHVybiBmYWxzZTsKKyAg ICB9LAorCiAgICAgY29tcHV0ZUJhckdyYXBoTGFiZWxzOiBmdW5jdGlvbihyZXNvdXJjZSkKICAg ICB7CiAgICAgICAgIHZhciByaWdodExhYmVsID0gIiI7Cg==