67928 2011-09-12 03:56:04 -0700 [Qt] Build fails after r94920 with strict compiler 2011-09-12 06:34:16 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) All Linux RESOLVED FIXED P2 Normal --- 43191 1 abecsi abecsi cmarcelo ossy oldest_to_newest 465553 0 abecsi 2011-09-12 03:56:04 -0700 The newly added wtf/RedBlackTree.h contains the variable Node* updateStart which is set but never used. This gives an error on newer gcc when Werror is set. Remove this dead variable. 465554 1 107036 abecsi 2011-09-12 03:59:23 -0700 Created attachment 107036 proposed fix 465567 2 cmarcelo 2011-09-12 04:49:20 -0700 LGTM, although I'm not a reviewer. New Red Black tree is based on PODRedBlackTree.h. The 'updateStart' variable was used to call 'updateNode' on the ascendants of the topmost updated node. The new one (RedBlackTree.h) doesn't have this functionality, so it is OK to remove. 465568 3 107036 cmarcelo 2011-09-12 05:00:14 -0700 Comment on attachment 107036 proposed fix View in context: https://bugs.webkit.org/attachment.cgi?id=107036&action=review Ops. Doesn't LGTM yet :P > Source/JavaScriptCore/wtf/RedBlackTree.h:-196 > - Node* newSubTreeRoot = rightRotate(x->parent()->parent()); You need to keep this rightRotate, just ignore the return value. > Source/JavaScriptCore/wtf/RedBlackTree.h:-218 > - Node* newSubTreeRoot = leftRotate(x->parent()->parent()); You need to keep this leftRotate, just ignore the return value. 465575 4 107043 abecsi 2011-09-12 06:06:50 -0700 Created attachment 107043 proposed patch 465579 5 107043 ossy 2011-09-12 06:24:56 -0700 Comment on attachment 107043 proposed patch LGTM, r=me. ( But cq-, because commit queue still doesn't like my name :( ) 465586 6 abecsi 2011-09-12 06:33:14 -0700 Committed r94954: <http://trac.webkit.org/changeset/94954> 465587 7 107043 abecsi 2011-09-12 06:34:16 -0700 Comment on attachment 107043 proposed patch Clearing flags from landed patch. 107036 2011-09-12 03:59:23 -0700 2011-09-12 06:06:50 -0700 proposed fix patch.diff text/plain 2720 abecsi ZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cgYi9Tb3VyY2UvSmF2 YVNjcmlwdENvcmUvQ2hhbmdlTG9nCmluZGV4IDUyMDFiYTYuLjk3NGVjNzggMTAwNjQ0Ci0tLSBh L1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL0phdmFTY3JpcHRD b3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEzIEBACisyMDExLTA5LTEyICBBbmRyYXMgQmVjc2kg IDxhbmRyYXMuYmVjc2lAbm9raWEuY29tPgorCisgICAgICAgIFtRdF0gQnVpbGQgZmFpbHMgYWZ0 ZXIgcjk0OTIwIHdpdGggc3RyaWN0IGNvbXBpbGVyCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJr aXQub3JnL3Nob3dfYnVnLmNnaT9pZD02NzkyOAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgICogd3RmL1JlZEJsYWNrVHJlZS5oOgorICAgICAgICAoV1RG OjpSZWRCbGFja1RyZWU6Omluc2VydCk6IFJlbW92ZSBkZWFkIHZhcmlhYmxlcyB1cGRhdGVTdGFy dCBhbmQgbmV3U3ViVHJlZVJvb3QuCisKIDIwMTEtMDktMTEgIEZpbGlwIFBpemxvICA8ZnBpemxv QGFwcGxlLmNvbT4KIAogICAgICAgICBERkdOb2RlLmggaGFzIG1hY3JvcyB0aGF0IGluZGljYXRl IHRoZSBlbmFibGluZyBvZiBhIGZlYXR1cmUsIGJ1dApkaWZmIC0tZ2l0IGEvU291cmNlL0phdmFT Y3JpcHRDb3JlL3d0Zi9SZWRCbGFja1RyZWUuaCBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS93dGYv UmVkQmxhY2tUcmVlLmgKaW5kZXggOWVmZTI3MC4uOTMwY2IyYSAxMDA2NDQKLS0tIGEvU291cmNl L0phdmFTY3JpcHRDb3JlL3d0Zi9SZWRCbGFja1RyZWUuaAorKysgYi9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvd3RmL1JlZEJsYWNrVHJlZS5oCkBAIC0xNzEsOSArMTcxLDYgQEAgcHVibGljOgogICAg ICAgICB0cmVlSW5zZXJ0KHgpOwogICAgICAgICB4LT5zZXRDb2xvcihSZWQpOwogCi0gICAgICAg IC8vIFRoZSBub2RlIGZyb20gd2hpY2ggdG8gc3RhcnQgcHJvcGFnYXRpbmcgdXBkYXRlcyB1cHdh cmRzLgotICAgICAgICBOb2RlKiB1cGRhdGVTdGFydCA9IHgtPnBhcmVudCgpOwotCiAgICAgICAg IHdoaWxlICh4ICE9IG1fcm9vdCAmJiB4LT5wYXJlbnQoKS0+Y29sb3IoKSA9PSBSZWQpIHsKICAg ICAgICAgICAgIGlmICh4LT5wYXJlbnQoKSA9PSB4LT5wYXJlbnQoKS0+cGFyZW50KCktPmxlZnQo KSkgewogICAgICAgICAgICAgICAgIE5vZGUqIHkgPSB4LT5wYXJlbnQoKS0+cGFyZW50KCktPnJp Z2h0KCk7CkBAIC0xODMsNyArMTgwLDYgQEAgcHVibGljOgogICAgICAgICAgICAgICAgICAgICB5 LT5zZXRDb2xvcihCbGFjayk7CiAgICAgICAgICAgICAgICAgICAgIHgtPnBhcmVudCgpLT5wYXJl bnQoKS0+c2V0Q29sb3IoUmVkKTsKICAgICAgICAgICAgICAgICAgICAgeCA9IHgtPnBhcmVudCgp LT5wYXJlbnQoKTsKLSAgICAgICAgICAgICAgICAgICAgdXBkYXRlU3RhcnQgPSB4LT5wYXJlbnQo KTsKICAgICAgICAgICAgICAgICB9IGVsc2UgewogICAgICAgICAgICAgICAgICAgICBpZiAoeCA9 PSB4LT5wYXJlbnQoKS0+cmlnaHQoKSkgewogICAgICAgICAgICAgICAgICAgICAgICAgLy8gQ2Fz ZSAyCkBAIC0xOTMsOCArMTg5LDYgQEAgcHVibGljOgogICAgICAgICAgICAgICAgICAgICAvLyBD YXNlIDMKICAgICAgICAgICAgICAgICAgICAgeC0+cGFyZW50KCktPnNldENvbG9yKEJsYWNrKTsK ICAgICAgICAgICAgICAgICAgICAgeC0+cGFyZW50KCktPnBhcmVudCgpLT5zZXRDb2xvcihSZWQp OwotICAgICAgICAgICAgICAgICAgICBOb2RlKiBuZXdTdWJUcmVlUm9vdCA9IHJpZ2h0Um90YXRl KHgtPnBhcmVudCgpLT5wYXJlbnQoKSk7Ci0gICAgICAgICAgICAgICAgICAgIHVwZGF0ZVN0YXJ0 ID0gbmV3U3ViVHJlZVJvb3QtPnBhcmVudCgpOwogICAgICAgICAgICAgICAgIH0KICAgICAgICAg ICAgIH0gZWxzZSB7CiAgICAgICAgICAgICAgICAgLy8gU2FtZSBhcyAidGhlbiIgY2xhdXNlIHdp dGggInJpZ2h0IiBhbmQgImxlZnQiIGV4Y2hhbmdlZC4KQEAgLTIwNSw3ICsxOTksNiBAQCBwdWJs aWM6CiAgICAgICAgICAgICAgICAgICAgIHktPnNldENvbG9yKEJsYWNrKTsKICAgICAgICAgICAg ICAgICAgICAgeC0+cGFyZW50KCktPnBhcmVudCgpLT5zZXRDb2xvcihSZWQpOwogICAgICAgICAg ICAgICAgICAgICB4ID0geC0+cGFyZW50KCktPnBhcmVudCgpOwotICAgICAgICAgICAgICAgICAg ICB1cGRhdGVTdGFydCA9IHgtPnBhcmVudCgpOwogICAgICAgICAgICAgICAgIH0gZWxzZSB7CiAg ICAgICAgICAgICAgICAgICAgIGlmICh4ID09IHgtPnBhcmVudCgpLT5sZWZ0KCkpIHsKICAgICAg ICAgICAgICAgICAgICAgICAgIC8vIENhc2UgMgpAQCAtMjE1LDggKzIwOCw2IEBAIHB1YmxpYzoK ICAgICAgICAgICAgICAgICAgICAgLy8gQ2FzZSAzCiAgICAgICAgICAgICAgICAgICAgIHgtPnBh cmVudCgpLT5zZXRDb2xvcihCbGFjayk7CiAgICAgICAgICAgICAgICAgICAgIHgtPnBhcmVudCgp LT5wYXJlbnQoKS0+c2V0Q29sb3IoUmVkKTsKLSAgICAgICAgICAgICAgICAgICAgTm9kZSogbmV3 U3ViVHJlZVJvb3QgPSBsZWZ0Um90YXRlKHgtPnBhcmVudCgpLT5wYXJlbnQoKSk7Ci0gICAgICAg ICAgICAgICAgICAgIHVwZGF0ZVN0YXJ0ID0gbmV3U3ViVHJlZVJvb3QtPnBhcmVudCgpOwogICAg ICAgICAgICAgICAgIH0KICAgICAgICAgICAgIH0KICAgICAgICAgfQo= 107043 2011-09-12 06:06:50 -0700 2011-09-12 06:34:16 -0700 proposed patch patch.diff text/plain 2833 abecsi ZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cgYi9Tb3VyY2UvSmF2 YVNjcmlwdENvcmUvQ2hhbmdlTG9nCmluZGV4IDUyMDFiYTYuLjk3NGVjNzggMTAwNjQ0Ci0tLSBh L1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL0phdmFTY3JpcHRD b3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEzIEBACisyMDExLTA5LTEyICBBbmRyYXMgQmVjc2kg IDxhbmRyYXMuYmVjc2lAbm9raWEuY29tPgorCisgICAgICAgIFtRdF0gQnVpbGQgZmFpbHMgYWZ0 ZXIgcjk0OTIwIHdpdGggc3RyaWN0IGNvbXBpbGVyCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJr aXQub3JnL3Nob3dfYnVnLmNnaT9pZD02NzkyOAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgICogd3RmL1JlZEJsYWNrVHJlZS5oOgorICAgICAgICAoV1RG OjpSZWRCbGFja1RyZWU6Omluc2VydCk6IFJlbW92ZSBkZWFkIHZhcmlhYmxlcyB1cGRhdGVTdGFy dCBhbmQgbmV3U3ViVHJlZVJvb3QuCisKIDIwMTEtMDktMTEgIEZpbGlwIFBpemxvICA8ZnBpemxv QGFwcGxlLmNvbT4KIAogICAgICAgICBERkdOb2RlLmggaGFzIG1hY3JvcyB0aGF0IGluZGljYXRl IHRoZSBlbmFibGluZyBvZiBhIGZlYXR1cmUsIGJ1dApkaWZmIC0tZ2l0IGEvU291cmNlL0phdmFT Y3JpcHRDb3JlL3d0Zi9SZWRCbGFja1RyZWUuaCBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS93dGYv UmVkQmxhY2tUcmVlLmgKaW5kZXggOWVmZTI3MC4uYWY0ZTVjOCAxMDA2NDQKLS0tIGEvU291cmNl L0phdmFTY3JpcHRDb3JlL3d0Zi9SZWRCbGFja1RyZWUuaAorKysgYi9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvd3RmL1JlZEJsYWNrVHJlZS5oCkBAIC0xNzEsOSArMTcxLDYgQEAgcHVibGljOgogICAg ICAgICB0cmVlSW5zZXJ0KHgpOwogICAgICAgICB4LT5zZXRDb2xvcihSZWQpOwogCi0gICAgICAg IC8vIFRoZSBub2RlIGZyb20gd2hpY2ggdG8gc3RhcnQgcHJvcGFnYXRpbmcgdXBkYXRlcyB1cHdh cmRzLgotICAgICAgICBOb2RlKiB1cGRhdGVTdGFydCA9IHgtPnBhcmVudCgpOwotCiAgICAgICAg IHdoaWxlICh4ICE9IG1fcm9vdCAmJiB4LT5wYXJlbnQoKS0+Y29sb3IoKSA9PSBSZWQpIHsKICAg ICAgICAgICAgIGlmICh4LT5wYXJlbnQoKSA9PSB4LT5wYXJlbnQoKS0+cGFyZW50KCktPmxlZnQo KSkgewogICAgICAgICAgICAgICAgIE5vZGUqIHkgPSB4LT5wYXJlbnQoKS0+cGFyZW50KCktPnJp Z2h0KCk7CkBAIC0xODMsNyArMTgwLDYgQEAgcHVibGljOgogICAgICAgICAgICAgICAgICAgICB5 LT5zZXRDb2xvcihCbGFjayk7CiAgICAgICAgICAgICAgICAgICAgIHgtPnBhcmVudCgpLT5wYXJl bnQoKS0+c2V0Q29sb3IoUmVkKTsKICAgICAgICAgICAgICAgICAgICAgeCA9IHgtPnBhcmVudCgp LT5wYXJlbnQoKTsKLSAgICAgICAgICAgICAgICAgICAgdXBkYXRlU3RhcnQgPSB4LT5wYXJlbnQo KTsKICAgICAgICAgICAgICAgICB9IGVsc2UgewogICAgICAgICAgICAgICAgICAgICBpZiAoeCA9 PSB4LT5wYXJlbnQoKS0+cmlnaHQoKSkgewogICAgICAgICAgICAgICAgICAgICAgICAgLy8gQ2Fz ZSAyCkBAIC0xOTMsOCArMTg5LDcgQEAgcHVibGljOgogICAgICAgICAgICAgICAgICAgICAvLyBD YXNlIDMKICAgICAgICAgICAgICAgICAgICAgeC0+cGFyZW50KCktPnNldENvbG9yKEJsYWNrKTsK ICAgICAgICAgICAgICAgICAgICAgeC0+cGFyZW50KCktPnBhcmVudCgpLT5zZXRDb2xvcihSZWQp OwotICAgICAgICAgICAgICAgICAgICBOb2RlKiBuZXdTdWJUcmVlUm9vdCA9IHJpZ2h0Um90YXRl KHgtPnBhcmVudCgpLT5wYXJlbnQoKSk7Ci0gICAgICAgICAgICAgICAgICAgIHVwZGF0ZVN0YXJ0 ID0gbmV3U3ViVHJlZVJvb3QtPnBhcmVudCgpOworICAgICAgICAgICAgICAgICAgICByaWdodFJv dGF0ZSh4LT5wYXJlbnQoKS0+cGFyZW50KCkpOwogICAgICAgICAgICAgICAgIH0KICAgICAgICAg ICAgIH0gZWxzZSB7CiAgICAgICAgICAgICAgICAgLy8gU2FtZSBhcyAidGhlbiIgY2xhdXNlIHdp dGggInJpZ2h0IiBhbmQgImxlZnQiIGV4Y2hhbmdlZC4KQEAgLTIwNSw3ICsyMDAsNiBAQCBwdWJs aWM6CiAgICAgICAgICAgICAgICAgICAgIHktPnNldENvbG9yKEJsYWNrKTsKICAgICAgICAgICAg ICAgICAgICAgeC0+cGFyZW50KCktPnBhcmVudCgpLT5zZXRDb2xvcihSZWQpOwogICAgICAgICAg ICAgICAgICAgICB4ID0geC0+cGFyZW50KCktPnBhcmVudCgpOwotICAgICAgICAgICAgICAgICAg ICB1cGRhdGVTdGFydCA9IHgtPnBhcmVudCgpOwogICAgICAgICAgICAgICAgIH0gZWxzZSB7CiAg ICAgICAgICAgICAgICAgICAgIGlmICh4ID09IHgtPnBhcmVudCgpLT5sZWZ0KCkpIHsKICAgICAg ICAgICAgICAgICAgICAgICAgIC8vIENhc2UgMgpAQCAtMjE1LDggKzIwOSw3IEBAIHB1YmxpYzoK ICAgICAgICAgICAgICAgICAgICAgLy8gQ2FzZSAzCiAgICAgICAgICAgICAgICAgICAgIHgtPnBh cmVudCgpLT5zZXRDb2xvcihCbGFjayk7CiAgICAgICAgICAgICAgICAgICAgIHgtPnBhcmVudCgp LT5wYXJlbnQoKS0+c2V0Q29sb3IoUmVkKTsKLSAgICAgICAgICAgICAgICAgICAgTm9kZSogbmV3 U3ViVHJlZVJvb3QgPSBsZWZ0Um90YXRlKHgtPnBhcmVudCgpLT5wYXJlbnQoKSk7Ci0gICAgICAg ICAgICAgICAgICAgIHVwZGF0ZVN0YXJ0ID0gbmV3U3ViVHJlZVJvb3QtPnBhcmVudCgpOworICAg ICAgICAgICAgICAgICAgICBsZWZ0Um90YXRlKHgtPnBhcmVudCgpLT5wYXJlbnQoKSk7CiAgICAg ICAgICAgICAgICAgfQogICAgICAgICAgICAgfQogICAgICAgICB9Cg==