67903 2011-09-10 23:54:09 -0700 ARM and MIPS assemblers still refer to executable pools. 2011-09-11 00:07:35 -0700 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 fpizlo webkit-unassigned ossy webkit.review.bot oldest_to_newest 465385 0 fpizlo 2011-09-10 23:54:09 -0700 There are still references to executable pools in some assemblers. Executable pools no longer exist. 465387 1 107002 fpizlo 2011-09-10 23:58:59 -0700 Created attachment 107002 the patch 465388 2 107002 webkit.review.bot 2011-09-11 00:03:36 -0700 Comment on attachment 107002 the patch Rejecting attachment 107002 from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 1 Last 500 characters of output: cripts/webkitpy/common/system/executive.py", line 420, in run_command close_fds=self._should_close_fds()) File "/mnt/git/webkit-commit-queue/Tools/Scripts/webkitpy/common/system/executive.py", line 476, in popen return subprocess.Popen(*args, **kwargs) File "/usr/lib/python2.6/subprocess.py", line 623, in __init__ errread, errwrite) File "/usr/lib/python2.6/subprocess.py", line 1141, in _execute_child raise child_exception TypeError: execv() arg 2 must contain only strings Full output: http://queues.webkit.org/results/9635408 465389 3 107002 ossy 2011-09-11 00:07:28 -0700 Comment on attachment 107002 the patch Clearing flags on attachment: 107002 Committed r94922: <http://trac.webkit.org/changeset/94922> 465390 4 ossy 2011-09-11 00:07:35 -0700 All reviewed patches have been landed. Closing bug. 107002 2011-09-10 23:58:59 -0700 2011-09-11 00:07:28 -0700 the patch execpoolkill_patch_1.diff text/plain 4445 fpizlo SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gOTQ5MjApCisrKyBTb3VyY2Uv SmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTcgQEAK KzIwMTEtMDktMTAgIEZpbGlwIFBpemxvICA8ZnBpemxvQGFwcGxlLmNvbT4KKworICAgICAgICBB Uk0gYW5kIE1JUFMgYXNzZW1ibGVycyBzdGlsbCByZWZlciB0byBleGVjdXRhYmxlIHBvb2xzLgor ICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9Njc5MDMKKwor ICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIGFzc2VtYmxl ci9BUk1Bc3NlbWJsZXIuY3BwOgorICAgICAgICAoSlNDOjpBUk1Bc3NlbWJsZXI6OmV4ZWN1dGFi bGVDb3B5KToKKyAgICAgICAgKiBhc3NlbWJsZXIvQVJNQXNzZW1ibGVyLmg6CisgICAgICAgICog YXNzZW1ibGVyL0Fzc2VtYmxlckJ1ZmZlcldpdGhDb25zdGFudFBvb2wuaDoKKyAgICAgICAgKiBh c3NlbWJsZXIvTUlQU0Fzc2VtYmxlci5oOgorICAgICAgICAoSlNDOjpNSVBTQXNzZW1ibGVyOjpl eGVjdXRhYmxlQ29weSk6CisKIDIwMTEtMDktMDggIEZpbGlwIFBpemxvICA8ZnBpemxvQGFwcGxl LmNvbT4KIAogICAgICAgICBUaGUgZXhlY3V0YWJsZSBhbGxvY2F0b3IgbWFrZXMgaXQgZGlmZmlj dWx0IHRvIGZyZWUgaW5kaXZpZHVhbApJbmRleDogU291cmNlL0phdmFTY3JpcHRDb3JlL2Fzc2Vt Ymxlci9BUk1Bc3NlbWJsZXIuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9KYXZhU2NyaXB0Q29y ZS9hc3NlbWJsZXIvQVJNQXNzZW1ibGVyLmNwcAkocmV2aXNpb24gOTQ5MTkpCisrKyBTb3VyY2Uv SmF2YVNjcmlwdENvcmUvYXNzZW1ibGVyL0FSTUFzc2VtYmxlci5jcHAJKHdvcmtpbmcgY29weSkK QEAgLTM0MywxNCArMzQzLDE1IEBAIHZvaWQgQVJNQXNzZW1ibGVyOjpkb3VibGVUcmFuc2Zlcihi b29sIGkKICAgICBmZHRyX3UoaXNMb2FkLCBzcmNEc3QsIEFSTVJlZ2lzdGVyczo6UzAsIDApOwog fQogCi12b2lkKiBBUk1Bc3NlbWJsZXI6OmV4ZWN1dGFibGVDb3B5KEpTR2xvYmFsRGF0YSYgZ2xv YmFsRGF0YSwgRXhlY3V0YWJsZVBvb2wqIGFsbG9jYXRvcikKK1Bhc3NSZWZQdHI8RXhlY3V0YWJs ZU1lbW9yeUhhbmRsZT4gQVJNQXNzZW1ibGVyOjpleGVjdXRhYmxlQ29weShKU0dsb2JhbERhdGEm IGdsb2JhbERhdGEpCiB7CiAgICAgLy8gNjQtYml0IGFsaWdubWVudCBpcyByZXF1aXJlZCBmb3Ig bmV4dCBjb25zdGFudCBwb29sIGFuZCBKSVQgY29kZSBhcyB3ZWxsCiAgICAgbV9idWZmZXIuZmx1 c2hXaXRob3V0QmFycmllcih0cnVlKTsKICAgICBpZiAoIW1fYnVmZmVyLmlzQWxpZ25lZCg4KSkK ICAgICAgICAgYmtwdCgwKTsKIAotICAgIGNoYXIqIGRhdGEgPSByZWludGVycHJldF9jYXN0PGNo YXIqPihtX2J1ZmZlci5leGVjdXRhYmxlQ29weShnbG9iYWxEYXRhLCBhbGxvY2F0b3IpKTsKKyAg ICBSZWZQdHI8RXhlY3V0YWJsZU1lbW9yeUhhbmRsZT4gcmVzdWx0ID0gbV9idWZmZXIuZXhlY3V0 YWJsZUNvcHkoZ2xvYmFsRGF0YSk7CisgICAgY2hhciogZGF0YSA9IHJlaW50ZXJwcmV0X2Nhc3Q8 Y2hhcio+KHJlc3VsdC0+c3RhcnQoKSk7CiAKICAgICBmb3IgKEp1bXBzOjpJdGVyYXRvciBpdGVy ID0gbV9qdW1wcy5iZWdpbigpOyBpdGVyICE9IG1fanVtcHMuZW5kKCk7ICsraXRlcikgewogICAg ICAgICAvLyBUaGUgbGFzdCBiaXQgaXMgc2V0IGlmIHRoZSBjb25zdGFudCBtdXN0IGJlIHBsYWNl ZCBvbiBjb25zdGFudCBwb29sLgpAQCAtMzcwLDcgKzM3MSw3IEBAIHZvaWQqIEFSTUFzc2VtYmxl cjo6ZXhlY3V0YWJsZUNvcHkoSlNHbG8KICAgICAgICAgfQogICAgIH0KIAotICAgIHJldHVybiBk YXRhOworICAgIHJldHVybiByZXN1bHQ7CiB9CiAKIH0gLy8gbmFtZXNwYWNlIEpTQwpJbmRleDog U291cmNlL0phdmFTY3JpcHRDb3JlL2Fzc2VtYmxlci9BUk1Bc3NlbWJsZXIuaAo9PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 Ci0tLSBTb3VyY2UvSmF2YVNjcmlwdENvcmUvYXNzZW1ibGVyL0FSTUFzc2VtYmxlci5oCShyZXZp c2lvbiA5NDkxOSkKKysrIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9hc3NlbWJsZXIvQVJNQXNzZW1i bGVyLmgJKHdvcmtpbmcgY29weSkKQEAgLTY3OSw3ICs2NzksNyBAQCBuYW1lc3BhY2UgSlNDIHsK ICAgICAgICAgICAgIHJldHVybiBsb2FkQnJhbmNoVGFyZ2V0KEFSTVJlZ2lzdGVyczo6cGMsIGNj LCB1c2VDb25zdGFudFBvb2wpOwogICAgICAgICB9CiAKLSAgICAgICAgdm9pZCogZXhlY3V0YWJs ZUNvcHkoSlNHbG9iYWxEYXRhJiwgRXhlY3V0YWJsZVBvb2wqIGFsbG9jYXRvcik7CisgICAgICAg IFBhc3NSZWZQdHI8RXhlY3V0YWJsZU1lbW9yeUhhbmRsZT4gZXhlY3V0YWJsZUNvcHkoSlNHbG9i YWxEYXRhJik7CiAKICNpZm5kZWYgTkRFQlVHCiAgICAgICAgIHVuc2lnbmVkIGRlYnVnT2Zmc2V0 KCkgeyByZXR1cm4gbV9idWZmZXIuZGVidWdPZmZzZXQoKTsgfQpJbmRleDogU291cmNlL0phdmFT Y3JpcHRDb3JlL2Fzc2VtYmxlci9Bc3NlbWJsZXJCdWZmZXJXaXRoQ29uc3RhbnRQb29sLmgKPT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PQotLS0gU291cmNlL0phdmFTY3JpcHRDb3JlL2Fzc2VtYmxlci9Bc3NlbWJsZXJCdWZm ZXJXaXRoQ29uc3RhbnRQb29sLmgJKHJldmlzaW9uIDk0OTE5KQorKysgU291cmNlL0phdmFTY3Jp cHRDb3JlL2Fzc2VtYmxlci9Bc3NlbWJsZXJCdWZmZXJXaXRoQ29uc3RhbnRQb29sLmgJKHdvcmtp bmcgY29weSkKQEAgLTE5NSwxMCArMTk1LDEwIEBAIHB1YmxpYzoKICAgICAgICAgcHV0SW50ZWdy YWxVbmNoZWNrZWQodmFsdWUubG93KTsKICAgICB9CiAKLSAgICB2b2lkKiBleGVjdXRhYmxlQ29w eShKU0dsb2JhbERhdGEmIGdsb2JhbERhdGEsIEV4ZWN1dGFibGVQb29sKiBhbGxvY2F0b3IpCisg ICAgUGFzc1JlZlB0cjxFeGVjdXRhYmxlTWVtb3J5SGFuZGxlPiBleGVjdXRhYmxlQ29weShKU0ds b2JhbERhdGEmIGdsb2JhbERhdGEpCiAgICAgewogICAgICAgICBmbHVzaENvbnN0YW50UG9vbChm YWxzZSk7Ci0gICAgICAgIHJldHVybiBBc3NlbWJsZXJCdWZmZXI6OmV4ZWN1dGFibGVDb3B5KGds b2JhbERhdGEsIGFsbG9jYXRvcik7CisgICAgICAgIHJldHVybiBBc3NlbWJsZXJCdWZmZXI6OmV4 ZWN1dGFibGVDb3B5KGdsb2JhbERhdGEpOwogICAgIH0KIAogICAgIHZvaWQgcHV0U2hvcnRXaXRo Q29uc3RhbnRJbnQodWludDE2X3QgaW5zbiwgdWludDMyX3QgY29uc3RhbnQsIGJvb2wgaXNSZXVz YWJsZSA9IGZhbHNlKQpJbmRleDogU291cmNlL0phdmFTY3JpcHRDb3JlL2Fzc2VtYmxlci9NSVBT QXNzZW1ibGVyLmgKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL0phdmFTY3JpcHRDb3JlL2Fzc2VtYmxl ci9NSVBTQXNzZW1ibGVyLmgJKHJldmlzaW9uIDk0OTE5KQorKysgU291cmNlL0phdmFTY3JpcHRD b3JlL2Fzc2VtYmxlci9NSVBTQXNzZW1ibGVyLmgJKHdvcmtpbmcgY29weSkKQEAgLTY0NSwxNCAr NjQ1LDE0IEBAIHB1YmxpYzoKICAgICAgICAgcmV0dXJuIG1fYnVmZmVyLmNvZGVTaXplKCk7CiAg ICAgfQogCi0gICAgdm9pZCogZXhlY3V0YWJsZUNvcHkoSlNHbG9iYWxEYXRhJiBnbG9iYWxEYXRh LCBFeGVjdXRhYmxlUG9vbCogYWxsb2NhdG9yKQorICAgIFBhc3NSZWZQdHI8RXhlY3V0YWJsZU1l bW9yeUhhbmRsZT4gZXhlY3V0YWJsZUNvcHkoSlNHbG9iYWxEYXRhJiBnbG9iYWxEYXRhKQogICAg IHsKLSAgICAgICAgdm9pZCAqcmVzdWx0ID0gbV9idWZmZXIuZXhlY3V0YWJsZUNvcHkoZ2xvYmFs RGF0YSwgYWxsb2NhdG9yKTsKKyAgICAgICAgUmVmUHRyPEV4ZWN1dGFibGVNZW1vcnlIYW5kbGU+ IHJlc3VsdCA9IG1fYnVmZmVyLmV4ZWN1dGFibGVDb3B5KGdsb2JhbERhdGEpOwogICAgICAgICBp ZiAoIXJlc3VsdCkKICAgICAgICAgICAgIHJldHVybiAwOwogCi0gICAgICAgIHJlbG9jYXRlSnVt cHMobV9idWZmZXIuZGF0YSgpLCByZXN1bHQpOwotICAgICAgICByZXR1cm4gcmVzdWx0OworICAg ICAgICByZWxvY2F0ZUp1bXBzKG1fYnVmZmVyLmRhdGEoKSwgcmVzdWx0LT5zdGFydCgpKTsKKyAg ICAgICAgcmV0dXJuIHJlc3VsdC5yZWxlYXNlKCk7CiAgICAgfQogCiAjaWZuZGVmIE5ERUJVRwo=