67896 2011-09-10 15:03:55 -0700 Web Inspector: Profiler: Overlapping data in function names column 2011-09-13 08:32:50 -0700 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 mnaganov mnaganov apavlov bweinstein joepeck keishi loislo pfeldman pmuellr rik timothy yurys oldest_to_newest 465335 0 mnaganov 2011-09-10 15:03:55 -0700 Two problems, but of a similar kind. From http://code.google.com/p/chromium/issues/detail?id=92526: Google Chrome 15.0.849.0 (Official Build 96325) dev OS tested: Gunbutu lucid (10.4) What steps will reproduce the problem? 1.launch chrome 2.navigate to amazon.com 3.ctrl+shfit+i to bring up devtool 4. go to profile, click start profiling 5. navigate to some items in amazon 6. observe the profile saved What is the expected output? What do you see instead? all URL links should be properly list under function dropdown menu in Function column. currently those very long URl link will overlap the function name, especially when this function menu dropdown has sub-menu. URL link will overlap the function name pretty badly. From http://code.google.com/p/chromium/issues/detail?id=95904: What steps will reproduce the problem? 1.Open the browser. 2.Open the mentioned URL. 3.Open DevTools (Ctrl+Shift+I on Win/Linux, Command+Option+I on Mac) 4.Go to 'Profiles' page 5.Press 'Take heap snapshot' button (eye icon on the left side of status bar) 6.Now Click on the Snapshot 1 7.Now in the right side column "Constructor" keep expanding the items.Now we can see the Overlapping of Column data to next column area. What is the expected result? Should not be overlapped to next column data area. What happens instead? Overlapping column data of Snapshot to next column data area in the Profiles. 465337 1 106985 mnaganov 2011-09-10 15:06:27 -0700 Created attachment 106985 Patch 466210 2 106985 pfeldman 2011-09-13 02:38:04 -0700 Comment on attachment 106985 Patch Could you please make sure that it does not break the network panel and cookies grids. 466301 3 mnaganov 2011-09-13 08:18:37 -0700 (In reply to comment #2) > (From update of attachment 106985 [details]) > Could you please make sure that it does not break the network panel and cookies grids. Thanks! Both grids look OK. table-layout:fixed prescribes to use column width specified in style, not calculate them based on contents length (otherwise, if you have oversized contents, columns widths can be adjusted and the resulting table can be wider than specified in style rules); and overflow:hidden cuts off contents that overflow columns. I guess, both network panel and cookies don't requre an opposite behaviour. 466311 4 mnaganov 2011-09-13 08:32:50 -0700 Manually committed: http://trac.webkit.org/changeset/95027 2011-09-10 Mikhail Naganov <mnaganov@chromium.org> Web Inspector: Profiler: Fix overlapping data in function names column. https://bugs.webkit.org/show_bug.cgi?id=67896 Reviewed by Pavel Feldman. * inspector/front-end/ProfileDataGridTree.js: (WebInspector.ProfileDataGridNode.prototype.createCell): * inspector/front-end/dataGrid.css: (.data-grid table.data): (.data-grid td): 106985 2011-09-10 15:06:27 -0700 2011-09-13 02:38:04 -0700 Patch patch-67896 text/plain 2321 mnaganov ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCA5ZjIyOWNlLi42MzcwZDY0IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYg QEAKKzIwMTEtMDktMTAgIE1pa2hhaWwgTmFnYW5vdiAgPG1uYWdhbm92QGNocm9taXVtLm9yZz4K KworICAgICAgICBXZWIgSW5zcGVjdG9yOiBQcm9maWxlcjogRml4IG92ZXJsYXBwaW5nIGRhdGEg aW4gZnVuY3Rpb24gbmFtZXMgY29sdW1uLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9y Zy9zaG93X2J1Zy5jZ2k/aWQ9Njc4OTYKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9P UFMhKS4KKworICAgICAgICAqIGluc3BlY3Rvci9mcm9udC1lbmQvUHJvZmlsZURhdGFHcmlkVHJl ZS5qczoKKyAgICAgICAgKFdlYkluc3BlY3Rvci5Qcm9maWxlRGF0YUdyaWROb2RlLnByb3RvdHlw ZS5jcmVhdGVDZWxsKToKKyAgICAgICAgKiBpbnNwZWN0b3IvZnJvbnQtZW5kL2RhdGFHcmlkLmNz czoKKyAgICAgICAgKC5kYXRhLWdyaWQgdGFibGUuZGF0YSk6CisgICAgICAgICguZGF0YS1ncmlk IHRkKToKKwogMjAxMS0wOS0wNiAgRGlyayBTY2h1bHplICA8a3JpdEB3ZWJraXQub3JnPgogCiAg ICAgICAgIFJldHVybiB0byB0cmFuc2Zvcm0gbXVsdGlwbGljYXRpb246IG1vdGlvbiB0cmFuc2Zv cm0gKiBvdGhlciB0cmFuc2Zvcm1zCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0 b3IvZnJvbnQtZW5kL1Byb2ZpbGVEYXRhR3JpZFRyZWUuanMgYi9Tb3VyY2UvV2ViQ29yZS9pbnNw ZWN0b3IvZnJvbnQtZW5kL1Byb2ZpbGVEYXRhR3JpZFRyZWUuanMKaW5kZXggMzI0MWVhMi4uNTg1 NTY4YyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250LWVuZC9Qcm9m aWxlRGF0YUdyaWRUcmVlLmpzCisrKyBiL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9mcm9udC1l bmQvUHJvZmlsZURhdGFHcmlkVHJlZS5qcwpAQCAtOTksNiArOTksNyBAQCBXZWJJbnNwZWN0b3Iu UHJvZmlsZURhdGFHcmlkTm9kZS5wcm90b3R5cGUgPSB7CiAgICAgICAgICAgICAvLyBGSVhNRSg2 MjcyNSk6IHByb2ZpbGVOb2RlIHNob3VsZCByZWZlcmVuY2UgYSBkZWJ1Z2dlciBsb2NhdGlvbi4K ICAgICAgICAgICAgIHZhciBsaW5lTnVtYmVyID0gdGhpcy5wcm9maWxlTm9kZS5saW5lTnVtYmVy ID8gdGhpcy5wcm9maWxlTm9kZS5saW5lTnVtYmVyIC0gMSA6IDA7CiAgICAgICAgICAgICB2YXIg dXJsRWxlbWVudCA9IFdlYkluc3BlY3Rvci5kZWJ1Z2dlclByZXNlbnRhdGlvbk1vZGVsLmxpbmtp ZnlMb2NhdGlvbih0aGlzLnByb2ZpbGVOb2RlLnVybCwgbGluZU51bWJlciwgMCwgInByb2ZpbGUt bm9kZS1maWxlIik7CisgICAgICAgICAgICB1cmxFbGVtZW50LnN0eWxlLm1heFdpZHRoID0gIjc1 JSI7CiAgICAgICAgICAgICBjZWxsLmluc2VydEJlZm9yZSh1cmxFbGVtZW50LCBjZWxsLmZpcnN0 Q2hpbGQpOwogICAgICAgICB9CiAKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rv ci9mcm9udC1lbmQvZGF0YUdyaWQuY3NzIGIvU291cmNlL1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250 LWVuZC9kYXRhR3JpZC5jc3MKaW5kZXggY2RmNTU0NS4uMzhkZDg2NiAxMDA2NDQKLS0tIGEvU291 cmNlL1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250LWVuZC9kYXRhR3JpZC5jc3MKKysrIGIvU291cmNl L1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250LWVuZC9kYXRhR3JpZC5jc3MKQEAgLTczLDYgKzczLDcg QEAKICAgICBib3JkZXItdG9wOiAwIG5vbmUgdHJhbnNwYXJlbnQ7CiAgICAgYmFja2dyb3VuZC1p bWFnZTogLXdlYmtpdC1ncmFkaWVudChsaW5lYXIsIGxlZnQgdG9wLCBsZWZ0IGJvdHRvbSwgZnJv bSh3aGl0ZSksIGNvbG9yLXN0b3AoMC41LCB3aGl0ZSksIGNvbG9yLXN0b3AoMC41LCByZ2IoMjM0 LCAyNDMsIDI1NSkpLCB0byhyZ2IoMjM0LCAyNDMsIDI1NSkpKTsKICAgICAtd2Via2l0LWJhY2tn cm91bmQtc2l6ZTogMXB4IDMycHg7CisgICAgdGFibGUtbGF5b3V0OiBmaXhlZDsKIH0KIAogLmRh dGEtZ3JpZC5pbmxpbmUgdGFibGUuZGF0YSB7CkBAIC05Myw2ICs5NCw3IEBACiAgICAgbGluZS1o ZWlnaHQ6IDEycHg7CiAgICAgcGFkZGluZzogMnB4IDRweDsKICAgICB3aGl0ZS1zcGFjZTogbm93 cmFwOworICAgIG92ZXJmbG93OiBoaWRkZW47CiAgICAgYm9yZGVyLXJpZ2h0OiAxcHggc29saWQg I2FhYTsKICAgICAtd2Via2l0LXVzZXItc2VsZWN0OiB0ZXh0OwogfQo=