67889 2011-09-10 01:53:28 -0700 [Chromium] The checked state of WebPopupMenuItem isn't initialized 2011-09-13 14:42:25 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 66687 1 abarth abarth fishd peter steveblock webkit.review.bot oldest_to_newest 465269 0 abarth 2011-09-10 01:53:28 -0700 [Chromium] The checked state of WebPopupMenuItem isn't initialized 465270 1 106973 abarth 2011-09-10 01:54:53 -0700 Created attachment 106973 Patch 465271 2 abarth 2011-09-10 01:55:40 -0700 I don't fully understand this patch. If someone else can explain why this diff exists in the Android branch, I'd appreciate that. 465358 3 106973 fishd 2011-09-10 17:36:15 -0700 Comment on attachment 106973 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=106973&action=review > Source/WebKit/chromium/ChangeLog:10 > + use popup menus for <select> elements. the mac port uses "external" popup menus for select elements too. this parch seems fine to me, but i'd also like to know the answer to your question. perhaps jcivelli knows? 466253 4 peter 2011-09-13 06:09:24 -0700 The WebMenuItemInfo struct contained the checked property already, but since it wasn't being set in the ExternalPopupMenu::getPopupMenuInfo method it didn't propagate correctly to Chrome. The information will be used for implementing select boxes which accept multiple answers, for which we'll indeed need an external menu. 466512 5 106973 abarth 2011-09-13 13:40:55 -0700 Comment on attachment 106973 Patch Ok. 466554 6 106973 webkit.review.bot 2011-09-13 14:42:20 -0700 Comment on attachment 106973 Patch Clearing flags on attachment: 106973 Committed r95045: <http://trac.webkit.org/changeset/95045> 466556 7 webkit.review.bot 2011-09-13 14:42:25 -0700 All reviewed patches have been landed. Closing bug. 106973 2011-09-10 01:54:53 -0700 2011-09-13 14:42:20 -0700 Patch bug-67889-20110910015452.patch text/plain 1777 abarth U3VidmVyc2lvbiBSZXZpc2lvbjogOTQ5MDMKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvY2hy b21pdW0vQ2hhbmdlTG9nIGIvU291cmNlL1dlYktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cKaW5kZXgg NGU4MGNkODcwNDI1Y2IxYTExOGNlOGJiNzU2ZmI1Y2I0ZWRlOWMzYy4uZTUyY2IxNDU2MDI5MmQ0 MGExYmI4YmM4ZjI0Zjc5MzYyMTBiOTQxZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9jaHJv bWl1bS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cKQEAg LTEsNSArMSwxOSBAQAogMjAxMS0wOS0xMCAgQWRhbSBCYXJ0aCAgPGFiYXJ0aEB3ZWJraXQub3Jn PgogCisgICAgICAgIFtDaHJvbWl1bV0gVGhlIGNoZWNrZWQgc3RhdGUgb2YgV2ViUG9wdXBNZW51 SXRlbSBpc24ndCBpbml0aWFsaXplZAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9z aG93X2J1Zy5jZ2k/aWQ9Njc4ODkKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMh KS4KKworICAgICAgICBJdCBzZWVtcyB3ZSdyZSBmYWlsaW5nIHRvIGluaXRpYWxpemUgdGhlIGNo ZWNrZWQgc3RhdGUgb2YKKyAgICAgICAgV2ViUG9wdXBNZW51SXRlbXMsIHBvdGVudGlhbGx5IGJl Y2F1c2UgQW5kcm9pZCBpcyB0aGUgZmlyc3QgcGxhdGZvcm0gdG8KKyAgICAgICAgdXNlIHBvcHVw IG1lbnVzIGZvciA8c2VsZWN0PiBlbGVtZW50cy4KKworICAgICAgICAqIHNyYy9FeHRlcm5hbFBv cHVwTWVudS5jcHA6CisgICAgICAgIChXZWJLaXQ6OkV4dGVybmFsUG9wdXBNZW51OjpnZXRQb3B1 cE1lbnVJbmZvKToKKworMjAxMS0wOS0xMCAgQWRhbSBCYXJ0aCAgPGFiYXJ0aEB3ZWJraXQub3Jn PgorCiAgICAgICAgIFtDaHJvbWl1bV0gQWRkIHN0YXJ0RnVsbHNjcmVlbiB0byBXZWJNZWRpYVBs YXllciBmb3IgQW5kcm9pZAogICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1 Zy5jZ2k/aWQ9Njc4ODgKIApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9jaHJvbWl1bS9zcmMv RXh0ZXJuYWxQb3B1cE1lbnUuY3BwIGIvU291cmNlL1dlYktpdC9jaHJvbWl1bS9zcmMvRXh0ZXJu YWxQb3B1cE1lbnUuY3BwCmluZGV4IGY1ZTg4MDlkNTE3ZTZiNTI5N2Y0MWYxNTFkOGY2ZDNkN2Yw NjhkNjguLjIwYWU3Y2IyNzRhM2ZmYWJjYTcwNWI1Y2FhNTQ2ODA3YzcxMzI3MmMgMTAwNjQ0Ci0t LSBhL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vc3JjL0V4dGVybmFsUG9wdXBNZW51LmNwcAorKysg Yi9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3NyYy9FeHRlcm5hbFBvcHVwTWVudS5jcHAKQEAgLTE3 Myw2ICsxNzMsNyBAQCB2b2lkIEV4dGVybmFsUG9wdXBNZW51OjpnZXRQb3B1cE1lbnVJbmZvKFdl YlBvcHVwTWVudUluZm8qIGluZm8pCiAgICAgICAgIGVsc2UKICAgICAgICAgICAgIHBvcHVwSXRl bS50eXBlID0gV2ViTWVudUl0ZW1JbmZvOjpPcHRpb247CiAgICAgICAgIHBvcHVwSXRlbS5lbmFi bGVkID0gbV9wb3B1cE1lbnVDbGllbnQtPml0ZW1Jc0VuYWJsZWQoaSk7CisgICAgICAgIHBvcHVw SXRlbS5jaGVja2VkID0gbV9wb3B1cE1lbnVDbGllbnQtPml0ZW1Jc1NlbGVjdGVkKGkpOwogICAg ICAgICBQb3B1cE1lbnVTdHlsZSBzdHlsZSA9IG1fcG9wdXBNZW51Q2xpZW50LT5pdGVtU3R5bGUo aSk7CiAgICAgICAgIGlmIChzdHlsZS50ZXh0RGlyZWN0aW9uKCkgPT0gV2ViQ29yZTo6UlRMKQog ICAgICAgICAgICAgcG9wdXBJdGVtLnRleHREaXJlY3Rpb24gPSBXZWJUZXh0RGlyZWN0aW9uUmln aHRUb0xlZnQ7Cg==