<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>67884</bug_id>
          
          <creation_ts>2011-09-09 23:31:09 -0700</creation_ts>
          <short_desc>Delete button icon does not properly update when the device resolution changes dynamically</short_desc>
          <delta_ts>2011-09-15 17:17:25 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>Layout and Rendering</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords>InRadar</keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Beth Dakin">bdakin</reporter>
          <assigned_to name="Beth Dakin">bdakin</assigned_to>
          <cc>bdakin</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>465238</commentid>
    <comment_count>0</comment_count>
    <who name="Beth Dakin">bdakin</who>
    <bug_when>2011-09-09 23:31:09 -0700</bug_when>
    <thetext>https://bugs.webkit.org/show_bug.cgi?id=67819 added high resolution platform images to WebCore. The delete button, however, does not dynamically update to the appropriate resolution when the device scale factor changes dynamically.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>465239</commentid>
    <comment_count>1</comment_count>
    <who name="Beth Dakin">bdakin</who>
    <bug_when>2011-09-09 23:33:21 -0700</bug_when>
    <thetext>&lt;rdar://problem/10104632&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>468147</commentid>
    <comment_count>2</comment_count>
      <attachid>107562</attachid>
    <who name="Beth Dakin">bdakin</who>
    <bug_when>2011-09-15 16:19:41 -0700</bug_when>
    <thetext>Created attachment 107562
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>468155</commentid>
    <comment_count>3</comment_count>
      <attachid>107562</attachid>
    <who name="Darin Adler">darin</who>
    <bug_when>2011-09-15 16:31:36 -0700</bug_when>
    <thetext>Comment on attachment 107562
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=107562&amp;action=review

&gt; Source/WebCore/ChangeLog:15
&gt; +        takes an optional bool parameter indicated whether or not the change affects the 
&gt; +        Editor since page scale changes don&apos;t affect Editor.

It seems like the bool parameter indicates whether it’s the device scale factor changing or the page scale factor changing. Calling it “affectsEditor” seems kind of wrong.

Instead of adding a bool and attaching the deviceScaleFactorChanged work into the existing function, I suggest putting the code to iterate all the frames and call deviceScaleFactorChanged on each editor directly into Page::setDeviceScaleFactor. You wouldn’t have to touch Frame.h/cpp at all. Iterating all the frames in a page is simple and can be done without recursion.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>468166</commentid>
    <comment_count>4</comment_count>
      <attachid>107567</attachid>
    <who name="Beth Dakin">bdakin</who>
    <bug_when>2011-09-15 17:01:04 -0700</bug_when>
    <thetext>Created attachment 107567
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>468170</commentid>
    <comment_count>5</comment_count>
    <who name="Beth Dakin">bdakin</who>
    <bug_when>2011-09-15 17:17:25 -0700</bug_when>
    <thetext>Thanks! Fixed with revision 95244.</thetext>
  </long_desc>
      
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>107562</attachid>
            <date>2011-09-15 16:19:41 -0700</date>
            <delta_ts>2011-09-15 17:01:04 -0700</delta_ts>
            <desc>Patch</desc>
            <filename>for-review.txt</filename>
            <type>text/plain</type>
            <size>6306</size>
            <attacher name="Beth Dakin">bdakin</attacher>
            
              <data encoding="base64">SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi
Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDk1MjM4KQorKysgU291cmNlL1dlYkNvcmUvQ2hhbmdl
TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMzQgQEAKKzIwMTEtMDktMTUgIEJldGggRGFr
aW4gIDxiZGFraW5AYXBwbGUuY29tPgorCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3Jn
L3Nob3dfYnVnLmNnaT9pZD02Nzg4NAorICAgICAgICBEZWxldGUgYnV0dG9uIGljb24gZG9lcyBu
b3QgcHJvcGVybHkgdXBkYXRlIHdoZW4gdGhlIGRldmljZSByZXNvbHV0aW9uIGNoYW5nZXMgCisg
ICAgICAgIGR5bmFtaWNhbGx5CisgICAgICAgIC1hbmQgY29ycmVzcG9uZGluZy0KKyAgICAgICAg
PHJkYXI6Ly9wcm9ibGVtLzEwMTA0NjMyPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAo
T09QUyEpLgorCisgICAgICAgIFRoaXMgcGF0Y2ggdGFrZXMgYWR2YW50YWdlIG9mIHRoZSBwcmUt
ZXhpc3RpbmcgZnVuY3Rpb24gCisgICAgICAgIGRldmljZU9yUGFnZVNjYWxlRmFjdG9yQ2hhbmdl
ZCgpIG9uIEZyYW1lLiBQcmV2aW91c2x5IHRoaXMgZnVuY3Rpb24gd2FzIG9ubHkgCisgICAgICAg
IGNvbXBpbGVkIGZvciBhY2NlbGVyYXRlZCBjb250ZW50LCBidXQgdGhpcyBwYXRjaCBjaGFuZ2Vz
IHRoYXQuIFRoZSBmdW5jdGlvbiBub3cgCisgICAgICAgIHRha2VzIGFuIG9wdGlvbmFsIGJvb2wg
cGFyYW1ldGVyIGluZGljYXRlZCB3aGV0aGVyIG9yIG5vdCB0aGUgY2hhbmdlIGFmZmVjdHMgdGhl
IAorICAgICAgICBFZGl0b3Igc2luY2UgcGFnZSBzY2FsZSBjaGFuZ2VzIGRvbid0IGFmZmVjdCBF
ZGl0b3IuCisgICAgICAgICogcGFnZS9GcmFtZS5jcHA6CisgICAgICAgIChXZWJDb3JlOjpGcmFt
ZTo6ZGV2aWNlT3JQYWdlU2NhbGVGYWN0b3JDaGFuZ2VkKToKKyAgICAgICAgKiBwYWdlL0ZyYW1l
Lmg6CisgICAgICAgICogcGFnZS9QYWdlLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlBhZ2U6OnNl
dERldmljZVNjYWxlRmFjdG9yKToKKworICAgICAgICBJbiBEZWxldGVCdXR0b25Db250cm9sbGVy
OjpkZXZpY2VTY2FsZUZhY3RvckNoYW5nZWQoKSwgaWYgdGhlIGRlbGV0ZSBidXR0b24gaXMgCisg
ICAgICAgIGN1cnJlbnRseSBzaG93aW5nLCBoaWRlIGl0IGFuZCByZS1zaG93IGl0LCBmb3JjaW5n
IGl0IHRvIHJlLWNyZWF0ZSB0aGUgZGVsZXRpb24gCisgICAgICAgIFVJLgorICAgICAgICAqIGVk
aXRpbmcvRGVsZXRlQnV0dG9uQ29udHJvbGxlci5jcHA6CisgICAgICAgIChXZWJDb3JlOjpEZWxl
dGVCdXR0b25Db250cm9sbGVyOjpkZXZpY2VTY2FsZUZhY3RvckNoYW5nZWQpOgorICAgICAgICAq
IGVkaXRpbmcvRGVsZXRlQnV0dG9uQ29udHJvbGxlci5oOgorICAgICAgICAqIGVkaXRpbmcvRWRp
dG9yLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkVkaXRvcjo6ZGV2aWNlU2NhbGVGYWN0b3JDaGFu
Z2VkKToKKyAgICAgICAgKiBlZGl0aW5nL0VkaXRvci5oOgorCiAyMDExLTA5LTE1ICBKdWxpZW4g
Q2hhZmZyYWl4ICA8amNoYWZmcmFpeEB3ZWJraXQub3JnPgogCiAgICAgICAgIENyYXNoIGluIFJl
bmRlckJveDo6cGFpbnRNYXNrSW1hZ2VzIGR1ZSB0byBhIG1hc2sgd2l0aG91dCBhbiBhc3NvY2lh
dGVkIGltYWdlCkluZGV4OiBTb3VyY2UvV2ViQ29yZS9lZGl0aW5nL0RlbGV0ZUJ1dHRvbkNvbnRy
b2xsZXIuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJDb3JlL2VkaXRpbmcvRGVsZXRlQnV0
dG9uQ29udHJvbGxlci5jcHAJKHJldmlzaW9uIDk1MDc0KQorKysgU291cmNlL1dlYkNvcmUvZWRp
dGluZy9EZWxldGVCdXR0b25Db250cm9sbGVyLmNwcAkod29ya2luZyBjb3B5KQpAQCAtMTg1LDYg
KzE4NSwyMCBAQCB2b2lkIERlbGV0ZUJ1dHRvbkNvbnRyb2xsZXI6OnJlc3BvbmRUb0NoCiAgICAg
ICAgIGhpZGUoKTsKIH0KIAordm9pZCBEZWxldGVCdXR0b25Db250cm9sbGVyOjpkZXZpY2VTY2Fs
ZUZhY3RvckNoYW5nZWQoKQoreworICAgIGlmICghZW5hYmxlZCgpKQorICAgICAgICByZXR1cm47
CisgICAgCisgICAgSFRNTEVsZW1lbnQqIGN1cnJlbnRUYXJnZXQgPSBtX3RhcmdldC5nZXQoKTsK
KyAgICBoaWRlKCk7CisKKyAgICAvLyBTZXR0aW5nIG1fY29udGFpbmVyRWxlbWVudCB0byAwIHdp
bGwgZm9yY2UgdGhlIGRlbGV0aW9uVUkgdG8gYmUgcmUtY3JlYXRlZCB3aXRoCisgICAgLy8gYXJ0
d29yayBvZiB0aGUgYXBwcm9wcmlhdGUgcmVzb2x1dGlvbiBpbiBzaG93KCkuCisgICAgbV9jb250
YWluZXJFbGVtZW50ID0gMDsKKyAgICBzaG93KGN1cnJlbnRUYXJnZXQpOworfQorCiB2b2lkIERl
bGV0ZUJ1dHRvbkNvbnRyb2xsZXI6OmNyZWF0ZURlbGV0aW9uVUkoKQogewogICAgIFJlZlB0cjxI
VE1MRGl2RWxlbWVudD4gY29udGFpbmVyID0gSFRNTERpdkVsZW1lbnQ6OmNyZWF0ZShtX3Rhcmdl
dC0+ZG9jdW1lbnQoKSk7CkluZGV4OiBTb3VyY2UvV2ViQ29yZS9lZGl0aW5nL0RlbGV0ZUJ1dHRv
bkNvbnRyb2xsZXIuaAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9lZGl0aW5nL0RlbGV0
ZUJ1dHRvbkNvbnRyb2xsZXIuaAkocmV2aXNpb24gOTUwNzQpCisrKyBTb3VyY2UvV2ViQ29yZS9l
ZGl0aW5nL0RlbGV0ZUJ1dHRvbkNvbnRyb2xsZXIuaAkod29ya2luZyBjb3B5KQpAQCAtNDgsNiAr
NDgsOCBAQCBwdWJsaWM6CiAKICAgICB2b2lkIHJlc3BvbmRUb0NoYW5nZWRTZWxlY3Rpb24oY29u
c3QgVmlzaWJsZVNlbGVjdGlvbiYgb2xkU2VsZWN0aW9uKTsKIAorICAgIHZvaWQgZGV2aWNlU2Nh
bGVGYWN0b3JDaGFuZ2VkKCk7CisKICAgICB2b2lkIHNob3coSFRNTEVsZW1lbnQqKTsKICAgICB2
b2lkIGhpZGUoKTsKIApJbmRleDogU291cmNlL1dlYkNvcmUvZWRpdGluZy9FZGl0b3IuY3BwCj09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT0KLS0tIFNvdXJjZS9XZWJDb3JlL2VkaXRpbmcvRWRpdG9yLmNwcAkocmV2aXNpb24g
OTUwNzQpCisrKyBTb3VyY2UvV2ViQ29yZS9lZGl0aW5nL0VkaXRvci5jcHAJKHdvcmtpbmcgY29w
eSkKQEAgLTMyMzEsNCArMzIzMSw5IEBAIFRleHRDaGVja2luZ1R5cGVNYXNrIEVkaXRvcjo6cmVz
b2x2ZVRleHQKICAgICByZXR1cm4gY2hlY2tpbmdUeXBlczsKIH0KIAordm9pZCBFZGl0b3I6OmRl
dmljZVNjYWxlRmFjdG9yQ2hhbmdlZCgpCit7CisgICAgbV9kZWxldGVCdXR0b25Db250cm9sbGVy
LT5kZXZpY2VTY2FsZUZhY3RvckNoYW5nZWQoKTsKK30KKwogfSAvLyBuYW1lc3BhY2UgV2ViQ29y
ZQpJbmRleDogU291cmNlL1dlYkNvcmUvZWRpdGluZy9FZGl0b3IuaAo9PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBT
b3VyY2UvV2ViQ29yZS9lZGl0aW5nL0VkaXRvci5oCShyZXZpc2lvbiA5NTA3NCkKKysrIFNvdXJj
ZS9XZWJDb3JlL2VkaXRpbmcvRWRpdG9yLmgJKHdvcmtpbmcgY29weSkKQEAgLTM3OCw2ICszNzgs
OCBAQCBwdWJsaWM6CiAgICAgdm9pZCB1cGRhdGVNYXJrZXJzRm9yV29yZHNBZmZlY3RlZEJ5RWRp
dGluZyhib29sIG9ubHlIYW5kbGVXb3Jkc0NvbnRhaW5pbmdTZWxlY3Rpb24pOwogICAgIHZvaWQg
ZGVsZXRlZEF1dG9jb3JyZWN0aW9uQXRQb3NpdGlvbihjb25zdCBQb3NpdGlvbiYsIGNvbnN0IFN0
cmluZyYgb3JpZ2luYWxTdHJpbmcpOwogCisgICAgdm9pZCBkZXZpY2VTY2FsZUZhY3RvckNoYW5n
ZWQoKTsKKwogcHJpdmF0ZToKICAgICBGcmFtZSogbV9mcmFtZTsKICAgICBPd25QdHI8RGVsZXRl
QnV0dG9uQ29udHJvbGxlcj4gbV9kZWxldGVCdXR0b25Db250cm9sbGVyOwpJbmRleDogU291cmNl
L1dlYkNvcmUvcGFnZS9GcmFtZS5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYkNvcmUvcGFn
ZS9GcmFtZS5jcHAJKHJldmlzaW9uIDk1MDc0KQorKysgU291cmNlL1dlYkNvcmUvcGFnZS9GcmFt
ZS5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTEwMzMsMTcgKzEwMzMsMjEgQEAgZmxvYXQgRnJhbWU6
OnBhZ2VTY2FsZUZhY3RvcigpIGNvbnN0CiAgICAgcmV0dXJuIHBhZ2UtPnBhZ2VTY2FsZUZhY3Rv
cigpOwogfQogCi0jaWYgVVNFKEFDQ0VMRVJBVEVEX0NPTVBPU0lUSU5HKQotdm9pZCBGcmFtZTo6
ZGV2aWNlT3JQYWdlU2NhbGVGYWN0b3JDaGFuZ2VkKCkKK3ZvaWQgRnJhbWU6OmRldmljZU9yUGFn
ZVNjYWxlRmFjdG9yQ2hhbmdlZChib29sIGFmZmVjdHNFZGl0b3IpCiB7CiAgICAgZm9yIChGcmFt
ZSogY2hpbGQgPSB0cmVlKCktPmZpcnN0Q2hpbGQoKTsgY2hpbGQ7IGNoaWxkID0gY2hpbGQtPnRy
ZWUoKS0+bmV4dFNpYmxpbmcoKSkKLSAgICAgICAgY2hpbGQtPmRldmljZU9yUGFnZVNjYWxlRmFj
dG9yQ2hhbmdlZCgpOworICAgICAgICBjaGlsZC0+ZGV2aWNlT3JQYWdlU2NhbGVGYWN0b3JDaGFu
Z2VkKGFmZmVjdHNFZGl0b3IpOworCisgICAgaWYgKGFmZmVjdHNFZGl0b3IpCisgICAgICAgIGVk
aXRvcigpLT5kZXZpY2VTY2FsZUZhY3RvckNoYW5nZWQoKTsKIAorI2lmIFVTRShBQ0NFTEVSQVRF
RF9DT01QT1NJVElORykKICAgICBSZW5kZXJWaWV3KiByb290ID0gY29udGVudFJlbmRlcmVyKCk7
CiAgICAgaWYgKHJvb3QgJiYgcm9vdC0+Y29tcG9zaXRvcigpKQogICAgICAgICByb290LT5jb21w
b3NpdG9yKCktPmRldmljZU9yUGFnZVNjYWxlRmFjdG9yQ2hhbmdlZCgpOwotfQogI2VuZGlmCit9
CisKIHZvaWQgRnJhbWU6Om5vdGlmeUNocm9tZUNsaWVudFdoZWVsRXZlbnRIYW5kbGVyQ291bnRD
aGFuZ2VkKCkgY29uc3QKIHsKICAgICAvLyBFbnN1cmUgdGhhdCB0aGlzIG1ldGhvZCBpcyBiZWlu
ZyBjYWxsZWQgb24gdGhlIG1haW4gZnJhbWUgb2YgdGhlIHBhZ2UuCkluZGV4OiBTb3VyY2UvV2Vi
Q29yZS9wYWdlL0ZyYW1lLmgKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYkNvcmUvcGFnZS9GcmFt
ZS5oCShyZXZpc2lvbiA5NTA3NCkKKysrIFNvdXJjZS9XZWJDb3JlL3BhZ2UvRnJhbWUuaAkod29y
a2luZyBjb3B5KQpAQCAtMTY0LDkgKzE2NCw3IEBAIG5hbWVzcGFjZSBXZWJDb3JlIHsKICAgICAg
ICAgLy8gQ29udmVuaWVuY2UgaGVscGVyIG1ldGhvZCB0aGF0IGdyYWJzIHRoZSBwYWdlU2NhbGVG
YWN0b3IgZnJvbSBQYWdlLgogICAgICAgICBmbG9hdCBwYWdlU2NhbGVGYWN0b3IoKSBjb25zdDsK
IAotI2lmIFVTRShBQ0NFTEVSQVRFRF9DT01QT1NJVElORykKLSAgICAgICAgdm9pZCBkZXZpY2VP
clBhZ2VTY2FsZUZhY3RvckNoYW5nZWQoKTsKLSNlbmRpZgorICAgICAgICB2b2lkIGRldmljZU9y
UGFnZVNjYWxlRmFjdG9yQ2hhbmdlZChib29sIGFmZmVjdHNFZGl0b3IgPSBmYWxzZSk7CiAKICNp
ZiBFTkFCTEUoT1JJRU5UQVRJT05fRVZFTlRTKQogICAgICAgICAvLyBPcmllbnRhdGlvbiBpcyB0
aGUgaW50ZXJmYWNlIG9yaWVudGF0aW9uIGluIGRlZ3JlZXMuIFNvbWUgZXhhbXBsZXMgYXJlOgpJ
bmRleDogU291cmNlL1dlYkNvcmUvcGFnZS9QYWdlLmNwcAo9PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2Uv
V2ViQ29yZS9wYWdlL1BhZ2UuY3BwCShyZXZpc2lvbiA5NTA3NCkKKysrIFNvdXJjZS9XZWJDb3Jl
L3BhZ2UvUGFnZS5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTY0NSw5ICs2NDUsNyBAQCB2b2lkIFBh
Z2U6OnNldERldmljZVNjYWxlRmFjdG9yKGZsb2F0IHNjCiAgICAgbV9kZXZpY2VTY2FsZUZhY3Rv
ciA9IHNjYWxlRmFjdG9yOwogICAgIHNldE5lZWRzUmVjYWxjU3R5bGVJbkFsbEZyYW1lcygpOwog
Ci0jaWYgVVNFKEFDQ0VMRVJBVEVEX0NPTVBPU0lUSU5HKQotICAgIG1fbWFpbkZyYW1lLT5kZXZp
Y2VPclBhZ2VTY2FsZUZhY3RvckNoYW5nZWQoKTsKLSNlbmRpZgorICAgIG1fbWFpbkZyYW1lLT5k
ZXZpY2VPclBhZ2VTY2FsZUZhY3RvckNoYW5nZWQodHJ1ZSk7CiAKICAgICBiYWNrRm9yd2FyZCgp
LT5tYXJrUGFnZXNGb3JGdWxsU3R5bGVSZWNhbGMoKTsKIH0K
</data>
<flag name="review"
          id="104281"
          type_id="1"
          status="-"
          setter="darin"
    />
          </attachment>
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>107567</attachid>
            <date>2011-09-15 17:01:04 -0700</date>
            <delta_ts>2011-09-15 17:14:10 -0700</delta_ts>
            <desc>Patch</desc>
            <filename>for-review-2.txt</filename>
            <type>text/plain</type>
            <size>4157</size>
            <attacher name="Beth Dakin">bdakin</attacher>
            
              <data encoding="base64">SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi
Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDk1MjQzKQorKysgU291cmNlL1dlYkNvcmUvQ2hhbmdl
TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMjggQEAKKzIwMTEtMDktMTUgIEJldGggRGFr
aW4gIDxiZGFraW5AYXBwbGUuY29tPgorCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3Jn
L3Nob3dfYnVnLmNnaT9pZD02Nzg4NAorICAgICAgICBEZWxldGUgYnV0dG9uIGljb24gZG9lcyBu
b3QgcHJvcGVybHkgdXBkYXRlIHdoZW4gdGhlIGRldmljZSByZXNvbHV0aW9uIGNoYW5nZXMgCisg
ICAgICAgIGR5bmFtaWNhbGx5CisgICAgICAgIC1hbmQgY29ycmVzcG9uZGluZy0KKyAgICAgICAg
PHJkYXI6Ly9wcm9ibGVtLzEwMTA0NjMyPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAo
T09QUyEpLgorCisgICAgICAgIEluIERlbGV0ZUJ1dHRvbkNvbnRyb2xsZXI6OmRldmljZVNjYWxl
RmFjdG9yQ2hhbmdlZCgpLCBpZiB0aGUgZGVsZXRlIGJ1dHRvbiBpcyAKKyAgICAgICAgY3VycmVu
dGx5IHNob3dpbmcsIGhpZGUgaXQgYW5kIHJlLXNob3cgaXQsIGZvcmNpbmcgaXQgdG8gcmUtY3Jl
YXRlIHRoZSBkZWxldGlvbiAKKyAgICAgICAgVUkuCisgICAgICAgICogZWRpdGluZy9EZWxldGVC
dXR0b25Db250cm9sbGVyLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkRlbGV0ZUJ1dHRvbkNvbnRy
b2xsZXI6OmRldmljZVNjYWxlRmFjdG9yQ2hhbmdlZCk6CisgICAgICAgICogZWRpdGluZy9EZWxl
dGVCdXR0b25Db250cm9sbGVyLmg6CisgICAgICAgICogZWRpdGluZy9FZGl0b3IuY3BwOgorICAg
ICAgICAoV2ViQ29yZTo6RWRpdG9yOjpkZXZpY2VTY2FsZUZhY3RvckNoYW5nZWQpOgorICAgICAg
ICAqIGVkaXRpbmcvRWRpdG9yLmg6CisKKyAgICAgICAgSXRlcmF0ZSB0aHJvdWdoIGFsbCBvZiB0
aGUgZnJhbWVzIGFuZCBwcm9wYWdhdGUgdGhlIGRldmljZVNjYWxlRmFjdG9yQ2hhbmdlKCkgCisg
ICAgICAgIG1lc3NhZ2UgdG8gRWRpdG9yLgorICAgICAgICAqIHBhZ2UvUGFnZS5jcHA6CisgICAg
ICAgIChXZWJDb3JlOjpQYWdlOjpzZXREZXZpY2VTY2FsZUZhY3Rvcik6CisKIDIwMTEtMDktMTUg
IENocmlzIE1hcnJpbiAgPGNtYXJyaW5AYXBwbGUuY29tPgogCiAgICAgICAgIENyYXNoIGNhbiBv
Y2N1ciB3aGVuIGRvaW5nIGEgUGxhdGZvcm1DQUFuaW1hdGlvbjo6Y29weSgpIHdpdGggbm8gdmFs
dWVGdW5jdGlvbgpJbmRleDogU291cmNlL1dlYkNvcmUvZWRpdGluZy9EZWxldGVCdXR0b25Db250
cm9sbGVyLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9lZGl0aW5nL0RlbGV0ZUJ1
dHRvbkNvbnRyb2xsZXIuY3BwCShyZXZpc2lvbiA5NTA3NCkKKysrIFNvdXJjZS9XZWJDb3JlL2Vk
aXRpbmcvRGVsZXRlQnV0dG9uQ29udHJvbGxlci5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTE4NSw2
ICsxODUsMjAgQEAgdm9pZCBEZWxldGVCdXR0b25Db250cm9sbGVyOjpyZXNwb25kVG9DaAogICAg
ICAgICBoaWRlKCk7CiB9CiAKK3ZvaWQgRGVsZXRlQnV0dG9uQ29udHJvbGxlcjo6ZGV2aWNlU2Nh
bGVGYWN0b3JDaGFuZ2VkKCkKK3sKKyAgICBpZiAoIWVuYWJsZWQoKSkKKyAgICAgICAgcmV0dXJu
OworICAgIAorICAgIEhUTUxFbGVtZW50KiBjdXJyZW50VGFyZ2V0ID0gbV90YXJnZXQuZ2V0KCk7
CisgICAgaGlkZSgpOworCisgICAgLy8gU2V0dGluZyBtX2NvbnRhaW5lckVsZW1lbnQgdG8gMCB3
aWxsIGZvcmNlIHRoZSBkZWxldGlvblVJIHRvIGJlIHJlLWNyZWF0ZWQgd2l0aAorICAgIC8vIGFy
dHdvcmsgb2YgdGhlIGFwcHJvcHJpYXRlIHJlc29sdXRpb24gaW4gc2hvdygpLgorICAgIG1fY29u
dGFpbmVyRWxlbWVudCA9IDA7CisgICAgc2hvdyhjdXJyZW50VGFyZ2V0KTsKK30KKwogdm9pZCBE
ZWxldGVCdXR0b25Db250cm9sbGVyOjpjcmVhdGVEZWxldGlvblVJKCkKIHsKICAgICBSZWZQdHI8
SFRNTERpdkVsZW1lbnQ+IGNvbnRhaW5lciA9IEhUTUxEaXZFbGVtZW50OjpjcmVhdGUobV90YXJn
ZXQtPmRvY3VtZW50KCkpOwpJbmRleDogU291cmNlL1dlYkNvcmUvZWRpdGluZy9EZWxldGVCdXR0
b25Db250cm9sbGVyLmgKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYkNvcmUvZWRpdGluZy9EZWxl
dGVCdXR0b25Db250cm9sbGVyLmgJKHJldmlzaW9uIDk1MDc0KQorKysgU291cmNlL1dlYkNvcmUv
ZWRpdGluZy9EZWxldGVCdXR0b25Db250cm9sbGVyLmgJKHdvcmtpbmcgY29weSkKQEAgLTQ4LDYg
KzQ4LDggQEAgcHVibGljOgogCiAgICAgdm9pZCByZXNwb25kVG9DaGFuZ2VkU2VsZWN0aW9uKGNv
bnN0IFZpc2libGVTZWxlY3Rpb24mIG9sZFNlbGVjdGlvbik7CiAKKyAgICB2b2lkIGRldmljZVNj
YWxlRmFjdG9yQ2hhbmdlZCgpOworCiAgICAgdm9pZCBzaG93KEhUTUxFbGVtZW50Kik7CiAgICAg
dm9pZCBoaWRlKCk7CiAKSW5kZXg6IFNvdXJjZS9XZWJDb3JlL2VkaXRpbmcvRWRpdG9yLmNwcAo9
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9lZGl0aW5nL0VkaXRvci5jcHAJKHJldmlzaW9u
IDk1MDc0KQorKysgU291cmNlL1dlYkNvcmUvZWRpdGluZy9FZGl0b3IuY3BwCSh3b3JraW5nIGNv
cHkpCkBAIC0zMjMxLDQgKzMyMzEsOSBAQCBUZXh0Q2hlY2tpbmdUeXBlTWFzayBFZGl0b3I6OnJl
c29sdmVUZXh0CiAgICAgcmV0dXJuIGNoZWNraW5nVHlwZXM7CiB9CiAKK3ZvaWQgRWRpdG9yOjpk
ZXZpY2VTY2FsZUZhY3RvckNoYW5nZWQoKQoreworICAgIG1fZGVsZXRlQnV0dG9uQ29udHJvbGxl
ci0+ZGV2aWNlU2NhbGVGYWN0b3JDaGFuZ2VkKCk7Cit9CisKIH0gLy8gbmFtZXNwYWNlIFdlYkNv
cmUKSW5kZXg6IFNvdXJjZS9XZWJDb3JlL2VkaXRpbmcvRWRpdG9yLmgKPT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0g
U291cmNlL1dlYkNvcmUvZWRpdGluZy9FZGl0b3IuaAkocmV2aXNpb24gOTUwNzQpCisrKyBTb3Vy
Y2UvV2ViQ29yZS9lZGl0aW5nL0VkaXRvci5oCSh3b3JraW5nIGNvcHkpCkBAIC0zNzgsNiArMzc4
LDggQEAgcHVibGljOgogICAgIHZvaWQgdXBkYXRlTWFya2Vyc0ZvcldvcmRzQWZmZWN0ZWRCeUVk
aXRpbmcoYm9vbCBvbmx5SGFuZGxlV29yZHNDb250YWluaW5nU2VsZWN0aW9uKTsKICAgICB2b2lk
IGRlbGV0ZWRBdXRvY29ycmVjdGlvbkF0UG9zaXRpb24oY29uc3QgUG9zaXRpb24mLCBjb25zdCBT
dHJpbmcmIG9yaWdpbmFsU3RyaW5nKTsKIAorICAgIHZvaWQgZGV2aWNlU2NhbGVGYWN0b3JDaGFu
Z2VkKCk7CisKIHByaXZhdGU6CiAgICAgRnJhbWUqIG1fZnJhbWU7CiAgICAgT3duUHRyPERlbGV0
ZUJ1dHRvbkNvbnRyb2xsZXI+IG1fZGVsZXRlQnV0dG9uQ29udHJvbGxlcjsKSW5kZXg6IFNvdXJj
ZS9XZWJDb3JlL3BhZ2UvUGFnZS5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYkNvcmUvcGFn
ZS9QYWdlLmNwcAkocmV2aXNpb24gOTUwNzQpCisrKyBTb3VyY2UvV2ViQ29yZS9wYWdlL1BhZ2Uu
Y3BwCSh3b3JraW5nIGNvcHkpCkBAIC02NDksNiArNjQ5LDkgQEAgdm9pZCBQYWdlOjpzZXREZXZp
Y2VTY2FsZUZhY3RvcihmbG9hdCBzYwogICAgIG1fbWFpbkZyYW1lLT5kZXZpY2VPclBhZ2VTY2Fs
ZUZhY3RvckNoYW5nZWQoKTsKICNlbmRpZgogCisgICAgZm9yIChGcmFtZSogZnJhbWUgPSBtYWlu
RnJhbWUoKTsgZnJhbWU7IGZyYW1lID0gZnJhbWUtPnRyZWUoKS0+dHJhdmVyc2VOZXh0KCkpCisg
ICAgICAgIGZyYW1lLT5lZGl0b3IoKS0+ZGV2aWNlU2NhbGVGYWN0b3JDaGFuZ2VkKCk7CisKICAg
ICBiYWNrRm9yd2FyZCgpLT5tYXJrUGFnZXNGb3JGdWxsU3R5bGVSZWNhbGMoKTsKIH0KIAo=
</data>
<flag name="review"
          id="104288"
          type_id="1"
          status="+"
          setter="darin"
    />
          </attachment>
      

    </bug>

</bugzilla>