<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>67876</bug_id>
          
          <creation_ts>2011-09-09 16:53:28 -0700</creation_ts>
          <short_desc>[Chromium Win] 10% PLT regression r94589</short_desc>
          <delta_ts>2013-04-08 14:08:39 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>WebCore Misc.</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>All</rep_platform>
          <op_sys>All</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>WONTFIX</resolution>
          
          
          <bug_file_loc>http://build.chromium.org/f/chromium/perf/xp-release-dual-core/intl1/report.html?history=150&amp;rev=100517</bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P1</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          <blocked>69237</blocked>
          <everconfirmed>1</everconfirmed>
          <reporter name="Adam Barth">abarth</reporter>
          <assigned_to name="Mike Reed">reed</assigned_to>
          <cc>fishd</cc>
    
    <cc>ggaren</cc>
    
    <cc>japhet</cc>
    
    <cc>jar</cc>
    
    <cc>jshin</cc>
    
    <cc>kbr</cc>
    
    <cc>loislo</cc>
    
    <cc>reed</cc>
    
    <cc>sam</cc>
    
    <cc>schenney</cc>
    
    <cc>slewis</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>465108</commentid>
    <comment_count>0</comment_count>
    <who name="Adam Barth">abarth</who>
    <bug_when>2011-09-09 16:53:28 -0700</bug_when>
    <thetext>Something in this range:

http://trac.webkit.org/log/trunk?rev=94653&amp;stop_rev=94560&amp;verbose=on

Appears to have caused a 10% PLT regression:

http://build.chromium.org/f/chromium/perf/xp-release-dual-core/intl1/report.html?history=150&amp;rev=100517

Notice the first spike when those revs were rolled into Chromium in Chromium@99936 and then the sustained rise after they were rolling in again in Chromium@100029.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>465125</commentid>
    <comment_count>1</comment_count>
    <who name="Adam Barth">abarth</who>
    <bug_when>2011-09-09 17:11:57 -0700</bug_when>
    <thetext>I don&apos;t know whether this manifests on ports besides Chromium or on other test suites besides intl1.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>465128</commentid>
    <comment_count>2</comment_count>
    <who name="Stephanie Lewis">slewis</who>
    <bug_when>2011-09-09 17:13:47 -0700</bug_when>
    <thetext>i&apos;ll check our tests on Monday.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>465615</commentid>
    <comment_count>3</comment_count>
    <who name="Ilya Tikhonovsky">loislo</who>
    <bug_when>2011-09-12 08:22:46 -0700</bug_when>
    <thetext>(In reply to comment #2)
&gt; i&apos;ll check our tests on Monday.

I&apos;ve made some bisecting steps.

94619 - bad
94588 - good</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>465645</commentid>
    <comment_count>4</comment_count>
    <who name="Ilya Tikhonovsky">loislo</who>
    <bug_when>2011-09-12 09:55:46 -0700</bug_when>
    <thetext>(In reply to comment #3)
&gt; (In reply to comment #2)
&gt; &gt; i&apos;ll check our tests on Monday.
&gt; 
&gt; I&apos;ve made some bisecting steps.
&gt; 
&gt; 94619 - bad
&gt; 94588 - good

it is 94589


Author: reed@google.com &lt;reed@google.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc&gt;
Date:   Tue Sep 6 19:21:52 2011 +0000

    [skia] never draw with GDI, so that all text can be gpu-accelerated
    https://bugs.webkit.org/show_bug.cgi?id=65203
    
    Reviewed by Kenneth Russell.
    
    Source/WebCore:
    
    * platform/graphics/chromium/FontChromiumWin.cpp:
    (WebCore::TransparencyAwareFontPainter::TransparencyAwareFontPainter::TransparencyAwareFontPainter):
    (WebCore::TransparencyAwareFontPainter::TransparencyAwareGlyphPainter::TransparencyAwareGlyphPainter):
    (WebCore::TransparencyAwareFontPainter::TransparencyAwareGlyphPainter::drawGlyphs):
    (WebCore::TransparencyAwareFontPainter::TransparencyAwareUniscribePainter::TransparencyAwareUniscribePainter):
    (WebCore::drawGlyphsWin):
    (WebCore::Font::drawComplexText):
    * platform/graphics/chromium/UniscribeHelper.cpp:
    (WebCore::UniscribeHelper::draw):
    * platform/graphics/skia/PlatformContextSkia.cpp:
    * platform/graphics/skia/PlatformContextSkia.h:
    * platform/graphics/skia/SkiaFontWin.cpp:
    (WebCore::skiaDrawText):
    * platform/graphics/skia/SkiaFontWin.h:
    
    LayoutTests:
    
    * platform/chromium/test_expectations.txt:</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>465675</commentid>
    <comment_count>5</comment_count>
    <who name="Adam Barth">abarth</who>
    <bug_when>2011-09-12 10:49:16 -0700</bug_when>
    <thetext>Would it make sense to roll out that patch while we investigate?  We don&apos;t want this perf regression to hide other problems.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>465676</commentid>
    <comment_count>6</comment_count>
    <who name="Adam Barth">abarth</who>
    <bug_when>2011-09-12 10:50:23 -0700</bug_when>
    <thetext>(Just so others don&apos;t spend too long looking, this patch is after the M15 branch point.)</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>466542</commentid>
    <comment_count>7</comment_count>
    <who name="Jungshik Shin">jshin</who>
    <bug_when>2011-09-13 14:35:20 -0700</bug_when>
    <thetext>http://crbug.com/95748</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>474020</commentid>
    <comment_count>8</comment_count>
    <who name="Adam Barth">abarth</who>
    <bug_when>2011-09-27 10:00:09 -0700</bug_when>
    <thetext>What&apos;s the current status of this issue?  What the patch rolled out?  Was the performance regression fixed?</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>476785</commentid>
    <comment_count>9</comment_count>
    <who name="Adam Barth">abarth</who>
    <bug_when>2011-10-02 22:45:22 -0700</bug_when>
    <thetext>*** Bug 69239 has been marked as a duplicate of this bug. ***</thetext>
  </long_desc>
      
      

    </bug>

</bugzilla>