67874 2011-09-09 16:31:17 -0700 Cookies are not available after turning off Private Browsing after the last window has been closed 2011-09-09 17:58:13 -0700 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 jberlin jberlin adachan andersca ap jberlin mitz sam oldest_to_newest 465092 0 jberlin 2011-09-09 16:31:17 -0700 Private Browsing is a global setting, but it is treated as a per-page setting (see https://bugs.webkit.org/show_bug.cgi?id=67870). When Private Browsing is turned on, a (global) Private Browsing Storage Session is created as a result of the call to Settings::setPrivateBrowsingEnabled(true); When the last Page goes away, the last Settings object goes away. When a new Page is created, a new Settings object is created and it's m_privateBrowsingEnabled value is initialized to false in the constructor. When the PageGroup preferences are then applied to that Settings object to set the value to false, the early return if (m_privateBrowsingEnabled == privateBrowsingEnabled) in Settings::privateBrowsingStorageSession prevents the Private Browsing Storage Session from being destroyed. Hence, when any request asks for the current storage session, it gets the Private Browsing storage session - where there are no cookies available from the normal browsing session. <rdar://problem/9998144> 465105 1 106940 jberlin 2011-09-09 16:47:30 -0700 Created attachment 106940 Patch 465127 2 jberlin 2011-09-09 17:13:22 -0700 The references to the PageGroup updating the settings after the Page is created in the comments are wrong. It should be the WebPage, not the PageGroup. I will fix the comments. 465137 3 106940 adachan 2011-09-09 17:28:20 -0700 Comment on attachment 106940 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=106940&action=review > Source/WebCore/ChangeLog:20 > + global value for the storage session from being destroyed. Is "from being reset" better? 465141 4 adachan 2011-09-09 17:36:57 -0700 (In reply to comment #3) > (From update of attachment 106940 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=106940&action=review > > > Source/WebCore/ChangeLog:20 > > + global value for the storage session from being destroyed. > > Is "from being reset" better? Actually what you have is fine. Nevermind. 465148 5 106940 jberlin 2011-09-09 17:57:59 -0700 Comment on attachment 106940 Patch Thanks for the review! Committed in http://trac.webkit.org/changeset/94892. 106940 2011-09-09 16:47:30 -0700 2011-09-09 17:57:59 -0700 Patch 0001-Cookies-are-not-available-after-turning-off-Private-.patch text/plain 5152 jberlin RnJvbSAyMDBkOThiODhlN2ZhYjgxM2EyYWFlYzIyZmVkMDFiN2VjODcxMzZiIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBKZXNzaWUgQmVybGluIDxqYmVybGluQHdlYmtpdC5vcmc+CkRh dGU6IEZyaSwgOSBTZXAgMjAxMSAxNjo0NDo1NyAtMDcwMApTdWJqZWN0OiBbUEFUQ0hdIENvb2tp ZXMgYXJlIG5vdCBhdmFpbGFibGUgYWZ0ZXIgdHVybmluZyBvZmYgUHJpdmF0ZSBCcm93c2luZwog YWZ0ZXIgdGhlIGxhc3Qgd2luZG93IGhhcyBiZWVuIGNsb3NlZC4KIGh0dHBzOi8vYnVncy53ZWJr aXQub3JnL3Nob3dfYnVnLmNnaT9pZD02Nzg3NAoKUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISku CgpUaGUgcHJpdmF0ZSBicm93c2luZyBzdG9yYWdlIHNlc3Npb24gaXMgYSBnbG9iYWwgc2V0dGlu ZyB0aGF0IGlzIGJlaW5nIGluY29ycmVjdGx5IHNldCBvbiBhCnBlci1wYWdlIGJhc2lzIChzZWUg aHR0cDovL3dlYmtpdC5vcmcvYi82Nzg3MCkuCgpJbiB0aGlzIGNhc2UsIHRoZSBnbG9iYWwgdmFs dWUgd2FzIGdldHRpbmcgb3V0IG9mIHN5bmMgd2l0aCB0aGUgcGVyLXBhZ2Ugc2V0dGluZzoKMS4g VGhlIGdsb2JhbCB2YWx1ZSB3YXMgZ2V0dGluZyBzZXQgdG8gdHJ1ZSB3aGVuIHNldFByaXZhdGVC cm93c2luZ0VuYWJsZWQodHJ1ZSkgd2FzIGNhbGxlZC4KMi4gQWxsIFBhZ2VzIHdlcmUgdGhlbiBj bG9zZWQsIGRlc3Ryb3lpbmcgdGhlaXIgU2V0dGluZ3Mgb2JqZWN0cy4KMy4gV2hlbiBhIG5ldyBQ YWdlIHdhcyBjcmVhdGVkLCBhIG5ldyBTZXR0aW5ncyBvYmplY3Qgd2FzIGNyZWF0ZWQgYW5kIGl0 cwogICBtX3ByaXZhdGVCcm93c2luZ0VuYWJsZWQgdmFsdWUgd2FzIGdldHRpbmcgc2V0IHRvIGZh bHNlLgo0LiBUaGUgUGFnZUdyb3VwIHNldHRpbmdzIHdlcmUgdGhlbiBhcHBsaWVkIHRvIHRoZSBu ZXcgU2V0dGluZ3Mgb2JqZWN0LCByZXN1bHRpbmcgaW4KICAgc2V0UHJpdmF0ZUJyb3dzaW5nRW5h YmxlZChmYWxzZSkgdG8gYmUgY2FsbGVkLgo1LiBBbiBpZiAobV9wcml2YXRlQnJvd3NpbmdFbmFi bGVkID09IHByaXZhdGVCcm93c2luZ0VuYWJsZWQpIGVhcmx5IHJldHVybiBwcmV2ZW50ZWQgdGhl CiAgIGdsb2JhbCB2YWx1ZSBmb3IgdGhlIHN0b3JhZ2Ugc2Vzc2lvbiBmcm9tIGJlaW5nIGRlc3Ry b3llZC4KCiogcGFnZS9TZXR0aW5ncy5jcHA6CihXZWJDb3JlOjpTZXR0aW5nczo6c2V0UHJpdmF0 ZUJyb3dzaW5nRW5hYmxlZCk6Ck1vdmUgdGhlIGVhcmx5IHJldHVybiB0byBiZSBhZnRlciBzZXR0 aW5nIHRoZSBnbG9iYWwgcHJpdmF0ZSBicm93c2luZyB2YWx1ZXMsIGFuZCBhZGQgYQpjbGVhcmVy IGNvbW1lbnQgKyBGSVhNRS4KLS0tCiBTb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cgICAgICAgICB8 ICAgMjYgKysrKysrKysrKysrKysrKysrKysrKysrKysKIFNvdXJjZS9XZWJDb3JlL3BhZ2UvU2V0 dGluZ3MuY3BwIHwgICAyMCArKysrKysrKysrKysrKystLS0tLQogMiBmaWxlcyBjaGFuZ2VkLCA0 MSBpbnNlcnRpb25zKCspLCA1IGRlbGV0aW9ucygtKQoKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJD b3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCBkOWZhYjBiLi41 NjE1YWIyIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvU291cmNl L1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjkgQEAKKzIwMTEtMDktMDkgIEplc3NpZSBC ZXJsaW4gIDxqYmVybGluQGFwcGxlLmNvbT4KKworICAgICAgICBDb29raWVzIGFyZSBub3QgYXZh aWxhYmxlIGFmdGVyIHR1cm5pbmcgb2ZmIFByaXZhdGUgQnJvd3NpbmcgYWZ0ZXIgdGhlIGxhc3Qg d2luZG93IGhhcyBiZWVuCisgICAgICAgIGNsb3NlZC4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndl YmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTY3ODc0CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9C T0RZIChPT1BTISkuCisKKyAgICAgICAgVGhlIHByaXZhdGUgYnJvd3Npbmcgc3RvcmFnZSBzZXNz aW9uIGlzIGEgZ2xvYmFsIHNldHRpbmcgdGhhdCBpcyBiZWluZyBpbmNvcnJlY3RseSBzZXQgb24g YQorICAgICAgICBwZXItcGFnZSBiYXNpcyAoc2VlIGh0dHA6Ly93ZWJraXQub3JnL2IvNjc4NzAp LgorCisgICAgICAgIEluIHRoaXMgY2FzZSwgdGhlIGdsb2JhbCB2YWx1ZSB3YXMgZ2V0dGluZyBv dXQgb2Ygc3luYyB3aXRoIHRoZSBwZXItcGFnZSBzZXR0aW5nOgorICAgICAgICAxLiBUaGUgZ2xv YmFsIHZhbHVlIHdhcyBnZXR0aW5nIHNldCB0byB0cnVlIHdoZW4gc2V0UHJpdmF0ZUJyb3dzaW5n RW5hYmxlZCh0cnVlKSB3YXMgY2FsbGVkLgorICAgICAgICAyLiBBbGwgUGFnZXMgd2VyZSB0aGVu IGNsb3NlZCwgZGVzdHJveWluZyB0aGVpciBTZXR0aW5ncyBvYmplY3RzLgorICAgICAgICAzLiBX aGVuIGEgbmV3IFBhZ2Ugd2FzIGNyZWF0ZWQsIGEgbmV3IFNldHRpbmdzIG9iamVjdCB3YXMgY3Jl YXRlZCBhbmQgaXRzCisgICAgICAgICAgIG1fcHJpdmF0ZUJyb3dzaW5nRW5hYmxlZCB2YWx1ZSB3 YXMgZ2V0dGluZyBzZXQgdG8gZmFsc2UuCisgICAgICAgIDQuIFRoZSBQYWdlR3JvdXAgc2V0dGlu Z3Mgd2VyZSB0aGVuIGFwcGxpZWQgdG8gdGhlIG5ldyBTZXR0aW5ncyBvYmplY3QsIHJlc3VsdGlu ZyBpbgorICAgICAgICAgICBzZXRQcml2YXRlQnJvd3NpbmdFbmFibGVkKGZhbHNlKSB0byBiZSBj YWxsZWQuCisgICAgICAgIDUuIEFuIGlmIChtX3ByaXZhdGVCcm93c2luZ0VuYWJsZWQgPT0gcHJp dmF0ZUJyb3dzaW5nRW5hYmxlZCkgZWFybHkgcmV0dXJuIHByZXZlbnRlZCB0aGUKKyAgICAgICAg ICAgZ2xvYmFsIHZhbHVlIGZvciB0aGUgc3RvcmFnZSBzZXNzaW9uIGZyb20gYmVpbmcgZGVzdHJv eWVkLgorCisgICAgICAgICogcGFnZS9TZXR0aW5ncy5jcHA6CisgICAgICAgIChXZWJDb3JlOjpT ZXR0aW5nczo6c2V0UHJpdmF0ZUJyb3dzaW5nRW5hYmxlZCk6CisgICAgICAgIE1vdmUgdGhlIGVh cmx5IHJldHVybiB0byBiZSBhZnRlciBzZXR0aW5nIHRoZSBnbG9iYWwgcHJpdmF0ZSBicm93c2lu ZyB2YWx1ZXMsIGFuZCBhZGQgYQorICAgICAgICBjbGVhcmVyIGNvbW1lbnQgKyBGSVhNRS4KKwog MjAxMS0wOS0wNSAgUGF2ZWwgUG9kaXZpbG92ICA8cG9kaXZpbG92QGNocm9taXVtLm9yZz4KIAog ICAgICAgICBXZWIgSW5zcGVjdG9yOiByZS1pbXBsZW1lbnQgUmF3U291cmNlQ29kZS4KZGlmZiAt LWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BhZ2UvU2V0dGluZ3MuY3BwIGIvU291cmNlL1dlYkNvcmUv cGFnZS9TZXR0aW5ncy5jcHAKaW5kZXggMTAyOGI3Yi4uZWY4MGFiYyAxMDA2NDQKLS0tIGEvU291 cmNlL1dlYkNvcmUvcGFnZS9TZXR0aW5ncy5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvcGFnZS9T ZXR0aW5ncy5jcHAKQEAgLTQxMSwxNiArNDExLDI2IEBAIHZvaWQgU2V0dGluZ3M6OnNldFNlc3Np b25TdG9yYWdlUXVvdGEodW5zaWduZWQgc2Vzc2lvblN0b3JhZ2VRdW90YSkKIAogdm9pZCBTZXR0 aW5nczo6c2V0UHJpdmF0ZUJyb3dzaW5nRW5hYmxlZChib29sIHByaXZhdGVCcm93c2luZ0VuYWJs ZWQpCiB7Ci0gICAgaWYgKG1fcHJpdmF0ZUJyb3dzaW5nRW5hYmxlZCA9PSBwcml2YXRlQnJvd3Np bmdFbmFibGVkKQotICAgICAgICByZXR1cm47Ci0KKyAgICAvLyBGSVhNRSBodHRwOi8vd2Via2l0 Lm9yZy9iLzY3ODcwOiBUaGUgcHJpdmF0ZSBicm93c2luZyBzdG9yYWdlIHNlc3Npb24gYW5kIGNv b2tpZSBwcml2YXRlCisgICAgLy8gYnJvd3NpbmcgbW9kZSAod2hpY2ggaXMgdXNlZCBpZiBzdG9y YWdlIHNlc3Npb25zIGFyZSBub3QgYXZhaWxhYmxlKSBhcmUgZ2xvYmFsIHNldHRpbmdzLCBzbwor ICAgIC8vIGl0IGlzIG1pc2xlYWRpbmcgdG8gaGF2ZSB0aGVtIGFzIHBlci1wYWdlIHNldHRpbmdz LgorICAgIC8vIEluIGFkZGl0aW9uLCBpZiB0aGV5IGFyZSB0cmVhdGVkIGFzIGEgcGVyIFBhZ2Ug c2V0dGluZ3MsIHRoZSBnbG9iYWwgdmFsdWVzIGNhbiBnZXQgb3V0IG9mCisgICAgLy8gc3luYyB3 aXRoIHRoZSBwZXIgUGFnZSB2YWx1ZSBpbiB0aGUgZm9sbG93aW5nIHNpdHVhdGlvbjoKKyAgICAv LyAxLiBUaGUgZ2xvYmFsIHZhbHVlcyBnZXQgc2V0IHRvIHRydWUgd2hlbiBzZXRQcml2YXRlQnJv d3NpbmdFbmFibGVkKHRydWUpIGlzIGNhbGxlZC4KKyAgICAvLyAyLiBBbGwgUGFnZXMgYXJlIGNs b3NlZCwgc28gYWxsIFNldHRpbmdzIG9iamVjdHMgZ28gYXdheS4KKyAgICAvLyAzLiBBIG5ldyBQ YWdlIGlzIGNyZWF0ZWQsIGFuZCBhIGNvcnJlc3BvbmRpbmcgbmV3IFNldHRpbmdzIG9iamVjdCBp cyBjcmVhdGVkIC0gd2l0aAorICAgIC8vICAgIG1fcHJpdmF0ZUJyb3dzaW5nRW5hYmxlZCBzdGFy dGluZyBvdXQgYXMgZmFsc2UgaW4gdGhlIGNvbnN0cnVjdG9yLgorICAgIC8vIDQuIFRoZSBQYWdl R3JvdXAgc2V0dGluZ3MgZ2V0IGFwcGxpZWQgdG8gdGhlIG5ldyBQYWdlIGFuZCBzZXRQcml2YXRl QnJvd3NpbmdFbmFibGVkKGZhbHNlKQorICAgIC8vICAgIGlzIGNhbGxlZCwgYnV0IGFuIGlmICht X3ByaXZhdGVCcm93c2luZ0VuYWJsZWQgPT0gcHJpdmF0ZUJyb3dzaW5nRW5hYmxlZCkgZWFybHkg cmV0dXJuCisgICAgLy8gICAgcHJldmVudHMgdGhlIGdsb2JhbCB2YWx1ZXMgZnJvbSBnZXR0aW5n IGNoYW5nZWQgZnJvbSB0cnVlIHRvIGZhbHNlLgogI2lmIFVTRShDRlVSTFNUT1JBR0VTRVNTSU9O UykKICAgICBSZXNvdXJjZUhhbmRsZTo6c2V0UHJpdmF0ZUJyb3dzaW5nRW5hYmxlZChwcml2YXRl QnJvd3NpbmdFbmFibGVkKTsKICNlbmRpZgotCi0gICAgLy8gRklYTUU6IFdlIGNhbiBvbmx5IGVu YWJsZSBjb29raWUgcHJpdmF0ZSBicm93c2luZyBtb2RlIGdsb2JhbGx5LCBzbyBpdCdzIG1pc2xl YWRpbmcgdG8gaGF2ZSBpdCBhcyBhIHBlci1wYWdlIHNldHRpbmcuCiAgICAgc2V0Q29va2llU3Rv cmFnZVByaXZhdGVCcm93c2luZ0VuYWJsZWQocHJpdmF0ZUJyb3dzaW5nRW5hYmxlZCk7CiAKKyAg ICBpZiAobV9wcml2YXRlQnJvd3NpbmdFbmFibGVkID09IHByaXZhdGVCcm93c2luZ0VuYWJsZWQp CisgICAgICAgIHJldHVybjsKKwogICAgIG1fcHJpdmF0ZUJyb3dzaW5nRW5hYmxlZCA9IHByaXZh dGVCcm93c2luZ0VuYWJsZWQ7CiAgICAgbV9wYWdlLT5wcml2YXRlQnJvd3NpbmdTdGF0ZUNoYW5n ZWQoKTsKIH0KLS0gCjEuNy41LjQKCg==