67873 2011-09-09 16:24:11 -0700 Throttle rate of requestAnimationFrame when page is not visible 2011-10-17 13:14:56 -0700 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 cmarrin cmarrin dino jamesr simon.fraser webkit-bug-importer oldest_to_newest 465088 0 cmarrin 2011-09-09 16:24:11 -0700 The RequestAnimationFrame spec (http://dvcs.w3.org/hg/webperf/raw-file/tip/specs/RequestAnimationFrame/Overview.html) states that non-visible pages should reduce the rate of firing of requestAnimationFrame callbacks when the page is not visible. None of the WebKit implementations of rAF currently do this. Apparently Firefox throttles to a rate of 0.1Hz. I'm not sure if it's necessary to go that slow. Maybe 1Hz would be sufficient? 465093 1 jamesr 2011-09-09 16:31:38 -0700 (In reply to comment #0) > The RequestAnimationFrame spec (http://dvcs.w3.org/hg/webperf/raw-file/tip/specs/RequestAnimationFrame/Overview.html) states that non-visible pages should reduce the rate of firing of requestAnimationFrame callbacks when the page is not visible. None of the WebKit implementations of rAF currently do this. > Chromium does not fire rAF at all when the page is not visible. > Apparently Firefox throttles to a rate of 0.1Hz. I'm not sure if it's necessary to go that slow. Maybe 1Hz would be sufficient? Firefox has had an exponential backoff algorithm and a 1Hz delay. I'm not completely sure what they have now. Please see: http://lists.w3.org/Archives/Public/public-web-perf/2011Jul/0039.html 465102 2 cmarrin 2011-09-09 16:44:53 -0700 The question (as brought up in that thread) is whether non-visible pages should be throttled to 0 or some slow rate. As you mention, iOS suspends and that seems to be working fine. FWIW, you might be able to interpret the spec as saying that events should be fired no faster than the page renders. When a page is not visible is doesn't render at all, so a frame rate of 0 seems reasonable. 473489 3 cmarrin 2011-09-26 15:54:41 -0700 *** Bug 68772 has been marked as a duplicate of this bug. *** 476445 4 webkit-bug-importer 2011-09-30 17:32:04 -0700 <rdar://problem/10218835> 484432 5 111113 cmarrin 2011-10-14 17:29:07 -0700 Created attachment 111113 Patch 484434 6 jamesr 2011-10-14 17:33:19 -0700 Note that this functionality in requestAnimationFrame is defined in terms of the Page Visibility API's DocumentVisibility.hidden attribute (http://dvcs.w3.org/hg/webperf/raw-file/tip/specs/PageVisibility/Overview.html#sec-document-visibility-interface), so if you plan to implement that API it might be useful to share plumbing for RAF. There's an open issue on the page visibility spec about how to deal with a document being visible vs an entire toplevel browsing context (WebCore::Page) but that shouldn't impact the plumbing gunk too much. 485312 7 cmarrin 2011-10-17 11:27:22 -0700 (In reply to comment #6) > Note that this functionality in requestAnimationFrame is defined in terms of the Page Visibility API's DocumentVisibility.hidden attribute (http://dvcs.w3.org/hg/webperf/raw-file/tip/specs/PageVisibility/Overview.html#sec-document-visibility-interface), so if you plan to implement that API it might be useful to share plumbing for RAF. There's an open issue on the page visibility spec about how to deal with a document being visible vs an entire toplevel browsing context (WebCore::Page) but that shouldn't impact the plumbing gunk too much. It's nice to see a formal API proposal for this functionality and I think it's right to use it if and when it becomes available. There are several places where we deal with suspend and resume and it's not very consistent. But the time to restructure all this is when that API is implemented. I looked and didn't find any WebKit bugs related to this. Do you know of any such bugs? 485433 8 cmarrin 2011-10-17 13:14:56 -0700 Committed r97640: <http://trac.webkit.org/changeset/97640> 111113 2011-10-14 17:29:07 -0700 2011-10-17 11:27:39 -0700 Patch bug-67873-20111014172905.patch text/plain 7335 cmarrin U3VidmVyc2lvbiBSZXZpc2lvbjogOTc0MTMKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCAzYTVhODYyZDgwMDAyODA0 ZmZkZWExNmFiYzE5ZDI3M2MxY2ZiNTQ5Li4yYTE5MjRlOGNiM2JmMzhkNDQ2NDk5MWYwMDA0Yjli NGQxZmYzYWU4IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvU291 cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjIgQEAKKzIwMTEtMTAtMTQgIENocmlz IE1hcnJpbiAgPGNtYXJyaW5AYXBwbGUuY29tPgorCisgICAgICAgIFRocm90dGxlIHJhdGUgb2Yg cmVxdWVzdEFuaW1hdGlvbkZyYW1lIHdoZW4gcGFnZSBpcyBub3QgdmlzaWJsZQorICAgICAgICBo dHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9Njc4NzMKKworICAgICAgICBS ZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBBZGQgbG9naWMgdG8gc3VzcGVu ZCBhbmQgcmVzdW1lIHNjcmlwdGVkIGFuaW1hdGlvbnMgd2hlbiBwYWdlIGlzIGhpZGRlbiwKKyAg ICAgICAgbWluaW1pemVkIG9yIHRoZSB0YWIgaXMgbm90IHZpc2libGUuIFRoZSBoaWRlL21pbmlt aXplIG5vdGlmaWNhdGlvbiBjb21lcworICAgICAgICBpbiBmcm9tIFdlYktpdC9XZWJLaXQyIHRv IGEgbmV3IHNldCBvZiBmdW5jdGlvbnMuCisKKyAgICAgICAgKiBXZWJDb3JlLmV4cC5pbjoKKyAg ICAgICAgKiBwYWdlL1BhZ2UuY3BwOgorICAgICAgICAoV2ViQ29yZTo6UGFnZTo6ZGlkTW92ZU9u c2NyZWVuKToKKyAgICAgICAgKFdlYkNvcmU6OlBhZ2U6OndpbGxNb3ZlT2Zmc2NyZWVuKToKKyAg ICAgICAgKFdlYkNvcmU6OlBhZ2U6OnN1c3BlbmRTY3JpcHRlZEFuaW1hdGlvbnMpOgorICAgICAg ICAoV2ViQ29yZTo6UGFnZTo6cmVzdW1lU2NyaXB0ZWRBbmltYXRpb25zKToKKyAgICAgICAgKiBw YWdlL1BhZ2UuaDoKKwogMjAxMS0xMC0xMyAgQ2hyaXMgTWFycmluICA8Y21hcnJpbkBhcHBsZS5j b20+CiAKICAgICAgICAgRml4IExlb3BhcmQgYnVpbGQKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJD b3JlL1dlYkNvcmUuZXhwLmluIGIvU291cmNlL1dlYkNvcmUvV2ViQ29yZS5leHAuaW4KaW5kZXgg ZTQ3M2JhOTU3MjIxZWI5ODViNmE5MTZjYTQzNzAzNjNlM2U1MTZmMC4uOWMwNDhiMTgyZWE2N2Zh OTllOWUwMDM2NGM3NDBlYzZmZGUxNGQ0ZiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvV2Vi Q29yZS5leHAuaW4KKysrIGIvU291cmNlL1dlYkNvcmUvV2ViQ29yZS5leHAuaW4KQEAgLTczNSw2 ICs3MzUsOCBAQCBfX1pON1dlYkNvcmU0UGFnZTIxbWFya0FsbE1hdGNoZXNGb3JUZXh0RVJLTjNX VEY2U3RyaW5nRWpiagogX19aTjdXZWJDb3JlNFBhZ2UyMXdpbmRvd1NjcmVlbkRpZENoYW5nZUVq CiBfX1pON1dlYkNvcmU0UGFnZTIyYWxsVmlzaXRlZFN0YXRlQ2hhbmdlZEVQTlNfOVBhZ2VHcm91 cEUKIF9fWk43V2ViQ29yZTRQYWdlMjNjbGVhclVuZG9SZWRvT3BlcmF0aW9uc0V2CitfX1pON1dl YkNvcmU0UGFnZTI0cmVzdW1lU2NyaXB0ZWRBbmltYXRpb25zRXYKK19fWk43V2ViQ29yZTRQYWdl MjVzdXNwZW5kU2NyaXB0ZWRBbmltYXRpb25zRXYKIF9fWk43V2ViQ29yZTRQYWdlMjdzZXRKYXZh U2NyaXB0VVJMc0FyZUFsbG93ZWRFYgogX19aTjdXZWJDb3JlNFBhZ2UzMXNldEN1c3RvbUhUTUxU b2tlbml6ZXJDaHVua1NpemVFaQogX19aTjdXZWJDb3JlNFBhZ2UzMXNldEN1c3RvbUhUTUxUb2tl bml6ZXJUaW1lRGVsYXlFZApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGFnZS9QYWdlLmNw cCBiL1NvdXJjZS9XZWJDb3JlL3BhZ2UvUGFnZS5jcHAKaW5kZXggYmZiZTcwYTMyMjdkZjkyNTVi OTVjNjkzMDc2YmUyMWVmYzI2NTFkYS4uN2Q3NTM5ZDMyNDlhZGRmNWZhMTZjNjIzZmEyYmI4YjQ2 NWM1N2QwOCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGFnZS9QYWdlLmNwcAorKysgYi9T b3VyY2UvV2ViQ29yZS9wYWdlL1BhZ2UuY3BwCkBAIC02NzEsNiArNjcxLDggQEAgdm9pZCBQYWdl OjpkaWRNb3ZlT25zY3JlZW4oKQogICAgICAgICBpZiAoZnJhbWUtPnZpZXcoKSkKICAgICAgICAg ICAgIGZyYW1lLT52aWV3KCktPmRpZE1vdmVPbnNjcmVlbigpOwogICAgIH0KKyAgICAKKyAgICBy ZXN1bWVTY3JpcHRlZEFuaW1hdGlvbnMoKTsKIH0KIAogdm9pZCBQYWdlOjp3aWxsTW92ZU9mZnNj cmVlbigpCkBAIC02NzksNiArNjgxLDggQEAgdm9pZCBQYWdlOjp3aWxsTW92ZU9mZnNjcmVlbigp CiAgICAgICAgIGlmIChmcmFtZS0+dmlldygpKQogICAgICAgICAgICAgZnJhbWUtPnZpZXcoKS0+ d2lsbE1vdmVPZmZzY3JlZW4oKTsKICAgICB9CisgICAgCisgICAgc3VzcGVuZFNjcmlwdGVkQW5p bWF0aW9ucygpOwogfQogCiB2b2lkIFBhZ2U6OndpbmRvd1NjcmVlbkRpZENoYW5nZShQbGF0Zm9y bURpc3BsYXlJRCBkaXNwbGF5SUQpCkBAIC02OTEsNiArNjk1LDIyIEBAIHZvaWQgUGFnZTo6d2lu ZG93U2NyZWVuRGlkQ2hhbmdlKFBsYXRmb3JtRGlzcGxheUlEIGRpc3BsYXlJRCkKICAgICB9CiB9 CiAKK3ZvaWQgUGFnZTo6c3VzcGVuZFNjcmlwdGVkQW5pbWF0aW9ucygpCit7CisgICAgZm9yIChG cmFtZSogZnJhbWUgPSBtYWluRnJhbWUoKTsgZnJhbWU7IGZyYW1lID0gZnJhbWUtPnRyZWUoKS0+ dHJhdmVyc2VOZXh0KCkpIHsKKyAgICAgICAgaWYgKGZyYW1lLT5kb2N1bWVudCgpKQorICAgICAg ICAgICAgZnJhbWUtPmRvY3VtZW50KCktPnN1c3BlbmRTY3JpcHRlZEFuaW1hdGlvbkNvbnRyb2xs ZXJDYWxsYmFja3MoKTsKKyAgICB9Cit9CisKK3ZvaWQgUGFnZTo6cmVzdW1lU2NyaXB0ZWRBbmlt YXRpb25zKCkKK3sKKyAgICBmb3IgKEZyYW1lKiBmcmFtZSA9IG1haW5GcmFtZSgpOyBmcmFtZTsg ZnJhbWUgPSBmcmFtZS0+dHJlZSgpLT50cmF2ZXJzZU5leHQoKSkgeworICAgICAgICBpZiAoZnJh bWUtPmRvY3VtZW50KCkpCisgICAgICAgICAgICBmcmFtZS0+ZG9jdW1lbnQoKS0+cmVzdW1lU2Ny aXB0ZWRBbmltYXRpb25Db250cm9sbGVyQ2FsbGJhY2tzKCk7CisgICAgfQorfQorCiB2b2lkIFBh Z2U6OnVzZXJTdHlsZVNoZWV0TG9jYXRpb25DaGFuZ2VkKCkKIHsKICAgICAvLyBGSVhNRTogRXZl bnR1YWxseSB3ZSB3aWxsIG1vdmUgdG8gYSBtb2RlbCBvZiBqdXN0IGJlaW5nIGhhbmRlZCB0aGUg c2hlZXQKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BhZ2UvUGFnZS5oIGIvU291cmNlL1dl YkNvcmUvcGFnZS9QYWdlLmgKaW5kZXggZTcwZmRiZDA5OWRjZjFhNWQzNTM1Y2Y0NDY5ZWZiYjdj YTgzMWY1OC4uZGYxMDYzNjAzOGEzNThhMzAyZGJhOGNiMWFlNzY1ZWFkZWFiZWQyYiAxMDA2NDQK LS0tIGEvU291cmNlL1dlYkNvcmUvcGFnZS9QYWdlLmgKKysrIGIvU291cmNlL1dlYkNvcmUvcGFn ZS9QYWdlLmgKQEAgLTI1OSw2ICsyNTksOSBAQCBuYW1lc3BhY2UgV2ViQ29yZSB7CiAKICAgICAg ICAgdm9pZCB3aW5kb3dTY3JlZW5EaWRDaGFuZ2UoUGxhdGZvcm1EaXNwbGF5SUQpOwogICAgICAg ICAKKyAgICAgICAgdm9pZCBzdXNwZW5kU2NyaXB0ZWRBbmltYXRpb25zKCk7CisgICAgICAgIHZv aWQgcmVzdW1lU2NyaXB0ZWRBbmltYXRpb25zKCk7CisgICAgICAgIAogICAgICAgICB2b2lkIHVz ZXJTdHlsZVNoZWV0TG9jYXRpb25DaGFuZ2VkKCk7CiAgICAgICAgIGNvbnN0IFN0cmluZyYgdXNl clN0eWxlU2hlZXQoKSBjb25zdDsKIApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9tYWMvQ2hh bmdlTG9nIGIvU291cmNlL1dlYktpdC9tYWMvQ2hhbmdlTG9nCmluZGV4IDY3ODg1YTdhMzQ4NWIw YmU5NTljMjExNzkzYzhmNGZhYTRhNDQ3MzkuLmE4OTE3ZTg0NmJhNWFmM2VmNGUxODVmZmZhOTY3 ZmJkMGNlNzkyMTUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvbWFjL0NoYW5nZUxvZworKysg Yi9Tb3VyY2UvV2ViS2l0L21hYy9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNyBAQAorMjAxMS0xMC0x NCAgQ2hyaXMgTWFycmluICA8Y21hcnJpbkBhcHBsZS5jb20+CisKKyAgICAgICAgVGhyb3R0bGUg cmF0ZSBvZiByZXF1ZXN0QW5pbWF0aW9uRnJhbWUgd2hlbiBwYWdlIGlzIG5vdCB2aXNpYmxlCisg ICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD02Nzg3MworCisg ICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFBsdW1iIHRocm91 Z2ggbm90aWZpY2F0aW9uIHdoZW4gdGhlIHdpbmRvdyBpcyBoaWRkZW4vc2hvd24gb3IKKyAgICAg ICAgbWluaW1pemVkL3VubWluaW1pemVkCisKKyAgICAgICAgKiBXZWJWaWV3L1dlYlZpZXcubW06 CisgICAgICAgICgtW1dlYlZpZXcgX3dpbmRvd1dpbGxPcmRlck9uU2NyZWVuOl0pOgorICAgICAg ICAoLVtXZWJWaWV3IF93aW5kb3dXaWxsT3JkZXJPZmZTY3JlZW46XSk6CisKIDIwMTEtMTAtMTMg IEJldGggRGFraW4gIDxiZGFraW5AYXBwbGUuY29tPgogCiAgICAgICAgIGh0dHBzOi8vYnVncy53 ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD03MDA1MApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktp dC9tYWMvV2ViVmlldy9XZWJWaWV3Lm1tIGIvU291cmNlL1dlYktpdC9tYWMvV2ViVmlldy9XZWJW aWV3Lm1tCmluZGV4IDQyNGEzYzM3ZmM1YjQwYjQ2MzU4NmYwOGM1MzIxMDI2MmFlNDg4YmQuLjI0 YzBiM2ZjMWE0NjBhYmU0MjVmOGE5YmIwYjE3NTdjYWZlNzMyZWEgMTAwNjQ0Ci0tLSBhL1NvdXJj ZS9XZWJLaXQvbWFjL1dlYlZpZXcvV2ViVmlldy5tbQorKysgYi9Tb3VyY2UvV2ViS2l0L21hYy9X ZWJWaWV3L1dlYlZpZXcubW0KQEAgLTMzMjgsNiArMzMyOCw5IEBAIC0gKHZvaWQpX3dpbmRvd1dp bGxPcmRlck9uU2NyZWVuOihOU05vdGlmaWNhdGlvbiAqKW5vdGlmaWNhdGlvbgogCiAgICAgLy8g U2VuZCBhIGNoYW5nZSBzY3JlZW4gdG8gbWFrZSBzdXJlIHRoZSBpbml0aWFsIGRpc3BsYXlJRCBp cyBzZXQKICAgICBbc2VsZiBkb1dpbmRvd0RpZENoYW5nZVNjcmVlbl07CisKKyAgICBpZiAoX3By aXZhdGUgJiYgX3ByaXZhdGUtPnBhZ2UpCisgICAgICAgIF9wcml2YXRlLT5wYWdlLT5yZXN1bWVT Y3JpcHRlZEFuaW1hdGlvbnMoKTsgICAgCiB9CiAKIC0gKHZvaWQpX3dpbmRvd0RpZENoYW5nZVNj cmVlbjooTlNOb3RpZmljYXRpb24gKilub3RpZmljYXRpb24KQEAgLTMzNDEsNiArMzM0NCw5IEBA IC0gKHZvaWQpX3dpbmRvd1dpbGxPcmRlck9mZlNjcmVlbjooTlNOb3RpZmljYXRpb24gKilub3Rp ZmljYXRpb24KICAgICAvLyBUaGlzIGlzIG5lZWRlZCBiZWNhdXNlIHRoZSBub3JtYWwgTlNXaW5k b3dEaWRSZXNpZ25LZXlOb3RpZmljYXRpb24gaXMgbm90IGZpcmVkCiAgICAgLy8gZm9yIE5TUG9w b3ZlciB3aW5kb3dzIHNpbmNlIHRoZXkgc2hhcmUga2V5IHdpdGggdGhlaXIgcGFyZW50IHdpbmRv dy4KICAgICBbc2VsZiBfdXBkYXRlQWN0aXZlU3RhdGVdOworICAgIAorICAgIGlmIChfcHJpdmF0 ZSAmJiBfcHJpdmF0ZS0+cGFnZSkKKyAgICAgICAgX3ByaXZhdGUtPnBhZ2UtPnN1c3BlbmRTY3Jp cHRlZEFuaW1hdGlvbnMoKTsgICAgCiB9CiAKIC0gKHZvaWQpX3dpbmRvd1dpbGxDbG9zZTooTlNO b3RpZmljYXRpb24gKilub3RpZmljYXRpb24KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwppbmRleCAxZGUxMWQzYWUxNmMxYmU4 ZTQ4ZDQ5OGI0ZWZiY2ZkMDRmYjA0MjM1Li43YzdkN2I2ZDNlYTY5ODAxYzg5ZTc1Njc1YzFjZmRm MmEyOWU5ZGMxIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKKysrIGIvU291 cmNlL1dlYktpdDIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTcgQEAKKzIwMTEtMTAtMTQgIENocmlz IE1hcnJpbiAgPGNtYXJyaW5AYXBwbGUuY29tPgorCisgICAgICAgIFRocm90dGxlIHJhdGUgb2Yg cmVxdWVzdEFuaW1hdGlvbkZyYW1lIHdoZW4gcGFnZSBpcyBub3QgdmlzaWJsZQorICAgICAgICBo dHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9Njc4NzMKKworICAgICAgICBS ZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBQbHVtYiB0aHJvdWdoIG5vdGlm aWNhdGlvbiB3aGVuIHRoZSB3aW5kb3cgaXMgaGlkZGVuL3Nob3duIG9yCisgICAgICAgIG1pbmlt aXplZC91bm1pbmltaXplZAorCisgICAgICAgICogV2ViUHJvY2Vzcy9XZWJQYWdlL0RyYXdpbmdB cmVhSW1wbC5jcHA6CisgICAgICAgIChXZWJLaXQ6OkRyYXdpbmdBcmVhSW1wbDo6c3VzcGVuZFBh aW50aW5nKToKKyAgICAgICAgKFdlYktpdDo6RHJhd2luZ0FyZWFJbXBsOjpyZXN1bWVQYWludGlu Zyk6CisKIDIwMTEtMTAtMTMgIEFsZXhleSBQcm9za3VyeWFrb3YgIDxhcEBhcHBsZS5jb20+CiAK ICAgICAgICAgW01hY10gV2hlZWwgZXZlbnQgaGFuZGxlciBjb3VudGVyIGlzIGluY29ycmVjdCB3 aXRoIFBERiB2aWV3cwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9XZWJQ YWdlL0RyYXdpbmdBcmVhSW1wbC5jcHAgYi9Tb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL1dlYlBh Z2UvRHJhd2luZ0FyZWFJbXBsLmNwcAppbmRleCA5N2ZmODI3YzdhOWNkYWJiN2Y4OWIyZTNjNzVl NGMwNzNiYjRhMzc3Li5jNWM3ZjU5YjFlY2ZiZjM4YzNmMDU1MWRjZDhjOGI4M2I4NTA4NzdlIDEw MDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL1dlYlBhZ2UvRHJhd2luZ0FyZWFJ bXBsLmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL1dlYlBhZ2UvRHJhd2luZ0Fy ZWFJbXBsLmNwcApAQCAtNDA2LDYgKzQwNiw4IEBAIHZvaWQgRHJhd2luZ0FyZWFJbXBsOjpzdXNw ZW5kUGFpbnRpbmcoKQogCiAgICAgbV9pc1BhaW50aW5nU3VzcGVuZGVkID0gdHJ1ZTsKICAgICBt X2Rpc3BsYXlUaW1lci5zdG9wKCk7CisKKyAgICBtX3dlYlBhZ2UtPmNvcmVQYWdlKCktPnN1c3Bl bmRTY3JpcHRlZEFuaW1hdGlvbnMoKTsKIH0KIAogdm9pZCBEcmF3aW5nQXJlYUltcGw6OnJlc3Vt ZVBhaW50aW5nKCkKQEAgLTQyMyw2ICs0MjUsOCBAQCB2b2lkIERyYXdpbmdBcmVhSW1wbDo6cmVz dW1lUGFpbnRpbmcoKQogCiAgICAgLy8gRklYTUU6IFdlIHNob3VsZG4ndCBhbHdheXMgcmVwYWlu dCBldmVyeXRoaW5nIGhlcmUuCiAgICAgc2V0TmVlZHNEaXNwbGF5KG1fd2ViUGFnZS0+Ym91bmRz KCkpOworCisgICAgbV93ZWJQYWdlLT5jb3JlUGFnZSgpLT5yZXN1bWVTY3JpcHRlZEFuaW1hdGlv bnMoKTsKIH0KIAogdm9pZCBEcmF3aW5nQXJlYUltcGw6OmVudGVyQWNjZWxlcmF0ZWRDb21wb3Np dGluZ01vZGUoR3JhcGhpY3NMYXllciogZ3JhcGhpY3NMYXllcikK