67872 2011-09-09 16:14:41 -0700 DelayNode delay buffer is not correctly wrapping around 2011-09-12 11:54:09 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 crogers crogers kbr oldest_to_newest 465081 0 crogers 2011-09-09 16:14:41 -0700 DelayNode delay buffer is not correctly wrapping around 465082 1 106934 crogers 2011-09-09 16:16:12 -0700 Created attachment 106934 Patch 465333 2 106934 kbr 2011-09-10 14:45:15 -0700 Comment on attachment 106934 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=106934&action=review The test case is awesome. r=me > LayoutTests/webaudio/delaynode.html:37 > + } Even though this is just a layout test, WebKit style is no braces for single-line statements. > LayoutTests/webaudio/delaynode.html:82 > + } Braces on single-line statements. 465711 3 crogers 2011-09-12 11:54:09 -0700 Committed r94969: <http://trac.webkit.org/changeset/94969> 106934 2011-09-09 16:16:12 -0700 2011-09-10 14:45:15 -0700 Patch bug-67872-20110909161611.patch text/plain 6174 crogers U3VidmVyc2lvbiBSZXZpc2lvbjogOTQ4NzcKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5n ZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxvZwppbmRleCA3ZDNmNmQ4NWE0NmRlYzE1Y2U5MDRh NjZkOTEzN2Q5MThmOWY4ZjVmLi43MTUyZjUwOGU1OTMzYmU4YWNhYTMzZDA0NjIyZjU2MGViYWZm MDczIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKKysrIGIvTGF5b3V0VGVzdHMv Q2hhbmdlTG9nCkBAIC0xLDMgKzEsMTMgQEAKKzIwMTEtMDktMDkgIENocmlzIFJvZ2VycyAgPGNy b2dlcnNAZ29vZ2xlLmNvbT4KKworICAgICAgICBEZWxheU5vZGUgZGVsYXkgYnVmZmVyIGlzIG5v dCBjb3JyZWN0bHkgd3JhcHBpbmcgYXJvdW5kCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQu b3JnL3Nob3dfYnVnLmNnaT9pZD02Nzg3MgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAo T09QUyEpLgorCisgICAgICAgICogd2ViYXVkaW8vZGVsYXlub2RlLWV4cGVjdGVkLnR4dDogQWRk ZWQuCisgICAgICAgICogd2ViYXVkaW8vZGVsYXlub2RlLmh0bWw6IEFkZGVkLgorCiAyMDExLTA5 LTA5ICBSeW9zdWtlIE5pd2EgIDxybml3YUB3ZWJraXQub3JnPgogCiAgICAgICAgIEdUSyByZWJh c2VsaW5lLgpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvd2ViYXVkaW8vZGVsYXlub2RlLWV4cGVj dGVkLnR4dCBiL0xheW91dFRlc3RzL3dlYmF1ZGlvL2RlbGF5bm9kZS1leHBlY3RlZC50eHQKbmV3 IGZpbGUgbW9kZSAxMDA2NDQKaW5kZXggMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAw MDAwMDAwMC4uNjNhNTJkOGM0MGU3NWZjNjE2OWM2NjEyYWZmY2RiN2Q3NTI0ZDc4MQotLS0gL2Rl di9udWxsCisrKyBiL0xheW91dFRlc3RzL3dlYmF1ZGlvL2RlbGF5bm9kZS1leHBlY3RlZC50eHQK QEAgLTAsMCArMSw5IEBACitUZXN0cyBiYXNpYyBmdW5jdGlvbmFsaXR5IG9mIERlbGF5Tm9kZS4K KworT24gc3VjY2VzcywgeW91IHdpbGwgc2VlIGEgc2VyaWVzIG9mICJQQVNTIiBtZXNzYWdlcywg Zm9sbG93ZWQgYnkgIlRFU1QgQ09NUExFVEUiLgorCitQQVNTIFRlc3Qgc2lnbmFsIHdhcyBjb3Jy ZWN0bHkgZGVsYXllZC4KK1BBU1Mgc3VjY2Vzc2Z1bGx5UGFyc2VkIGlzIHRydWUKKworVEVTVCBD T01QTEVURQorCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy93ZWJhdWRpby9kZWxheW5vZGUuaHRt bCBiL0xheW91dFRlc3RzL3dlYmF1ZGlvL2RlbGF5bm9kZS5odG1sCm5ldyBmaWxlIG1vZGUgMTAw NjQ0CmluZGV4IDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAuLjEyZDJk MzNlMzBiMjRlNmU3MDEwYTM4YTU5NmQwMTI5MzcwNThkN2IKLS0tIC9kZXYvbnVsbAorKysgYi9M YXlvdXRUZXN0cy93ZWJhdWRpby9kZWxheW5vZGUuaHRtbApAQCAtMCwwICsxLDEyMCBAQAorPCFE T0NUWVBFIGh0bWw+CisKKzxodG1sPgorPGhlYWQ+Cis8bGluayByZWw9InN0eWxlc2hlZXQiIGhy ZWY9Ii4uL2Zhc3QvanMvcmVzb3VyY2VzL2pzLXRlc3Qtc3R5bGUuY3NzIi8+Cis8c2NyaXB0IHNy Yz0iLi4vZmFzdC9qcy9yZXNvdXJjZXMvanMtdGVzdC1wcmUuanMiPjwvc2NyaXB0PgorPC9oZWFk PgorCis8Ym9keT4KKworPGRpdiBpZD0iZGVzY3JpcHRpb24iPjwvZGl2PgorPGRpdiBpZD0iY29u c29sZSI+PC9kaXY+CisKKzxzY3JpcHQ+CitkZXNjcmlwdGlvbigiVGVzdHMgYmFzaWMgZnVuY3Rp b25hbGl0eSBvZiBEZWxheU5vZGUuIik7CisKK3ZhciBzYW1wbGVSYXRlID0gNDQxMDAuMDsKKwor dmFyIGNvbnRleHQ7Cit2YXIgdG9uZUJ1ZmZlcjsKKwordmFyIHJlbmRlckxlbmd0aFNlY29uZHMg PSA0OwordmFyIGRlbGF5VGltZVNlY29uZHMgPSAwLjU7Cit2YXIgdG9uZUxlbmd0aFNlY29uZHMg PSAyOworCitmdW5jdGlvbiBjcmVhdGVUb25lQnVmZmVyKGZyZXF1ZW5jeSwgbnVtYmVyT2ZDeWNs ZXMsIHNhbXBsZVJhdGUpIHsKKyAgICB2YXIgZHVyYXRpb24gPSBudW1iZXJPZkN5Y2xlcyAvIGZy ZXF1ZW5jeTsKKyAgICB2YXIgc2FtcGxlRnJhbWVMZW5ndGggPSBkdXJhdGlvbiAqIHNhbXBsZVJh dGU7CisgICAgCisgICAgdmFyIGF1ZGlvQnVmZmVyID0gY29udGV4dC5jcmVhdGVCdWZmZXIoMSwg c2FtcGxlRnJhbWVMZW5ndGgsIHNhbXBsZVJhdGUpOworCisgICAgdmFyIG4gPSBhdWRpb0J1ZmZl ci5sZW5ndGg7CisgICAgdmFyIGRhdGEgPSBhdWRpb0J1ZmZlci5nZXRDaGFubmVsRGF0YSgwKTsK KworICAgIGZvciAodmFyIGkgPSAwOyBpIDwgbjsgKytpKSB7CisgICAgICAgIGRhdGFbaV0gPSBN YXRoLnNpbihmcmVxdWVuY3kgKiAyLjAqTWF0aC5QSSAqIGkgLyBzYW1wbGVSYXRlKTsKKyAgICB9 CisKKyAgICByZXR1cm4gYXVkaW9CdWZmZXI7Cit9CisKK2Z1bmN0aW9uIGNoZWNrRGVsYXllZFJl c3VsdChldmVudCkgeworICAgIHZhciByZW5kZXJlZEJ1ZmZlciA9IGV2ZW50LnJlbmRlcmVkQnVm ZmVyOworCisgICAgdmFyIHNvdXJjZURhdGEgPSB0b25lQnVmZmVyLmdldENoYW5uZWxEYXRhKDAp OworICAgIHZhciByZW5kZXJlZERhdGEgPSByZW5kZXJlZEJ1ZmZlci5nZXRDaGFubmVsRGF0YSgw KTsKKyAgICAKKyAgICB2YXIgZGVsYXlUaW1lRnJhbWVzID0gZGVsYXlUaW1lU2Vjb25kcyAqIHNh bXBsZVJhdGU7CisgICAgdmFyIHRvbmVMZW5ndGhGcmFtZXMgPSB0b25lTGVuZ3RoU2Vjb25kcyAq IHNhbXBsZVJhdGU7CisKKyAgICB2YXIgc3VjY2VzcyA9IHRydWU7CisgICAgCisgICAgdmFyIG4g PSByZW5kZXJlZEJ1ZmZlci5sZW5ndGg7CisgICAgCisgICAgZm9yICh2YXIgaSA9IDA7IGkgPCBu OyArK2kpIHsKKyAgICAgICAgaWYgKGkgPCBkZWxheVRpbWVGcmFtZXMpIHsKKyAgICAgICAgICAg IC8vIENoZWNrIHRoYXQgaW5pdGlhbCBwb3J0aW9uIGlzIDAgKHNpbmNlIHNpZ25hbCBpcyBkZWxh eWVkKS4KKyAgICAgICAgICAgIGlmIChyZW5kZXJlZERhdGFbaV0gIT0gMCkgeworICAgICAgICAg ICAgICAgIHN1Y2Nlc3MgPSBmYWxzZTsKKyAgICAgICAgICAgICAgICBicmVhazsKKyAgICAgICAg ICAgIH0KKyAgICAgICAgfSBlbHNlIGlmIChpID49IGRlbGF5VGltZUZyYW1lcyAmJiBpIDwgZGVs YXlUaW1lRnJhbWVzICsgdG9uZUxlbmd0aEZyYW1lcykgeworICAgICAgICAgICAgLy8gTWFrZSBz dXJlIHRoYXQgdGhlIHRvbmUgZGF0YSBpcyBkZWxheWVkIGJ5IGV4YWN0bHkgdGhlIGV4cGVjdGVk IG51bWJlciBvZiBmcmFtZXMuCisgICAgICAgICAgICB2YXIgaiA9IGkgLSBkZWxheVRpbWVGcmFt ZXM7CisgICAgICAgICAgICBpZiAocmVuZGVyZWREYXRhW2ldICE9IHNvdXJjZURhdGFbal0pIHsK KyAgICAgICAgICAgICAgICBzdWNjZXNzID0gZmFsc2U7CisgICAgICAgICAgICAgICAgYnJlYWs7 CisgICAgICAgICAgICB9CisgICAgICAgIH0gZWxzZSB7CisgICAgICAgICAgICAvLyBNYWtlIHN1 cmUgd2UgaGF2ZSBzaWxlbmNlIGFmdGVyIHRoZSBkZWxheWVkIHRvbmUuCisgICAgICAgICAgICBp ZiAocmVuZGVyZWREYXRhW2ldICE9IDApIHsKKyAgICAgICAgICAgICAgICBzdWNjZXNzID0gZmFs c2U7CisgICAgICAgICAgICAgICAgYnJlYWs7CisgICAgICAgICAgICB9CisgICAgICAgIH0gICAg CisgICAgfQorCisgICAgaWYgKHN1Y2Nlc3MpIHsKKyAgICAgICAgdGVzdFBhc3NlZCgiVGVzdCBz aWduYWwgd2FzIGNvcnJlY3RseSBkZWxheWVkLiIpOworICAgIH0gZWxzZSB7CisgICAgICAgIHRl c3RGYWlsZWQoIlRlc3Qgc2lnbmFsIHdhcyBub3QgY29ycmVjdGx5IGRlbGF5ZWQuIik7CisgICAg fQorCisgICAgZmluaXNoSlNUZXN0KCk7Cit9CisKK2Z1bmN0aW9uIHJ1blRlc3QoKSB7CisgICAg aWYgKHdpbmRvdy5sYXlvdXRUZXN0Q29udHJvbGxlcikgeworICAgICAgICBsYXlvdXRUZXN0Q29u dHJvbGxlci5kdW1wQXNUZXh0KCk7CisgICAgICAgIGxheW91dFRlc3RDb250cm9sbGVyLndhaXRV bnRpbERvbmUoKTsKKyAgICB9CisgICAgCisgICAgd2luZG93LmpzVGVzdElzQXN5bmMgPSB0cnVl OworICAgICAgICAKKyAgICAvLyBDcmVhdGUgb2ZmbGluZSBhdWRpbyBjb250ZXh0LgorICAgIGNv bnRleHQgPSBuZXcgd2Via2l0QXVkaW9Db250ZXh0KDEsIHNhbXBsZVJhdGUgKiByZW5kZXJMZW5n dGhTZWNvbmRzLCBzYW1wbGVSYXRlKTsKKyAgICB0b25lQnVmZmVyID0gY3JlYXRlVG9uZUJ1ZmZl cigyMCwgMjAgKiB0b25lTGVuZ3RoU2Vjb25kcywgc2FtcGxlUmF0ZSk7IC8vIDIwSHogdG9uZQor ICAgIAorICAgIHZhciBidWZmZXJTb3VyY2UgPSBjb250ZXh0LmNyZWF0ZUJ1ZmZlclNvdXJjZSgp OworICAgIGJ1ZmZlclNvdXJjZS5idWZmZXIgPSB0b25lQnVmZmVyOworCisgICAgdmFyIGRlbGF5 ID0gY29udGV4dC5jcmVhdGVEZWxheU5vZGUoKTsKKyAgICBkZWxheS5kZWxheVRpbWUudmFsdWUg PSBkZWxheVRpbWVTZWNvbmRzOworCisgICAgYnVmZmVyU291cmNlLmNvbm5lY3QoZGVsYXkpOwor ICAgIGRlbGF5LmNvbm5lY3QoY29udGV4dC5kZXN0aW5hdGlvbik7CisgICAgYnVmZmVyU291cmNl Lm5vdGVPbigwKTsKKyAgICAKKyAgICBjb250ZXh0Lm9uY29tcGxldGUgPSBjaGVja0RlbGF5ZWRS ZXN1bHQ7CisgICAgY29udGV4dC5zdGFydFJlbmRlcmluZygpOworfQorCitydW5UZXN0KCk7Citz dWNjZXNzZnVsbHlQYXJzZWQgPSB0cnVlOworCis8L3NjcmlwdD4KKworPHNjcmlwdCBzcmM9Ii4u L2Zhc3QvanMvcmVzb3VyY2VzL2pzLXRlc3QtcG9zdC5qcyI+PC9zY3JpcHQ+Cis8L2JvZHk+Cis8 L2h0bWw+CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cKaW5kZXggYWY3NzE3ODhkMTE1MGFmMmY3OGIyZjVmY2VhOWIyMzMzNTU4 YjJjNi4uZmM4YjE3MWVjYmNlY2NkZWMwNGJiOTc1NGE4NWQ2NzVmNmE4ODcyMCAxMDA2NDQKLS0t IGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxv ZwpAQCAtMSwzICsxLDE1IEBACisyMDExLTA5LTA5ICBDaHJpcyBSb2dlcnMgIDxjcm9nZXJzQGdv b2dsZS5jb20+CisKKyAgICAgICAgRGVsYXlOb2RlIGRlbGF5IGJ1ZmZlciBpcyBub3QgY29ycmVj dGx5IHdyYXBwaW5nIGFyb3VuZAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93 X2J1Zy5jZ2k/aWQ9Njc4NzIKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4K KworICAgICAgICBUZXN0OiB3ZWJhdWRpby9kZWxheW5vZGUuaHRtbAorCisgICAgICAgICogd2Vi YXVkaW8vRGVsYXlEU1BLZXJuZWwuY3BwOgorICAgICAgICAoV2ViQ29yZTo6RGVsYXlEU1BLZXJu ZWw6OnByb2Nlc3MpOgorCiAyMDExLTA5LTA5ICBEYW4gQmVybnN0ZWluICA8bWl0ekBhcHBsZS5j b20+CiAKICAgICAgICAgUmVuZGVyQmxvY2s6OmFkZE92ZXJoYW5naW5nRmxvYXRzKCkgdGFrZXMg c3VwZXJmbHVvdXMgcGFyYW1ldGVycwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvd2ViYXVk aW8vRGVsYXlEU1BLZXJuZWwuY3BwIGIvU291cmNlL1dlYkNvcmUvd2ViYXVkaW8vRGVsYXlEU1BL ZXJuZWwuY3BwCmluZGV4IDQ1YTliMzI1ZWQyZmRlNGJhYjkzMTRmZTI2ZGQ3ZWQ0NTA3NmVjMjEu LjhlMGI0MGVmY2JiN2QxZTBmMzlmNjYwMzI2NmJjYzIyNDI0ZGQ2YjIgMTAwNjQ0Ci0tLSBhL1Nv dXJjZS9XZWJDb3JlL3dlYmF1ZGlvL0RlbGF5RFNQS2VybmVsLmNwcAorKysgYi9Tb3VyY2UvV2Vi Q29yZS93ZWJhdWRpby9EZWxheURTUEtlcm5lbC5jcHAKQEAgLTEwOCw3ICsxMDgsNyBAQCB2b2lk IERlbGF5RFNQS2VybmVsOjpwcm9jZXNzKGNvbnN0IGZsb2F0KiBzb3VyY2UsIGZsb2F0KiBkZXN0 aW5hdGlvbiwgc2l6ZV90IGZyYQogICAgICAgICBkb3VibGUgZGVzaXJlZERlbGF5RnJhbWVzID0g bV9jdXJyZW50RGVsYXlUaW1lICogc2FtcGxlUmF0ZTsKIAogICAgICAgICBkb3VibGUgcmVhZFBv c2l0aW9uID0gbV93cml0ZUluZGV4ICsgYnVmZmVyTGVuZ3RoIC0gZGVzaXJlZERlbGF5RnJhbWVz OwotICAgICAgICBpZiAocmVhZFBvc2l0aW9uID4gYnVmZmVyTGVuZ3RoKQorICAgICAgICBpZiAo cmVhZFBvc2l0aW9uID49IGJ1ZmZlckxlbmd0aCkKICAgICAgICAgICAgIHJlYWRQb3NpdGlvbiAt PSBidWZmZXJMZW5ndGg7CiAKICAgICAgICAgLy8gTGluZWFybHkgaW50ZXJwb2xhdGUgaW4tYmV0 d2VlbiBkZWxheSB0aW1lcy4K