67865 2011-09-09 14:24:06 -0700 [V8] V8WebKitPoint::constructorCallback leaks 2011-09-09 18:15:23 -0700 1 1 1 Unclassified WebKit WebCore JavaScript 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 jchaffraix jchaffraix abarth dglazkov japhet webkit.review.bot oldest_to_newest 465020 0 jchaffraix 2011-09-09 14:24:06 -0700 Seen under valgrind while testing LayoutTests/fast/js/instanceof-XMLHTTPRequest.html. Also using a PassRefPtr in this code is not right. 465026 1 106924 jchaffraix 2011-09-09 14:32:18 -0700 Created attachment 106924 Proposed change: use toV8 and correct RefPtr usage. 465121 2 106924 abarth 2011-09-09 17:07:35 -0700 Comment on attachment 106924 Proposed change: use toV8 and correct RefPtr usage. Wow. 465122 3 abarth 2011-09-09 17:08:07 -0700 Looks like the leak was added by japhet and reviewed by dglazkov two years ago in http://trac.webkit.org/changeset/48834 465129 4 106924 jchaffraix 2011-09-09 17:15:08 -0700 Comment on attachment 106924 Proposed change: use toV8 and correct RefPtr usage. Thanks Adam! 465154 5 106924 webkit.review.bot 2011-09-09 18:15:19 -0700 Comment on attachment 106924 Proposed change: use toV8 and correct RefPtr usage. Clearing flags on attachment: 106924 Committed r94894: <http://trac.webkit.org/changeset/94894> 465155 6 webkit.review.bot 2011-09-09 18:15:23 -0700 All reviewed patches have been landed. Closing bug. 106924 2011-09-09 14:32:18 -0700 2011-09-09 18:15:19 -0700 Proposed change: use toV8 and correct RefPtr usage. bug-67865-20110909143216.patch text/plain 1778 jchaffraix U3VidmVyc2lvbiBSZXZpc2lvbjogOTQ3NTgKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCBhNzY5NTEzNjIxMTA3MjE5 NmVlZWFhYmQ1M2FhYzUxMjEyZjQ4NTZhLi41NWQ5M2VkYjFlZjhhZGZhMmJjYTEzNjlhZTY3MmYx ZTMxYzE1NmI2IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvU291 cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTcgQEAKKzIwMTEtMDktMDkgIEp1bGll biBDaGFmZnJhaXggIDxqY2hhZmZyYWl4QHdlYmtpdC5vcmc+CisKKyAgICAgICAgW1Y4XSBWOFdl YktpdFBvaW50Ojpjb25zdHJ1Y3RvckNhbGxiYWNrIGxlYWtzCisgICAgICAgIGh0dHBzOi8vYnVn cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD02Nzg2NQorCisgICAgICAgIFJldmlld2VkIGJ5 IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIENvdmVyZWQgYnkgZmFzdC9qcy9pbnN0YW5jZW9m LVhNTEh0dHBSZXF1ZXN0Lmh0bWwgdW5kZXIgVmFsZ3JpbmQuCisKKyAgICAgICAgKiBiaW5kaW5n cy92OC9jdXN0b20vVjhXZWJLaXRQb2ludENvbnN0cnVjdG9yLmNwcDoKKyAgICAgICAgKFdlYkNv cmU6OlY4V2ViS2l0UG9pbnQ6OmNvbnN0cnVjdG9yQ2FsbGJhY2spOiBDaGFuZ2VkIHRoZSBjb2Rl CisgICAgICAgIHRvIHVzZSBhIFJlZlB0ciAocGVyIG91ciB1c3VhbCBzdHlsZSkuIEFsc28gdXNl IHRvVjggdGhhdCB3aWxsCisgICAgICAgIHRha2UgY2FyZSBvZiBwcm9wZXJseSB3cmFwcGluZyB0 aGUgb2JqZWN0LgorCiAyMDExLTA5LTA4ICBBbGV4YW5kZXIgUGF2bG92ICA8YXBhdmxvdkBjaHJv bWl1bS5vcmc+CiAKICAgICAgICAgV2ViIEluc3BlY3RvcjogW1JFR1JFU1NJT05dIENsZWFyIGNv bnNvbGUgc2hvcnRjdXQgQ3RybCArIEwgYnJva2VuCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29y ZS9iaW5kaW5ncy92OC9jdXN0b20vVjhXZWJLaXRQb2ludENvbnN0cnVjdG9yLmNwcCBiL1NvdXJj ZS9XZWJDb3JlL2JpbmRpbmdzL3Y4L2N1c3RvbS9WOFdlYktpdFBvaW50Q29uc3RydWN0b3IuY3Bw CmluZGV4IGQ5MDQxYzUzZmJlMjRjY2JkOTZiMDNiMzNlNjUyODlmOGQyYThkZjguLjYwMzQ3ZDU1 ZTE1Yjk0YjU1MGJjZDVhNmQ0ODYxNjVjZTBjYTMwNDQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJD b3JlL2JpbmRpbmdzL3Y4L2N1c3RvbS9WOFdlYktpdFBvaW50Q29uc3RydWN0b3IuY3BwCisrKyBi L1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL3Y4L2N1c3RvbS9WOFdlYktpdFBvaW50Q29uc3RydWN0 b3IuY3BwCkBAIC02MSwxMCArNjEsOSBAQCB2ODo6SGFuZGxlPHY4OjpWYWx1ZT4gVjhXZWJLaXRQ b2ludDo6Y29uc3RydWN0b3JDYWxsYmFjayhjb25zdCB2ODo6QXJndW1lbnRzJiBhcgogICAgICAg ICAgICAgICAgIHkgPSAwOwogICAgICAgICB9CiAgICAgfQotICAgIFBhc3NSZWZQdHI8V2ViS2l0 UG9pbnQ+IHBvaW50ID0gV2ViS2l0UG9pbnQ6OmNyZWF0ZSh4LCB5KTsKLSAgICBwb2ludC0+cmVm KCk7CisgICAgUmVmUHRyPFdlYktpdFBvaW50PiBwb2ludCA9IFdlYktpdFBvaW50OjpjcmVhdGUo eCwgeSk7CiAgICAgVjhET01XcmFwcGVyOjpzZXRET01XcmFwcGVyKGFyZ3MuSG9sZGVyKCksICZp bmZvLCBwb2ludC5nZXQoKSk7Ci0gICAgcmV0dXJuIGFyZ3MuSG9sZGVyKCk7CisgICAgcmV0dXJu IHRvVjgocG9pbnQucmVsZWFzZSgpLCBhcmdzLkhvbGRlcigpKTsKIH0KIAogfSAvLyBuYW1lc3Bh Y2UgV2ViQ29yZQo=