67863 2011-09-09 14:14:46 -0700 RenderBlock::addOverhangingFloats() takes superfluous parameters 2011-09-09 15:08:10 -0700 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 mitz mitz oldest_to_newest 465013 0 mitz 2011-09-09 14:14:46 -0700 RenderBlock::addOverhangingFloats() takes superfluous parameters 465015 1 106919 mitz 2011-09-09 14:19:19 -0700 Created attachment 106919 Remove the logical{Left,Top}Offset parameters 465044 2 106919 hyatt 2011-09-09 14:55:41 -0700 Comment on attachment 106919 Remove the logical{Left,Top}Offset parameters r=me. 465049 3 mitz 2011-09-09 15:08:10 -0700 Landed <http://trac.webkit.org/r94877>. 106919 2011-09-09 14:19:19 -0700 2011-09-09 14:55:41 -0700 Remove the logical{Left,Top}Offset parameters bug-67863-20110909141918.patch text/plain 5206 mitz SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDk0ODcyKQorKysgU291cmNlL1dlYkNvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTkgQEAKKzIwMTEtMDktMDkgIERhbiBCZXJu c3RlaW4gIDxtaXR6QGFwcGxlLmNvbT4KKworICAgICAgICBSZW5kZXJCbG9jazo6YWRkT3Zlcmhh bmdpbmdGbG9hdHMoKSB0YWtlcyBzdXBlcmZsdW91cyBwYXJhbWV0ZXJzCisgICAgICAgIGh0dHBz Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD02Nzg2MworCisgICAgICAgIFJldmll d2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIE5vIG5ldyB0ZXN0cywgYmVjYXVzZSBi ZWhhdmlvciBpcyB1bmNoYW5nZWQuCisKKyAgICAgICAgKiByZW5kZXJpbmcvUmVuZGVyQmxvY2su Y3BwOgorICAgICAgICAoV2ViQ29yZTo6UmVuZGVyQmxvY2s6OmxheW91dEJsb2NrKToKKyAgICAg ICAgKFdlYkNvcmU6OlJlbmRlckJsb2NrOjpsYXlvdXRCbG9ja0NoaWxkKToKKyAgICAgICAgKFdl YkNvcmU6OlJlbmRlckJsb2NrOjphZGRPdmVyaGFuZ2luZ0Zsb2F0cyk6IFJlbW92ZWQgdGhlIGxv Z2ljYWx7TGVmdCwgVG9wfU9mZnNldCBwYXJhbWV0ZXJzLAorICAgICAgICBzaW5jZSB0aGV5IHdl cmUgYWx3YXlzIHRoZSBpbnZlcnNlIG9mIHRoZSBsb2dpY2Fse0xlZnQsIFRvcH0oKSBvZiB0aGUg Y2hpbGQgcGFyYW1ldGVyLgorICAgICAgICAqIHJlbmRlcmluZy9SZW5kZXJCbG9jay5oOgorCiAy MDExLTA5LTA5ICBBZGFtIEtsZWluICA8YWRhbWtAY2hyb21pdW0ub3JnPgogCiAgICAgICAgIElu aXRpYWxpemUgRXhjZXB0aW9uQ29kZSBpbiBFbGVtZW50OjpyZW1vdmVBdHRyaWJ1dGUKSW5kZXg6 IFNvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJCbG9jay5jcHAKPT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0g U291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckJsb2NrLmNwcAkocmV2aXNpb24gOTQ4NTUp CisrKyBTb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyQmxvY2suY3BwCSh3b3JraW5nIGNv cHkpCkBAIC0xMjk1LDcgKzEyOTUsNyBAQCB2b2lkIFJlbmRlckJsb2NrOjpsYXlvdXRCbG9jayhi b29sIHJlbGF5CiAgICAgICAgICAgICAgICAgaWYgKGNoaWxkLT5pc0Jsb2NrRmxvdygpICYmICFj aGlsZC0+aXNGbG9hdGluZ09yUG9zaXRpb25lZCgpKSB7CiAgICAgICAgICAgICAgICAgICAgIFJl bmRlckJsb2NrKiBibG9jayA9IHRvUmVuZGVyQmxvY2soY2hpbGQpOwogICAgICAgICAgICAgICAg ICAgICBpZiAoYmxvY2stPmxvd2VzdEZsb2F0TG9naWNhbEJvdHRvbUluY2x1ZGluZ1Bvc2l0aW9u ZWRGbG9hdHMoKSArIGJsb2NrLT5sb2dpY2FsVG9wKCkgPiBuZXdIZWlnaHQpCi0gICAgICAgICAg ICAgICAgICAgICAgICBhZGRPdmVyaGFuZ2luZ0Zsb2F0cyhibG9jaywgLWJsb2NrLT5sb2dpY2Fs TGVmdCgpLCAtYmxvY2stPmxvZ2ljYWxUb3AoKSwgZmFsc2UpOworICAgICAgICAgICAgICAgICAg ICAgICAgYWRkT3ZlcmhhbmdpbmdGbG9hdHMoYmxvY2ssIGZhbHNlKTsKICAgICAgICAgICAgICAg ICB9CiAgICAgICAgICAgICB9CiAgICAgICAgIH0KQEAgLTIxMDUsNyArMjEwNSw3IEBAIHZvaWQg UmVuZGVyQmxvY2s6OmxheW91dEJsb2NrQ2hpbGQoUmVuZGUKICAgICAvLyBJZiB0aGUgY2hpbGQg aGFzIG92ZXJoYW5naW5nIGZsb2F0cyB0aGF0IGludHJ1ZGUgaW50byBmb2xsb3dpbmcgc2libGlu Z3MgKG9yIHBvc3NpYmx5IG91dAogICAgIC8vIG9mIHRoaXMgYmxvY2spLCB0aGVuIHRoZSBwYXJl bnQgZ2V0cyBub3RpZmllZCBvZiB0aGUgZmxvYXRzIG5vdy4KICAgICBpZiAoY2hpbGRSZW5kZXJC bG9jayAmJiBjaGlsZFJlbmRlckJsb2NrLT5jb250YWluc0Zsb2F0cygpKQotICAgICAgICBtYXhG bG9hdExvZ2ljYWxCb3R0b20gPSBtYXgobWF4RmxvYXRMb2dpY2FsQm90dG9tLCBhZGRPdmVyaGFu Z2luZ0Zsb2F0cyh0b1JlbmRlckJsb2NrKGNoaWxkKSwgLWNoaWxkLT5sb2dpY2FsTGVmdCgpLCAt Y2hpbGQtPmxvZ2ljYWxUb3AoKSwgIWNoaWxkTmVlZGVkTGF5b3V0KSk7CisgICAgICAgIG1heEZs b2F0TG9naWNhbEJvdHRvbSA9IG1heChtYXhGbG9hdExvZ2ljYWxCb3R0b20sIGFkZE92ZXJoYW5n aW5nRmxvYXRzKHRvUmVuZGVyQmxvY2soY2hpbGQpLCAhY2hpbGROZWVkZWRMYXlvdXQpKTsKIAog ICAgIExheW91dFNpemUgY2hpbGRPZmZzZXQoY2hpbGQtPngoKSAtIG9sZFJlY3QueCgpLCBjaGls ZC0+eSgpIC0gb2xkUmVjdC55KCkpOwogICAgIGlmIChjaGlsZE9mZnNldC53aWR0aCgpIHx8IGNo aWxkT2Zmc2V0LmhlaWdodCgpKSB7CkBAIC0zODA5LDEzICszODA5LDE0IEBAIHZvaWQgUmVuZGVy QmxvY2s6OmNsZWFyRmxvYXRzKEJsb2NrTGF5b3UKICAgICB9CiB9CiAKLUxheW91dFVuaXQgUmVu ZGVyQmxvY2s6OmFkZE92ZXJoYW5naW5nRmxvYXRzKFJlbmRlckJsb2NrKiBjaGlsZCwgTGF5b3V0 VW5pdCBsb2dpY2FsTGVmdE9mZnNldCwgTGF5b3V0VW5pdCBsb2dpY2FsVG9wT2Zmc2V0LCBib29s IG1ha2VDaGlsZFBhaW50T3RoZXJGbG9hdHMpCitMYXlvdXRVbml0IFJlbmRlckJsb2NrOjphZGRP dmVyaGFuZ2luZ0Zsb2F0cyhSZW5kZXJCbG9jayogY2hpbGQsIGJvb2wgbWFrZUNoaWxkUGFpbnRP dGhlckZsb2F0cykKIHsKICAgICAvLyBQcmV2ZW50IGZsb2F0cyBmcm9tIGJlaW5nIGFkZGVkIHRv IHRoZSBjYW52YXMgYnkgdGhlIHJvb3QgZWxlbWVudCwgZS5nLiwgPGh0bWw+LgogICAgIGlmIChj aGlsZC0+aGFzT3ZlcmZsb3dDbGlwKCkgfHwgIWNoaWxkLT5jb250YWluc0Zsb2F0cygpIHx8IGNo aWxkLT5pc1Jvb3QoKSB8fCBjaGlsZC0+aGFzQ29sdW1ucygpIHx8IGNoaWxkLT5pc1dyaXRpbmdN b2RlUm9vdCgpKQogICAgICAgICByZXR1cm4gMDsKIAogICAgIExheW91dFVuaXQgY2hpbGRMb2dp Y2FsVG9wID0gY2hpbGQtPmxvZ2ljYWxUb3AoKTsKKyAgICBMYXlvdXRVbml0IGNoaWxkTG9naWNh bExlZnQgPSBjaGlsZC0+bG9naWNhbExlZnQoKTsKICAgICBMYXlvdXRVbml0IGxvd2VzdEZsb2F0 TG9naWNhbEJvdHRvbSA9IDA7CiAKICAgICAvLyBGbG9hdHMgdGhhdCB3aWxsIHJlbWFpbiB0aGUg Y2hpbGQncyByZXNwb25zaWJpbGl0eSB0byBwYWludCBzaG91bGQgZmFjdG9yIGludG8gaXRzCkBA IC0zODMwLDggKzM4MzEsOCBAQCBMYXlvdXRVbml0IFJlbmRlckJsb2NrOjphZGRPdmVyaGFuZ2lu Z0ZsCiAgICAgICAgIGlmIChsb2dpY2FsQm90dG9tID4gbG9naWNhbEhlaWdodCgpKSB7CiAgICAg ICAgICAgICAvLyBJZiB0aGUgb2JqZWN0IGlzIG5vdCBpbiB0aGUgbGlzdCwgd2UgYWRkIGl0IG5v dy4KICAgICAgICAgICAgIGlmICghY29udGFpbnNGbG9hdChyLT5tX3JlbmRlcmVyKSkgewotICAg ICAgICAgICAgICAgIExheW91dFVuaXQgbGVmdE9mZnNldCA9IGlzSG9yaXpvbnRhbFdyaXRpbmdN b2RlKCkgPyBsb2dpY2FsTGVmdE9mZnNldCA6IGxvZ2ljYWxUb3BPZmZzZXQ7Ci0gICAgICAgICAg ICAgICAgTGF5b3V0VW5pdCB0b3BPZmZzZXQgPSBpc0hvcml6b250YWxXcml0aW5nTW9kZSgpID8g bG9naWNhbFRvcE9mZnNldCA6IGxvZ2ljYWxMZWZ0T2Zmc2V0OworICAgICAgICAgICAgICAgIExh eW91dFVuaXQgbGVmdE9mZnNldCA9IGlzSG9yaXpvbnRhbFdyaXRpbmdNb2RlKCkgPyAtY2hpbGRM b2dpY2FsTGVmdCA6IC1jaGlsZExvZ2ljYWxUb3A7CisgICAgICAgICAgICAgICAgTGF5b3V0VW5p dCB0b3BPZmZzZXQgPSBpc0hvcml6b250YWxXcml0aW5nTW9kZSgpID8gLWNoaWxkTG9naWNhbFRv cCA6IC1jaGlsZExvZ2ljYWxMZWZ0OwogICAgICAgICAgICAgICAgIEZsb2F0aW5nT2JqZWN0KiBm bG9hdGluZ09iaiA9IG5ldyBGbG9hdGluZ09iamVjdChyLT50eXBlKCksIExheW91dFJlY3Qoci0+ eCgpIC0gbGVmdE9mZnNldCwgci0+eSgpIC0gdG9wT2Zmc2V0LCByLT53aWR0aCgpLCByLT5oZWln aHQoKSkpOwogICAgICAgICAgICAgICAgIGZsb2F0aW5nT2JqLT5tX3JlbmRlcmVyID0gci0+bV9y ZW5kZXJlcjsKIApJbmRleDogU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckJsb2NrLmgK PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PQotLS0gU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckJsb2NrLmgJKHJl dmlzaW9uIDk0ODU1KQorKysgU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckJsb2NrLmgJ KHdvcmtpbmcgY29weSkKQEAgLTYzMSw3ICs2MzEsNyBAQCBwcml2YXRlOgogICAgIGJvb2wgaGFz T3ZlcmhhbmdpbmdGbG9hdHMoKSB7IHJldHVybiBwYXJlbnQoKSAmJiAhaGFzQ29sdW1ucygpICYm IGNvbnRhaW5zRmxvYXRzKCkgJiYgbG93ZXN0RmxvYXRMb2dpY2FsQm90dG9tSW5jbHVkaW5nUG9z aXRpb25lZEZsb2F0cygpID4gbG9naWNhbEhlaWdodCgpOyB9CiAgICAgYm9vbCBoYXNPdmVyaGFu Z2luZ0Zsb2F0KFJlbmRlckJveCopOwogICAgIHZvaWQgYWRkSW50cnVkaW5nRmxvYXRzKFJlbmRl ckJsb2NrKiBwcmV2LCBMYXlvdXRVbml0IHhvZmZzZXQsIExheW91dFVuaXQgeW9mZnNldCk7Ci0g ICAgTGF5b3V0VW5pdCBhZGRPdmVyaGFuZ2luZ0Zsb2F0cyhSZW5kZXJCbG9jayogY2hpbGQsIExh eW91dFVuaXQgeG9mZnNldCwgTGF5b3V0VW5pdCB5b2Zmc2V0LCBib29sIG1ha2VDaGlsZFBhaW50 T3RoZXJGbG9hdHMpOworICAgIExheW91dFVuaXQgYWRkT3ZlcmhhbmdpbmdGbG9hdHMoUmVuZGVy QmxvY2sqIGNoaWxkLCBib29sIG1ha2VDaGlsZFBhaW50T3RoZXJGbG9hdHMpOwogCiAgICAgTGF5 b3V0VW5pdCBsb3dlc3RGbG9hdExvZ2ljYWxCb3R0b20oKSBjb25zdCB7IHJldHVybiBsb3dlc3RG bG9hdExvZ2ljYWxCb3R0b20oRmxvYXRpbmdPYmplY3Q6OkZsb2F0TGVmdFJpZ2h0KTsgfQogICAg IExheW91dFVuaXQgbG93ZXN0RmxvYXRMb2dpY2FsQm90dG9tSW5jbHVkaW5nUG9zaXRpb25lZEZs b2F0cygpIGNvbnN0IHsgcmV0dXJuIGxvd2VzdEZsb2F0TG9naWNhbEJvdHRvbShGbG9hdGluZ09i amVjdDo6RmxvYXRBbGwpOyB9Cg==