67860 2011-09-09 12:05:49 -0700 Never #define ENABLE_SINGLE_THREADED, !ENABLE_JSC_MULTIPLE_THREADS, or !ENABLE_WTF_MULTIPLE_THREADS 2011-09-12 04:08:42 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 ggaren ggaren mitz ossy paroga webkit.review.bot oldest_to_newest 464964 0 ggaren 2011-09-09 12:05:49 -0700 First step toward making the baseline platform assumption that threads exist. 464965 1 106898 ggaren 2011-09-09 12:06:29 -0700 Created attachment 106898 patch As discussed on webkit-dev. 464967 2 webkit.review.bot 2011-09-09 12:09:46 -0700 Attachment 106898 did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/ChangeLog', u'Source..." exit_code: 1 Source/JavaScriptCore/ChangeLog:1: ChangeLog entry has no bug number [changelog/bugnumber] [5] Total errors found: 1 in 1 files If any of these errors are false positives, please file a bug against check-webkit-style. 464980 3 106902 ggaren 2011-09-09 12:37:02 -0700 Created attachment 106902 more straightforward way of doing things, suggested by mitz 464987 4 ggaren 2011-09-09 12:44:12 -0700 Committed r94871: <http://trac.webkit.org/changeset/94871> 465033 5 ossy 2011-09-09 14:44:13 -0700 It broke Qt build on Windows: ./release/libjscore.a(MachineStackMarker.o):MachineStackMarker.cpp:(.text+0x43): undefined reference to `__imp__pthread_self' ./release/libjscore.a(MachineStackMarker.o):MachineStackMarker.cpp:(.text+0x88): undefined reference to `__imp__pthread_equal' ./release/libjscore.a(MachineStackMarker.o):MachineStackMarker.cpp:(.text+0xab): undefined reference to `__imp__pthread_equal' ./release/libjscore.a(MachineStackMarker.o):MachineStackMarker.cpp:(.text+0x1f5): undefined reference to `__imp__pthread_key_delete' ./release/libjscore.a(MachineStackMarker.o):MachineStackMarker.cpp:(.text+0x2d0): undefined reference to `__imp__pthread_key_create' ./release/libjscore.a(MachineStackMarker.o):MachineStackMarker.cpp:(.text+0x338): undefined reference to `__imp__pthread_getspecific' ./release/libjscore.a(MachineStackMarker.o):MachineStackMarker.cpp:(.text+0x366): undefined reference to `__imp__pthread_setspecific' ./release/libjscore.a(MachineStackMarker.o):MachineStackMarker.cpp:(.text+0x36b): undefined reference to `__imp__pthread_self' ./release/libjscore.a(MachineStackMarker.o):MachineStackMarker.cpp:(.text+0x386): undefined reference to `__imp__pthread_getw32threadhandle_np' ./release/libjscore.a(MachineStackMarker.o):MachineStackMarker.cpp:(.text+0x588): undefined reference to `__imp__pthread_self' ./release/libjscore.a(MachineStackMarker.o):MachineStackMarker.cpp:(.text+0x5cd): undefined reference to `__imp__pthread_equal' ./release/libjscore.a(MachineStackMarker.o):MachineStackMarker.cpp:(.text+0x5f0): undefined reference to `__imp__pthread_equal' ./release/libjscore.a(MachineStackMarker.o):MachineStackMarker.cpp:(.text+0x9ba): undefined reference to `__imp__pthread_self' ./release/libjscore.a(MachineStackMarker.o):MachineStackMarker.cpp:(.text+0xa00): undefined reference to `__imp__pthread_equal' 465558 6 paroga 2011-09-12 04:08:42 -0700 Committed r94952: <http://trac.webkit.org/changeset/94952> 106898 2011-09-09 12:06:29 -0700 2011-09-09 12:37:02 -0700 patch ro.txt text/plain 2435 ggaren SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gOTQ4NzApCisrKyBTb3VyY2Uv SmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTcgQEAK KzIwMTEtMDktMDkgIEdlb2ZmcmV5IEdhcmVuICA8Z2dhcmVuQGFwcGxlLmNvbT4KKworICAgICAg ICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBGaXJzdCBzdGVwIHRvd2Fy ZCBtYWtpbmcgdGhlIGJhc2VsaW5lIHBsYXRmb3JtIGFzc3VtcHRpb24gdGhhdCB0aHJlYWRzCisg ICAgICAgIGV4aXN0OiBOZXZlciAjZGVmaW5lIEVOQUJMRV9TSU5HTEVfVEhSRUFERUQsICFFTkFC TEVfSlNDX01VTFRJUExFX1RIUkVBRFMsCisgICAgICAgIG9yICFFTkFCTEVfV1RGX01VTFRJUExF X1RIUkVBRFMuCisKKyAgICAgICAgVGhpcyBpbXBsaWNpdGx5IG1lYW5zIHdlIGNhbiBuZXZlciAj ZGVmaW5lIFBMQVRGT1JNKEJSRVdNUCopIG9yCisgICAgICAgIFBMQVRGT1JNKFFOWCksIHdoaWNo IGRlcGVuZGVkIG9uIHRoZSBhYm92ZS4gSXQgYWxzbyBvcGVucyB1cCBsb3RzIG9mCisgICAgICAg IHBvc3NpYmlsaXRpZXMgZm9yIGRlYWQgY29kZSByZW1vdmFsIGluIGEgZnV0dXJlIHBhdGNoLgor CisgICAgICAgICogd3RmL1BsYXRmb3JtLmg6CisKIDIwMTEtMDktMDkgIExhc3psbyBHb21ib3Mg IDxsYXN6bG8uMS5nb21ib3NAbm9raWEuY29tPgogCiAgICAgICAgIFtRdF0gUmVtb3ZlIGNvbW1v bi5wcmkKSW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS93dGYvUGxhdGZvcm0uaAo9PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09Ci0tLSBTb3VyY2UvSmF2YVNjcmlwdENvcmUvd3RmL1BsYXRmb3JtLmgJKHJldmlzaW9uIDk0 ODU1KQorKysgU291cmNlL0phdmFTY3JpcHRDb3JlL3d0Zi9QbGF0Zm9ybS5oCSh3b3JraW5nIGNv cHkpCkBAIC0zNjgsMTEgKzM2OCw2IEBACiAjZGVmaW5lIFdURl9PU19PUEVOQlNEIDEKICNlbmRp ZgogCi0vKiBPUyhRTlgpIC0gUU5YICovCi0jaWYgZGVmaW5lZChfX1FOWE5UT19fKQotI2RlZmlu ZSBXVEZfT1NfUU5YIDEKLSNlbmRpZgotCiAvKiBPUyhTT0xBUklTKSAtIFNvbGFyaXMgKi8KICNp ZiBkZWZpbmVkKHN1bikgfHwgZGVmaW5lZChfX3N1bikKICNkZWZpbmUgV1RGX09TX1NPTEFSSVMg MQpAQCAtNDMxLDE1ICs0MjYsNiBAQAogI2RlZmluZSBXVEZfUExBVEZPUk1fR1RLIDEKICNlbGlm IGRlZmluZWQoQlVJTERJTkdfSEFJS1VfXykKICNkZWZpbmUgV1RGX1BMQVRGT1JNX0hBSUtVIDEK LSNlbGlmIGRlZmluZWQoQlVJTERJTkdfQlJFV01QX18pCi0jZGVmaW5lIFdURl9QTEFURk9STV9C UkVXTVAgMQotI2lmIGRlZmluZWQoQUVFX1NJTVVMQVRPUikKLSNkZWZpbmUgV1RGX1BMQVRGT1JN X0JSRVdNUF9TSU1VTEFUT1IgMQotI2Vsc2UKLSNkZWZpbmUgV1RGX1BMQVRGT1JNX0JSRVdNUF9T SU1VTEFUT1IgMAotI2VuZGlmCi0jdW5kZWYgV1RGX09TX1dJTkRPV1MKLSN1bmRlZiBXVEZfUExB VEZPUk1fV0lOCiAjZWxpZiBPUyhEQVJXSU4pCiAjZGVmaW5lIFdURl9QTEFURk9STV9NQUMgMQog I2VsaWYgT1MoV0lORE9XUykKQEAgLTUwOSwxMyArNDk1LDggQEAKICNkZWZpbmUgV1RGX1VTRV9Q VEhSRUFEX0JBU0VEX1FUIDEKICNlbmRpZgogCi0jaWYgKFBMQVRGT1JNKEdUSykgfHwgUExBVEZP Uk0oSU9TKSB8fCBQTEFURk9STShNQUMpIHx8IFBMQVRGT1JNKFdJTikgfHwgKFBMQVRGT1JNKFFU KSAmJiAoT1MoREFSV0lOKSB8fCBVU0UoUFRIUkVBRF9CQVNFRF9RVCkpICYmICFFTkFCTEUoU0lO R0xFX1RIUkVBREVEKSkpICYmICFPUyhRTlgpICYmICFkZWZpbmVkKEVOQUJMRV9KU0NfTVVMVElQ TEVfVEhSRUFEUykKICNkZWZpbmUgRU5BQkxFX0pTQ19NVUxUSVBMRV9USFJFQURTIDEKLSNlbmRp ZgotCi0jaWYgRU5BQkxFKEpTQ19NVUxUSVBMRV9USFJFQURTKSB8fCBQTEFURk9STShDSFJPTUlV TSkKICNkZWZpbmUgRU5BQkxFX1dURl9NVUxUSVBMRV9USFJFQURTIDEKLSNlbmRpZgogCiAvKiBP biBXaW5kb3dzLCB1c2UgUXVlcnlQZXJmb3JtYW5jZUNvdW50ZXIgYnkgZGVmYXVsdCAqLwogI2lm IE9TKFdJTkRPV1MpCkBAIC01ODEsMTAgKzU2Miw2IEBACiAjZGVmaW5lIFdURl9VU0VfV0tfU0NS T0xMQkFSX1BBSU5URVIgMQogI2VuZGlmCiAKLSNpZiBQTEFURk9STShCUkVXTVApCi0jZGVmaW5l IEVOQUJMRV9TSU5HTEVfVEhSRUFERUQgMQotI2VuZGlmCi0KICNpZiBQTEFURk9STShRVCkgJiYg T1MoREFSV0lOKQogI2RlZmluZSBXVEZfVVNFX0NGIDEKICNlbmRpZgo= 106902 2011-09-09 12:37:02 -0700 2011-09-09 12:38:42 -0700 more straightforward way of doing things, suggested by mitz ro.txt text/plain 1620 ggaren SW5kZXg6IHd0Zi9QbGF0Zm9ybS5oCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIHd0Zi9QbGF0Zm9ybS5oCShyZXZp c2lvbiA5NDg1NSkKKysrIHd0Zi9QbGF0Zm9ybS5oCSh3b3JraW5nIGNvcHkpCkBAIC01MDksMTMg KzUwOSw4IEBACiAjZGVmaW5lIFdURl9VU0VfUFRIUkVBRF9CQVNFRF9RVCAxCiAjZW5kaWYKIAot I2lmIChQTEFURk9STShHVEspIHx8IFBMQVRGT1JNKElPUykgfHwgUExBVEZPUk0oTUFDKSB8fCBQ TEFURk9STShXSU4pIHx8IChQTEFURk9STShRVCkgJiYgKE9TKERBUldJTikgfHwgVVNFKFBUSFJF QURfQkFTRURfUVQpKSAmJiAhRU5BQkxFKFNJTkdMRV9USFJFQURFRCkpKSAmJiAhT1MoUU5YKSAm JiAhZGVmaW5lZChFTkFCTEVfSlNDX01VTFRJUExFX1RIUkVBRFMpCiAjZGVmaW5lIEVOQUJMRV9K U0NfTVVMVElQTEVfVEhSRUFEUyAxCi0jZW5kaWYKLQotI2lmIEVOQUJMRShKU0NfTVVMVElQTEVf VEhSRUFEUykgfHwgUExBVEZPUk0oQ0hST01JVU0pCiAjZGVmaW5lIEVOQUJMRV9XVEZfTVVMVElQ TEVfVEhSRUFEUyAxCi0jZW5kaWYKIAogLyogT24gV2luZG93cywgdXNlIFF1ZXJ5UGVyZm9ybWFu Y2VDb3VudGVyIGJ5IGRlZmF1bHQgKi8KICNpZiBPUyhXSU5ET1dTKQpAQCAtNTgxLDEwICs1NzYs NiBAQAogI2RlZmluZSBXVEZfVVNFX1dLX1NDUk9MTEJBUl9QQUlOVEVSIDEKICNlbmRpZgogCi0j aWYgUExBVEZPUk0oQlJFV01QKQotI2RlZmluZSBFTkFCTEVfU0lOR0xFX1RIUkVBREVEIDEKLSNl bmRpZgotCiAjaWYgUExBVEZPUk0oUVQpICYmIE9TKERBUldJTikKICNkZWZpbmUgV1RGX1VTRV9D RiAxCiAjZW5kaWYKSW5kZXg6IENoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBDaGFuZ2VMb2cJKHJl dmlzaW9uIDk0ODcwKQorKysgQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTcg QEAKKzIwMTEtMDktMDkgIEdlb2ZmcmV5IEdhcmVuICA8Z2dhcmVuQGFwcGxlLmNvbT4KKworICAg ICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBOZXZlciAjZGVmaW5l IEVOQUJMRV9TSU5HTEVfVEhSRUFERUQsICFFTkFCTEVfSlNDX01VTFRJUExFX1RIUkVBRFMsIG9y CisgICAgICAgICFFTkFCTEVfV1RGX01VTFRJUExFX1RIUkVBRFMKKyAgICAgICAgaHR0cHM6Ly9i dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTY3ODYwCisKKyAgICAgICAgRmlyc3Qgc3Rl cCB0b3dhcmQgbWFraW5nIHRoZSBiYXNlbGluZSBwbGF0Zm9ybSBhc3N1bXB0aW9uIHRoYXQgdGhy ZWFkcworICAgICAgICBleGlzdDogTmV2ZXIgI2RlZmluZSBFTkFCTEVfU0lOR0xFX1RIUkVBREVE LCAhRU5BQkxFX0pTQ19NVUxUSVBMRV9USFJFQURTLAorICAgICAgICBvciAhRU5BQkxFX1dURl9N VUxUSVBMRV9USFJFQURTLgorCisgICAgICAgICogd3RmL1BsYXRmb3JtLmg6CisKIDIwMTEtMDkt MDkgIExhc3psbyBHb21ib3MgIDxsYXN6bG8uMS5nb21ib3NAbm9raWEuY29tPgogCiAgICAgICAg IFtRdF0gUmVtb3ZlIGNvbW1vbi5wcmkK