67859 2011-09-09 11:28:13 -0700 Enable Viewport Meta Tag on Chromium Platforms [Work in Progress] 2011-10-25 15:45:19 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED DUPLICATE 70559 P2 Normal --- 68075 1 fsamuel fsamuel abarth dglazkov fishd fsamuel jamesr rjkroege webkit.review.bot oldest_to_newest 464935 0 fsamuel 2011-09-09 11:28:13 -0700 Enable Viewport Meta Tag on Chromium Platforms [Work in Progress] 464936 1 106891 fsamuel 2011-09-09 11:28:48 -0700 Created attachment 106891 Patch 464937 2 106891 fsamuel 2011-09-09 11:29:42 -0700 Comment on attachment 106891 Patch Not for review. Here to monitor progress. 464939 3 webkit.review.bot 2011-09-09 11:31:16 -0700 Attachment 106891 did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit/chromium/ChangeLog', u'Sourc..." exit_code: 1 Source/WebKit/chromium/src/WebViewImpl.cpp:1022: Boolean expressions that span multiple lines should have their operators on the left side of the line instead of the right side. [whitespace/operators] [4] Source/WebKit/chromium/src/WebViewImpl.cpp:1027: Boolean expressions that span multiple lines should have their operators on the left side of the line instead of the right side. [whitespace/operators] [4] Source/WebKit/chromium/src/ChromeClientImpl.cpp:643: Should have only a single space after a punctuation in a comment. [whitespace/comments] [5] Source/WebKit/chromium/src/ChromeClientImpl.cpp:647: Boolean expressions that span multiple lines should have their operators on the left side of the line instead of the right side. [whitespace/operators] [4] Source/WebKit/chromium/src/ChromeClientImpl.cpp:648: Boolean expressions that span multiple lines should have their operators on the left side of the line instead of the right side. [whitespace/operators] [4] Source/WebKit/chromium/src/ChromeClientImpl.cpp:649: Boolean expressions that span multiple lines should have their operators on the left side of the line instead of the right side. [whitespace/operators] [4] Source/WebKit/chromium/src/ChromeClientImpl.cpp:674: Boolean expressions that span multiple lines should have their operators on the left side of the line instead of the right side. [whitespace/operators] [4] Source/WebKit/chromium/src/ChromeClientImpl.cpp:676: Should have a space between // and comment [whitespace/comments] [4] Source/WebKit/chromium/src/ChromeClientImpl.h:128: The parameter name "arguments" adds no information, so it should be removed. [readability/parameter_name] [5] Source/WebKit/chromium/public/WebViewClient.h:123: Place brace on its own line for function definitions. [whitespace/braces] [4] Source/WebKit/chromium/public/WebViewClient.h:124: One space before end of line comments [whitespace/comments] [5] Source/WebKit/chromium/public/WebViewClient.h:128: Place brace on its own line for function definitions. [whitespace/braces] [4] Total errors found: 12 in 6 files If any of these errors are false positives, please file a bug against check-webkit-style. 464954 4 106891 webkit.review.bot 2011-09-09 11:50:59 -0700 Comment on attachment 106891 Patch Attachment 106891 did not pass cr-mac-ews (chromium): Output: http://queues.webkit.org/results/9621943 464957 5 abarth 2011-09-09 11:55:38 -0700 See also https://bugs.webkit.org/show_bug.cgi?id=67616 465194 6 106891 webkit.review.bot 2011-09-09 19:24:13 -0700 Comment on attachment 106891 Patch Attachment 106891 did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/9631102 490426 7 fsamuel 2011-10-25 15:45:19 -0700 This has been replaced by the master bug: https://bugs.webkit.org/show_bug.cgi?id=70559 Marking this as a Duplicate. (In reply to comment #6) > (From update of attachment 106891 [details]) > Attachment 106891 [details] did not pass chromium-ews (chromium-xvfb): > Output: http://queues.webkit.org/results/9631102 *** This bug has been marked as a duplicate of bug 70559 *** 106891 2011-09-09 11:28:48 -0700 2011-09-09 19:24:13 -0700 Patch bug-67859-20110909142846.patch text/plain 11263 fsamuel U3VidmVyc2lvbiBSZXZpc2lvbjogOTQ4NTUKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvY2hy b21pdW0vQ2hhbmdlTG9nIGIvU291cmNlL1dlYktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cKaW5kZXgg YzU4NzA0ZmNlNzdhOTIyOTMwNTAxYWJmMWRmMjEyZmIzNWUyMTg5Yi4uNzQxNzllMzNhOWVjYTQ1 MGI5ZTVmNTA2ZDNkY2FjYTgyNWE3ZTI4NSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9jaHJv bWl1bS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cKQEAg LTEsMyArMSwyMyBAQAorMjAxMS0wOS0wOSAgRmFkeSBTYW11ZWwgIDxmc2FtdWVsQGNocm9taXVt Lm9yZz4KKworICAgICAgICBFbmFibGUgVmlld3BvcnQgTWV0YSBUYWcgb24gQ2hyb21pdW0gUGxh dGZvcm1zIFtXb3JrIGluIFByb2dyZXNzXQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9y Zy9zaG93X2J1Zy5jZ2k/aWQ9Njc4NTkKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9P UFMhKS4KKworICAgICAgICAqIHB1YmxpYy9XZWJWaWV3Q2xpZW50Lmg6CisgICAgICAgIChXZWJL aXQ6OldlYlZpZXdDbGllbnQ6OnVzZUZpeGVkTGF5b3V0KToKKyAgICAgICAgKFdlYktpdDo6V2Vi Vmlld0NsaWVudDo6Z2V0Rml4ZWRMYXlvdXRXaWR0aCk6CisgICAgICAgIChXZWJLaXQ6OldlYlZp ZXdDbGllbnQ6OmdldERldmljZURwaSk6CisgICAgICAgIChXZWJLaXQ6OldlYlZpZXdDbGllbnQ6 OmdldERldmljZVJlY3QpOgorICAgICAgICAqIHB1YmxpYy9XZWJWaWV3cG9ydC5oOiBBZGRlZC4K KyAgICAgICAgKFdlYktpdDo6V2ViVmlld3BvcnQ6OldlYlZpZXdwb3J0KToKKyAgICAgICAgKiBz cmMvQ2hyb21lQ2xpZW50SW1wbC5jcHA6CisgICAgICAgIChXZWJLaXQ6OkNocm9tZUNsaWVudElt cGw6OmRpc3BhdGNoVmlld3BvcnREYXRhRGlkQ2hhbmdlKToKKyAgICAgICAgKiBzcmMvQ2hyb21l Q2xpZW50SW1wbC5oOgorICAgICAgICAqIHNyYy9XZWJWaWV3SW1wbC5jcHA6CisgICAgICAgIChX ZWJLaXQ6OldlYlZpZXdJbXBsOjpyZXNpemUpOgorCiAyMDExLTA5LTA5ICBNYXJ0aW4gS29zaWJh ICA8bWtvc2liYUBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgRXhwb3NpbmcgdGhlIGlzTGluayBt ZXRob2Qgb24gV2ViTm9kZSBmb3IgdGhlIENocm9taXVtIHBvcnQgb24gQW5kcm9pZC4KZGlmZiAt LWdpdCBhL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vcHVibGljL1dlYlZpZXdDbGllbnQuaCBiL1Nv dXJjZS9XZWJLaXQvY2hyb21pdW0vcHVibGljL1dlYlZpZXdDbGllbnQuaAppbmRleCA1MmJmYzIx NTVhNWZiNjdiODMyODQzMzkwMDNjNDk1OThkMDdiNzliLi5jYTJlYTIyMTJiNzRlNWZjZmY3MGY3 ODhmOGQwYmJhMTY1N2M1NGU1IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3B1 YmxpYy9XZWJWaWV3Q2xpZW50LmgKKysrIGIvU291cmNlL1dlYktpdC9jaHJvbWl1bS9wdWJsaWMv V2ViVmlld0NsaWVudC5oCkBAIC0xMTAsNiArMTEwLDI1IEBAIHB1YmxpYzoKICAgICB2aXJ0dWFs IHZvaWQgZGlkQWRkTWVzc2FnZVRvQ29uc29sZSgKICAgICAgICAgY29uc3QgV2ViQ29uc29sZU1l c3NhZ2UmLCBjb25zdCBXZWJTdHJpbmcmIHNvdXJjZU5hbWUsIHVuc2lnbmVkIHNvdXJjZUxpbmUp IHsgfQogCisgICAgLy8gQSBtZXRob2QgdG8gYWxsb3cgdGhlIGNsaWVudCB0byBzcGVjaWZ5IHdo ZXRoZXIgdGhlIFdlYlZpZXcgc2hvdWxkIHVzZQorICAgIC8vIGZpeGVkTGF5b3V0IG9yIG5vdC4K KyAgICB2aXJ0dWFsIGJvb2wgdXNlRml4ZWRMYXlvdXQoKSBjb25zdCB7IHJldHVybiBmYWxzZTsg fQorCisgICAgLy8gQSBtZXRob2QgdG8gYWxsb3cgdGhlIGNsaWVudCB0byBzZXQgdGhlIGRlZmF1 bHQgd2lkdGggZm9yIHRoZQorICAgIC8vIGZpeGVkTGF5b3V0LiBXZSBjYWxjdWxhdGUgdGhlIGhl aWdodCBvZiBmaXhlZExheW91dCBhY2NvcmRpbmcgdG8gdGhpcworICAgIC8vIHdpZHRoIHdpdGgg a2VlcGluZyB0aGUgc2NyZWVuIHJhdGlvLgorICAgIHZpcnR1YWwgaW50IGdldEZpeGVkTGF5b3V0 V2lkdGgoKSBjb25zdCB7IHJldHVybiAwOyB9CisKKyAgICAvLyBHZXQgZGV2aWNlIGRlbnNpdHkg dmFsdWUuCisgICAgdmlydHVhbCBpbnQgZ2V0RGV2aWNlRHBpKCkgY29uc3QgeworICAgICAgICBy ZXR1cm4gMTYwOyAgLy8gMTYwIGlzIGEgY29tbW9uIGRlZmF1bHQgdmFsdWU7CisgICAgfQorCisg ICAgLy8gR2V0IGN1cnJlbnQgZGV2aWNlJ3Mgd2luZG93IHJlY3QgaW4gcGl4ZWxzLgorICAgIHZp cnR1YWwgV2ViUmVjdCBnZXREZXZpY2VSZWN0KCkgY29uc3QgeworICAgICAgICByZXR1cm4gV2Vi UmVjdCgpOworICAgIH0KKwogICAgIC8vIENhbGxlZCB3aGVuIHNjcmlwdCBpbiB0aGUgcGFnZSBj YWxscyB3aW5kb3cucHJpbnQoKS4gIElmIGZyYW1lIGlzCiAgICAgLy8gbm9uLW51bGwsIHRoZW4g aXQgc2VsZWN0cyBhIHBhcnRpY3VsYXIgZnJhbWUsIGluY2x1ZGluZyBpdHMKICAgICAvLyBjaGls ZHJlbiwgdG8gcHJpbnQuICBPdGhlcndpc2UsIHRoZSBtYWluIGZyYW1lIGFuZCBpdHMgY2hpbGRy ZW4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vcHVibGljL1dlYlZpZXdwb3J0 LmggYi9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3B1YmxpYy9XZWJWaWV3cG9ydC5oCm5ldyBmaWxl IG1vZGUgMTAwNjQ0CmluZGV4IDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAw MDAuLjhhYTQyMTUxZjNhNzgzMTYwYmRjMjc0MDFlMTQ3Y2FmM2IwNDVkNDUKLS0tIC9kZXYvbnVs bAorKysgYi9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3B1YmxpYy9XZWJWaWV3cG9ydC5oCkBAIC0w LDAgKzEsNjYgQEAKKy8qCisgKiBDb3B5cmlnaHQgKEMpIDIwMTEgR29vZ2xlIEluYy4gQWxsIHJp Z2h0cyByZXNlcnZlZC4KKyAqCisgKiBSZWRpc3RyaWJ1dGlvbiBhbmQgdXNlIGluIHNvdXJjZSBh bmQgYmluYXJ5IGZvcm1zLCB3aXRoIG9yIHdpdGhvdXQKKyAqIG1vZGlmaWNhdGlvbiwgYXJlIHBl cm1pdHRlZCBwcm92aWRlZCB0aGF0IHRoZSBmb2xsb3dpbmcgY29uZGl0aW9ucyBhcmUKKyAqIG1l dDoKKyAqCisgKiAgICAgKiBSZWRpc3RyaWJ1dGlvbnMgb2Ygc291cmNlIGNvZGUgbXVzdCByZXRh aW4gdGhlIGFib3ZlIGNvcHlyaWdodAorICogbm90aWNlLCB0aGlzIGxpc3Qgb2YgY29uZGl0aW9u cyBhbmQgdGhlIGZvbGxvd2luZyBkaXNjbGFpbWVyLgorICogICAgICogUmVkaXN0cmlidXRpb25z IGluIGJpbmFyeSBmb3JtIG11c3QgcmVwcm9kdWNlIHRoZSBhYm92ZQorICogY29weXJpZ2h0IG5v dGljZSwgdGhpcyBsaXN0IG9mIGNvbmRpdGlvbnMgYW5kIHRoZSBmb2xsb3dpbmcgZGlzY2xhaW1l cgorICogaW4gdGhlIGRvY3VtZW50YXRpb24gYW5kL29yIG90aGVyIG1hdGVyaWFscyBwcm92aWRl ZCB3aXRoIHRoZQorICogZGlzdHJpYnV0aW9uLgorICogICAgICogTmVpdGhlciB0aGUgbmFtZSBv ZiBHb29nbGUgSW5jLiBub3IgdGhlIG5hbWVzIG9mIGl0cworICogY29udHJpYnV0b3JzIG1heSBi ZSB1c2VkIHRvIGVuZG9yc2Ugb3IgcHJvbW90ZSBwcm9kdWN0cyBkZXJpdmVkIGZyb20KKyAqIHRo aXMgc29mdHdhcmUgd2l0aG91dCBzcGVjaWZpYyBwcmlvciB3cml0dGVuIHBlcm1pc3Npb24uCisg KgorICogVEhJUyBTT0ZUV0FSRSBJUyBQUk9WSURFRCBCWSBUSEUgQ09QWVJJR0hUIEhPTERFUlMg QU5EIENPTlRSSUJVVE9SUworICogIkFTIElTIiBBTkQgQU5ZIEVYUFJFU1MgT1IgSU1QTElFRCBX QVJSQU5USUVTLCBJTkNMVURJTkcsIEJVVCBOT1QKKyAqIExJTUlURUQgVE8sIFRIRSBJTVBMSUVE IFdBUlJBTlRJRVMgT0YgTUVSQ0hBTlRBQklMSVRZIEFORCBGSVRORVNTIEZPUgorICogQSBQQVJU SUNVTEFSIFBVUlBPU0UgQVJFIERJU0NMQUlNRUQuIElOIE5PIEVWRU5UIFNIQUxMIFRIRSBDT1BZ UklHSFQKKyAqIE9XTkVSIE9SIENPTlRSSUJVVE9SUyBCRSBMSUFCTEUgRk9SIEFOWSBESVJFQ1Qs IElORElSRUNULCBJTkNJREVOVEFMLAorICogU1BFQ0lBTCwgRVhFTVBMQVJZLCBPUiBDT05TRVFV RU5USUFMIERBTUFHRVMgKElOQ0xVRElORywgQlVUIE5PVAorICogTElNSVRFRCBUTywgUFJPQ1VS RU1FTlQgT0YgU1VCU1RJVFVURSBHT09EUyBPUiBTRVJWSUNFUzsgTE9TUyBPRiBVU0UsCisgKiBE QVRBLCBPUiBQUk9GSVRTOyBPUiBCVVNJTkVTUyBJTlRFUlJVUFRJT04pIEhPV0VWRVIgQ0FVU0VE IEFORCBPTiBBTlkKKyAqIFRIRU9SWSBPRiBMSUFCSUxJVFksIFdIRVRIRVIgSU4gQ09OVFJBQ1Qs IFNUUklDVCBMSUFCSUxJVFksIE9SIFRPUlQKKyAqIChJTkNMVURJTkcgTkVHTElHRU5DRSBPUiBP VEhFUldJU0UpIEFSSVNJTkcgSU4gQU5ZIFdBWSBPVVQgT0YgVEhFIFVTRQorICogT0YgVEhJUyBT T0ZUV0FSRSwgRVZFTiBJRiBBRFZJU0VEIE9GIFRIRSBQT1NTSUJJTElUWSBPRiBTVUNIIERBTUFH RS4KKyAqLworCisjaWZuZGVmIFdlYlZpZXdwb3J0X2gKKyNkZWZpbmUgV2ViVmlld3BvcnRfaAor CituYW1lc3BhY2UgV2ViS2l0IHsKKworc3RydWN0IFdlYlZpZXdwb3J0IHsKKworICAgIGVudW0g eyBWYWx1ZVVuZGVmaW5lZCA9IC0xLCBEZXZpY2VWYWx1ZSA9IDAgfTsKKworICAgIGZsb2F0IGlu aXRpYWxTY2FsZTsKKyAgICBib29sIGluaXRpYWxTY2FsZUV4cGxpY2l0bHlTZXQ7CisgICAgZmxv YXQgbWluaW11bVNjYWxlOworICAgIGZsb2F0IG1heGltdW1TY2FsZTsKKyAgICBpbnQgd2lkdGg7 CisgICAgaW50IGhlaWdodDsKKyAgICBpbnQgdGFyZ2V0RGVuc2l0eURwaTsKKyAgICBib29sIHVz ZXJTY2FsYWJsZTsKKyAgICBmbG9hdCBkZXZpY2VQaXhlbFJhdGlvOworCisgICAgV2ViVmlld3Bv cnQoKQorICAgICAgICA6IGluaXRpYWxTY2FsZShWYWx1ZVVuZGVmaW5lZCkKKyAgICAgICAgLCBp bml0aWFsU2NhbGVFeHBsaWNpdGx5U2V0KGZhbHNlKQorICAgICAgICAsIG1pbmltdW1TY2FsZShW YWx1ZVVuZGVmaW5lZCkKKyAgICAgICAgLCBtYXhpbXVtU2NhbGUoVmFsdWVVbmRlZmluZWQpCisg ICAgICAgICwgd2lkdGgoVmFsdWVVbmRlZmluZWQpCisgICAgICAgICwgaGVpZ2h0KFZhbHVlVW5k ZWZpbmVkKQorICAgICAgICAsIHRhcmdldERlbnNpdHlEcGkoVmFsdWVVbmRlZmluZWQpCisgICAg ICAgICwgdXNlclNjYWxhYmxlKHRydWUpCisgICAgICAgICwgZGV2aWNlUGl4ZWxSYXRpbyhWYWx1 ZVVuZGVmaW5lZCkKKyAgICB7CisgICAgfQorfTsKKworfSAvLyBuYW1lc3BhY2UgV2ViS2l0CisK KyNlbmRpZgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9jaHJvbWl1bS9zcmMvQ2hyb21lQ2xp ZW50SW1wbC5jcHAgYi9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3NyYy9DaHJvbWVDbGllbnRJbXBs LmNwcAppbmRleCBmZWY3ZTdjOWQwM2Q2YzI2ZmVhM2RkZTZjNTZmYTUzMzVjOWFmOWY0Li5hY2E1 NzM5NTEyNDdjOTIxNmVlZGJmYmM2NTY4ZGVlMmMwYTVmNWU2IDEwMDY0NAotLS0gYS9Tb3VyY2Uv V2ViS2l0L2Nocm9taXVtL3NyYy9DaHJvbWVDbGllbnRJbXBsLmNwcAorKysgYi9Tb3VyY2UvV2Vi S2l0L2Nocm9taXVtL3NyYy9DaHJvbWVDbGllbnRJbXBsLmNwcApAQCAtODcsNiArODcsNyBAQAog I2luY2x1ZGUgIldlYlRleHREaXJlY3Rpb24uaCIKICNpbmNsdWRlICJXZWJVUkxSZXF1ZXN0Lmgi CiAjaW5jbHVkZSAiV2ViVmlld0NsaWVudC5oIgorI2luY2x1ZGUgIldlYlZpZXdwb3J0LmgiCiAj aW5jbHVkZSAiV2ViVmlld0ltcGwuaCIKICNpbmNsdWRlICJXZWJXaW5kb3dGZWF0dXJlcy5oIgog I2luY2x1ZGUgIldpbmRvd0ZlYXR1cmVzLmgiCkBAIC02MzQsNiArNjM1LDYyIEBAIHZvaWQgQ2hy b21lQ2xpZW50SW1wbDo6c2V0VG9vbFRpcChjb25zdCBTdHJpbmcmIHRvb2x0aXBUZXh0LCBUZXh0 RGlyZWN0aW9uIGRpcikKICAgICAgICAgdG9vbHRpcFRleHQsIHRleHREaXJlY3Rpb24pOwogfQog Cit2b2lkIENocm9tZUNsaWVudEltcGw6OmRpc3BhdGNoVmlld3BvcnREYXRhRGlkQ2hhbmdlKGNv bnN0IFZpZXdwb3J0QXJndW1lbnRzJiBhcmd1bWVudHMpIGNvbnN0Cit7CisgICAgaWYgKG1fd2Vi Vmlldy0+Y2xpZW50KCkpIHsKKyAgICAgICAgVmlld3BvcnRBcmd1bWVudHMgYXJnczsKKyAgICAg ICAgaWYgKGFyZ3VtZW50cyA9PSBhcmdzKSB7CisgICAgICAgICAgICAvLyBEZWZhdWx0IHZpZXdw b3J0IGFyZ3VtZW50cyBwYXNzZWQgaW4uICBUaGlzIGlzIGEgc2lnbmFsIHRvIHJlc2V0IHRoZSB2 aWV3cG9ydC4KKyAgICAgICAgICAgIGFyZ3Mud2lkdGggPSBWaWV3cG9ydEFyZ3VtZW50czo6VmFs dWVEZXNrdG9wV2lkdGg7CisgICAgICAgIH0gZWxzZSB7CisgICAgICAgICAgICBhcmdzID0gYXJn dW1lbnRzOworICAgICAgICAgICAgaWYgKGFyZ3VtZW50cy5taW5pbXVtU2NhbGUgPT0gMS4wZiAm JgorICAgICAgICAgICAgICAgIGFyZ3VtZW50cy5pbml0aWFsU2NhbGUgPT0gVmlld3BvcnRBcmd1 bWVudHM6OlZhbHVlQXV0byAmJgorICAgICAgICAgICAgICAgIGFyZ3VtZW50cy53aWR0aCA9PSBW aWV3cG9ydEFyZ3VtZW50czo6VmFsdWVBdXRvICYmCisgICAgICAgICAgICAgICAgYXJndW1lbnRz LmhlaWdodCA9PSBWaWV3cG9ydEFyZ3VtZW50czo6VmFsdWVBdXRvKSB7CisgICAgICAgICAgICAg ICAgLy8gRml4IGZvciBtb2JpbGUgZ29vZ2xlLmNvbSwgc2luY2UgcmlnaHQgbm93IG9ubHkgbWlu aW11bS1zY2FsZQorICAgICAgICAgICAgICAgIC8vIDEuMCBpcyBwYXNzZWQgaW4gdGhlIHZpZXdw b3J0IGFyZ3VtZW50LgorICAgICAgICAgICAgICAgIGFyZ3Mud2lkdGggPSBWaWV3cG9ydEFyZ3Vt ZW50czo6VmFsdWVEZXZpY2VXaWR0aDsKKyAgICAgICAgICAgIH0KKyAgICAgICAgfQorICAgICAg ICBXZWJWaWV3Q2xpZW50KiBjbGllbnQgPSBtX3dlYlZpZXctPmNsaWVudCgpOworICAgICAgICBX ZWJSZWN0IGRldmljZVJlY3QgPSBjbGllbnQtPmdldERldmljZVJlY3QoKTsKKyAgICAgICAgLy8g Q2FsbCB0aGUgY29tbW9uIHZpZXdwb3J0IGNvbXB1dGluZyBsb2dpYyBpbiBWaWV3cG9ydEFyZ3Vt ZW50cy5jcHAuCisgICAgICAgIFZpZXdwb3J0QXR0cmlidXRlcyBjb21wdXRlZCA9IGNvbXB1dGVW aWV3cG9ydEF0dHJpYnV0ZXMoCisgICAgICAgICAgICBhcmdzLCBjbGllbnQtPmdldEZpeGVkTGF5 b3V0V2lkdGgoKSwgZGV2aWNlUmVjdC53aWR0aCwgZGV2aWNlUmVjdC5oZWlnaHQsCisgICAgICAg ICAgICBjbGllbnQtPmdldERldmljZURwaSgpLCBJbnRTaXplKGRldmljZVJlY3Qud2lkdGgsIGRl dmljZVJlY3QuaGVpZ2h0KSk7CisgICAgICAgIGludCBjb21wdXRlZFdpZHRoID0gY29tcHV0ZWQu bGF5b3V0U2l6ZS53aWR0aCgpOworICAgICAgICBpbnQgY29tcHV0ZWRIZWlnaHQgPSBjb21wdXRl ZC5sYXlvdXRTaXplLmhlaWdodCgpOworCisgICAgICAgIFdlYlZpZXdwb3J0IHZpZXdwb3J0Owor ICAgICAgICB2aWV3cG9ydC5pbml0aWFsU2NhbGUgPSBjb21wdXRlZC5pbml0aWFsU2NhbGU7Cisg ICAgICAgIHZpZXdwb3J0LmluaXRpYWxTY2FsZUV4cGxpY2l0bHlTZXQgPQorICAgICAgICAgICAg KGFyZ3VtZW50cy5pbml0aWFsU2NhbGUgIT0gVmlld3BvcnRBcmd1bWVudHM6OlZhbHVlQXV0byk7 CisgICAgICAgIHZpZXdwb3J0Lm1pbmltdW1TY2FsZSA9IGNvbXB1dGVkLm1pbmltdW1TY2FsZTsK KyAgICAgICAgdmlld3BvcnQubWF4aW11bVNjYWxlID0gY29tcHV0ZWQubWF4aW11bVNjYWxlOwor ICAgICAgICB2aWV3cG9ydC53aWR0aCA9IGNvbXB1dGVkV2lkdGg7CisgICAgICAgIHZpZXdwb3J0 LmhlaWdodCA9IGNvbXB1dGVkSGVpZ2h0OworICAgICAgICB2aWV3cG9ydC5kZXZpY2VQaXhlbFJh dGlvID0gY29tcHV0ZWQuZGV2aWNlUGl4ZWxSYXRpbzsKKyAgICAgICAgdmlld3BvcnQudXNlclNj YWxhYmxlID0gKGNvbXB1dGVkLnVzZXJTY2FsYWJsZSA9PSAxIHx8CisgICAgICAgICAgICBjb21w dXRlZC51c2VyU2NhbGFibGUgPT0gVmlld3BvcnRBcmd1bWVudHM6OlZhbHVlQXV0byk7CisgICAg ICAgIC8vbV93ZWJWaWV3LT5jbGllbnQoKS0+ZGlkUmVjZWl2ZVZpZXdwb3J0KHZpZXdwb3J0KTsK KworLyoKKyAgICAgICAgLy8gIndpZHRoPTMyMCIgaXMgYSBtYWdpYyBudW1iZXIgYXMgaXQgd2Fz IHVzZWQgaW4gdGhlIGVhcmx5IGRheXMgdG8KKyAgICAgICAgLy8gaW5kaWNhdGUgdGhlIHNpdGUg d2FudHMgdGhlIGRldmljZSB3aWR0aDsgd2hpbGUgaXQncyBub3QgaGFuZGxlZCBpbgorICAgICAg ICAvLyBjb21wdXRlVmlld3BvcnRBdHRyaWJ1dGVzLiAgTWF5IHdhbnQgdG8gdXBzdHJlYW0gbGF0 ZXIuCisgICAgICAgIEludFNpemUgc2l6ZShjb21wdXRlZFdpZHRoLCBjb21wdXRlZEhlaWdodCk7 CisgICAgICAgIGlmIChjb21wdXRlZFdpZHRoID09IDMyMCB8fCAhdmlld3BvcnQudXNlclNjYWxh YmxlKSB7CisgICAgICAgICAgICBGbG9hdFJlY3QgcmVjdCA9IGNvbnN0X2Nhc3Q8Q2hyb21lQ2xp ZW50SW1wbCo+KHRoaXMpLT53aW5kb3dSZWN0KCk7CisgICAgICAgICAgICBzaXplLnNldFdpZHRo KHJlY3Qud2lkdGgoKSk7CisgICAgICAgICAgICBzaXplLnNldEhlaWdodChyZWN0LmhlaWdodCgp KTsKKyAgICAgICAgfQorKi8KKyAgICAgICAgbV93ZWJWaWV3LT5wYWdlKCktPm1haW5GcmFtZSgp LT52aWV3KCktPnNldEZpeGVkTGF5b3V0U2l6ZShzaXplKTsKKyAgICB9Cit9CisKKwogdm9pZCBD aHJvbWVDbGllbnRJbXBsOjpwcmludChGcmFtZSogZnJhbWUpCiB7CiAgICAgaWYgKG1fd2ViVmll dy0+Y2xpZW50KCkpCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3NyYy9DaHJv bWVDbGllbnRJbXBsLmggYi9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3NyYy9DaHJvbWVDbGllbnRJ bXBsLmgKaW5kZXggMDkwOTM5MGNjYjliN2MyMzIwYmRmYWQ4N2Q4NjIxZGQ5OTA3ZTE0MC4uNjFm ZTdkMDcyZTAzZGIzMzNlZDg1NTVmMzhjY2I5MWMxYjM0ZjgzYiAxMDA2NDQKLS0tIGEvU291cmNl L1dlYktpdC9jaHJvbWl1bS9zcmMvQ2hyb21lQ2xpZW50SW1wbC5oCisrKyBiL1NvdXJjZS9XZWJL aXQvY2hyb21pdW0vc3JjL0Nocm9tZUNsaWVudEltcGwuaApAQCAtMTI1LDYgKzEyNSw3IEBAIHB1 YmxpYzoKICAgICB2aXJ0dWFsIHZvaWQgbW91c2VEaWRNb3ZlT3ZlckVsZW1lbnQoCiAgICAgICAg IGNvbnN0IFdlYkNvcmU6OkhpdFRlc3RSZXN1bHQmIHJlc3VsdCwgdW5zaWduZWQgbW9kaWZpZXJG bGFncyk7CiAgICAgdmlydHVhbCB2b2lkIHNldFRvb2xUaXAoY29uc3QgV1RGOjpTdHJpbmcmIHRv b2x0aXBUZXh0LCBXZWJDb3JlOjpUZXh0RGlyZWN0aW9uKTsKKyAgICB2aXJ0dWFsIHZvaWQgZGlz cGF0Y2hWaWV3cG9ydERhdGFEaWRDaGFuZ2UoY29uc3QgV2ViQ29yZTo6Vmlld3BvcnRBcmd1bWVu dHMmIGFyZ3VtZW50cykgY29uc3Q7CiAgICAgdmlydHVhbCB2b2lkIHByaW50KFdlYkNvcmU6OkZy YW1lKik7CiAgICAgdmlydHVhbCB2b2lkIGV4Y2VlZGVkRGF0YWJhc2VRdW90YSgKICAgICAgICAg V2ViQ29yZTo6RnJhbWUqLCBjb25zdCBXVEY6OlN0cmluZyYgZGF0YWJhc2VOYW1lKTsKZGlmZiAt LWdpdCBhL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vc3JjL1dlYlZpZXdJbXBsLmNwcCBiL1NvdXJj ZS9XZWJLaXQvY2hyb21pdW0vc3JjL1dlYlZpZXdJbXBsLmNwcAppbmRleCA3MzhkN2EzZDk1ZGM1 M2VmODEyZWQ0MzlkMmIxOWMxOGM4MmJmN2M5Li4xY2VlOGRiY2YzZGE1YWFiYzRiOGExYzAwOGY4 ZjJmYzVlMjIyNjQ1IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3NyYy9XZWJW aWV3SW1wbC5jcHAKKysrIGIvU291cmNlL1dlYktpdC9jaHJvbWl1bS9zcmMvV2ViVmlld0ltcGwu Y3BwCkBAIC0xMDExLDggKzEwMTEsMjkgQEAgdm9pZCBXZWJWaWV3SW1wbDo6cmVzaXplKGNvbnN0 IFdlYlNpemUmIG5ld1NpemUpCiAgICAgICAgIHJldHVybjsKICAgICBtX3NpemUgPSBuZXdTaXpl OwogCi0gICAgaWYgKG1haW5GcmFtZUltcGwoKS0+ZnJhbWVWaWV3KCkpIHsKLSAgICAgICAgbWFp bkZyYW1lSW1wbCgpLT5mcmFtZVZpZXcoKS0+cmVzaXplKG1fc2l6ZS53aWR0aCwgbV9zaXplLmhl aWdodCk7CisgICAgRnJhbWVWaWV3KiBmcmFtZVZpZXcgPSBtYWluRnJhbWVJbXBsKCktPmZyYW1l VmlldygpOworICAgIGlmIChmcmFtZVZpZXcpIHsKKyAgICAgICAgaWYgKG1fY2xpZW50ICYmIGZy YW1lVmlldy0+dXNlRml4ZWRMYXlvdXQoKSkgeworICAgICAgICAgIFdlYlJlY3QgZGV2aWNlUmVj dCA9IG1fY2xpZW50LT5nZXREZXZpY2VSZWN0KCk7CisgICAgICAgICAgSW50U2l6ZSBmaXhlZExh eW91dFNpemUgPSBmcmFtZVZpZXctPmZpeGVkTGF5b3V0U2l6ZSgpOworICAgICAgICAgIGJvb2wg Zml4ZWRMYXlvdXRTaXplQ2hhbmdlZCA9IGZhbHNlOworICAgICAgICAgIERvY3VtZW50KiBkb2N1 bWVudCA9ICBtYWluRnJhbWVJbXBsKCktPmZyYW1lKCktPmRvY3VtZW50KCk7CisgICAgICAgICAg Vmlld3BvcnRBcmd1bWVudHMgdmlld3BvcnQgPSBkb2N1bWVudC0+dmlld3BvcnRBcmd1bWVudHMo KTsKKyAgICAgICAgICBpZiAodmlld3BvcnQud2lkdGggPT0gVmlld3BvcnRBcmd1bWVudHM6OlZh bHVlRGV2aWNlV2lkdGggJiYKKyAgICAgICAgICAgICAgZml4ZWRMYXlvdXRTaXplLndpZHRoKCkg IT0gZGV2aWNlUmVjdC53aWR0aCkgeworICAgICAgICAgICAgZml4ZWRMYXlvdXRTaXplLnNldFdp ZHRoKGRldmljZVJlY3Qud2lkdGgpOworICAgICAgICAgICAgZml4ZWRMYXlvdXRTaXplQ2hhbmdl ZCA9IHRydWU7CisgICAgICAgICAgfQorICAgICAgICAgIGlmICh2aWV3cG9ydC5oZWlnaHQgPT0g Vmlld3BvcnRBcmd1bWVudHM6OlZhbHVlRGV2aWNlSGVpZ2h0ICYmCisgICAgICAgICAgICAgIGZp eGVkTGF5b3V0U2l6ZS5oZWlnaHQoKSAhPSBkZXZpY2VSZWN0LmhlaWdodCkgeworICAgICAgICAg ICAgZml4ZWRMYXlvdXRTaXplLnNldEhlaWdodChkZXZpY2VSZWN0LmhlaWdodCk7CisgICAgICAg ICAgICBmaXhlZExheW91dFNpemVDaGFuZ2VkID0gdHJ1ZTsKKyAgICAgICAgICB9CisgICAgICAg ICAgc2V0Rml4ZWRMYXlvdXRTaXplKGZpeGVkTGF5b3V0U2l6ZSk7CisgICAgICAgICAgaWYgKGZp eGVkTGF5b3V0U2l6ZUNoYW5nZWQpCisgICAgICAgICAgICAgIGZyYW1lVmlldy0+bGF5b3V0KCk7 CisgICAgICAgIH0KKyAgICAgICAgZnJhbWVWaWV3LT5yZXNpemUobV9zaXplLndpZHRoLCBtX3Np emUuaGVpZ2h0KTsKICAgICAgICAgbWFpbkZyYW1lSW1wbCgpLT5mcmFtZSgpLT5ldmVudEhhbmRs ZXIoKS0+c2VuZFJlc2l6ZUV2ZW50KCk7CiAgICAgfQogCg==