67858 2011-09-09 11:26:24 -0700 Pixel result shows that compositing/iframes/repaint-after-losing-scrollbars.html is failing 2011-09-27 12:00:38 -0700 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 68872 68893 1 simon.fraser simon.fraser bdakin jamesr ossy simon.fraser oldest_to_newest 464932 0 simon.fraser 2011-09-09 11:26:24 -0700 Loading compositing/iframes/repaint-after-losing-scrollbars.html shows that the test is failing; the scrollbars remain visible on Mac in Safari. 464940 1 simon.fraser 2011-09-09 11:32:00 -0700 I have non-overlay scrollbars and am testing on Lion. 464951 2 jamesr 2011-09-09 11:45:22 -0700 The tests works as expected on chromium. On mac it looks like it's a graphical issue (the scrollbar pixels are there, but there's no actual scrollbar widget). Looks like we aren't routing an invalidation to the composited layer when the scrollbars vanish. I suspect that either those invalidations are going nowhere or to the root. Can you try on lion with overlay scrollbars? Mac with overlay scrollbars behaves almost identically to chromium. 465104 3 simon.fraser 2011-09-09 16:45:11 -0700 I don't see any code that does repaints when scrollbars come and go. Maybe we were just relying on the native widgets to repaint? 465174 4 simon.fraser 2011-09-09 18:48:53 -0700 I filed 67878 to track the pixel test issue. 465175 5 106952 simon.fraser 2011-09-09 18:54:17 -0700 Created attachment 106952 Patch 465186 6 106952 darin 2011-09-09 19:02:24 -0700 Comment on attachment 106952 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=106952&action=review > Source/WebCore/ChangeLog:15 > + Tested by compositing/iframes/repaint-after-losing-scrollbars.html, even though the pixel > + result doesn't show the correct result (bug 67878). Does the expected result of that test need to be updated, or is it already failing? > Source/WebCore/platform/ScrollView.cpp:583 > + if (!m_horizontalScrollbar && !m_verticalScrollbar && !oldScrollCornerRect.isEmpty()) > + invalidateScrollCornerRect(oldScrollCornerRect); I’m not sure I understand which call sites are responsible for checking if the rectangle is empty. There is a check here, but no check in RenderLayerCompositor::destroyRootLayer. Is it important to check everywhere? Or unnecessary to check anywhere? Or helpful to check in some places even if not in others? > Source/WebCore/rendering/RenderLayerCompositor.cpp:1746 > + m_renderView->frameView()->invalidateScrollCorner(m_renderView->frameView()->scrollCornerRect()); If frameView() is a non-trivial function it might be nice to call it only once. 473683 7 simon.fraser 2011-09-26 22:49:49 -0700 http://trac.webkit.org/changeset/96070 473708 8 ossy 2011-09-26 23:37:16 -0700 (In reply to comment #7) > http://trac.webkit.org/changeset/96070 It made 2 tests crash on the Qt bot: fast/loader/stateobjects/pushstate-clears-forward-history.html fast/frames/frame-dead-region.html http://build.webkit.org/results/Qt%20Linux%20Release/r96070%20%2837910%29/results.html 473839 9 vestbo 2011-09-27 04:09:20 -0700 (In reply to comment #7) > http://trac.webkit.org/changeset/96070 SL-WK2 tests started crashing after this it seems: http://build.webkit.org/builders/SnowLeopard%20Intel%20Debug%20%28WebKit2%20Tests%29/builds/1939 Similar symptoms on the Qt -WK2 bot: http://build.webkit.sed.hu/builders/x86-32%20Linux%20Qt%20Release%20WebKit2/builds/12394/ 473840 10 ossy 2011-09-27 04:12:05 -0700 (In reply to comment #9) > (In reply to comment #7) > > http://trac.webkit.org/changeset/96070 > > SL-WK2 tests started crashing after this it seems: > > http://build.webkit.org/builders/SnowLeopard%20Intel%20Debug%20%28WebKit2%20Tests%29/builds/1939 > > Similar symptoms on the Qt -WK2 bot: > > http://build.webkit.sed.hu/builders/x86-32%20Linux%20Qt%20Release%20WebKit2/builds/12394/ Here is the bugreport: https://bugs.webkit.org/show_bug.cgi?id=68872 473889 11 106952 ossy 2011-09-27 06:06:03 -0700 Comment on attachment 106952 Patch remove r+, because it was landed and rolled out and the bug is reopened. 474130 12 simon.fraser 2011-09-27 12:00:38 -0700 Back in in http://trac.webkit.org/changeset/96138. r96130 fixed the crash. 106952 2011-09-09 18:54:17 -0700 2011-09-27 06:06:03 -0700 Patch bug-67858-20110909185416.patch text/plain 8601 simon.fraser U3VidmVyc2lvbiBSZXZpc2lvbjogOTQ4NTkKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCA4ZDA1YTI1MDE0ZGRhMDkz M2VkMzdkYTdiZmU2MThiNmQzNDU4MTIwLi41NDUyNmFkZGU0NmFhMDQ5YjgyNThiOTA3ZDE3OGU2 ZTUyOTE2MWNiIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvU291 cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDUgKzEsNDAgQEAKIDIwMTEtMDktMDkgIFNpbW9u IEZyYXNlciAgPHNpbW9uLmZyYXNlckBhcHBsZS5jb20+CiAKKyAgICAgICAgUGl4ZWwgcmVzdWx0 IHNob3dzIHRoYXQgY29tcG9zaXRpbmcvaWZyYW1lcy9yZXBhaW50LWFmdGVyLWxvc2luZy1zY3Jv bGxiYXJzLmh0bWwgaXMgZmFpbGluZworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9z aG93X2J1Zy5jZ2k/aWQ9Njc4NTgKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMh KS4KKyAgICAgICAgCisgICAgICAgIFdoZW4gbm9uLW92ZXJsYXkgc2Nyb2xsYmFycyBhcmUgaGlk ZGVuIG9uIGEgY29tcG9zaXRlZCBpZnJhbWUsIG5vdGhpbmcgaW52YWxpZGF0ZWQKKyAgICAgICAg dGhlIHNjcm9sbGJhciBhcmVhcyBvciB0aGUgc2Nyb2xsIGNvcm5lciwgc28gdGhlIHNjcm9sbGJh cnMgYXBwZWFyIHRvIHJlbWFpbi4KKyAgICAgICAgCisgICAgICAgIEZpeCBieSBpbnZhbGlkYXRp bmcgdGhlIHNjcm9sbGJhcnMgYW5kIHNjcm9sbCBjb3JuZXIgd2hlbiB0aGV5IGFyZSByZW1vdmVk LiBJbnZhbGlkYXRpb24KKyAgICAgICAgb24gc2Nyb2xsYmFyIGNyZWF0aW9uIGFwcGVhcnMgdG8g aGFwcGVuIHZpYSB1cGRhdGluZyB0aGUgc2Nyb2xsYmFyIHN0eWxlLgorCisgICAgICAgIFRlc3Rl ZCBieSBjb21wb3NpdGluZy9pZnJhbWVzL3JlcGFpbnQtYWZ0ZXItbG9zaW5nLXNjcm9sbGJhcnMu aHRtbCwgZXZlbiB0aG91Z2ggdGhlIHBpeGVsCisgICAgICAgIHJlc3VsdCBkb2Vzbid0IHNob3cg dGhlIGNvcnJlY3QgcmVzdWx0IChidWcgNjc4NzgpLgorCisgICAgICAgICogcGFnZS9GcmFtZVZp ZXcuY3BwOgorICAgICAgICAoV2ViQ29yZTo6RnJhbWVWaWV3Ojp1cGRhdGVTY3JvbGxDb3JuZXIp OiBQYXNzIHRoZSBjb3JuZXIgcmVjdCBpbnRvIGludmFsaWRhdGVTY3JvbGxDb3JuZXIoKS4KKyAg ICAgICAgKiBwbGF0Zm9ybS9TY3JvbGxWaWV3LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlNjcm9s bFZpZXc6OnNldEhhc0hvcml6b250YWxTY3JvbGxiYXIpOiBJbnZhbGlkYXRlIHRoZSBzY3JvbGxi YXIgYXJlYSBpZiBoaWRpbmcgaXQuCisgICAgICAgIChXZWJDb3JlOjpTY3JvbGxWaWV3OjpzZXRI YXNWZXJ0aWNhbFNjcm9sbGJhcik6IERpdHRvLgorICAgICAgICAoV2ViQ29yZTo6U2Nyb2xsVmll dzo6dXBkYXRlU2Nyb2xsYmFycyk6IEluIHRoZSBjYXNlIHdoZXJlIGJvdGggc2Nyb2xsYmFycyBh cmUgZ29pbmcgYXdheSwKKyAgICAgICAgY29tcHV0ZSB0aGUgc2Nyb2xsIGNvcm5lciByZWN0IHdo aWxlIHdlIHN0aWxsIGhhdmUgc2Nyb2xsYmFycywgYW5kIHRoZW4gaW52YWxpZGF0ZSBpdAorICAg ICAgICBleHBsaWNpdGx5LiAodXBkYXRlU2Nyb2xsQ29ybmVyKCkgZG9lc24ndCwgYmVjYXVzZSBp dCBkb2Vzbid0IGhhdmUgYWNjZXNzIHRvIHRoZSBvbGQgY29ybmVyCisgICAgICAgIHJlY3QuKQor ICAgICAgICAqIHBsYXRmb3JtL1Njcm9sbGFibGVBcmVhLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6 OlNjcm9sbGFibGVBcmVhOjppbnZhbGlkYXRlU2Nyb2xsQ29ybmVyKTogUGFzcyB0aGUgcmVjdCBp biwgYmVjYXVzZSB3ZSBjYW4ndAorICAgICAgICBjb21wdXRlIGl0IGluIHRoZSBjYXNlIHdoZXJl IHRoZSBzY3JvbGxiYXJzIGFyZSBnb2luZyBhd2F5LgorICAgICAgICAqIHBsYXRmb3JtL1Njcm9s bGFibGVBcmVhLmg6IFBhc3MgaW4gYSByZWN0IHRvIGludmFsaWRhdGVTY3JvbGxDb3JuZXIoKSwg d2hpY2ggbWF0Y2hlcworICAgICAgICBpbnZhbGlkYXRlU2Nyb2xsYmFyKCkuCisgICAgICAgICog cmVuZGVyaW5nL1JlbmRlckxheWVyQ29tcG9zaXRvci5jcHA6CisgICAgICAgIChXZWJDb3JlOjpS ZW5kZXJMYXllckNvbXBvc2l0b3I6OmRlc3Ryb3lSb290TGF5ZXIpOiBQYXNzIHRoZSBjb3JuZXIg cmVjdCBpbnRvIGludmFsaWRhdGVTY3JvbGxDb3JuZXIoKS4KKyAgICAgICAgKiByZW5kZXJpbmcv UmVuZGVyU2Nyb2xsYmFyUGFydC5jcHA6IERpdHRvLgorICAgICAgICAoV2ViQ29yZTo6UmVuZGVy U2Nyb2xsYmFyUGFydDo6aW1hZ2VDaGFuZ2VkKTogRGl0dG8uCisKKzIwMTEtMDktMDkgIFNpbW9u IEZyYXNlciAgPHNpbW9uLmZyYXNlckBhcHBsZS5jb20+CisKICAgICAgICAgVHJhbnNsdWNlbnQg c2Nyb2xsYmFycyBvbiBjb21wb3NpdGVkIGxheWVycyByZW5kZXIgaW5jb3JyZWN0bHkKICAgICAg ICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTU4NTE1CiAKZGlmZiAt LWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BhZ2UvRnJhbWVWaWV3LmNwcCBiL1NvdXJjZS9XZWJDb3Jl L3BhZ2UvRnJhbWVWaWV3LmNwcAppbmRleCA0ZGI5ZmE5YmZkNjAyMDgyYjU1N2I4MmU5MTU5MmQ2 M2QxNTA3OTQ5Li5jNDRiMWE3Y2RiYTcxNTczZmNjNTBhYmQ3YThkYjVlNzdlYTIyMjNhIDEwMDY0 NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wYWdlL0ZyYW1lVmlldy5jcHAKKysrIGIvU291cmNlL1dl YkNvcmUvcGFnZS9GcmFtZVZpZXcuY3BwCkBAIC0yNDM5LDggKzI0MzksOSBAQCB2b2lkIEZyYW1l Vmlldzo6dXBkYXRlU2Nyb2xsQ29ybmVyKCkKIHsKICAgICBSZW5kZXJPYmplY3QqIHJlbmRlcmVy ID0gMDsKICAgICBSZWZQdHI8UmVuZGVyU3R5bGU+IGNvcm5lclN0eWxlOworICAgIEludFJlY3Qg Y29ybmVyUmVjdCA9IHNjcm9sbENvcm5lclJlY3QoKTsKICAgICAKLSAgICBpZiAoIXNjcm9sbENv cm5lclJlY3QoKS5pc0VtcHR5KCkpIHsKKyAgICBpZiAoIWNvcm5lclJlY3QuaXNFbXB0eSgpKSB7 CiAgICAgICAgIC8vIFRyeSB0aGUgPGJvZHk+IGVsZW1lbnQgZmlyc3QgYXMgYSBzY3JvbGwgY29y bmVyIHNvdXJjZS4KICAgICAgICAgRG9jdW1lbnQqIGRvYyA9IG1fZnJhbWUtPmRvY3VtZW50KCk7 CiAgICAgICAgIEVsZW1lbnQqIGJvZHkgPSBkb2MgPyBkb2MtPmJvZHkoKSA6IDA7CkBAIC0yNDY5 LDcgKzI0NzAsNyBAQCB2b2lkIEZyYW1lVmlldzo6dXBkYXRlU2Nyb2xsQ29ybmVyKCkKICAgICAg ICAgaWYgKCFtX3Njcm9sbENvcm5lcikKICAgICAgICAgICAgIG1fc2Nyb2xsQ29ybmVyID0gbmV3 IChyZW5kZXJlci0+cmVuZGVyQXJlbmEoKSkgUmVuZGVyU2Nyb2xsYmFyUGFydChyZW5kZXJlci0+ ZG9jdW1lbnQoKSk7CiAgICAgICAgIG1fc2Nyb2xsQ29ybmVyLT5zZXRTdHlsZShjb3JuZXJTdHls ZS5yZWxlYXNlKCkpOwotICAgICAgICBpbnZhbGlkYXRlU2Nyb2xsQ29ybmVyKCk7CisgICAgICAg IGludmFsaWRhdGVTY3JvbGxDb3JuZXIoY29ybmVyUmVjdCk7CiAgICAgfSBlbHNlIGlmIChtX3Nj cm9sbENvcm5lcikgewogICAgICAgICBtX3Njcm9sbENvcm5lci0+ZGVzdHJveSgpOwogICAgICAg ICBtX3Njcm9sbENvcm5lciA9IDA7CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9y bS9TY3JvbGxWaWV3LmNwcCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL1Njcm9sbFZpZXcuY3Bw CmluZGV4IDA0MWUzODI3YzFmZWNjM2I4MGQzYzhhMjc5NDZmNDVlODJlODEwMDcuLjFjNzlhNDlk ZjhlZTZhM2QwMGM5OTVjYWIwMjczNjAzZWNhMGU0NTEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJD b3JlL3BsYXRmb3JtL1Njcm9sbFZpZXcuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3Jt L1Njcm9sbFZpZXcuY3BwCkBAIC05NSw2ICs5NSw3IEBAIHZvaWQgU2Nyb2xsVmlldzo6c2V0SGFz SG9yaXpvbnRhbFNjcm9sbGJhcihib29sIGhhc0JhcikKICAgICAgICAgZGlkQWRkSG9yaXpvbnRh bFNjcm9sbGJhcihtX2hvcml6b250YWxTY3JvbGxiYXIuZ2V0KCkpOwogICAgICAgICBtX2hvcml6 b250YWxTY3JvbGxiYXItPnN0eWxlQ2hhbmdlZCgpOwogICAgIH0gZWxzZSBpZiAoIWhhc0JhciAm JiBtX2hvcml6b250YWxTY3JvbGxiYXIpIHsKKyAgICAgICAgbV9ob3Jpem9udGFsU2Nyb2xsYmFy LT5pbnZhbGlkYXRlKCk7CiAgICAgICAgIHdpbGxSZW1vdmVIb3Jpem9udGFsU2Nyb2xsYmFyKG1f aG9yaXpvbnRhbFNjcm9sbGJhci5nZXQoKSk7CiAgICAgICAgIHJlbW92ZUNoaWxkKG1faG9yaXpv bnRhbFNjcm9sbGJhci5nZXQoKSk7CiAgICAgICAgIG1faG9yaXpvbnRhbFNjcm9sbGJhciA9IDA7 CkBAIC0xMTMsNiArMTE0LDcgQEAgdm9pZCBTY3JvbGxWaWV3OjpzZXRIYXNWZXJ0aWNhbFNjcm9s bGJhcihib29sIGhhc0JhcikKICAgICAgICAgZGlkQWRkVmVydGljYWxTY3JvbGxiYXIobV92ZXJ0 aWNhbFNjcm9sbGJhci5nZXQoKSk7CiAgICAgICAgIG1fdmVydGljYWxTY3JvbGxiYXItPnN0eWxl Q2hhbmdlZCgpOwogICAgIH0gZWxzZSBpZiAoIWhhc0JhciAmJiBtX3ZlcnRpY2FsU2Nyb2xsYmFy KSB7CisgICAgICAgIG1fdmVydGljYWxTY3JvbGxiYXItPmludmFsaWRhdGUoKTsKICAgICAgICAg d2lsbFJlbW92ZVZlcnRpY2FsU2Nyb2xsYmFyKG1fdmVydGljYWxTY3JvbGxiYXIuZ2V0KCkpOwog ICAgICAgICByZW1vdmVDaGlsZChtX3ZlcnRpY2FsU2Nyb2xsYmFyLmdldCgpKTsKICAgICAgICAg bV92ZXJ0aWNhbFNjcm9sbGJhciA9IDA7CkBAIC00NDksNiArNDUxLDggQEAgdm9pZCBTY3JvbGxW aWV3Ojp1cGRhdGVTY3JvbGxiYXJzKGNvbnN0IEludFNpemUmIGRlc2lyZWRPZmZzZXQpCiAgICAg ICAgIG1faW5VcGRhdGVTY3JvbGxiYXJzID0gZmFsc2U7CiAgICAgfQogCisgICAgSW50UmVjdCBv bGRTY3JvbGxDb3JuZXJSZWN0ID0gc2Nyb2xsQ29ybmVyUmVjdCgpOworCiAgICAgYm9vbCBoYXNI b3Jpem9udGFsU2Nyb2xsYmFyID0gbV9ob3Jpem9udGFsU2Nyb2xsYmFyOwogICAgIGJvb2wgaGFz VmVydGljYWxTY3JvbGxiYXIgPSBtX3ZlcnRpY2FsU2Nyb2xsYmFyOwogICAgIApAQCAtNTc1LDYg KzU3OSw4IEBAIHZvaWQgU2Nyb2xsVmlldzo6dXBkYXRlU2Nyb2xsYmFycyhjb25zdCBJbnRTaXpl JiBkZXNpcmVkT2Zmc2V0KQogICAgICAgICBmcmFtZVJlY3RzQ2hhbmdlZCgpOwogICAgICAgICBw b3NpdGlvblNjcm9sbGJhckxheWVycygpOwogICAgICAgICB1cGRhdGVTY3JvbGxDb3JuZXIoKTsK KyAgICAgICAgaWYgKCFtX2hvcml6b250YWxTY3JvbGxiYXIgJiYgIW1fdmVydGljYWxTY3JvbGxi YXIgJiYgIW9sZFNjcm9sbENvcm5lclJlY3QuaXNFbXB0eSgpKQorICAgICAgICAgICAgaW52YWxp ZGF0ZVNjcm9sbENvcm5lclJlY3Qob2xkU2Nyb2xsQ29ybmVyUmVjdCk7CiAgICAgfQogCiAgICAg SW50UG9pbnQgc2Nyb2xsUG9pbnQgPSBhZGp1c3RTY3JvbGxQb3NpdGlvbldpdGhpblJhbmdlKElu dFBvaW50KGRlc2lyZWRPZmZzZXQpKSArIEludFNpemUobV9zY3JvbGxPcmlnaW4ueCgpLCBtX3Nj cm9sbE9yaWdpbi55KCkpOwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vU2Ny b2xsYWJsZUFyZWEuY3BwIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vU2Nyb2xsYWJsZUFyZWEu Y3BwCmluZGV4IDRiNTFhNjUwNTUyYWJiYjI4NzkyNDg3MjZmOTc1MjQyNmI4ZGYyZDguLmM3YTM5 OTdiNTU1ODI4YzQ2NmVjZmVhOWQxMzY4ZjE5N2Y4MTI5YTggMTAwNjQ0Ci0tLSBhL1NvdXJjZS9X ZWJDb3JlL3BsYXRmb3JtL1Njcm9sbGFibGVBcmVhLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9w bGF0Zm9ybS9TY3JvbGxhYmxlQXJlYS5jcHAKQEAgLTI3NCw3ICsyNzQsNyBAQCB2b2lkIFNjcm9s bGFibGVBcmVhOjppbnZhbGlkYXRlU2Nyb2xsYmFyKFNjcm9sbGJhciogc2Nyb2xsYmFyLCBjb25z dCBJbnRSZWN0JiByZQogICAgIGludmFsaWRhdGVTY3JvbGxiYXJSZWN0KHNjcm9sbGJhciwgcmVj dCk7CiB9CiAKLXZvaWQgU2Nyb2xsYWJsZUFyZWE6OmludmFsaWRhdGVTY3JvbGxDb3JuZXIoKQor dm9pZCBTY3JvbGxhYmxlQXJlYTo6aW52YWxpZGF0ZVNjcm9sbENvcm5lcihjb25zdCBJbnRSZWN0 JiByZWN0KQogewogI2lmIFVTRShBQ0NFTEVSQVRFRF9DT01QT1NJVElORykKICAgICBpZiAoR3Jh cGhpY3NMYXllciogZ3JhcGhpY3NMYXllciA9IGxheWVyRm9yU2Nyb2xsQ29ybmVyKCkpIHsKQEAg LTI4Miw3ICsyODIsNyBAQCB2b2lkIFNjcm9sbGFibGVBcmVhOjppbnZhbGlkYXRlU2Nyb2xsQ29y bmVyKCkKICAgICAgICAgcmV0dXJuOwogICAgIH0KICNlbmRpZgotICAgIGludmFsaWRhdGVTY3Jv bGxDb3JuZXJSZWN0KHNjcm9sbENvcm5lclJlY3QoKSk7CisgICAgaW52YWxpZGF0ZVNjcm9sbENv cm5lclJlY3QocmVjdCk7CiB9CiAKIGJvb2wgU2Nyb2xsYWJsZUFyZWE6Omhhc0xheWVyRm9ySG9y aXpvbnRhbFNjcm9sbGJhcigpIGNvbnN0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0 Zm9ybS9TY3JvbGxhYmxlQXJlYS5oIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vU2Nyb2xsYWJs ZUFyZWEuaAppbmRleCBjMzllMTVjNWMwYjNhZDlhMWViZjI3OWU0ZTFjM2JlM2NlNTY5OTJhLi43 YzE3ODcxNjkxZWFjOGRhYzcyZjk4MTU3MTExMGQ3NTBhOGI0M2VkIDEwMDY0NAotLS0gYS9Tb3Vy Y2UvV2ViQ29yZS9wbGF0Zm9ybS9TY3JvbGxhYmxlQXJlYS5oCisrKyBiL1NvdXJjZS9XZWJDb3Jl L3BsYXRmb3JtL1Njcm9sbGFibGVBcmVhLmgKQEAgLTg5LDcgKzg5LDcgQEAgcHVibGljOgogICAg IHZvaWQgaW52YWxpZGF0ZVNjcm9sbGJhcihTY3JvbGxiYXIqLCBjb25zdCBJbnRSZWN0Jik7CiAg ICAgdmlydHVhbCBib29sIGlzU2Nyb2xsQ29ybmVyVmlzaWJsZSgpIGNvbnN0ID0gMDsKICAgICB2 aXJ0dWFsIEludFJlY3Qgc2Nyb2xsQ29ybmVyUmVjdCgpIGNvbnN0ID0gMDsKLSAgICB2b2lkIGlu dmFsaWRhdGVTY3JvbGxDb3JuZXIoKTsKKyAgICB2b2lkIGludmFsaWRhdGVTY3JvbGxDb3JuZXIo Y29uc3QgSW50UmVjdCYpOwogICAgIHZpcnR1YWwgdm9pZCBnZXRUaWNrbWFya3MoVmVjdG9yPElu dFJlY3Q+JikgY29uc3QgeyB9CiAKICAgICAvLyBUaGlzIGZ1bmN0aW9uIHNob3VsZCBiZSBvdmVy cmlkZW4gYnkgc3ViY2xhc3NlcyB0byBwZXJmb3JtIHRoZSBhY3R1YWwKZGlmZiAtLWdpdCBhL1Nv dXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJMYXllckNvbXBvc2l0b3IuY3BwIGIvU291cmNl L1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckxheWVyQ29tcG9zaXRvci5jcHAKaW5kZXggYWM4NDE1 NjNmZTFlNWJmYzQwZTA4ZTJmNDM2NmNkODRkN2JlOWRlOS4uY2E5NmFmM2RjZmY4NjI4MDA5YmY3 NGQxNTExOGMxYTEwOTBjZDFiMyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5n L1JlbmRlckxheWVyQ29tcG9zaXRvci5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5n L1JlbmRlckxheWVyQ29tcG9zaXRvci5jcHAKQEAgLTE3NDMsNyArMTc0Myw3IEBAIHZvaWQgUmVu ZGVyTGF5ZXJDb21wb3NpdG9yOjpkZXN0cm95Um9vdExheWVyKCkKIAogICAgIGlmIChtX2xheWVy Rm9yU2Nyb2xsQ29ybmVyKSB7CiAgICAgICAgIG1fbGF5ZXJGb3JTY3JvbGxDb3JuZXIgPSBudWxs cHRyOwotICAgICAgICBtX3JlbmRlclZpZXctPmZyYW1lVmlldygpLT5pbnZhbGlkYXRlU2Nyb2xs Q29ybmVyKCk7CisgICAgICAgIG1fcmVuZGVyVmlldy0+ZnJhbWVWaWV3KCktPmludmFsaWRhdGVT Y3JvbGxDb3JuZXIobV9yZW5kZXJWaWV3LT5mcmFtZVZpZXcoKS0+c2Nyb2xsQ29ybmVyUmVjdCgp KTsKICAgICB9CiAKICAgICBpZiAobV9vdmVyZmxvd0NvbnRyb2xzSG9zdExheWVyKSB7CmRpZmYg LS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyU2Nyb2xsYmFyUGFydC5jcHAg Yi9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyU2Nyb2xsYmFyUGFydC5jcHAKaW5kZXgg NWE1NGRlMWYyOGFlNjQ5YzMxNjJhZGRlZTA0M2M3Mzk0YzAyYWYzYi4uY2NhMjcyNzY2Njg3YTgw YjgyNjEyYmJjMTFmMTQ0Njg1NDM5MTdkOSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcmVu ZGVyaW5nL1JlbmRlclNjcm9sbGJhclBhcnQuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3JlbmRl cmluZy9SZW5kZXJTY3JvbGxiYXJQYXJ0LmNwcApAQCAtMTUwLDcgKzE1MCw3IEBAIHZvaWQgUmVu ZGVyU2Nyb2xsYmFyUGFydDo6aW1hZ2VDaGFuZ2VkKFdyYXBwZWRJbWFnZVB0ciBpbWFnZSwgY29u c3QgSW50UmVjdCogcmVjCiAgICAgZWxzZSB7CiAgICAgICAgIGlmIChGcmFtZVZpZXcqIGZyYW1l VmlldyA9IHZpZXcoKS0+ZnJhbWVWaWV3KCkpIHsKICAgICAgICAgICAgIGlmIChmcmFtZVZpZXct PmlzRnJhbWVWaWV3U2Nyb2xsQ29ybmVyKHRoaXMpKSB7Ci0gICAgICAgICAgICAgICAgZnJhbWVW aWV3LT5pbnZhbGlkYXRlU2Nyb2xsQ29ybmVyKCk7CisgICAgICAgICAgICAgICAgZnJhbWVWaWV3 LT5pbnZhbGlkYXRlU2Nyb2xsQ29ybmVyKGZyYW1lVmlldy0+c2Nyb2xsQ29ybmVyUmVjdCgpKTsK ICAgICAgICAgICAgICAgICByZXR1cm47CiAgICAgICAgICAgICB9CiAgICAgICAgIH0K