67853 2011-09-09 09:49:35 -0700 Add myself to committers.py 2011-09-09 11:16:42 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 mhahnenberg mhahnenberg webkit.review.bot oldest_to_newest 464847 0 mhahnenberg 2011-09-09 09:49:35 -0700 See summary. 464850 1 106882 mhahnenberg 2011-09-09 09:54:04 -0700 Created attachment 106882 Patch 464851 2 106882 webkit.review.bot 2011-09-09 09:54:40 -0700 Comment on attachment 106882 Patch Rejecting attachment 106882 from commit-queue. mhahnenberg@apple.com does not have committer permissions according to http://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/common/config/committers.py. - If you do not have committer rights please read http://webkit.org/coding/contributing.html for instructions on how to use bugzilla flags. - If you have committer rights please correct the error in Tools/Scripts/webkitpy/common/config/committers.py by adding yourself to the file (no review needed). The commit-queue restarts itself every 2 hours. After restart the commit-queue will correctly respect your committer rights. 464857 3 106882 webkit.review.bot 2011-09-09 10:09:34 -0700 Comment on attachment 106882 Patch Rejecting attachment 106882 from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 1 Last 500 characters of output: working directory Updating working directory Processing patch 106882 from bug 67853. ERROR: /mnt/git/webkit-commit-queue/Tools/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive). Updating OpenSource Current branch master is up to date. Updating chromium port dependencies using gclient... ________ running '/usr/bin/python gyp_webkit' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium' Updating webkit projects from gyp files... Full output: http://queues.webkit.org/results/9622885 464863 4 106884 mhahnenberg 2011-09-09 10:13:33 -0700 Created attachment 106884 Patch 464925 5 106884 webkit.review.bot 2011-09-09 11:16:38 -0700 Comment on attachment 106884 Patch Clearing flags on attachment: 106884 Committed r94867: <http://trac.webkit.org/changeset/94867> 464926 6 webkit.review.bot 2011-09-09 11:16:42 -0700 All reviewed patches have been landed. Closing bug. 106882 2011-09-09 09:54:04 -0700 2011-09-09 10:13:29 -0700 Patch bug-67853-20110909095401.patch text/plain 1425 mhahnenberg U3VidmVyc2lvbiBSZXZpc2lvbjogOTQ4NTYKZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBi L1Rvb2xzL0NoYW5nZUxvZwppbmRleCBhMWMyYjlmNGQ3MmY3MmZjZTNlNWM1YzI5NTcwZDU1MTMy YTUyZmJmLi5mYmM3YTBmMDBlMTUxZTQzZWVhY2JmY2E0NWVlZTczYzVlNTZlMGMxIDEwMDY0NAot LS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIvVG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTAg QEAKKzIwMTEtMDktMDkgIE1hcmsgSGFobmVuYmVyZyAgPG1oYWhuZW5iZXJnQGFwcGxlLmNvbT4K KworICAgICAgICBBZGQgbXlzZWxmIHRvIGNvbW1pdHRlcnMucHkKKyAgICAgICAgaHR0cHM6Ly9i dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTY3ODUzCisKKyAgICAgICAgKiBTY3JpcHRz L3dlYmtpdHB5L2NvbW1vbi9jb25maWcvY29tbWl0dGVycy5weToKKwogMjAxMS0wOS0wOSAgU2hl cmlmZiBCb3QgIDx3ZWJraXQucmV2aWV3LmJvdEBnbWFpbC5jb20+CiAKICAgICAgICAgVW5yZXZp ZXdlZCwgcm9sbGluZyBvdXQgcjk0ODUxLgpkaWZmIC0tZ2l0IGEvVG9vbHMvU2NyaXB0cy93ZWJr aXRweS9jb21tb24vY29uZmlnL2NvbW1pdHRlcnMucHkgYi9Ub29scy9TY3JpcHRzL3dlYmtpdHB5 L2NvbW1vbi9jb25maWcvY29tbWl0dGVycy5weQppbmRleCAxODUwZGMwNDlhYjNmNTk3MTNiM2Nj YWQ0MjIyNDYwOTE4ZDZlNGVkLi45ZDhiNmMzYWFjNWQ5OGNkNjQ0NGM4MDlhZGQzNjJmZGRhNmZm MDRlIDEwMDY0NAotLS0gYS9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L2NvbW1vbi9jb25maWcvY29t bWl0dGVycy5weQorKysgYi9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L2NvbW1vbi9jb25maWcvY29t bWl0dGVycy5weQpAQCAtMjI3LDYgKzIyNyw3IEBAIGNvbW1pdHRlcnNfdW5hYmxlX3RvX3Jldmll dyA9IFsKICAgICBDb21taXR0ZXIoIk1haGVzaCBLdWxrYXJuaSIsICJtYWhlc2gua3Vsa2FybmlA bm9raWEuY29tIiwgIm1haGVzaGsiKSwKICAgICBDb21taXR0ZXIoIk1hcmN1cyBWb2x0aXMgQnVs YWNoIiwgImJ1bGFjaEBjaHJvbWl1bS5vcmciKSwKICAgICBDb21taXR0ZXIoIk1hcmlvIFNhbmNo ZXogUHJhZGEiLCBbIm1zYW5jaGV6QGlnYWxpYS5jb20iLCAibWFyaW9Ad2Via2l0Lm9yZyJdLCAi bXNhbmNoZXoiKSwKKyAgICBDb21taXR0ZXIoIk1hcmsgSGFobmVuYmVyZyIsICJtaGFobmVuYmVy Z0BhcHBsZS5jb20iKSwKICAgICBDb21taXR0ZXIoIk1hdHQgRGVsYW5leSIsICJtZGVsYW5leUBh cHBsZS5jb20iKSwKICAgICBDb21taXR0ZXIoIk1hdHQgTGlsZWsiLCBbIm1saWxla0BhcHBsZS5j b20iLCAid2Via2l0QG1hdHRsaWxlay5jb20iLCAicGV3dGVybW9vc2VAd2Via2l0Lm9yZyJdKSwK ICAgICBDb21taXR0ZXIoIk1hdHQgUGVycnkiLCAibXBjb21wbGV0ZUBjaHJvbWl1bS5vcmciKSwK 106884 2011-09-09 10:13:33 -0700 2011-09-09 11:16:38 -0700 Patch bug-67853-20110909101329.patch text/plain 1512 mhahnenberg U3VidmVyc2lvbiBSZXZpc2lvbjogOTQ4NTkKZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBi L1Rvb2xzL0NoYW5nZUxvZwppbmRleCBlMjEwNzBlMDRhNGQxYzZmY2MzYmI4MmE0YzQxZjM3MjVl YTkyOTIxLi5kZDdkOTY1MjU5ZGNjYWNkNWIxODg5MTY0M2VlZmM2MzBkMDIxYTFkIDEwMDY0NAot LS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIvVG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTIg QEAKKzIwMTEtMDktMDkgIE1hcmsgSGFobmVuYmVyZyAgPG1oYWhuZW5iZXJnQGFwcGxlLmNvbT4K KworICAgICAgICBBZGQgbXlzZWxmIHRvIGNvbW1pdHRlcnMucHkKKyAgICAgICAgaHR0cHM6Ly9i dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTY3ODUzCisKKyAgICAgICAgUmV2aWV3ZWQg YnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBTY3JpcHRzL3dlYmtpdHB5L2NvbW1vbi9j b25maWcvY29tbWl0dGVycy5weToKKwogMjAxMS0wOS0wOSAgS2V2aW4gT2xsaXZpZXIgIDxrZXZp bm9AdGhlb2xsaXZpZXJzLmNvbT4KIAogICAgICAgICBbd3hdIFVucmV2aWV3ZWQgYnVpbGQgZml4 LiBBZGQgU291cmNlL0phdmFTY3JpcHRDb3JlL2RmZyBkaXJlY3RvcnkgdG8gdGhlIGJ1aWxkLgpk aWZmIC0tZ2l0IGEvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9jb21tb24vY29uZmlnL2NvbW1pdHRl cnMucHkgYi9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L2NvbW1vbi9jb25maWcvY29tbWl0dGVycy5w eQppbmRleCAxODUwZGMwNDlhYjNmNTk3MTNiM2NjYWQ0MjIyNDYwOTE4ZDZlNGVkLi45ZDhiNmMz YWFjNWQ5OGNkNjQ0NGM4MDlhZGQzNjJmZGRhNmZmMDRlIDEwMDY0NAotLS0gYS9Ub29scy9TY3Jp cHRzL3dlYmtpdHB5L2NvbW1vbi9jb25maWcvY29tbWl0dGVycy5weQorKysgYi9Ub29scy9TY3Jp cHRzL3dlYmtpdHB5L2NvbW1vbi9jb25maWcvY29tbWl0dGVycy5weQpAQCAtMjI3LDYgKzIyNyw3 IEBAIGNvbW1pdHRlcnNfdW5hYmxlX3RvX3JldmlldyA9IFsKICAgICBDb21taXR0ZXIoIk1haGVz aCBLdWxrYXJuaSIsICJtYWhlc2gua3Vsa2FybmlAbm9raWEuY29tIiwgIm1haGVzaGsiKSwKICAg ICBDb21taXR0ZXIoIk1hcmN1cyBWb2x0aXMgQnVsYWNoIiwgImJ1bGFjaEBjaHJvbWl1bS5vcmci KSwKICAgICBDb21taXR0ZXIoIk1hcmlvIFNhbmNoZXogUHJhZGEiLCBbIm1zYW5jaGV6QGlnYWxp YS5jb20iLCAibWFyaW9Ad2Via2l0Lm9yZyJdLCAibXNhbmNoZXoiKSwKKyAgICBDb21taXR0ZXIo Ik1hcmsgSGFobmVuYmVyZyIsICJtaGFobmVuYmVyZ0BhcHBsZS5jb20iKSwKICAgICBDb21taXR0 ZXIoIk1hdHQgRGVsYW5leSIsICJtZGVsYW5leUBhcHBsZS5jb20iKSwKICAgICBDb21taXR0ZXIo Ik1hdHQgTGlsZWsiLCBbIm1saWxla0BhcHBsZS5jb20iLCAid2Via2l0QG1hdHRsaWxlay5jb20i LCAicGV3dGVybW9vc2VAd2Via2l0Lm9yZyJdKSwKICAgICBDb21taXR0ZXIoIk1hdHQgUGVycnki LCAibXBjb21wbGV0ZUBjaHJvbWl1bS5vcmciKSwK