6785 2006-01-25 00:49:52 -0800 Fix for possible leak of applet, object, or embed (and plugin view) 2006-02-03 20:56:55 -0800 1 1 1 Unclassified WebKit Plug-ins 420+ Mac OS X 10.4 RESOLVED FIXED P1 Critical --- 1 timo timo oldest_to_newest 29818 0 timo 2006-01-25 00:49:52 -0800 An application which uses WebKit might leak plugins if it uses -[WebScriptObject setValue:forKey:] to alter an <embed> element's style. Doing so causes HTMLObjectElementImpl to create and cache a KJS::Bindings::Instance, which it owns but never deletes. I've got a patch which fixes the problem, and a similar problem with <object> and <applet>. 29819 1 5941 timo 2006-01-25 00:52:33 -0800 Created attachment 5941 Patch 29910 2 5941 timo 2006-01-25 13:55:22 -0800 Comment on attachment 5941 Patch Dave Harrison reviewed this. 31251 3 darin 2006-02-03 20:56:55 -0800 Tim landed this 2006-01-24. 5941 2006-01-25 00:52:33 -0800 2006-01-25 13:55:22 -0800 Patch diffs.txt text/plain 4569 timo SW5kZXg6IENoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBDaGFuZ2VMb2cJKHJldmlzaW9uIDEyMzQ0 KQorKysgQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMjkgQEAKKzIwMDYtMDEt MjQgIFRpbSBPbWVybmljayAgPHRpbW9AYXBwbGUuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5 IE5PQk9EWSAoT09QUyEpLgorCisJPHJkYXI6Ly9wcm9ibGVtLzQzMzkwMjQ+CisJPGh0dHA6Ly9i dWd6aWxsYS5vcGVuZGFyd2luLm9yZy9zaG93X2J1Zy5jZ2k/aWQ9Njc4NT4gIkZpeCBmb3IgcG9z c2libGUgbGVhayBvZiBhcHBsZXQsIG9iamVjdCwgb3IgZW1iZWQKKwkoYW5kIHBsdWdpbiB2aWV3 KSIKKwkKKyAgICAgICAgKiBraHRtbC9odG1sL2h0bWxfb2JqZWN0aW1wbC5jcHA6CisgICAgICAg IChXZWJDb3JlOjpIVE1MQXBwbGV0RWxlbWVudEltcGw6On5IVE1MQXBwbGV0RWxlbWVudEltcGwp OgorCUFzc2VydCB0aGF0IGFwcGxldEluc3RhbmNlIGhhcyBiZWVuIGRlbGV0ZWQgYnkgZGV0YWNo KCkuCisgICAgICAgIChXZWJDb3JlOjpIVE1MQXBwbGV0RWxlbWVudEltcGw6OmRldGFjaCk6CisJ RGVsZXRlIGFwcGxldEluc3RhbmNlLCBiZWNhdXNlIGl0IHJlZmVyZW5jZXMgdGhlIHdpZGdldCBv d25lZCBieSB0aGUgcmVuZGVyZXIgd2UncmUgYWJvdXQgdG8gZGVzdHJveS4KKwlJdCBpcyBhc3N1 bWVkIGVsc2V3aGVyZSAoZ2V0UnVudGltZU9iamVjdCgpLCBranNfZG9tLmNwcCkgdGhhdCB0aGUg aW5zdGFuY2UgaXMgb3duZWQgYnkgdGhlIGFwcGxldAorCWVsZW1lbnQuICBUaGVyZWZvcmUsIGl0 IGlzIHJlcXVpcmVkIHRoYXQgdGhlIGVsZW1lbnQgZGVzdHJveSB0aGUgaW5zdGFuY2UgaW4gaXRz IHRlYXItZG93biBwaGFzZS4KKyAgICAgICAgKFdlYkNvcmU6OkhUTUxFbWJlZEVsZW1lbnRJbXBs Ojp+SFRNTEVtYmVkRWxlbWVudEltcGwpOgorCUFzc2VydCB0aGF0IGVtYmVkSW5zdGFuY2UgaGFz IGJlZW4gZGVsZXRlZCBieSBkZXRhY2goKS4KKyAgICAgICAgKFdlYkNvcmU6OkhUTUxFbWJlZEVs ZW1lbnRJbXBsOjpkZXRhY2gpOgorCURlbGV0ZSBlbWJlZEluc3RhbmNlLCBzYW1lIHJlYXNvbi4g IFRoaXMgaXMgdGhlIG9uZSB0aGF0IGZpeGVzIDxyZGFyOi8vcHJvYmxlbS80MzM5MDI0Pi4KKyAg ICAgICAgKFdlYkNvcmU6OkhUTUxPYmplY3RFbGVtZW50SW1wbDo6fkhUTUxPYmplY3RFbGVtZW50 SW1wbCk6CisJQXNzZXJ0IHRoYXQgb2JqZWN0SW5zdGFuY2UgaGFzIGJlZW4gZGVsZXRlZCBieSBk ZXRhY2goKS4KKyAgICAgICAgKFdlYkNvcmU6OkhUTUxPYmplY3RFbGVtZW50SW1wbDo6ZGV0YWNo KToKKwlEZWxldGUgZW1iZWRJbnN0YW5jZSwgc2FtZSByZWFzb24uCisgICAgICAgICoga2h0bWwv aHRtbC9odG1sX29iamVjdGltcGwuaDoKKwlEZWNsYXJlZCBIVE1MQXBwbGV0RWxlbWVudEltcGw6 OmRldGFjaCgpIGFuZCBIVE1MRW1iZWRFbGVtZW50SW1wbDo6ZGV0YWNoKCkuCisKIDIwMDYtMDEt MjQgIERhcmluIEFkbGVyICA8ZGFyaW5AYXBwbGUuY29tPgogCiAgICAgICAgIFJldmlld2VkIGJ5 IEVyaWMuCkluZGV4OiBraHRtbC9odG1sL2h0bWxfb2JqZWN0aW1wbC5jcHAKPT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQot LS0ga2h0bWwvaHRtbC9odG1sX29iamVjdGltcGwuY3BwCShyZXZpc2lvbiAxMjMzOSkKKysrIGto dG1sL2h0bWwvaHRtbF9vYmplY3RpbXBsLmNwcAkod29ya2luZyBjb3B5KQpAQCAtNTksNyArNTks OCBAQAogCiBIVE1MQXBwbGV0RWxlbWVudEltcGw6On5IVE1MQXBwbGV0RWxlbWVudEltcGwoKQog ewotICAgIGRlbGV0ZSBhcHBsZXRJbnN0YW5jZTsKKyAgICAvLyBhcHBsZXRJbnN0YW5jZSBzaG91 bGQgaGF2ZSBiZWVuIGNsZWFuZWQgdXAgaW4gZGV0YWNoKCkuCisgICAgYXNzZXJ0KCFhcHBsZXRJ bnN0YW5jZSk7CiB9CiAKIGJvb2wgSFRNTEFwcGxldEVsZW1lbnRJbXBsOjpjaGVja0RURChjb25z dCBOb2RlSW1wbCogbmV3Q2hpbGQpCkBAIC0yMjMsNiArMjI0LDE3IEBACiAgICAgSFRNTEVsZW1l bnRJbXBsOjpjbG9zZVJlbmRlcmVyKCk7CiB9CiAKK3ZvaWQgSFRNTEFwcGxldEVsZW1lbnRJbXBs OjpkZXRhY2goKQoreworICAgIC8vIERlbGV0ZSBhcHBsZXRJbnN0YW5jZSwgYmVjYXVzZSBpdCBy ZWZlcmVuY2VzIHRoZSB3aWRnZXQgb3duZWQgYnkgdGhlIHJlbmRlcmVyIHdlJ3JlIGFib3V0IHRv IGRlc3Ryb3kuCisgICAgaWYgKGFwcGxldEluc3RhbmNlKSB7CisgICAgICAgIGRlbGV0ZSBhcHBs ZXRJbnN0YW5jZTsKKyAgICAgICAgYXBwbGV0SW5zdGFuY2UgPSAwOworICAgIH0KKworICAgIEhU TUxFbGVtZW50SW1wbDo6ZGV0YWNoKCk7Cit9CisKIGJvb2wgSFRNTEFwcGxldEVsZW1lbnRJbXBs OjphbGxQYXJhbXNBdmFpbGFibGUoKQogewogICAgIHJldHVybiBtX2FsbFBhcmFtc0F2YWlsYWJs ZTsKQEAgLTM0Niw2ICszNTgsOCBAQAogCiBIVE1MRW1iZWRFbGVtZW50SW1wbDo6fkhUTUxFbWJl ZEVsZW1lbnRJbXBsKCkKIHsKKyAgICAvLyBlbWJlZEluc3RhbmNlIHNob3VsZCBoYXZlIGJlZW4g Y2xlYW5lZCB1cCBpbiBkZXRhY2goKS4KKyAgICBhc3NlcnQoIWVtYmVkSW5zdGFuY2UpOwogfQog CiBib29sIEhUTUxFbWJlZEVsZW1lbnRJbXBsOjpjaGVja0RURChjb25zdCBOb2RlSW1wbCogbmV3 Q2hpbGQpCkBAIC00ODYsNiArNTAwLDE3IEBACiAgICAgICAgIHN0YXRpY19jYXN0PFJlbmRlclBh cnRPYmplY3QqPihyZW5kZXJlcigpKS0+dXBkYXRlV2lkZ2V0KCk7CiB9CiAKK3ZvaWQgSFRNTEVt YmVkRWxlbWVudEltcGw6OmRldGFjaCgpCit7CisgICAgLy8gRGVsZXRlIGVtYmVkSW5zdGFuY2Us IGJlY2F1c2UgaXQgcmVmZXJlbmNlcyB0aGUgd2lkZ2V0IG93bmVkIGJ5IHRoZSByZW5kZXJlciB3 ZSdyZSBhYm91dCB0byBkZXN0cm95LgorICAgIGlmIChlbWJlZEluc3RhbmNlKSB7CisgICAgICAg IGRlbGV0ZSBlbWJlZEluc3RhbmNlOworICAgICAgICBlbWJlZEluc3RhbmNlID0gMDsKKyAgICB9 CisKKyAgICBIVE1MRWxlbWVudEltcGw6OmRldGFjaCgpOworfQorCiB2b2lkIEhUTUxFbWJlZEVs ZW1lbnRJbXBsOjppbnNlcnRlZEludG9Eb2N1bWVudCgpCiB7CiAgICAgaWYgKGdldERvY3VtZW50 KCktPmlzSFRNTERvY3VtZW50KCkpIHsKQEAgLTUyNCw2ICs1NDksOSBAQAogCiBIVE1MT2JqZWN0 RWxlbWVudEltcGw6On5IVE1MT2JqZWN0RWxlbWVudEltcGwoKQogeworICAgIC8vIG9iamVjdElu c3RhbmNlIHNob3VsZCBoYXZlIGJlZW4gY2xlYW5lZCB1cCBpbiBkZXRhY2goKS4KKyAgICBhc3Nl cnQoIW9iamVjdEluc3RhbmNlKTsKKyAgICAKICAgICBkZWxldGUgbV9pbWFnZUxvYWRlcjsKIH0K IApAQCAtNzMxLDYgKzc1OSwxMiBAQAogICAgICAgICBuZWVkV2lkZ2V0VXBkYXRlID0gdHJ1ZTsK ICAgICB9CiAKKyAgICAvLyBEZWxldGUgb2JqZWN0SW5zdGFuY2UsIGJlY2F1c2UgaXQgcmVmZXJl bmNlcyB0aGUgd2lkZ2V0IG93bmVkIGJ5IHRoZSByZW5kZXJlciB3ZSdyZSBhYm91dCB0byBkZXN0 cm95LgorICAgIGlmIChvYmplY3RJbnN0YW5jZSkgeworICAgICAgICBkZWxldGUgb2JqZWN0SW5z dGFuY2U7CisgICAgICAgIG9iamVjdEluc3RhbmNlID0gMDsKKyAgICB9CisgICAgCiAgICAgSFRN TEVsZW1lbnRJbXBsOjpkZXRhY2goKTsKIH0KIApJbmRleDoga2h0bWwvaHRtbC9odG1sX29iamVj dGltcGwuaAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09Ci0tLSBraHRtbC9odG1sL2h0bWxfb2JqZWN0aW1wbC5oCShyZXZp c2lvbiAxMjMzOSkKKysrIGtodG1sL2h0bWwvaHRtbF9vYmplY3RpbXBsLmgJKHdvcmtpbmcgY29w eSkKQEAgLTU1LDYgKzU1LDcgQEAKICAgICB2aXJ0dWFsIGJvb2wgcmVuZGVyZXJJc05lZWRlZChr aHRtbDo6UmVuZGVyU3R5bGUgKik7CiAgICAgdmlydHVhbCBraHRtbDo6UmVuZGVyT2JqZWN0ICpj cmVhdGVSZW5kZXJlcihSZW5kZXJBcmVuYSAqLCBraHRtbDo6UmVuZGVyU3R5bGUgKik7CiAgICAg dmlydHVhbCB2b2lkIGNsb3NlUmVuZGVyZXIoKTsKKyAgICB2aXJ0dWFsIHZvaWQgZGV0YWNoKCk7 CiAgICAgCiAgICAgRE9NU3RyaW5nIGFsaWduKCkgY29uc3Q7CiAgICAgdm9pZCBzZXRBbGlnbihj b25zdCBET01TdHJpbmcgJik7CkBAIC0xMjUsNiArMTI2LDcgQEAKICAgICB2aXJ0dWFsIHZvaWQg cGFyc2VNYXBwZWRBdHRyaWJ1dGUoTWFwcGVkQXR0cmlidXRlSW1wbCAqYXR0cik7CiAKICAgICB2 aXJ0dWFsIHZvaWQgYXR0YWNoKCk7CisgICAgdmlydHVhbCB2b2lkIGRldGFjaCgpOwogICAgIHZp cnR1YWwgYm9vbCByZW5kZXJlcklzTmVlZGVkKGtodG1sOjpSZW5kZXJTdHlsZSAqKTsKICAgICB2 aXJ0dWFsIGtodG1sOjpSZW5kZXJPYmplY3QgKmNyZWF0ZVJlbmRlcmVyKFJlbmRlckFyZW5hICos IGtodG1sOjpSZW5kZXJTdHlsZSAqKTsKICAgICB2aXJ0dWFsIHZvaWQgaW5zZXJ0ZWRJbnRvRG9j dW1lbnQoKTsK