67849 2011-09-09 08:21:52 -0700 Chromium shadow-buffer-partial test change. 2011-09-12 10:44:39 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) All All RESOLVED FIXED P3 Normal --- 0 bungeman webkit-unassigned kbr webkit.review.bot oldest_to_newest 464803 0 bungeman 2011-09-09 08:21:52 -0700 A skia change ( http://code.google.com/p/skia/source/detail?r=2211 ) fixes issues with clipped blurs. This fix is currently disabled in chromium. In order to enable this fix, the chromium test fast/box-shadow/ inset-box-shadow-radius and inset-box-shadows need to be updated, as they currently have an incorrect blur. This change will be to set these tests to be skipped. Once chromium rolls to skip the tests, the fix there (currently disabled) will be enabled. Then, after webkit rolls chromium past this change, there will be another webkit change to re-enable the tests. This is an extension to Bug 67724 as Bug 67596 (which went in yesterday right after Bug 67724 went in) re-enabled these two tests in test expectations. 464806 1 106874 bungeman 2011-09-09 08:29:58 -0700 Created attachment 106874 Patch 464808 2 bungeman 2011-09-09 08:32:54 -0700 Adding reviewer. Note that this is an extension to Bug 67724, since Bug 67596 managed to make the blur change affect more tests. 465042 3 106874 kbr 2011-09-09 14:54:59 -0700 Comment on attachment 106874 Patch Unless the tests are crashing we should not skip running them, because then we won't see any really bad code changes that might make them actually crash. Just mark the expectations PASS FAIL. 465581 4 107046 bungeman 2011-09-12 06:28:22 -0700 Created attachment 107046 Patch 465584 5 107046 bungeman 2011-09-12 06:29:43 -0700 Comment on attachment 107046 Patch Have changed tests from SKIP to just PASS FAIL. 465636 6 107046 kbr 2011-09-12 09:43:49 -0700 Comment on attachment 107046 Patch Looks fine. r=me 465671 7 107046 webkit.review.bot 2011-09-12 10:44:33 -0700 Comment on attachment 107046 Patch Clearing flags on attachment: 107046 Committed r94963: <http://trac.webkit.org/changeset/94963> 465672 8 webkit.review.bot 2011-09-12 10:44:39 -0700 All reviewed patches have been landed. Closing bug. 106874 2011-09-09 08:29:58 -0700 2011-09-12 06:28:16 -0700 Patch bug-67849-20110909112957.patch text/plain 1312 bungeman SW5kZXg6IExheW91dFRlc3RzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9D aGFuZ2VMb2cJKHJldmlzaW9uIDk0ODU1KQorKysgTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCSh3b3Jr aW5nIGNvcHkpCkBAIC0xLDMgKzEsMTIgQEAKKzIwMTEtMDktMDkgIEJlbiBXYWduZXIgIDxidW5n ZW1hbkBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgQ2hyb21pdW0gc2hhZG93LWJ1ZmZlci1wYXJ0 aWFsIHRlc3QgY2hhbmdlLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1 Zy5jZ2k/aWQ9Njc4NDkKKyAgICAgICAgUGFydDI6IFN0aWxsIGRpc2FibGluZyB0ZXN0cyBzbyBj aHJvbWl1bSBjYW4gcmViYXNlbGluZS4KKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BT ISkuCisKKyAgICAgICAgKiBwbGF0Zm9ybS9jaHJvbWl1bS90ZXN0X2V4cGVjdGF0aW9ucy50eHQ6 CisKIDIwMTEtMDktMDkgIENhcnkgQ2xhcmsgIDxjYXJ5Y2xhcmtAZ29vZ2xlLmNvbT4KIAogICAg ICAgICBVbnJldmlld2VkOyBuZXcgYmFzZWxpbmVzIChTa2lhIG9uIE1hYywgR1BVIGVkaXRpb24p CkluZGV4OiBMYXlvdXRUZXN0cy9wbGF0Zm9ybS9jaHJvbWl1bS90ZXN0X2V4cGVjdGF0aW9ucy50 eHQKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PQotLS0gTGF5b3V0VGVzdHMvcGxhdGZvcm0vY2hyb21pdW0vdGVzdF9leHBl Y3RhdGlvbnMudHh0CShyZXZpc2lvbiA5NDg1MykKKysrIExheW91dFRlc3RzL3BsYXRmb3JtL2No cm9taXVtL3Rlc3RfZXhwZWN0YXRpb25zLnR4dAkod29ya2luZyBjb3B5KQpAQCAtODUsNiArODUs OCBAQCBCVUdDUjIwNDA0IDogZWRpdGluZy9leGVjQ29tbWFuZC9jb3B5LXdpCiAKIC8vIFNraWEg Y2xpcHBlZCBibHVyIGNoYW5nZSBpbiBwcm9ncmVzcy4KIEJVR1dLNjc3MjQgU0tJUCA6IGZhc3Qv Ym94LXNoYWRvdy9zaGFkb3ctYnVmZmVyLXBhcnRpYWwuaHRtbCA9IFBBU1MgRkFJTAorQlVHV0s2 Nzg0OSBTS0lQIDogZmFzdC9ib3gtc2hhZG93L2luc2V0LWJveC1zaGFkb3ctcmFkaXVzLmh0bWwg PSBQQVNTIEZBSUwKK0JVR1dLNjc4NDkgU0tJUCA6IGZhc3QvYm94LXNoYWRvdy9pbnNldC1ib3gt c2hhZG93cy5odG1sID0gUEFTUyBGQUlMCiAKIC8vIC0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tCiAvLyBXT05URklYIFRFU1RT Cg== 107046 2011-09-12 06:28:22 -0700 2011-09-12 10:44:32 -0700 Patch bug-67849-20110912092821.patch text/plain 1375 bungeman SW5kZXg6IExheW91dFRlc3RzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9D aGFuZ2VMb2cJKHJldmlzaW9uIDk0OTUzKQorKysgTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCSh3b3Jr aW5nIGNvcHkpCkBAIC0xLDMgKzEsMTIgQEAKKzIwMTEtMDktMTIgIEJlbiBXYWduZXIgIDxidW5n ZW1hbkBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgQ2hyb21pdW0gc2hhZG93LWJ1ZmZlci1wYXJ0 aWFsIHRlc3QgY2hhbmdlLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1 Zy5jZ2k/aWQ9Njc4NDkKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKwor ICAgICAgICAqIHBsYXRmb3JtL2Nocm9taXVtL3Rlc3RfZXhwZWN0YXRpb25zLnR4dDoKKwogMjAx MS0wOS0xMiAgS2VudGFybyBIYXJhICA8aGFyYWtlbkBnb29nbGUuY29tPgogCiAgICAgICAgIElt cGxlbWVudCBhIFdlYktpdEFuaW1hdGlvbkV2ZW50IGNvbnN0cnVjdG9yIGZvciBWOApJbmRleDog TGF5b3V0VGVzdHMvcGxhdGZvcm0vY2hyb21pdW0vdGVzdF9leHBlY3RhdGlvbnMudHh0Cj09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT0KLS0tIExheW91dFRlc3RzL3BsYXRmb3JtL2Nocm9taXVtL3Rlc3RfZXhwZWN0YXRpb25z LnR4dAkocmV2aXNpb24gOTQ5NTMpCisrKyBMYXlvdXRUZXN0cy9wbGF0Zm9ybS9jaHJvbWl1bS90 ZXN0X2V4cGVjdGF0aW9ucy50eHQJKHdvcmtpbmcgY29weSkKQEAgLTg5LDcgKzg5LDkgQEAgQlVH Q1IxMDM5NSBTS0lQIDogaHR0cC90ZXN0cy93ZWJhcmNoaXZlIAogQlVHQ1IyMDQwNCA6IGVkaXRp bmcvZXhlY0NvbW1hbmQvY29weS13aXRob3V0LXNlbGVjdGlvbi5odG1sID0gVEVYVAogCiAvLyBT a2lhIGNsaXBwZWQgYmx1ciBjaGFuZ2UgaW4gcHJvZ3Jlc3MuCi1CVUdXSzY3NzI0IFNLSVAgOiBm YXN0L2JveC1zaGFkb3cvc2hhZG93LWJ1ZmZlci1wYXJ0aWFsLmh0bWwgPSBQQVNTIEZBSUwKK0JV R1dLNjc3MjQgOiBmYXN0L2JveC1zaGFkb3cvc2hhZG93LWJ1ZmZlci1wYXJ0aWFsLmh0bWwgPSBQ QVNTIEZBSUwKK0JVR1dLNjc4NDkgOiBmYXN0L2JveC1zaGFkb3cvaW5zZXQtYm94LXNoYWRvdy1y YWRpdXMuaHRtbCA9IFBBU1MgRkFJTAorQlVHV0s2Nzg0OSA6IGZhc3QvYm94LXNoYWRvdy9pbnNl dC1ib3gtc2hhZG93cy5odG1sID0gUEFTUyBGQUlMCiAKIC8vIC0tLS0tLS0tLS0tLS0tLS0tLS0t LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tCiAvLyBXT05URklY IFRFU1RTCg==