67848 2011-09-09 07:50:41 -0700 [chromium] Workaround for String/HashSet/StringHash #include order glitch 2011-09-14 09:28:25 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED WONTFIX P2 Normal --- 1 husky husky husky jamesr kbr nduca oldest_to_newest 464793 0 husky 2011-09-09 07:50:41 -0700 [chromium] Workaround for String/HashSet/StringHash #include order glitch 464794 1 106869 husky 2011-09-09 07:55:42 -0700 Created attachment 106869 Patch 464797 2 husky 2011-09-09 07:56:55 -0700 Kind of a long explanation for a one-line change, but it's bit of a head-scratcher. 464800 3 nduca 2011-09-09 08:13:05 -0700 +kbr who knows this file pretty well. 464810 4 husky 2011-09-09 08:39:42 -0700 Simple version: nobody actually includes StringHash.h! So this doesn't compile: #include <wtf/HashSet.h> #include <wtf/text/WTFString.h> class ScoobyDoo { HashSet<String> scrappy; }; #include <wtf/text/StringHash.h> I think this *does* mean we were using the wrong hash traits. The only core header that includes StringHash.h is WTFThreadData.h, which is why it showed up when I had thread-related code and GraphicsContext3D in the same .cpp file. 465036 5 106869 kbr 2011-09-09 14:48:27 -0700 Comment on attachment 106869 Patch This seems awfully suspicious because there are some files (like Extensions3DChromium.cpp) which compile just fine and include only their header, GraphicsContext3D.h and GraphicsContext3DPrivate.h -- and GraphicsContext3DPrivate.h already includes GraphicsContext3D.h. Could you please continue to investigate the underlying problem rather than committing this workaround, which isn't necessary for the sources currently in the tree? 465038 6 106869 jamesr 2011-09-09 14:50:16 -0700 Comment on attachment 106869 Patch If there's a problem with the string headers, fix the string headers. 465563 7 husky 2011-09-12 04:15:54 -0700 Here's the fix for the string headers: https://bugs.webkit.org/show_bug.cgi?id=67851 465706 8 kbr 2011-09-12 11:51:22 -0700 (In reply to comment #7) > Here's the fix for the string headers: https://bugs.webkit.org/show_bug.cgi?id=67851 Thanks. After looking at the comments on that other bug it seems that there was a deliberate decision to avoid including the hash traits from all files which include WTFString.h. Given that, I think this fix to GraphicsContext3DPrivate.h is the right thing to do. I'll r+ this and you can close the other one as WontFix. 467070 9 husky 2011-09-14 09:28:25 -0700 Obsoleted by https://bugs.webkit.org/show_bug.cgi?id=67851 106869 2011-09-09 07:55:42 -0700 2011-09-12 11:51:29 -0700 Patch bug-67848-20110909155541.patch text/plain 1721 husky SW5kZXg6IFNvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNv dXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCShyZXZpc2lvbiA5NDg1MykKKysrIFNvdXJj ZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMjIg QEAKKzIwMTEtMDktMDkgIElhaW4gTWVycmljayAgPGh1c2t5QGdvb2dsZS5jb20+CisKKyAgICAg ICAgW2Nocm9taXVtXSBXb3JrYXJvdW5kIGZvciBTdHJpbmcvSGFzaFNldC9TdHJpbmdIYXNoICNp bmNsdWRlIG9yZGVyIGdsaXRjaAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93 X2J1Zy5jZ2k/aWQ9Njc4NDgKKworICAgICAgICBHcmFwaGljc0NvbnRleHQzRFByaXZhdGUuaCBo YXMgYSBjb3VwbGUgb2YgaW5saW5lIEhhc2hTZXQ8U3RyaW5nPiBtZW1iZXJzLgorICAgICAgICBJ biBzb21lICNpbmNsdWRlIG9yZGVycywgaXQgc29tZWhvdyBtaXNzZXMgdGhlIHRlbXBsYXRlIHNw ZWNpYWxpemF0aW9uCisgICAgICAgIG9mIEhhc2hUcmFpdHM8U3RyaW5nPiwgd2hpY2ggaXMgaW4g U3RyaW5nSGFzaC5oLiBUaGlzIGNvdWxkIG1lYW4gd2UncmUKKyAgICAgICAgdXNpbmcgYW4gdW5u ZWNlc3NhcmlseSBpbmVmZmljaWVudCBoYXNoIHRhYmxlLiBJIGZvdW5kIHRoaXMgd2hlbgorICAg ICAgICBjb21waWxpbmcgQ0NMYXllclRyZWVIb3N0VGVzdC5jY3AgKGN1cnJlbnRseSAjaWZkZWYn ZCBvdXQpLgorCisgICAgICAgIEl0IHNob3VsZG4ndCBiZSBwb3NzaWJsZSB0byBpbmNsdWRlIHRo ZXNlIGhlYWRlcnMgaW4gdGhlIHdyb25nIG9yZGVyOworICAgICAgICBJJ20gc3RpbGwgdHJhY2tp bmcgZG93biB0aGUgdW5kZXJseWluZyBwcm9ibGVtLiBUaGlzIENMIGFkZHMgYW4gZXh0cmEKKyAg ICAgICAgI2luY2x1ZGUgdG8gR3JhcGhpY3NDb250ZXh0M0RQcml2YXRlLmggdGhhdCB3b3JrcyBh cm91bmQgdGhlIHByb2JsZW0uCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISku CisKKyAgICAgICAgKiBzcmMvR3JhcGhpY3NDb250ZXh0M0RQcml2YXRlLmg6CisKIDIwMTEtMDkt MDkgIE1hcnRpbiBLb3NpYmEgIDxta29zaWJhQGNocm9taXVtLm9yZz4KIAogICAgICAgICBFeHBv c2luZyB0aGUgaXNMaW5rIG1ldGhvZCBvbiBXZWJOb2RlIGZvciB0aGUgQ2hyb21pdW0gcG9ydCBv biBBbmRyb2lkLgpJbmRleDogU291cmNlL1dlYktpdC9jaHJvbWl1bS9zcmMvR3JhcGhpY3NDb250 ZXh0M0RQcml2YXRlLmgKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYktpdC9jaHJvbWl1bS9zcmMv R3JhcGhpY3NDb250ZXh0M0RQcml2YXRlLmgJKHJldmlzaW9uIDk0ODUxKQorKysgU291cmNlL1dl YktpdC9jaHJvbWl1bS9zcmMvR3JhcGhpY3NDb250ZXh0M0RQcml2YXRlLmgJKHdvcmtpbmcgY29w eSkKQEAgLTMxLDYgKzMxLDcgQEAKICNpbmNsdWRlIDx3dGYvSGFzaFNldC5oPgogI2luY2x1ZGUg PHd0Zi9Pd25BcnJheVB0ci5oPgogI2luY2x1ZGUgPHd0Zi9Pd25QdHIuaD4KKyNpbmNsdWRlIDx3 dGYvdGV4dC9TdHJpbmdIYXNoLmg+CiAjaWYgVVNFKFNLSUEpCiAjaW5jbHVkZSAiU2tCaXRtYXAu aCIKICNlbmRpZgo=