67837 2011-09-09 03:28:46 -0700 Web Inspector: [Chromium] Valgrind signals use of uninitialized field in InspectorStyleSheetForInlineStyle 2011-09-20 09:56:20 -0700 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 apavlov apavlov apavlov bweinstein joepeck keishi loislo pfeldman pmuellr rik timothy yurys oldest_to_newest 464708 0 apavlov 2011-09-09 03:28:46 -0700 m_isStyleTextValid is not initialized in the ctor and seemingly results in valgrind errors. Upstreaming http://crbug.com/87380 464713 1 apavlov 2011-09-09 03:40:29 -0700 Committed r94844: <http://trac.webkit.org/changeset/94844> 465713 2 joepeck 2011-09-12 11:59:34 -0700 Good catch and fix. I just happened to open up the bug and see no attached patch but a committed changeset. I think maybe this change should still have had a reviewer (even simple, non-build issues typically have reviews) but certainly a ChangeLog. In either case keep up the good fixes! 466171 3 apavlov 2011-09-13 00:23:51 -0700 (In reply to comment #2) > Good catch and fix. > > I just happened to open up the bug and see no attached patch but a committed > changeset. I think maybe this change should still have had a reviewer (even > simple, non-build issues typically have reviews) but certainly a ChangeLog. > In either case keep up the good fixes! Well, the change seemed trivial, so Pavel who was on vacation and was having difficulties doing the actual review (i.e. setting r+), said that it could surely be committed unreviewed (even though the change had a reviewer de facto, and there were no other reviewers around). I'll do my best finding a real reviewer from now on. 466329 4 joepeck 2011-09-13 09:27:34 -0700 It wasn't so much the review (I trust your judgement with the small change) it was the Missing ChangeLog that I wanted to call out. Either way thanks for the explanation! 466332 5 joepeck 2011-09-13 09:29:46 -0700 Also changes like this are easy to get a quick review from someone in #webkit if you need one. Or people like Darin are always checking the list of patches for review and might review without even being CC'd! 470126 6 joepeck 2011-09-20 09:56:20 -0700 (In reply to comment #4) > It wasn't so much the review (I trust your judgement with the small change) > it was the Missing ChangeLog that I wanted to call out. Either way thanks > for the explanation! As you rightly pointed out, there was a ChangeLog. I don't know how I missed that =(. Thanks for following up.