67835 2011-09-09 01:38:00 -0700 [NRWT] the nrwt check httpd with --no-http option 2011-09-09 11:02:21 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 67847 1 kkristof webkit-unassigned dpranke ossy tony webkit.review.bot oldest_to_newest 464687 0 kkristof 2011-09-09 01:38:00 -0700 $ Tools/Scripts/new-run-webkit-tests --platform=qt --no-http Could not find apache. Not installed or unknown path. Traceback (most recent call last): File "/home/kosztyo/WebKit/Tools/Scripts/webkitpy/layout_tests/run_webkit_tests.py", line 440, in <module> sys.exit(main()) File "/home/kosztyo/WebKit/Tools/Scripts/webkitpy/layout_tests/run_webkit_tests.py", line 435, in main return run(port, options, args) File "/home/kosztyo/WebKit/Tools/Scripts/webkitpy/layout_tests/run_webkit_tests.py", line 105, in run result_summary = manager.set_up_run() File "/home/kosztyo/WebKit/Tools/Scripts/webkitpy/layout_tests/controllers/manager.py", line 838, in set_up_run if not self._port.check_sys_deps(self.needs_servers()): File "/home/kosztyo/WebKit/Tools/Scripts/webkitpy/layout_tests/port/base.py", line 192, in check_sys_deps return self.check_httpd() File "/home/kosztyo/WebKit/Tools/Scripts/webkitpy/layout_tests/port/base.py", line 239, in check_httpd server_name = self._filesystem.basename(httpd_path) File "/home/kosztyo/WebKit/Tools/Scripts/webkitpy/common/system/filesystem.py", line 71, in basename return os.path.basename(path) File "/usr/lib/python2.6/posixpath.py", line 111, in basename i = p.rfind('/') + 1 AttributeError: 'NoneType' object has no attribute 'rfind' 464688 1 106850 kkristof 2011-09-09 01:41:50 -0700 Created attachment 106850 proposed fix 464756 2 106850 ossy 2011-09-09 06:03:26 -0700 Comment on attachment 106850 proposed fix Nice catch, r=me. 464757 3 ossy 2011-09-09 06:04:51 -0700 Unfortunately I got same error message without --no-http if I don't have apache. Could you file another bug report about it? It would be better if NRWT exits with a nicer mode. 464758 4 106850 ossy 2011-09-09 06:07:08 -0700 Comment on attachment 106850 proposed fix Clearing flags on attachment: 106850 Committed r94851: <http://trac.webkit.org/changeset/94851> 464759 5 ossy 2011-09-09 06:07:15 -0700 All reviewed patches have been landed. Closing bug. 464773 6 ossy 2011-09-09 07:08:05 -0700 It broke a unittest: Traceback (most recent call last): File "/ramdisk/qt-linux-release/build/Tools/Scripts/webkitpy/layout_tests/controllers/manager_unittest.py", line 239, in test_needs_servers self.assertTrue(manager.needs_servers()) File "/ramdisk/qt-linux-release/build/Tools/Scripts/webkitpy/layout_tests/controllers/manager.py", line 820, in needs_servers return any(self._test_requires_lock(test_name) for test_name in self._test_files) and self._options.http AttributeError: 'MockOptions' object has no attribute 'http' 464776 7 106867 kkristof 2011-09-09 07:25:23 -0700 Created attachment 106867 fix for the test-webkitpy 464783 8 106867 ossy 2011-09-09 07:38:36 -0700 Comment on attachment 106867 fix for the test-webkitpy Argh, it is an ugly hack. :-/ We should find a proper fix for it. 464787 9 ossy 2011-09-09 07:41:40 -0700 Dirk, Tony, could you give us some hint how should we fix this webkitpy test in a proper way? 464792 10 ossy 2011-09-09 07:49:41 -0700 Original patch was rolled out by http://trac.webkit.org/changeset/94853 464796 11 106871 kkristof 2011-09-09 07:56:19 -0700 Created attachment 106871 proposed fix Indeed it was an ugly hack, maybe this will be better. 464904 12 106871 webkit.review.bot 2011-09-09 10:59:17 -0700 Comment on attachment 106871 proposed fix Clearing flags on attachment: 106871 Committed r94863: <http://trac.webkit.org/changeset/94863> 464905 13 webkit.review.bot 2011-09-09 10:59:22 -0700 All reviewed patches have been landed. Closing bug. 464907 14 106871 dpranke 2011-09-09 11:02:21 -0700 Comment on attachment 106871 proposed fix Hm. Ideally you'd pass in the http flag to get_manager_with_tests and add a third test to make sure that the right thing happens with http=False as well. 106850 2011-09-09 01:41:50 -0700 2011-09-09 07:26:20 -0700 proposed fix 9.patch text/plain 1311 kkristof ZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBiL1Rvb2xzL0NoYW5nZUxvZwppbmRleCAwYTNj YWMyLi45NTdkZGVhIDEwMDY0NAotLS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIvVG9vbHMvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMTIgQEAKKzIwMTEtMDktMDkgIEtyaXN0w7NmIEtvc3p0ecOzICA8 a2tyaXN0b2ZAaW5mLnUtc3plZ2VkLmh1PgorCisgICAgICAgIFtOUldUXSB0aGUgbnJ3dCBjaGVj ayBodHRwZCB3aXRoIC0tbm8taHR0cCBvcHRpb24KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtp dC5vcmcvc2hvd19idWcuY2dpP2lkPTY3ODM1CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZ IChPT1BTISkuCisKKyAgICAgICAgKiBTY3JpcHRzL3dlYmtpdHB5L2xheW91dF90ZXN0cy9jb250 cm9sbGVycy9tYW5hZ2VyLnB5OgorCiAyMDExLTA5LTA4ICBCcmlhbiBXZWluc3RlaW4gIDxid2Vp bnN0ZWluQGFwcGxlLmNvbT4KIAogICAgICAgICBXZWJLaXQyOiBBc3NlcnRpb24gd2hlbiBjYWxs aW5nIGRpZFBlcmZvcm0qUmVkaXJlY3Qgb24gbnVsbCBzb3VyY2UvZGVzdGluYXRpb24gVVJMIHN0 cmluZwpkaWZmIC0tZ2l0IGEvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9sYXlvdXRfdGVzdHMvY29u dHJvbGxlcnMvbWFuYWdlci5weSBiL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvbGF5b3V0X3Rlc3Rz L2NvbnRyb2xsZXJzL21hbmFnZXIucHkKaW5kZXggN2FjZGVjMy4uMDEwZWMzNiAxMDA2NDQKLS0t IGEvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9sYXlvdXRfdGVzdHMvY29udHJvbGxlcnMvbWFuYWdl ci5weQorKysgYi9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L2xheW91dF90ZXN0cy9jb250cm9sbGVy cy9tYW5hZ2VyLnB5CkBAIC04MTcsNyArODE3LDggQEAgY2xhc3MgTWFuYWdlcihvYmplY3QpOgog ICAgICAgICByZXR1cm4gKHRocmVhZF90aW1pbmdzLCB0ZXN0X3RpbWluZ3MsIGluZGl2aWR1YWxf dGVzdF90aW1pbmdzKQogCiAgICAgZGVmIG5lZWRzX3NlcnZlcnMoc2VsZik6Ci0gICAgICAgIHJl dHVybiBhbnkoc2VsZi5fdGVzdF9yZXF1aXJlc19sb2NrKHRlc3RfbmFtZSkgZm9yIHRlc3RfbmFt ZSBpbiBzZWxmLl90ZXN0X2ZpbGVzKQorICAgICAgICByZXR1cm4gYW55KHNlbGYuX3Rlc3RfcmVx dWlyZXNfbG9jayh0ZXN0X25hbWUpIGZvciB0ZXN0X25hbWUgaW4gc2VsZi5fdGVzdF9maWxlcykg YW5kIHNlbGYuX29wdGlvbnMuaHR0cAorCiAKICAgICBkZWYgc2V0X3VwX3J1bihzZWxmKToKICAg ICAgICAgIiIiQ29uZmlndXJlcyB0aGUgc3lzdGVtIHRvIGJlIHJlYWR5IHRvIHJ1biB0ZXN0cy4K 106867 2011-09-09 07:25:23 -0700 2011-09-09 07:56:19 -0700 fix for the test-webkitpy 9fix.patch text/plain 1478 kkristof ZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBiL1Rvb2xzL0NoYW5nZUxvZwppbmRleCAyYzU4 MDQyLi42YTkzZmY0IDEwMDY0NAotLS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIvVG9vbHMvQ2hh bmdlTG9nCkBAIC0zLDYgKzMsMTcgQEAKICAgICAgICAgW05SV1RdIHRoZSBucnd0IGNoZWNrIGh0 dHBkIHdpdGggLS1uby1odHRwIG9wdGlvbgogICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9y Zy9zaG93X2J1Zy5jZ2k/aWQ9Njc4MzUKIAorICAgICAgICBGaXggZm9yIHRoZSB0ZXN0LXdlYmtp dHB5CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBT Y3JpcHRzL3dlYmtpdHB5L2xheW91dF90ZXN0cy9jb250cm9sbGVycy9tYW5hZ2VyLnB5OgorCisy MDExLTA5LTA5ICBLcmlzdMOzZiBLb3N6dHnDsyAgPGtrcmlzdG9mQGluZi51LXN6ZWdlZC5odT4K KworICAgICAgICBbTlJXVF0gdGhlIG5yd3QgY2hlY2sgaHR0cGQgd2l0aCAtLW5vLWh0dHAgb3B0 aW9uCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD02Nzgz NQorCiAgICAgICAgIFJldmlld2VkIGJ5IENzYWJhIE9zenRyb2dvbsOhYy4KIAogICAgICAgICAq IFNjcmlwdHMvd2Via2l0cHkvbGF5b3V0X3Rlc3RzL2NvbnRyb2xsZXJzL21hbmFnZXIucHk6CmRp ZmYgLS1naXQgYS9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L2xheW91dF90ZXN0cy9jb250cm9sbGVy cy9tYW5hZ2VyLnB5IGIvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9sYXlvdXRfdGVzdHMvY29udHJv bGxlcnMvbWFuYWdlci5weQppbmRleCAwMTBlYzM2Li41MzA2YWMxIDEwMDY0NAotLS0gYS9Ub29s cy9TY3JpcHRzL3dlYmtpdHB5L2xheW91dF90ZXN0cy9jb250cm9sbGVycy9tYW5hZ2VyLnB5Cisr KyBiL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvbGF5b3V0X3Rlc3RzL2NvbnRyb2xsZXJzL21hbmFn ZXIucHkKQEAgLTgxNyw3ICs4MTcsMTEgQEAgY2xhc3MgTWFuYWdlcihvYmplY3QpOgogICAgICAg ICByZXR1cm4gKHRocmVhZF90aW1pbmdzLCB0ZXN0X3RpbWluZ3MsIGluZGl2aWR1YWxfdGVzdF90 aW1pbmdzKQogCiAgICAgZGVmIG5lZWRzX3NlcnZlcnMoc2VsZik6Ci0gICAgICAgIHJldHVybiBh bnkoc2VsZi5fdGVzdF9yZXF1aXJlc19sb2NrKHRlc3RfbmFtZSkgZm9yIHRlc3RfbmFtZSBpbiBz ZWxmLl90ZXN0X2ZpbGVzKSBhbmQgc2VsZi5fb3B0aW9ucy5odHRwCisgICAgICAgIHRyeToKKyAg ICAgICAgICAgIGh0dHAgPSBzZWxmLl9vcHRpb25zLmh0dHAKKyAgICAgICAgZXhjZXB0IEF0dHJp YnV0ZUVycm9yOgorICAgICAgICAgICAgaHR0cCA9IFRydWUKKyAgICAgICAgcmV0dXJuIGFueShz ZWxmLl90ZXN0X3JlcXVpcmVzX2xvY2sodGVzdF9uYW1lKSBmb3IgdGVzdF9uYW1lIGluIHNlbGYu X3Rlc3RfZmlsZXMpIGFuZCBodHRwCiAKIAogICAgIGRlZiBzZXRfdXBfcnVuKHNlbGYpOgo= 106871 2011-09-09 07:56:19 -0700 2011-09-09 11:02:21 -0700 proposed fix 9fix2.patch text/plain 2592 kkristof ZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBiL1Rvb2xzL0NoYW5nZUxvZwppbmRleCBhMWMy YjlmLi43ZWVjMjA2IDEwMDY0NAotLS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIvVG9vbHMvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMTMgQEAKKzIwMTEtMDktMDkgIEtyaXN0w7NmIEtvc3p0ecOzICA8 a2tyaXN0b2ZAaW5mLnUtc3plZ2VkLmh1PgorCisgICAgICAgIFtOUldUXSB0aGUgbnJ3dCBjaGVj ayBodHRwZCB3aXRoIC0tbm8taHR0cCBvcHRpb24KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtp dC5vcmcvc2hvd19idWcuY2dpP2lkPTY3ODM1CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZ IChPT1BTISkuCisKKyAgICAgICAgKiBTY3JpcHRzL3dlYmtpdHB5L2xheW91dF90ZXN0cy9jb250 cm9sbGVycy9tYW5hZ2VyLnB5OgorICAgICAgICAqIFNjcmlwdHMvd2Via2l0cHkvbGF5b3V0X3Rl c3RzL2NvbnRyb2xsZXJzL21hbmFnZXJfdW5pdHRlc3QucHk6CisKIDIwMTEtMDktMDkgIFNoZXJp ZmYgQm90ICA8d2Via2l0LnJldmlldy5ib3RAZ21haWwuY29tPgogCiAgICAgICAgIFVucmV2aWV3 ZWQsIHJvbGxpbmcgb3V0IHI5NDg1MS4KZGlmZiAtLWdpdCBhL1Rvb2xzL1NjcmlwdHMvd2Via2l0 cHkvbGF5b3V0X3Rlc3RzL2NvbnRyb2xsZXJzL21hbmFnZXIucHkgYi9Ub29scy9TY3JpcHRzL3dl YmtpdHB5L2xheW91dF90ZXN0cy9jb250cm9sbGVycy9tYW5hZ2VyLnB5CmluZGV4IDdhY2RlYzMu LmI0MDJjNDMgMTAwNjQ0Ci0tLSBhL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvbGF5b3V0X3Rlc3Rz L2NvbnRyb2xsZXJzL21hbmFnZXIucHkKKysrIGIvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9sYXlv dXRfdGVzdHMvY29udHJvbGxlcnMvbWFuYWdlci5weQpAQCAtODE3LDcgKzgxNyw3IEBAIGNsYXNz IE1hbmFnZXIob2JqZWN0KToKICAgICAgICAgcmV0dXJuICh0aHJlYWRfdGltaW5ncywgdGVzdF90 aW1pbmdzLCBpbmRpdmlkdWFsX3Rlc3RfdGltaW5ncykKIAogICAgIGRlZiBuZWVkc19zZXJ2ZXJz KHNlbGYpOgotICAgICAgICByZXR1cm4gYW55KHNlbGYuX3Rlc3RfcmVxdWlyZXNfbG9jayh0ZXN0 X25hbWUpIGZvciB0ZXN0X25hbWUgaW4gc2VsZi5fdGVzdF9maWxlcykKKyAgICAgICAgcmV0dXJu IGFueShzZWxmLl90ZXN0X3JlcXVpcmVzX2xvY2sodGVzdF9uYW1lKSBmb3IgdGVzdF9uYW1lIGlu IHNlbGYuX3Rlc3RfZmlsZXMpIGFuZCBzZWxmLl9vcHRpb25zLmh0dHAKIAogICAgIGRlZiBzZXRf dXBfcnVuKHNlbGYpOgogICAgICAgICAiIiJDb25maWd1cmVzIHRoZSBzeXN0ZW0gdG8gYmUgcmVh ZHkgdG8gcnVuIHRlc3RzLgpkaWZmIC0tZ2l0IGEvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9sYXlv dXRfdGVzdHMvY29udHJvbGxlcnMvbWFuYWdlcl91bml0dGVzdC5weSBiL1Rvb2xzL1NjcmlwdHMv d2Via2l0cHkvbGF5b3V0X3Rlc3RzL2NvbnRyb2xsZXJzL21hbmFnZXJfdW5pdHRlc3QucHkKaW5k ZXggZjI4MDE2NC4uOTJlNDkwYSAxMDA2NDQKLS0tIGEvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9s YXlvdXRfdGVzdHMvY29udHJvbGxlcnMvbWFuYWdlcl91bml0dGVzdC5weQorKysgYi9Ub29scy9T Y3JpcHRzL3dlYmtpdHB5L2xheW91dF90ZXN0cy9jb250cm9sbGVycy9tYW5hZ2VyX3VuaXR0ZXN0 LnB5CkBAIC0yMjcsNyArMjI3LDcgQEAgY2xhc3MgTWFuYWdlclRlc3QodW5pdHRlc3QuVGVzdENh c2UpOgogICAgICAgICBkZWYgZ2V0X21hbmFnZXJfd2l0aF90ZXN0cyh0ZXN0X25hbWVzKToKICAg ICAgICAgICAgIHBvcnQgPSBNb2NrKCkKICAgICAgICAgICAgIHBvcnQuVEVTVF9QQVRIX1NFUEFS QVRPUiA9ICcvJwotICAgICAgICAgICAgbWFuYWdlciA9IE1hbmFnZXIocG9ydCwgb3B0aW9ucz1N b2NrT3B0aW9ucygpLCBwcmludGVyPU1vY2soKSkKKyAgICAgICAgICAgIG1hbmFnZXIgPSBNYW5h Z2VyKHBvcnQsIG9wdGlvbnM9TW9ja09wdGlvbnMoaHR0cD1UcnVlKSwgcHJpbnRlcj1Nb2NrKCkp CiAgICAgICAgICAgICBtYW5hZ2VyLl90ZXN0X2ZpbGVzID0gc2V0KHRlc3RfbmFtZXMpCiAgICAg ICAgICAgICBtYW5hZ2VyLl90ZXN0X2ZpbGVzX2xpc3QgPSB0ZXN0X25hbWVzCiAgICAgICAgICAg ICByZXR1cm4gbWFuYWdlcgpAQCAtMjQxLDcgKzI0MSw3IEBAIGNsYXNzIE1hbmFnZXJUZXN0KHVu aXR0ZXN0LlRlc3RDYXNlKToKICAgICBkZWYgaW50ZWdyYXRpb25fdGVzdF9uZWVkc19zZXJ2ZXJz KHNlbGYpOgogICAgICAgICBkZWYgZ2V0X21hbmFnZXJfd2l0aF90ZXN0cyh0ZXN0X25hbWVzKToK ICAgICAgICAgICAgIHBvcnQgPSBsYXlvdXRfdGVzdHMucG9ydC5nZXQoKQotICAgICAgICAgICAg bWFuYWdlciA9IE1hbmFnZXIocG9ydCwgb3B0aW9ucz1Nb2NrT3B0aW9ucyh0ZXN0X2xpc3Q9Tm9u ZSksIHByaW50ZXI9TW9jaygpKQorICAgICAgICAgICAgbWFuYWdlciA9IE1hbmFnZXIocG9ydCwg b3B0aW9ucz1Nb2NrT3B0aW9ucyh0ZXN0X2xpc3Q9Tm9uZSwgaHR0cD1UcnVlKSwgcHJpbnRlcj1N b2NrKCkpCiAgICAgICAgICAgICBtYW5hZ2VyLmNvbGxlY3RfdGVzdHModGVzdF9uYW1lcykKICAg ICAgICAgICAgIHJldHVybiBtYW5hZ2VyCiAK