67829 2011-09-08 20:27:37 -0700 REGRESSION(r94811): Assertion failure in 2 worker tests 2011-09-08 23:06:20 -0700 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P1 Normal --- 1 rniwa mhahnenberg aroben barraclough ggaren mhahnenberg oliver sam xan.lopez oldest_to_newest 464611 0 rniwa 2011-09-08 20:27:37 -0700 The following 2 tests started hitting an assertion. fast/workers/worker-close-more.html fast/workers/use-machine-stack.html 464612 1 rniwa 2011-09-08 20:27:42 -0700 http://build.webkit.org/results/SnowLeopard%20Intel%20Debug%20(Tests)/r94823%20(2063)/results.html 464613 2 rniwa 2011-09-08 20:27:49 -0700 http://build.webkit.org/builders/SnowLeopard%20Intel%20Debug%20%28Tests%29/builds/2061 464614 3 rniwa 2011-09-08 20:29:32 -0700 Same failure on GTK+: http://build.webkit.org/results/GTK%20Linux%2064-bit%20Debug/r94828%20(25869)/results.html and Windows: http://build.webkit.org/results/Windows%20XP%20Debug%20(Tests)/r94825%20(31981)/results.html 464616 4 rniwa 2011-09-08 20:33:53 -0700 Oops, I mistook build numbers for revision numbers. 464637 5 rniwa 2011-09-08 21:32:52 -0700 I manually bisected and determined r94811 to be the cause. 464642 6 sam 2011-09-08 21:59:47 -0700 Looks like it is a missing &Base::s_info in exception classes I added. Mark H. is going to land a fix for me. 464643 7 106840 mhahnenberg 2011-09-08 22:03:40 -0700 Created attachment 106840 Patch 464644 8 sam 2011-09-08 22:04:58 -0700 Thanks Mark! 464657 9 rniwa 2011-09-08 22:52:30 -0700 I have confirmed that this patch works and passes all the layout tests. Thanks Mark! 464662 10 106840 rniwa 2011-09-08 23:06:16 -0700 Comment on attachment 106840 Patch Clearing flags on attachment: 106840 Committed r94835: <http://trac.webkit.org/changeset/94835> 464663 11 rniwa 2011-09-08 23:06:20 -0700 All reviewed patches have been landed. Closing bug. 106840 2011-09-08 22:03:40 -0700 2011-09-08 23:06:16 -0700 Patch bug-67829-20110908220332.patch text/plain 1839 mhahnenberg U3VidmVyc2lvbiBSZXZpc2lvbjogOTQ4MjgKZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0 Q29yZS9DaGFuZ2VMb2cgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nCmluZGV4IDgz MGRlZGMwMGEzN2ZjNGVjOGI1NzUwNWYzYmQwODM5ZDU4YTYwMDQuLjA5MTZhMDMxZGIwZDNkOTZj ZmIyZmEyZmRmNDhlYTZlNGNiZWIxMmUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9KYXZhU2NyaXB0Q29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwpAQCAtMSwz ICsxLDE2IEBACisyMDExLTA5LTA4ICBNYXJrIEhhaG5lbmJlcmcgIDxtaGFobmVuYmVyZ0BhcHBs ZS5jb20+CisKKyAgICAgICAgUkVHUkVTU0lPTihyOTQ4MTEpOiBBc3NlcnRpb24gZmFpbHVyZSBp biAyIHdvcmtlciB0ZXN0cworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1 Zy5jZ2k/aWQ9Njc4MjkKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKwor ICAgICAgICBGaXhpbmcgYSBjb3VwbGUgdGVzdHMgdGhhdCB3ZXJlIGJyb2tlbiBkdWUgdG8gdGhl IHdyb25nIHZhbHVlcyBiZWluZyAKKyAgICAgICAgc2V0IGluIHRoZSBwYXJlbnQgY2xhc3MgcG9p bnRlcnMgaW4gdGhlIENsYXNzSW5mbyBzdHJ1Y3RzIGZvciAKKyAgICAgICAgVGVybWluYXRlZEV4 ZWN1dGlvbkVycm9yIGFuZCBJbnRlcnJ1cHRlZEV4ZWN1dGlvbkVycm9yLgorCisgICAgICAgICog cnVudGltZS9FeGNlcHRpb25IZWxwZXJzLmNwcDoKKwogMjAxMS0wOS0wOCAgT2xpdmVyIEh1bnQg IDxvbGl2ZXJAYXBwbGUuY29tPgogCiAgICAgICAgIFVzZSBidW1wIGFsbG9jYXRvciBmb3IgaW5p dGlhbCBwcm9wZXJ0eSBzdG9yYWdlCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUv cnVudGltZS9FeGNlcHRpb25IZWxwZXJzLmNwcCBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9ydW50 aW1lL0V4Y2VwdGlvbkhlbHBlcnMuY3BwCmluZGV4IDEwYzMzM2Q5YmZjZjEwOTdhODJiMTQ4ZWQz OWQ1NWYzMDNkMGU0MTMuLmU0NWVjYzQ5NDkzOWEzZTY4YWY5OTllNGI4OTE4N2FhMTc5OWFlODQg MTAwNjQ0Ci0tLSBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1lL0V4Y2VwdGlvbkhlbHBl cnMuY3BwCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1lL0V4Y2VwdGlvbkhlbHBl cnMuY3BwCkBAIC00MSwxNCArNDEsMTQgQEAKIAogbmFtZXNwYWNlIEpTQyB7CiAKLWNvbnN0IENs YXNzSW5mbyBJbnRlcnJ1cHRlZEV4ZWN1dGlvbkVycm9yOjpzX2luZm8gPSB7ICJJbnRlcnJ1cHRl ZEV4ZWN1dGlvbkVycm9yIiwgMCwgMCwgMCB9OworY29uc3QgQ2xhc3NJbmZvIEludGVycnVwdGVk RXhlY3V0aW9uRXJyb3I6OnNfaW5mbyA9IHsgIkludGVycnVwdGVkRXhlY3V0aW9uRXJyb3IiLCAm QmFzZTo6c19pbmZvLCAwLCAwIH07CiAKIFVTdHJpbmcgSW50ZXJydXB0ZWRFeGVjdXRpb25FcnJv cjo6dG9TdHJpbmcoRXhlY1N0YXRlKikgY29uc3QKIHsKICAgICByZXR1cm4gIkphdmFTY3JpcHQg ZXhlY3V0aW9uIGV4Y2VlZGVkIHRpbWVvdXQuIjsKIH0KIAotY29uc3QgQ2xhc3NJbmZvIFRlcm1p bmF0ZWRFeGVjdXRpb25FcnJvcjo6c19pbmZvID0geyAiVGVybWluYXRlZEV4ZWN1dGlvbkVycm9y IiwgMCwgMCwgMCB9OworY29uc3QgQ2xhc3NJbmZvIFRlcm1pbmF0ZWRFeGVjdXRpb25FcnJvcjo6 c19pbmZvID0geyAiVGVybWluYXRlZEV4ZWN1dGlvbkVycm9yIiwgJkJhc2U6OnNfaW5mbywgMCwg MCB9OwogCiBVU3RyaW5nIFRlcm1pbmF0ZWRFeGVjdXRpb25FcnJvcjo6dG9TdHJpbmcoRXhlY1N0 YXRlKikgY29uc3QKIHsK