67816 2011-09-08 16:12:40 -0700 [chromium] REGRESSION(94353): Compositor textures and resources leaked when tab closed that is not last tab in the process 2011-09-12 10:51:55 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 jamesr jamesr enne kbr nduca senorblanco vangelis oldest_to_newest 464471 0 jamesr 2011-09-08 16:12:40 -0700 [chromium] REGRESSION(94353): Compositor textures and resources leaked when tab closed that is not last tab in the process 464472 1 106810 jamesr 2011-09-08 16:13:15 -0700 Created attachment 106810 Patch 464473 2 jamesr 2011-09-08 16:14:16 -0700 This fixes the leak, but I really really really want to get some automated tests for this before landed. I left the OOPS! in the changelog to remind myself. I've fixed this bug twice and don't really want to have to do it again :/ 464475 3 jamesr 2011-09-08 16:15:53 -0700 Note that this is another sign that https://bugs.webkit.org/show_bug.cgi?id=66995 is something we need, the problem here is our overuse of RefPtr<>s which needs lots of manual cleanup. 465338 4 106810 kbr 2011-09-10 15:12:07 -0700 Comment on attachment 106810 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=106810&action=review Looks fine to me. ChangeLog needs a small cleanup before landing. > Source/WebCore/ChangeLog:8 > + No new tests. (OOPS!) That OOPS needs to be removed. 465673 5 jamesr 2011-09-12 10:47:33 -0700 Thanks Ken. We need this patch for 15 so I'll clean up the ChangeLog and continue to work on testing infrastructure. 465677 6 jamesr 2011-09-12 10:51:55 -0700 Committed r94964: <http://trac.webkit.org/changeset/94964> 106810 2011-09-08 16:13:15 -0700 2011-09-10 15:12:07 -0700 Patch bug-67816-20110908161314.patch text/plain 5551 jamesr U3VidmVyc2lvbiBSZXZpc2lvbjogOTQ3MzgKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCA5ZDI0N2QzYTM3YTE5YTlk ZjRmODNiNjI5ZGE0ODNkMDM0ODdlYmRhLi5mZWRkOGQ0YzM2ZjBkYzEzZDY5MDBjYzc0NDJlZjdh YWExNmQ1MTRiIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvU291 cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjIgQEAKKzIwMTEtMDktMDggIEphbWVz IFJvYmluc29uICA8amFtZXNyQGNocm9taXVtLm9yZz4KKworICAgICAgICBbY2hyb21pdW1dIFJF R1JFU1NJT04oOTQzNTMpOiBDb21wb3NpdG9yIHRleHR1cmVzIGFuZCByZXNvdXJjZXMgbGVha2Vk IHdoZW4gdGFiIGNsb3NlZCB0aGF0IGlzIG5vdCBsYXN0IHRhYiBpbiB0aGUgcHJvY2VzcworICAg ICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9Njc4MTYKKworICAg ICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBObyBuZXcgdGVzdHMu IChPT1BTISkKKworICAgICAgICAqIHBsYXRmb3JtL2dyYXBoaWNzL2Nocm9taXVtL0xheWVyQ2hy b21pdW0uaDoKKyAgICAgICAgKiBwbGF0Zm9ybS9ncmFwaGljcy9jaHJvbWl1bS9UaWxlZExheWVy Q2hyb21pdW0uY3BwOgorICAgICAgICAoV2ViQ29yZTo6VGlsZWRMYXllckNocm9taXVtOjpzZXRM YXllclRyZWVIb3N0KToKKyAgICAgICAgKiBwbGF0Zm9ybS9ncmFwaGljcy9jaHJvbWl1bS9WaWRl b0xheWVyQ2hyb21pdW0uY3BwOgorICAgICAgICAoV2ViQ29yZTo6VmlkZW9MYXllckNocm9taXVt OjpzZXRMYXllclRyZWVIb3N0KToKKyAgICAgICAgKiBwbGF0Zm9ybS9ncmFwaGljcy9jaHJvbWl1 bS9jYy9DQ0xheWVyVHJlZUhvc3QuY3BwOgorICAgICAgICAoV2ViQ29yZTo6Q0NMYXllclRyZWVI b3N0OjpjbGVhclJlbmRlclN1cmZhY2VzUmVjdXJzaXZlKToKKyAgICAgICAgKFdlYkNvcmU6OkND TGF5ZXJUcmVlSG9zdDo6c2V0Um9vdExheWVyKToKKyAgICAgICAgKiBwbGF0Zm9ybS9ncmFwaGlj cy9jaHJvbWl1bS9jYy9DQ0xheWVyVHJlZUhvc3QuaDoKKwogMjAxMS0wOS0wNyAgRGFuIEJlcm5z dGVpbiAgPG1pdHpAYXBwbGUuY29tPgogCiAgICAgICAgIFJlbW92ZWQgaHlwaGVuYXRpb24gZnVu Y3Rpb24gaW1wbGVtZW50YXRpb25zIGZvciBhbiB1c3VwcG9ydGVkIGJ1aWxkIGNvbmZpZ3VyYXRp b24uCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9jaHJvbWl1 bS9MYXllckNocm9taXVtLmggYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9jaHJv bWl1bS9MYXllckNocm9taXVtLmgKaW5kZXggYjZhZmM2ZmQ0ZjFmZTdjMmQzNjllY2Q2OGNjZTdh YmY0NTJjYmFiNC4uOGQzMGQ3ZDQ0NWExMWY0YTY2ZWU2MTU0YmNhMzMwNTMzMmJkMzg0NyAxMDA2 NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvY2hyb21pdW0vTGF5ZXJD aHJvbWl1bS5oCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2Nocm9taXVt L0xheWVyQ2hyb21pdW0uaApAQCAtMjA3LDcgKzIwNyw3IEBAIHB1YmxpYzoKICAgICBib29sIGRl c2NlbmRhbnREcmF3c0NvbnRlbnQoKTsKIAogICAgIENDTGF5ZXJUcmVlSG9zdCogbGF5ZXJUcmVl SG9zdCgpIGNvbnN0IHsgcmV0dXJuIG1fbGF5ZXJUcmVlSG9zdC5nZXQoKTsgfQotICAgIHZpcnR1 YWwgdm9pZCBjbGVhbnVwUmVzb3VyY2VzUmVjdXJzaXZlKCk7CisgICAgdm9pZCBjbGVhbnVwUmVz b3VyY2VzUmVjdXJzaXZlKCk7CiAKIHByb3RlY3RlZDoKICAgICBHcmFwaGljc0xheWVyQ2hyb21p dW0qIG1fb3duZXI7CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGlj cy9jaHJvbWl1bS9UaWxlZExheWVyQ2hyb21pdW0uY3BwIGIvU291cmNlL1dlYkNvcmUvcGxhdGZv cm0vZ3JhcGhpY3MvY2hyb21pdW0vVGlsZWRMYXllckNocm9taXVtLmNwcAppbmRleCBjOTFkYmE3 YzQzOTEyYWNkZTNmN2UwMDE1ZTVhNGIwMGM5ZDM3ZTlhLi5kZGVmZmU3MjgyNDI5NzE1MTIzMzY4 MjQ5NjFkNmIzZWRhNTIyOThlIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9n cmFwaGljcy9jaHJvbWl1bS9UaWxlZExheWVyQ2hyb21pdW0uY3BwCisrKyBiL1NvdXJjZS9XZWJD b3JlL3BsYXRmb3JtL2dyYXBoaWNzL2Nocm9taXVtL1RpbGVkTGF5ZXJDaHJvbWl1bS5jcHAKQEAg LTEzOCw3ICsxMzgsNyBAQCB2b2lkIFRpbGVkTGF5ZXJDaHJvbWl1bTo6c2V0TGF5ZXJUcmVlSG9z dChDQ0xheWVyVHJlZUhvc3QqIGhvc3QpCiB7CiAgICAgTGF5ZXJDaHJvbWl1bTo6c2V0TGF5ZXJU cmVlSG9zdChob3N0KTsKIAotICAgIGlmIChtX3RpbGVyKQorICAgIGlmIChtX3RpbGVyIHx8ICFo b3N0KQogICAgICAgICByZXR1cm47CiAKICAgICBjcmVhdGVUZXh0dXJlVXBkYXRlcihob3N0KTsK ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2Nocm9taXVtL1Zp ZGVvTGF5ZXJDaHJvbWl1bS5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9j aHJvbWl1bS9WaWRlb0xheWVyQ2hyb21pdW0uY3BwCmluZGV4IDNhYzU3NDdmOTQ3ZDkyMzdkYjMy ODJmNTZhZDg2ZjIwZmJhNWYwYmUuLjE4OGUyZjBjY2RiNWI5YTQ3NDRjZjViMzYzNjY4YjI4MWQ4 MWM1NmMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2Nocm9t aXVtL1ZpZGVvTGF5ZXJDaHJvbWl1bS5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0v Z3JhcGhpY3MvY2hyb21pdW0vVmlkZW9MYXllckNocm9taXVtLmNwcApAQCAtMTQ4LDcgKzE0OCw3 IEBAIHZvaWQgVmlkZW9MYXllckNocm9taXVtOjpwdXNoUHJvcGVydGllc1RvKENDTGF5ZXJJbXBs KiBsYXllcikKIAogdm9pZCBWaWRlb0xheWVyQ2hyb21pdW06OnNldExheWVyVHJlZUhvc3QoQ0NM YXllclRyZWVIb3N0KiBob3N0KQogewotICAgIGlmIChsYXllclRyZWVIb3N0KCkgIT0gaG9zdCkg eworICAgIGlmIChob3N0ICYmIGxheWVyVHJlZUhvc3QoKSAhPSBob3N0KSB7CiAgICAgICAgIGZv ciAoc2l6ZV90IGkgPSAwOyBpIDwgMzsgKytpKSB7CiAgICAgICAgICAgICBtX3RleHR1cmVzW2ld Lm1fdmlzaWJsZVNpemUgPSBJbnRTaXplKCk7CiAgICAgICAgICAgICBtX3RleHR1cmVzW2ldLm1f dGV4dHVyZSA9IE1hbmFnZWRUZXh0dXJlOjpjcmVhdGUoaG9zdC0+Y29udGVudHNUZXh0dXJlTWFu YWdlcigpKTsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2No cm9taXVtL2NjL0NDTGF5ZXJUcmVlSG9zdC5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9n cmFwaGljcy9jaHJvbWl1bS9jYy9DQ0xheWVyVHJlZUhvc3QuY3BwCmluZGV4IGYxMjQ5NWI2NTVm MzljN2Y2OWE0ZjcwYzI0ZDc3ZjgxMzA4MTRjYmIuLmRkNTEwNWNhYWRjZWM5NmU0N2UwYTI2YWFl ODA1OGMxNmNiYTljM2IgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBo aWNzL2Nocm9taXVtL2NjL0NDTGF5ZXJUcmVlSG9zdC5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUv cGxhdGZvcm0vZ3JhcGhpY3MvY2hyb21pdW0vY2MvQ0NMYXllclRyZWVIb3N0LmNwcApAQCAtMjAy LDEyICsyMDIsMzIgQEAgdm9pZCBDQ0xheWVyVHJlZUhvc3Q6OnNldE5lZWRzUmVkcmF3KCkKICNl bmRpZgogfQogCit2b2lkIENDTGF5ZXJUcmVlSG9zdDo6Y2xlYXJSZW5kZXJTdXJmYWNlc1JlY3Vy c2l2ZShMYXllckNocm9taXVtKiBsYXllcikKK3sKKyAgICBmb3IgKHNpemVfdCBpID0gMDsgaSA8 IGxheWVyLT5jaGlsZHJlbigpLnNpemUoKTsgKytpKQorICAgICAgICBjbGVhclJlbmRlclN1cmZh Y2VzUmVjdXJzaXZlKGxheWVyLT5jaGlsZHJlbigpW2ldLmdldCgpKTsKKworICAgIGlmIChsYXll ci0+cmVwbGljYUxheWVyKCkpCisgICAgICAgIGNsZWFyUmVuZGVyU3VyZmFjZXNSZWN1cnNpdmUo bGF5ZXItPnJlcGxpY2FMYXllcigpKTsKKworICAgIGlmIChsYXllci0+bWFza0xheWVyKCkpCisg ICAgICAgIGNsZWFyUmVuZGVyU3VyZmFjZXNSZWN1cnNpdmUobGF5ZXItPm1hc2tMYXllcigpKTsK KworICAgIGxheWVyLT5jbGVhclJlbmRlclN1cmZhY2UoKTsKK30KKworCiB2b2lkIENDTGF5ZXJU cmVlSG9zdDo6c2V0Um9vdExheWVyKEdyYXBoaWNzTGF5ZXIqIGxheWVyKQogewogICAgIG1fbm9u Q29tcG9zaXRlZENvbnRlbnRIb3N0LT5ncmFwaGljc0xheWVyKCktPnJlbW92ZUFsbENoaWxkcmVu KCk7CiAgICAgbV9ub25Db21wb3NpdGVkQ29udGVudEhvc3QtPmludmFsaWRhdGVFbnRpcmVMYXll cigpOwogICAgIGlmIChsYXllcikKICAgICAgICAgbV9ub25Db21wb3NpdGVkQ29udGVudEhvc3Qt PmdyYXBoaWNzTGF5ZXIoKS0+YWRkQ2hpbGQobGF5ZXIpOworICAgIGVsc2UgeworICAgICAgICBj bGVhclJlbmRlclN1cmZhY2VzUmVjdXJzaXZlKHJvb3RMYXllcigpLT5wbGF0Zm9ybUxheWVyKCkp OworICAgICAgICBtX25vbkNvbXBvc2l0ZWRDb250ZW50SG9zdC0+Z3JhcGhpY3NMYXllcigpLT5w bGF0Zm9ybUxheWVyKCktPnNldExheWVyVHJlZUhvc3QoMCk7CisgICAgICAgIG1fcm9vdExheWVy LT5wbGF0Zm9ybUxheWVyKCktPnNldExheWVyVHJlZUhvc3QoMCk7CisgICAgfQogfQogCiB2b2lk IENDTGF5ZXJUcmVlSG9zdDo6c2V0Vmlld3BvcnQoY29uc3QgSW50U2l6ZSYgdmlld3BvcnRTaXpl LCBjb25zdCBJbnRTaXplJiBjb250ZW50c1NpemUsIGNvbnN0IEludFBvaW50JiBzY3JvbGxQb3Np dGlvbikKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2Nocm9t aXVtL2NjL0NDTGF5ZXJUcmVlSG9zdC5oIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhp Y3MvY2hyb21pdW0vY2MvQ0NMYXllclRyZWVIb3N0LmgKaW5kZXggNDg4OTQ4NDQxZDg1YzA5ZDBi NDE3NzVmYTJhYzY1Y2UzM2NjZWEwNy4uMGQwMGQwZjI0ZGE4ZjE1ODNiN2E2NjFkZjFjYTAwM2Ex Zjc0ZWQ0ZiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvY2hy b21pdW0vY2MvQ0NMYXllclRyZWVIb3N0LmgKKysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0v Z3JhcGhpY3MvY2hyb21pdW0vY2MvQ0NMYXllclRyZWVIb3N0LmgKQEAgLTE2Nyw2ICsxNjcsOCBA QCBwcml2YXRlOgogICAgIHZvaWQgdXBkYXRlQ29tcG9zaXRvclJlc291cmNlcyhjb25zdCBMYXll ckxpc3QmLCBHcmFwaGljc0NvbnRleHQzRCopOwogICAgIHZvaWQgdXBkYXRlQ29tcG9zaXRvclJl c291cmNlcyhMYXllckNocm9taXVtKiwgR3JhcGhpY3NDb250ZXh0M0QqKTsKIAorICAgIHZvaWQg Y2xlYXJSZW5kZXJTdXJmYWNlc1JlY3Vyc2l2ZShMYXllckNocm9taXVtKik7CisKICAgICBib29s IGluaXRpYWxpemUoKTsKIAogICAgIFBhc3NSZWZQdHI8TGF5ZXJSZW5kZXJlckNocm9taXVtPiBj cmVhdGVMYXllclJlbmRlcmVyKCk7Cg==