67813 2011-09-08 16:00:46 -0700 -[WKView attributedSubstringForProposedRange:actualRange:] doesn't update actualRange when it's out of bounds 2011-11-30 00:11:46 -0800 1 1 1 Unclassified WebKit WebKit API 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 61889 1 ap ap webkit.review.bot oldest_to_newest 464458 0 ap 2011-09-08 16:00:46 -0700 WebKit currently attempts to send a range as large as the client requested, not trying to make it shorter for performance. But we have to shorten it if the length is out of bounds, and need to update actualRange accordingly. 464460 1 106807 ap 2011-09-08 16:02:23 -0700 Created attachment 106807 proposed fix 511352 2 106807 webkit.review.bot 2011-11-29 21:15:28 -0800 Comment on attachment 106807 proposed fix Rejecting attachment 106807 from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2 Last 500 characters of output: force --reset --delete_unversioned_trees' No such file or directory at /mnt/git/webkit-commit-queue/Tools/Scripts/webkitdirs.pm line 2020. Failed to run "['Tools/Scripts/build-webkit', '--release', '--chromium', '--update-chromium']" exit_code: 2 3 tries and returned 256 at Tools/Scripts/update-webkit-chromium line 109. Re-trying 'depot_tools/gclient sync --force --reset --delete_unversioned_trees' No such file or directory at /mnt/git/webkit-commit-queue/Tools/Scripts/webkitdirs.pm line 2020. Full output: http://queues.webkit.org/results/10687049 511417 3 106807 ap 2011-11-29 23:11:41 -0800 Comment on attachment 106807 proposed fix Error makes no sense, trying again. 511454 4 106807 webkit.review.bot 2011-11-30 00:11:41 -0800 Comment on attachment 106807 proposed fix Clearing flags on attachment: 106807 Committed r101454: <http://trac.webkit.org/changeset/101454> 511455 5 webkit.review.bot 2011-11-30 00:11:46 -0800 All reviewed patches have been landed. Closing bug. 106807 2011-09-08 16:02:23 -0700 2011-11-30 00:11:41 -0800 proposed fix ActualRange.txt text/plain 2219 ap SW5kZXg6IFNvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi S2l0Mi9DaGFuZ2VMb2cJKHJldmlzaW9uIDk0ODE1KQorKysgU291cmNlL1dlYktpdDIvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTYgQEAKKzIwMTEtMDktMDggIEFsZXhleSBQ cm9za3VyeWFrb3YgIDxhcEBhcHBsZS5jb20+CisKKyAgICAgICAgLVtXS1ZpZXcgYXR0cmlidXRl ZFN1YnN0cmluZ0ZvclByb3Bvc2VkUmFuZ2U6YWN0dWFsUmFuZ2U6XSBkb2Vzbid0IHVwZGF0ZSBh Y3R1YWxSYW5nZSB3aGVuIGl0J3Mgb3V0IG9mIGJvdW5kcworICAgICAgICBodHRwczovL2J1Z3Mu d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9Njc4MTMKKworICAgICAgICBSZXZpZXdlZCBieSBO T0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIFVJUHJvY2Vzcy9BUEkvbWFjL1dLVmlldy5tbToK KyAgICAgICAgKC1bV0tWaWV3IGF0dHJpYnV0ZWRTdWJzdHJpbmdGb3JQcm9wb3NlZFJhbmdlOmFj dHVhbFJhbmdlOl0pOiBVcGRhdGUgYWN0dWFsUmFuZ2UgdG8gbWF0Y2gKKyAgICAgICAgcmVzdWx0 IGxlbmd0aC4KKyAgICAgICAgKC1bV0tWaWV3IGZpcnN0UmVjdEZvckNoYXJhY3RlclJhbmdlOmFj dHVhbFJhbmdlOl0pOiBBZGRlZCBhIEZJWE1FLiBUaGlzIGlzIGhhcmRlciB0bworICAgICAgICBp bXBsZW1lbnQsIGFuZCBpdCdzIHVuY2xlYXIgaWYgY2xpZW50cyBjYXJlIGF0IHRoaXMgdGltZS4K KwogMjAxMS0wOS0wOCAgU2FtIFdlaW5pZyAgPHNhbUB3ZWJraXQub3JnPgogCiAgICAgICAgIFJl bW92ZSBhY2NpZGVudGFsbHkgY29tbWl0dGVkIHR5cG8uCkluZGV4OiBTb3VyY2UvV2ViS2l0Mi9V SVByb2Nlc3MvQVBJL21hYy9XS1ZpZXcubW0KPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYktpdDIv VUlQcm9jZXNzL0FQSS9tYWMvV0tWaWV3Lm1tCShyZXZpc2lvbiA5NDY3NSkKKysrIFNvdXJjZS9X ZWJLaXQyL1VJUHJvY2Vzcy9BUEkvbWFjL1dLVmlldy5tbQkod29ya2luZyBjb3B5KQpAQCAtMTU1 Myw4ICsxNTUzLDEwIEBAIC0gKE5TQXR0cmlidXRlZFN0cmluZyAqKWF0dHJpYnV0ZWRTdWJzdHIK ICAgICBBdHRyaWJ1dGVkU3RyaW5nIHJlc3VsdDsKICAgICBfZGF0YS0+X3BhZ2UtPmdldEF0dHJp YnV0ZWRTdWJzdHJpbmdGcm9tUmFuZ2UobnNSYW5nZS5sb2NhdGlvbiwgTlNNYXhSYW5nZShuc1Jh bmdlKSwgcmVzdWx0KTsKIAotICAgIGlmIChhY3R1YWxSYW5nZSkKKyAgICBpZiAoYWN0dWFsUmFu Z2UpIHsKICAgICAgICAgKmFjdHVhbFJhbmdlID0gbnNSYW5nZTsKKyAgICAgICAgYWN0dWFsUmFu Z2UtPmxlbmd0aCA9IFtyZXN1bHQuc3RyaW5nLmdldCgpIGxlbmd0aF07CisgICAgfQogCiAgICAg TE9HKFRleHRJbnB1dCwgImF0dHJpYnV0ZWRTdWJzdHJpbmdGcm9tUmFuZ2U6KCV1LCAldSkgLT4g XCIlQFwiIiwgbnNSYW5nZS5sb2NhdGlvbiwgbnNSYW5nZS5sZW5ndGgsIFtyZXN1bHQuc3RyaW5n LmdldCgpIHN0cmluZ10pOwogICAgIHJldHVybiBbW3Jlc3VsdC5zdHJpbmcuZ2V0KCkgcmV0YWlu XSBhdXRvcmVsZWFzZV07CkBAIC0xNTkyLDggKzE1OTQsMTAgQEAgLSAoTlNSZWN0KWZpcnN0UmVj dEZvckNoYXJhY3RlclJhbmdlOihOUwogICAgIGlmICh3aW5kb3cpCiAgICAgICAgIHJlc3VsdFJl Y3Qub3JpZ2luID0gW3dpbmRvdyBjb252ZXJ0QmFzZVRvU2NyZWVuOnJlc3VsdFJlY3Qub3JpZ2lu XTsKIAotICAgIGlmIChhY3R1YWxSYW5nZSkKKyAgICBpZiAoYWN0dWFsUmFuZ2UpIHsKKyAgICAg ICAgLy8gRklYTUU6IFVwZGF0ZSBhY3R1YWxSYW5nZSB0byBtYXRjaCB0aGUgcmFuZ2Ugb2YgZmly c3QgcmVjdC4KICAgICAgICAgKmFjdHVhbFJhbmdlID0gdGhlUmFuZ2U7CisgICAgfQogCiAgICAg TE9HKFRleHRJbnB1dCwgImZpcnN0UmVjdEZvckNoYXJhY3RlclJhbmdlOigldSwgJXUpIC0+ICgl ZiwgJWYsICVmLCAlZikiLCB0aGVSYW5nZS5sb2NhdGlvbiwgdGhlUmFuZ2UubGVuZ3RoLCByZXN1 bHRSZWN0Lm9yaWdpbi54LCByZXN1bHRSZWN0Lm9yaWdpbi55LCByZXN1bHRSZWN0LnNpemUud2lk dGgsIHJlc3VsdFJlY3Quc2l6ZS5oZWlnaHQpOwogICAgIHJldHVybiByZXN1bHRSZWN0Owo=