67797 2011-09-08 13:24:22 -0700 check-webkit-style: Ref|Own Ptr& should be allowed as a parameter. 2011-10-04 19:26:27 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 levin levin abarth eric pfeldman webkit.review.bot oldest_to_newest 464288 0 levin 2011-09-08 13:24:22 -0700 check-webkit-style: Ref|Own Ptr& should be allowed as a parameter. 464293 1 106779 levin 2011-09-08 13:27:54 -0700 Created attachment 106779 Patch 464333 2 106779 eric 2011-09-08 13:55:10 -0700 Comment on attachment 106779 Patch Thank you. 464348 3 106779 webkit.review.bot 2011-09-08 14:11:30 -0700 Comment on attachment 106779 Patch Attachment 106779 did not pass mac-ews (mac): Output: http://queues.webkit.org/results/9618912 464389 4 106779 webkit.review.bot 2011-09-08 14:49:56 -0700 Comment on attachment 106779 Patch Clearing flags on attachment: 106779 Committed r94803: <http://trac.webkit.org/changeset/94803> 464390 5 webkit.review.bot 2011-09-08 14:50:00 -0700 All reviewed patches have been landed. Closing bug. 478118 6 levin 2011-10-04 19:26:27 -0700 *** Bug 66548 has been marked as a duplicate of this bug. *** 106779 2011-09-08 13:27:54 -0700 2011-09-08 14:49:56 -0700 Patch bug-67797-20110908132753.patch text/plain 2692 levin U3VidmVyc2lvbiBSZXZpc2lvbjogOTQ3NjYKZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBi L1Rvb2xzL0NoYW5nZUxvZwppbmRleCA4NzY1OWE1OTllZDJiZjM0YjFkMDk2ZDNhMjIxYTU3YmJi ZWRjYWI0Li5hNDk3Yjg2YTMzOWNhOWEwNmY4YThiMTIzNmM2ZWI1NWE2NzJmZmJhIDEwMDY0NAot LS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIvVG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTMg QEAKKzIwMTEtMDktMDggIERhdmlkIExldmluICA8bGV2aW5AY2hyb21pdW0ub3JnPgorCisgICAg ICAgIGNoZWNrLXdlYmtpdC1zdHlsZTogUmVmfE93biBQdHImIHNob3VsZCBiZSBhbGxvd2VkIGFz IGEgcGFyYW1ldGVyLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5j Z2k/aWQ9Njc3OTcKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAg ICAgICAqIFNjcmlwdHMvd2Via2l0cHkvc3R5bGUvY2hlY2tlcnMvY3BwLnB5OiBBbGxvdyBSZWYv T3duIFB0ciB3aGVuIGl0IGVuZHMgd2l0aCAmLgorICAgICAgICAqIFNjcmlwdHMvd2Via2l0cHkv c3R5bGUvY2hlY2tlcnMvY3BwX3VuaXR0ZXN0LnB5OiBBZGRlZCB0ZXN0IGNhc2VzIGZvciB0aGlz LgorCiAyMDExLTA5LTA3ICBNYXR0aGV3IERlbGFuZXkgIDxtZGVsYW5leUBhcHBsZS5jb20+CiAK ICAgICAgICAgQWRkIHN0YW5kYWxvbmUgc2NyaXB0IHRoYXQgZmlsdGVycyB0aGUgb3V0cHV0IG9m IGJ1aWxkLXdlYmtpdCB0byBiZSBtb3JlIGh1bWFuLXJlYWRhYmxlCmRpZmYgLS1naXQgYS9Ub29s cy9TY3JpcHRzL3dlYmtpdHB5L3N0eWxlL2NoZWNrZXJzL2NwcC5weSBiL1Rvb2xzL1NjcmlwdHMv d2Via2l0cHkvc3R5bGUvY2hlY2tlcnMvY3BwLnB5CmluZGV4IGY1OTUxMTQzMzliOGVhOGU1ZmI4 NzljOWRhMjkwNWQzYmIzMTFkZTIuLjdkZWQ1YjE3OWRlOGU2MjIxN2ZjNGQyMzU1ODFiZGQ0Nzk3 NTQ2ZjEgMTAwNjQ0Ci0tLSBhL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvc3R5bGUvY2hlY2tlcnMv Y3BwLnB5CisrKyBiL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvc3R5bGUvY2hlY2tlcnMvY3BwLnB5 CkBAIC0xNTc3LDcgKzE1NzcsNyBAQCBkZWYgY2hlY2tfZnVuY3Rpb25fZGVmaW5pdGlvbl9hbmRf cGFzc19wdHIodHlwZV90ZXh0LCByb3csIGxvY2F0aW9uX2Rlc2NyaXB0aW9uLAogICAgICIiIgog ICAgIG1hdGNoX3JlZl9vcl9vd25fcHRyID0gJyg/PVxXfF4pKFJlZnxPd24pUHRyKD89XFcpJwog ICAgIGJhZF90eXBlX3VzYWdlID0gc2VhcmNoKG1hdGNoX3JlZl9vcl9vd25fcHRyLCB0eXBlX3Rl eHQpCi0gICAgaWYgbm90IGJhZF90eXBlX3VzYWdlOgorICAgIGlmIG5vdCBiYWRfdHlwZV91c2Fn ZSBvciB0eXBlX3RleHQuZW5kc3dpdGgoJyYnKToKICAgICAgICAgcmV0dXJuCiAgICAgdHlwZV9u YW1lID0gYmFkX3R5cGVfdXNhZ2UuZ3JvdXAoMCkKICAgICBlcnJvcihyb3csICdyZWFkYWJpbGl0 eS9wYXNzX3B0cicsIDUsCmRpZmYgLS1naXQgYS9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L3N0eWxl L2NoZWNrZXJzL2NwcF91bml0dGVzdC5weSBiL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvc3R5bGUv Y2hlY2tlcnMvY3BwX3VuaXR0ZXN0LnB5CmluZGV4IDNkOThiZmUxM2JlOWFlYTFjNWM4NzYzOGE0 OTllZTM3ZDQyNTg0MTUuLjQzMjJiNDA0ZjA3M2QyYmYzOTA5YzUzZjI1NDMxNTQ4YzZlYmI5MzMg MTAwNjQ0Ci0tLSBhL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvc3R5bGUvY2hlY2tlcnMvY3BwX3Vu aXR0ZXN0LnB5CisrKyBiL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvc3R5bGUvY2hlY2tlcnMvY3Bw X3VuaXR0ZXN0LnB5CkBAIC0zMjc1LDYgKzMyNzUsMTEgQEAgY2xhc3MgUGFzc1B0clRlc3QoQ3Bw U3R5bGVUZXN0QmFzZSk6CiAgICAgICAgICAgICAne1xuJwogICAgICAgICAgICAgJ30nLAogICAg ICAgICAgICAgJ1RoZSBwYXJhbWV0ZXIgdHlwZSBzaG91bGQgdXNlIFBhc3NSZWZQdHIgaW5zdGVh ZCBvZiBSZWZQdHIuICBbcmVhZGFiaWxpdHkvcGFzc19wdHJdIFs1XScpCisgICAgICAgIHNlbGYu YXNzZXJ0X3Bhc3NfcHRyX2NoZWNrKAorICAgICAgICAgICAgJ2ludCBteUZ1bmN0aW9uKFJlZlB0 cjxUeXBlMT4mKVxuJworICAgICAgICAgICAgJ3tcbicKKyAgICAgICAgICAgICd9JywKKyAgICAg ICAgICAgICcnKQogCiAgICAgZGVmIHRlc3Rfb3duX3B0cl9wYXJhbWV0ZXJfdmFsdWUoc2VsZik6 CiAgICAgICAgIHNlbGYuYXNzZXJ0X3Bhc3NfcHRyX2NoZWNrKApAQCAtMzI4Nyw2ICszMjkyLDEx IEBAIGNsYXNzIFBhc3NQdHJUZXN0KENwcFN0eWxlVGVzdEJhc2UpOgogICAgICAgICAgICAgJ3tc bicKICAgICAgICAgICAgICd9JywKICAgICAgICAgICAgICdUaGUgcGFyYW1ldGVyIHR5cGUgc2hv dWxkIHVzZSBQYXNzT3duUHRyIGluc3RlYWQgb2YgT3duUHRyLiAgW3JlYWRhYmlsaXR5L3Bhc3Nf cHRyXSBbNV0nKQorICAgICAgICBzZWxmLmFzc2VydF9wYXNzX3B0cl9jaGVjaygKKyAgICAgICAg ICAgICdpbnQgbXlGdW5jdGlvbihPd25QdHI8VHlwZTE+JiBzaW1wbGUpXG4nCisgICAgICAgICAg ICAne1xuJworICAgICAgICAgICAgJ30nLAorICAgICAgICAgICAgJycpCiAKICAgICBkZWYgdGVz dF9yZWZfcHRyX21lbWJlcl92YXJpYWJsZShzZWxmKToKICAgICAgICAgc2VsZi5hc3NlcnRfcGFz c19wdHJfY2hlY2soCg==