67783 2011-09-08 08:47:11 -0700 Preserve absolute position of mouse events while taking into account page scaling. 2011-09-19 02:33:44 -0700 1 1 1 Unclassified WebKit UI Events 528+ (Nightly build) Unspecified Unspecified RESOLVED INVALID P2 Normal --- 68075 1 jknotten jknotten aroben fsamuel oldest_to_newest 464075 0 jknotten 2011-09-08 08:47:11 -0700 Preserve absolute position of mouse events while taking into account page scaling. 464076 1 106744 jknotten 2011-09-08 08:47:36 -0700 Created attachment 106744 Patch 464453 2 106744 fsamuel 2011-09-08 15:57:43 -0700 Comment on attachment 106744 Patch Make a static pageScaleFactor instead of modifying the static pageZoomFactor, please. 468691 3 106744 darin 2011-09-16 12:10:48 -0700 Comment on attachment 106744 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=106744&action=review > Source/WebCore/dom/MouseRelatedEvent.cpp:122 > - return frame->pageZoomFactor(); > + return frame->pageZoomFactor() * frame->pageScaleFactor(); It’s not good to change what this function does, but leave its name the same. The function is named pageZoomFactor but no longer returns the page zoom factor. We don’t want to use two different names for the same thing. 469299 4 jknotten 2011-09-19 02:33:44 -0700 I'm going to mark this bug as invalid, because my fix to pageX and pageY coordinates (https://bugs.webkit.org/show_bug.cgi?id=67592 ) caused this problem of accidentally modifying the event's absolute location. I reverted that change, so this bug is no longer necessary. It would, however, be nice to have a layout test that ensured the absolute positioning was preserved under the presence of page scaling. Some ideas on how to do this would be to use an <input type="range"> element, since this element processes the absolute location of the mouse event. Another possibility would be to extend EventSender or LayoutTestController to allow the extraction of the absolute location of the mouse event. However, this might be a bad idea since implementation details of the mouse event would be exposed in a test, making it more fragile. 106744 2011-09-08 08:47:36 -0700 2011-09-16 12:10:48 -0700 Patch bug-67783-20110908164734.patch text/plain 7293 jknotten U3VidmVyc2lvbiBSZXZpc2lvbjogOTQ3NDUKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5n ZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxvZwppbmRleCBjNjg5NTNmMDdkNDE1ZTkxN2JiNDlj YzRiN2VhMDI3NzYzNmZmYmRjLi43ZDZiNWRkYzQzMWFjODNhMzE0YjFlYzJmMzAyNDI0ZDY1OTlh YmM0IDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKKysrIGIvTGF5b3V0VGVzdHMv Q2hhbmdlTG9nCkBAIC0xLDMgKzEsMTMgQEAKKzIwMTEtMDktMDggIEpvaG4gS25vdHRlbmJlbHQg IDxqa25vdHRlbkBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgUHJlc2VydmUgYWJzb2x1dGUgcG9z aXRpb24gb2YgbW91c2UgZXZlbnRzIHdoaWxlIHRha2luZyBpbnRvIGFjY291bnQgcGFnZSBzY2Fs aW5nLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9Njc3 ODMKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIGZh c3QvZXZlbnRzL2NsaWVudFhZLWluLXNjYWxlLWFuZC1zY3JvbGwtZXhwZWN0ZWQudHh0OiBBZGRl ZC4KKyAgICAgICAgKiBmYXN0L2V2ZW50cy9jbGllbnRYWS1pbi1zY2FsZS1hbmQtc2Nyb2xsLmh0 bWw6IEFkZGVkLgorCiAyMDExLTA5LTA3ICBCZW4gV2VsbHMgIDxiZW53ZWxsc0BjaHJvbWl1bS5v cmc+CiAKICAgICAgICAgRml4IHR5cG8gaW4gdGVzdF9leHBlY3RhdGlvbnMgaW50cm9kdWNlZCB3 aXRoIHI5NDcyNQpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvZmFzdC9ldmVudHMvY2xpZW50WFkt aW4tc2NhbGUtYW5kLXNjcm9sbC1leHBlY3RlZC50eHQgYi9MYXlvdXRUZXN0cy9mYXN0L2V2ZW50 cy9jbGllbnRYWS1pbi1zY2FsZS1hbmQtc2Nyb2xsLWV4cGVjdGVkLnR4dApuZXcgZmlsZSBtb2Rl IDEwMDY0NAppbmRleCAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwLi5l OWFhYTdhNjJmYzllNWYyYWU4MzBiMDAxMmVhMzFhMTc5M2JiZTNjCi0tLSAvZGV2L251bGwKKysr IGIvTGF5b3V0VGVzdHMvZmFzdC9ldmVudHMvY2xpZW50WFktaW4tc2NhbGUtYW5kLXNjcm9sbC1l eHBlY3RlZC50eHQKQEAgLTAsMCArMSwyNyBAQAorQmFzZQorUEFTUyBldmVudC5jbGllbnRYIGlz IDEwMAorUEFTUyBldmVudC5jbGllbnRZIGlzIDEwMAorUEFTUyBldmVudC5wYWdlWCBpcyAxMDAK K1BBU1MgZXZlbnQucGFnZVkgaXMgMTAwCisKK0p1c3Qgc2NhbGVkCitQQVNTIGV2ZW50LmNsaWVu dFggaXMgNTAKK1BBU1MgZXZlbnQuY2xpZW50WSBpcyA1MAorUEFTUyBldmVudC5wYWdlWCBpcyA1 MAorUEFTUyBldmVudC5wYWdlWSBpcyA1MAorCitKdXN0IHNjcm9sbGVkCitQQVNTIGV2ZW50LmNs aWVudFggaXMgMTAwCitQQVNTIGV2ZW50LmNsaWVudFkgaXMgMTAwCitQQVNTIGV2ZW50LnBhZ2VY IGlzIDE1MAorUEFTUyBldmVudC5wYWdlWSBpcyAxNTAKKworU2NhbGVkIGFuZCBzY3JvbGxlZAor RkFJTCBldmVudC5jbGllbnRYIHNob3VsZCBiZSA4NC4gV2FzIDUwLgorRkFJTCBldmVudC5jbGll bnRZIHNob3VsZCBiZSA4NC4gV2FzIDUwLgorRkFJTCBldmVudC5wYWdlWCBzaG91bGQgYmUgMTMz LiBXYXMgNzUuCitGQUlMIGV2ZW50LnBhZ2VZIHNob3VsZCBiZSAxMzMuIFdhcyA3NS4KK1BBU1Mg c3VjY2Vzc2Z1bGx5UGFyc2VkIGlzIHRydWUKKworVEVTVCBDT01QTEVURQorCmRpZmYgLS1naXQg YS9MYXlvdXRUZXN0cy9mYXN0L2V2ZW50cy9jbGllbnRYWS1pbi1zY2FsZS1hbmQtc2Nyb2xsLmh0 bWwgYi9MYXlvdXRUZXN0cy9mYXN0L2V2ZW50cy9jbGllbnRYWS1pbi1zY2FsZS1hbmQtc2Nyb2xs Lmh0bWwKbmV3IGZpbGUgbW9kZSAxMDA2NDQKaW5kZXggMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAw MDAwMDAwMDAwMDAwMDAwMC4uNzAyZTY3ODhhNThmODhiNzk4YTM5YmI2YTI1NGUzYmRmZTYyZTUy NAotLS0gL2Rldi9udWxsCisrKyBiL0xheW91dFRlc3RzL2Zhc3QvZXZlbnRzL2NsaWVudFhZLWlu LXNjYWxlLWFuZC1zY3JvbGwuaHRtbApAQCAtMCwwICsxLDEyMyBAQAorPGxpbmsgcmVsPSJzdHls ZXNoZWV0IiBocmVmPSIuLi9qcy9yZXNvdXJjZXMvanMtdGVzdC1zdHlsZS5jc3MiPgorPHNjcmlw dCBzcmM9Ii4uL2pzL3Jlc291cmNlcy9qcy10ZXN0LXByZS5qcyI+PC9zY3JpcHQ+Cis8c3R5bGU+ CisgICAgI3B1c2hlciB7CisgICAgICAgIHdpZHRoOiAxMDAwcHg7CisgICAgICAgIGhlaWdodDog MTAwMHB4OworICAgICAgICBvdXRsaW5lOiAxcHggc29saWQgYmxhY2s7CisgICAgfQorPC9zdHls ZT4KKzxkaXYgaWQ9ImNvbnNvbGUiPjwvZGl2PgorPGRpdiBpZD0idGVzdEFyZWEiPgorICAgIDxk aXYgaWQ9InB1c2hlciI+VGhpcyBib3ggaXMgaGVyZSB0byBjcmVhdGUgc2Nyb2xsYmFycy48L2Rp dj4KKzwvZGl2PgorPHNjcmlwdD4KKyAgICB2YXIgZXZlbnQ7CisKKyAgICBmdW5jdGlvbiBzZW5k Q2xpY2soKQorICAgIHsKKyAgICAgICAgaWYgKHdpbmRvdy5ldmVudFNlbmRlcikgeworICAgICAg ICAgICAgZXZlbnRTZW5kZXIubW91c2VNb3ZlVG8oMTAwLCAxMDApOworICAgICAgICAgICAgZXZl bnRTZW5kZXIubW91c2VEb3duKCk7CisgICAgICAgICAgICBldmVudFNlbmRlci5tb3VzZVVwKCk7 CisgICAgICAgIH0KKyAgICB9CisKKyAgICBmdW5jdGlvbiBzY2FsZVBhZ2VJbigpCisgICAgewor ICAgICAgICBpZiAod2luZG93LmV2ZW50U2VuZGVyKSB7CisgICAgICAgICAgICBldmVudFNlbmRl ci5zY2FsZVBhZ2VCeSgyLCAwLCAwKTsKKyAgICAgICAgfQorICAgIH0KKworICAgIGZ1bmN0aW9u IHNjYWxlUGFnZU91dCgpCisgICAgeworICAgICAgICBpZiAod2luZG93LmV2ZW50U2VuZGVyKSB7 CisgICAgICAgICAgICBldmVudFNlbmRlci5zY2FsZVBhZ2VCeSgxLjAsIDAsIDApOworICAgICAg ICB9CisgICAgfQorCisgICAgZnVuY3Rpb24gc2Nyb2xsUGFnZSh4LCB5KQorICAgIHsKKyAgICAg ICAgd2luZG93LnNjcm9sbFRvKHgsIHkpOworICAgIH0KKworICAgIGlmICh3aW5kb3cubGF5b3V0 VGVzdENvbnRyb2xsZXIpIHsKKyAgICAgICAgbGF5b3V0VGVzdENvbnRyb2xsZXIuZHVtcEFzVGV4 dCgpOworICAgICAgICBsYXlvdXRUZXN0Q29udHJvbGxlci53YWl0VW50aWxEb25lKCk7CisgICAg fQorCisgICAgLy8gRGVmYXVsdC4KKyAgICBmdW5jdGlvbiBiYXNlKGUpCisgICAgeworICAgICAg ICBldmVudCA9IGU7CisgICAgICAgIGRlYnVnKCJCYXNlIik7CisgICAgICAgIHNob3VsZEJlKCJl dmVudC5jbGllbnRYIiwgIjEwMCIpOworICAgICAgICBzaG91bGRCZSgiZXZlbnQuY2xpZW50WSIs ICIxMDAiKTsKKyAgICAgICAgc2hvdWxkQmUoImV2ZW50LnBhZ2VYIiwgIjEwMCIpOworICAgICAg ICBzaG91bGRCZSgiZXZlbnQucGFnZVkiLCAiMTAwIik7CisgICAgfQorICAgIHdpbmRvdy5hZGRF dmVudExpc3RlbmVyKCJjbGljayIsIGJhc2UsIGZhbHNlKTsKKyAgICBzZW5kQ2xpY2soKTsKKyAg ICB3aW5kb3cucmVtb3ZlRXZlbnRMaXN0ZW5lcigiY2xpY2siLCBiYXNlLCBmYWxzZSk7CisgICAg CisgICAgLy8gSnVzdCBzY2FsZWQuCisgICAgZnVuY3Rpb24ganVzdFNjYWxlZChlKQorICAgIHsK KyAgICAgICAgZXZlbnQgPSBlOworICAgICAgICBkZWJ1ZygiXG5KdXN0IHNjYWxlZCIpOworICAg ICAgICBzaG91bGRCZSgiZXZlbnQuY2xpZW50WCIsICI1MCIpOworICAgICAgICBzaG91bGRCZSgi ZXZlbnQuY2xpZW50WSIsICI1MCIpOworICAgICAgICBzaG91bGRCZSgiZXZlbnQucGFnZVgiLCAi NTAiKTsKKyAgICAgICAgc2hvdWxkQmUoImV2ZW50LnBhZ2VZIiwgIjUwIik7CisgICAgfQorICAg IHdpbmRvdy5hZGRFdmVudExpc3RlbmVyKCJjbGljayIsIGp1c3RTY2FsZWQsIGZhbHNlKTsKKyAg ICBzY2FsZVBhZ2VJbigpOworICAgIHNlbmRDbGljaygpOworICAgIHNjYWxlUGFnZU91dCgpOwor ICAgIHdpbmRvdy5yZW1vdmVFdmVudExpc3RlbmVyKCJjbGljayIsIGp1c3RTY2FsZWQsIGZhbHNl KTsKKworICAgIC8vIEp1c3Qgc2Nyb2xsZWQuCisgICAgZnVuY3Rpb24ganVzdFNjcm9sbGVkKGUp CisgICAgeworICAgICAgICBldmVudCA9IGU7CisgICAgICAgIGRlYnVnKCJcbkp1c3Qgc2Nyb2xs ZWQiKTsKKyAgICAgICAgc2hvdWxkQmUoImV2ZW50LmNsaWVudFgiLCAiMTAwIik7CisgICAgICAg IHNob3VsZEJlKCJldmVudC5jbGllbnRZIiwgIjEwMCIpOworICAgICAgICBzaG91bGRCZSgiZXZl bnQucGFnZVgiLCAiMTUwIik7CisgICAgICAgIHNob3VsZEJlKCJldmVudC5wYWdlWSIsICIxNTAi KTsKKyAgICB9CisgICAgd2luZG93LmFkZEV2ZW50TGlzdGVuZXIoImNsaWNrIiwganVzdFNjcm9s bGVkLCBmYWxzZSk7CisgICAgc2Nyb2xsUGFnZSg1MCwgNTApOworICAgIHNlbmRDbGljaygpOwor ICAgIHNjcm9sbFBhZ2UoMCwgMCk7CisgICAgd2luZG93LnJlbW92ZUV2ZW50TGlzdGVuZXIoImNs aWNrIiwganVzdFNjcm9sbGVkLCBmYWxzZSk7CisKKyAgICAvLyBTY2FsZWQgYW5kIHNjcm9sbGVk LgorICAgIGZ1bmN0aW9uIHNjYWxlZEFuZFNjcm9sbGVkKGUpCisgICAgeworICAgICAgICBldmVu dCA9IGU7CisgICAgICAgIGRlYnVnKCJcblNjYWxlZCBhbmQgc2Nyb2xsZWQiKTsKKyAgICAgICAg c2hvdWxkQmUoImV2ZW50LmNsaWVudFgiLCAiODQiKTsKKyAgICAgICAgc2hvdWxkQmUoImV2ZW50 LmNsaWVudFkiLCAiODQiKTsKKyAgICAgICAgc2hvdWxkQmUoImV2ZW50LnBhZ2VYIiwgIjEzMyIp OworICAgICAgICBzaG91bGRCZSgiZXZlbnQucGFnZVkiLCAiMTMzIik7CisgICAgfQorICAgIHdp bmRvdy5hZGRFdmVudExpc3RlbmVyKCJjbGljayIsIHNjYWxlZEFuZFNjcm9sbGVkLCBmYWxzZSk7 CisgICAgc2NhbGVQYWdlSW4oKTsKKyAgICBzY3JvbGxQYWdlKDUwLCA1MCk7CisgICAgc2VuZENs aWNrKCk7CisgICAgc2NhbGVQYWdlT3V0KCk7CisgICAgc2Nyb2xsUGFnZSgwLCAwKTsKKyAgICB3 aW5kb3cucmVtb3ZlRXZlbnRMaXN0ZW5lcigiY2xpY2siLCBzY2FsZWRBbmRTY3JvbGxlZCwgZmFs c2UpOworCisgICAgaWYgKHdpbmRvdy5sYXlvdXRUZXN0Q29udHJvbGxlcikgeworICAgICAgICB2 YXIgYXJlYSA9IGRvY3VtZW50LmdldEVsZW1lbnRCeUlkKCd0ZXN0QXJlYScpOworICAgICAgICBh cmVhLnBhcmVudE5vZGUucmVtb3ZlQ2hpbGQoYXJlYSk7CisKKyAgICAgICAgbGF5b3V0VGVzdENv bnRyb2xsZXIubm90aWZ5RG9uZSgpOworICAgIH0KKworICAgIHN1Y2Nlc3NmdWxseVBhcnNlZCA9 IHRydWU7Cis8L3NjcmlwdD4KKzxzY3JpcHQgc3JjPSIuLi9qcy9yZXNvdXJjZXMvanMtdGVzdC1w b3N0LmpzIj48L3NjcmlwdD4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBi L1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCBlMTA1MmQwMjI3ZDE2YjU2NTU5MmQ1ZDc1 MzhiMjljNWNhYjM1MDlkLi45ZGVmZmI3NDdhNTQ4ZTBkMDI2ZWQ5MWQ2MGYwMDBkYjhmNDRkNDVj IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNv cmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYgQEAKKzIwMTEtMDktMDggIEpvaG4gS25vdHRlbmJl bHQgIDxqa25vdHRlbkBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgUHJlc2VydmUgYWJzb2x1dGUg cG9zaXRpb24gb2YgbW91c2UgZXZlbnRzIHdoaWxlIHRha2luZyBpbnRvIGFjY291bnQgcGFnZSBz Y2FsaW5nLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9 Njc3ODMKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBU ZXN0OiBmYXN0L2V2ZW50cy9jbGllbnRYWS1pbi1zY2FsZS1hbmQtc2Nyb2xsLmh0bWwKKworICAg ICAgICAqIGRvbS9Nb3VzZVJlbGF0ZWRFdmVudC5jcHA6CisgICAgICAgIChXZWJDb3JlOjpjb250 ZW50c1Njcm9sbE9mZnNldCk6CisgICAgICAgIChXZWJDb3JlOjpwYWdlWm9vbUZhY3Rvcik6CisK IDIwMTEtMDktMDcgIFNoZXJpZmYgQm90ICA8d2Via2l0LnJldmlldy5ib3RAZ21haWwuY29tPgog CiAgICAgICAgIFVucmV2aWV3ZWQsIHJvbGxpbmcgb3V0IHI5NDY3NCBhbmQgcjk0Njg5LgpkaWZm IC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvZG9tL01vdXNlUmVsYXRlZEV2ZW50LmNwcCBiL1NvdXJj ZS9XZWJDb3JlL2RvbS9Nb3VzZVJlbGF0ZWRFdmVudC5jcHAKaW5kZXggMmQ4MTkzNTZlNzQ1YTZi Yzg2NzhjZDg0MTVmZjcxMGEyYjM2ODg3Ni4uNzg1ZGE5OGE1ZmFkMjZlY2I4OWFhNWJlNmI3YWQw MzE1ODMxYTY5MSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvZG9tL01vdXNlUmVsYXRlZEV2 ZW50LmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9kb20vTW91c2VSZWxhdGVkRXZlbnQuY3BwCkBA IC00OCw4ICs0OCw4IEBAIHN0YXRpYyBMYXlvdXRTaXplIGNvbnRlbnRzU2Nyb2xsT2Zmc2V0KEFi c3RyYWN0VmlldyogYWJzdHJhY3RWaWV3KQogICAgIEZyYW1lVmlldyogZnJhbWVWaWV3ID0gZnJh bWUtPnZpZXcoKTsKICAgICBpZiAoIWZyYW1lVmlldykKICAgICAgICAgcmV0dXJuIExheW91dFNp emUoKTsKLSAgICByZXR1cm4gTGF5b3V0U2l6ZShmcmFtZVZpZXctPnNjcm9sbFgoKSAvIGZyYW1l LT5wYWdlWm9vbUZhY3RvcigpLAotICAgICAgICBmcmFtZVZpZXctPnNjcm9sbFkoKSAvIGZyYW1l LT5wYWdlWm9vbUZhY3RvcigpKTsKKyAgICBmbG9hdCBwYWdlWm9vbSA9IGZyYW1lLT5wYWdlWm9v bUZhY3RvcigpICogZnJhbWUtPnBhZ2VTY2FsZUZhY3RvcigpOworICAgIHJldHVybiBJbnRTaXpl KGZyYW1lVmlldy0+c2Nyb2xsWCgpIC8gcGFnZVpvb20sIGZyYW1lVmlldy0+c2Nyb2xsWSgpIC8g cGFnZVpvb20pOwogfQogCiBNb3VzZVJlbGF0ZWRFdmVudDo6TW91c2VSZWxhdGVkRXZlbnQoY29u c3QgQXRvbWljU3RyaW5nJiBldmVudFR5cGUsIGJvb2wgY2FuQnViYmxlLCBib29sIGNhbmNlbGFi bGUsIFBhc3NSZWZQdHI8QWJzdHJhY3RWaWV3PiBhYnN0cmFjdFZpZXcsCkBAIC0xMTksNyArMTE5 LDcgQEAgc3RhdGljIGZsb2F0IHBhZ2Vab29tRmFjdG9yKGNvbnN0IFVJRXZlbnQqIGV2ZW50KQog ICAgIEZyYW1lKiBmcmFtZSA9IHdpbmRvdy0+ZnJhbWUoKTsKICAgICBpZiAoIWZyYW1lKQogICAg ICAgICByZXR1cm4gMTsKLSAgICByZXR1cm4gZnJhbWUtPnBhZ2Vab29tRmFjdG9yKCk7CisgICAg cmV0dXJuIGZyYW1lLT5wYWdlWm9vbUZhY3RvcigpICogZnJhbWUtPnBhZ2VTY2FsZUZhY3Rvcigp OwogfQogCiB2b2lkIE1vdXNlUmVsYXRlZEV2ZW50Ojpjb21wdXRlUGFnZUxvY2F0aW9uKCkK