6778 2006-01-24 16:29:09 -0800 Crash if a node is removed from the DOM before being reparented due to residual style 2006-01-25 00:34:57 -0800 1 1 1 Unclassified WebKit DOM 420+ PC Linux RESOLVED FIXED http://www.hixie.ch/tests/adhoc/html/parsing/error-handling/031-demo.html P2 Normal --- 1 ian mjs gavin.sharp maksim oldest_to_newest 29778 0 ian 2006-01-24 16:29:09 -0800 The immortal words: <hyatt> i don't see why we would have any trouble with that <hyatt> the parser can deal with elements getting yanked away by script 29779 1 5932 mjs 2006-01-24 17:27:36 -0800 Created attachment 5932 a simple fix This fix will avoid the crash from trying to remove a node from a null parent, but in the case where the block has been detached by script, it will also skip reattaching it in its new location. 29783 2 5932 darin 2006-01-24 18:14:52 -0800 Comment on attachment 5932 a simple fix Needs test case and change log. 29786 3 5932 hyatt 2006-01-24 18:51:52 -0800 Comment on attachment 5932 a simple fix r=me, add a comment above the decl of blockStillInTree that explains what it is and why it is needed. 5932 2006-01-24 17:27:36 -0800 2006-01-24 18:51:52 -0800 a simple fix no-parse-crash.patch.txt text/plain 1628 mjs SW5kZXg6IGtodG1sL2h0bWwvaHRtbHBhcnNlci5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0ga2h0bWwvaHRt bC9odG1scGFyc2VyLmNwcAkocmV2aXNpb24gMTIzMzkpCisrKyBraHRtbC9odG1sL2h0bWxwYXJz ZXIuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0xMDMyLDYgKzEwMzIsOCBAQAogICAgICAgICAgICAg ZWxlbS0+bm9kZS0+YXBwZW5kQ2hpbGQocHJldk5vZGUsIGV4Y2VwdGlvbkNvZGUpOwogICAgIH0K ICAgICAgICAgIAorICAgIGJvb2wgYmxvY2tTdGlsbEluVHJlZSA9IGJsb2NrRWxlbS0+cGFyZW50 Tm9kZSgpOworCiAgICAgLy8gV2UgbmVlZCB0byBtYWtlIGEgY2xvbmUgb2YgfHJlc2lkdWFsRWxl bXwgYW5kIHBsYWNlIGl0IGp1c3QgaW5zaWRlIHxibG9ja0VsZW18LgogICAgIC8vIEFsbCBjb250 ZW50IG9mIHxibG9ja0VsZW18IGlzIHJlcGFyZW50ZWQgdG8gYmUgdW5kZXIgdGhpcyBjbG9uZS4g IFdlIHRoZW4KICAgICAvLyByZXBhcmVudCB8YmxvY2tFbGVtfCB1c2luZyByZWFsIERPTSBjYWxs cyBzbyB0aGF0IGF0dGFjaG1lbnQvZGV0YWNobWVudCB3aWxsCkBAIC0xMDQwLDcgKzEwNDIsOCBA QAogICAgIC8vIFRoZSBlbmQgcmVzdWx0IHdpbGwgYmU6IDxiPi4uLjwvYj48cD48Yj5Gb288L2I+ R29vPC9wPgogICAgIC8vCiAgICAgLy8gU3RlcCAxOiBSZW1vdmUgfGJsb2NrRWxlbXwgZnJvbSBp dHMgcGFyZW50LCBkb2luZyBhIGJhdGNoIGRldGFjaCBvZiBhbGwgdGhlIGtpZHMuCi0gICAgYmxv Y2tFbGVtLT5wYXJlbnROb2RlKCktPnJlbW92ZUNoaWxkKGJsb2NrRWxlbSwgZXhjZXB0aW9uQ29k ZSk7CisgICAgaWYgKGJsb2NrU3RpbGxJblRyZWUpCisgICAgICAgIGJsb2NrRWxlbS0+cGFyZW50 Tm9kZSgpLT5yZW1vdmVDaGlsZChibG9ja0VsZW0sIGV4Y2VwdGlvbkNvZGUpOwogICAgICAgICAK ICAgICAvLyBTdGVwIDI6IENsb25lIHxyZXNpZHVhbEVsZW18LgogICAgIFBhc3NSZWZQdHI8Tm9k ZUltcGw+IG5ld05vZGUgPSByZXNpZHVhbEVsZW0tPmNsb25lTm9kZShmYWxzZSk7IC8vIFNoYWxs b3cgY2xvbmUuIFdlIGRvbid0IHBpY2sgdXAgdGhlIHNhbWUga2lkcy4KQEAgLTEwNjAsNyArMTA2 Myw4IEBACiAgICAgYmxvY2tFbGVtLT5hcHBlbmRDaGlsZChuZXdOb2RlLCBleGNlcHRpb25Db2Rl KTsKICAgICAKICAgICAvLyBTdGVwIDU6IFJlcGFyZW50IHxibG9ja0VsZW18LiAgTm93IHRoZSBm dWxsIGF0dGFjaG1lbnQgb2YgdGhlIGZpeGVkIHVwIHRyZWUgdGFrZXMgcGxhY2UuCi0gICAgcGFy ZW50RWxlbS0+YXBwZW5kQ2hpbGQoYmxvY2tFbGVtLCBleGNlcHRpb25Db2RlKTsKKyAgICBpZiAo YmxvY2tTdGlsbEluVHJlZSkKKyAgICAgICAgcGFyZW50RWxlbS0+YXBwZW5kQ2hpbGQoYmxvY2tF bGVtLCBleGNlcHRpb25Db2RlKTsKICAgICAgICAgCiAgICAgLy8gU3RlcCA2OiBFbGlkZSB8ZWxl bXwsIHNpbmNlIGl0IGlzIGVmZmVjdGl2ZWx5IG5vIGxvbmdlciBvcGVuLiAgQWxzbyB1cGRhdGUK ICAgICAvLyB0aGUgbm9kZSBhc3NvY2lhdGVkIHdpdGggdGhlIHByZXZpb3VzIHN0YWNrIGVsZW1l bnQgc28gdGhhdCB3aGVuIGl0IGdldHMgcG9wcGVkLAo=