67779 2011-09-08 07:13:17 -0700 HiDPI: WebKit2's drag images are blurry 2012-02-09 16:36:16 -0800 1 1 1 Unclassified WebKit Platform 528+ (Nightly build) Mac (Intel) OS X 10.7 RESOLVED FIXED InRadar, PlatformOnly P2 Normal --- 1 aroben mdelaney7 bdakin mdelaney7 oldest_to_newest 464023 0 aroben 2011-09-08 07:13:17 -0700 To reproduce: 1. On a display with a >1.0 scale factor, go to http://www.webkit.org/ 2. Drag a link The drag image is blurry. 464025 1 aroben 2011-09-08 07:13:54 -0700 This affects both WebKit1 and WebKit2. WebKit2 will probably need more fixes, though, since the drag image has to be shipped over to the UI process before it's displayed. 464026 2 webkit-bug-importer 2011-09-08 07:14:09 -0700 <rdar://problem/10093255> 464357 3 aroben 2011-09-08 14:16:17 -0700 WebKit1's behavior is somewhat different, so it is now covered by bug 67802. 553257 4 126322 mdelaney7 2012-02-09 10:09:16 -0800 Created attachment 126322 Patch 553363 5 mdelaney7 2012-02-09 11:35:23 -0800 Committed r107267: <http://trac.webkit.org/changeset/107267> 553515 6 126322 aroben 2012-02-09 14:39:39 -0800 Comment on attachment 126322 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=126322&action=review > Source/WebKit2/UIProcess/API/mac/WKView.mm:2566 > + IntSize size([image size]); > + size.scale(1.0 / [self _intrinsicDeviceScaleFactor]); > + [image setSize:size]; I think you should be using WebPageProxy::deviceScaleFactor instead of -[WKView _intrinsicDeviceScaleFactor]. Otherwise you'll get incorrect behavior when WKPageSetCustomDeviceScaleFactor has been called. 553591 7 mdelaney7 2012-02-09 16:08:25 -0800 Reopening to add in Adam's suggestion. 553597 8 126399 mdelaney7 2012-02-09 16:14:14 -0800 Created attachment 126399 Patch 553613 9 mdelaney7 2012-02-09 16:36:16 -0800 Committed r107307: <http://trac.webkit.org/changeset/107307> 126322 2012-02-09 10:09:16 -0800 2012-02-09 16:14:12 -0800 Patch bug-67779-20120209100915.patch text/plain 3431 mdelaney7 SW5kZXg6IFNvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi S2l0Mi9DaGFuZ2VMb2cJKHJldmlzaW9uIDEwNzE4OCkKKysrIFNvdXJjZS9XZWJLaXQyL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDIxIEBACisyMDEyLTAyLTA5ICBNYXR0aGV3 IERlbGFuZXkgIDxtZGVsYW5leUBhcHBsZS5jb20+CisKKyAgICAgICAgSGlEUEk6IFdlYktpdDIn cyBsaW5rLWRyYWdnaW5nIGltYWdlcyBhcmUgYmx1cnJ5CisgICAgICAgIGh0dHBzOi8vYnVncy53 ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD02Nzc3OQorCisgICAgICAgIFJldmlld2VkIGJ5IE5P Qk9EWSAoT09QUyEpLgorCisgICAgICAgIFRlYWNoIHN0YXJ0RHJhZyBhYm91dCB0aGUgZGV2aWNl U2NhbGVGYWN0b3Igc28gdGhhdCBpdCBjcmVhdGVzCisgICAgICAgIGFuIGFwcHJvcHJpYXRlbHkg c2NhbGVkIGJpdG1hcCBpbWFnZSB0byBzaGlwIG92ZXIuCisgICAgICAgICogV2ViUHJvY2Vzcy9X ZWJDb3JlU3VwcG9ydC9tYWMvV2ViRHJhZ0NsaWVudE1hYy5tbToKKyAgICAgICAgKFdlYktpdDo6 V2ViRHJhZ0NsaWVudDo6c3RhcnREcmFnKToKKyAgICAgICAgKFdlYktpdDo6Y29udmVydEltYWdl VG9CaXRtYXApOgorCisgICAgICAgIEhhdmUgc2V0RHJhZ0ltYWdlIGFzc3VtZSB0aGF0IGl0J3Mg cmVjZWl2aW5nIGEgYml0bWFwIGltYWdlIHNjYWxlZAorICAgICAgICB1cCBieSB0aGUgZGV2aWNl U2NhbGVGYWN0b3IgdGhhdCBpdCBzZWVzLgorICAgICAgICAqIFVJUHJvY2Vzcy9BUEkvbWFjL1dL Vmlldy5tbToKKyAgICAgICAgKC1bV0tWaWV3IF9zZXREcmFnSW1hZ2U6YXQ6bGlua0RyYWc6XSk6 CisKIDIwMTItMDItMDggIEtldW5zb29uIExlZSAgPGtldW5zb29uLmxlZUBzYW1zdW5nLmNvbT4K IAogICAgICAgICBbV0syXVtFRkxdIGNyZWF0aW5nIGR1bW15IGNsYXNzIGRlcml2ZWQgZnJvbSBS ZXNvdXJjZUhhbmRsZUNsaWVudCBmb3IgRWZsIGRvd25sb2FkIG1vZHVsZS4KSW5kZXg6IFNvdXJj ZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvbWFjL1dLVmlldy5tbQo9PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3Vy Y2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL21hYy9XS1ZpZXcubW0JKHJldmlzaW9uIDEwNzEwMikK KysrIFNvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvbWFjL1dLVmlldy5tbQkod29ya2luZyBj b3B5KQpAQCAtMjU2MSw2ICsyNTYxLDkgQEAgLSAodm9pZClfc2V0RHJhZ0ltYWdlOihOU0ltYWdl ICopaW1hZ2UgYQogICAgICAgICByZXR1cm47CiAgICAgCiAgICAgX2RhdGEtPl9kcmFnSGFzU3Rh cnRlZCA9IFlFUzsKKyAgICBJbnRTaXplIHNpemUoW2ltYWdlIHNpemVdKTsKKyAgICBzaXplLnNj YWxlKDEuMCAvIFtzZWxmIF9pbnRyaW5zaWNEZXZpY2VTY2FsZUZhY3Rvcl0pOworICAgIFtpbWFn ZSBzZXRTaXplOnNpemVdOwogICAgIAogICAgIC8vIFRoZSBjYWxsIHRvIHN1cGVyIGNvdWxkIHJl bGVhc2UgdGhpcyBXS1ZpZXcuCiAgICAgUmV0YWluUHRyPFdLVmlldz4gcHJvdGVjdG9yKHNlbGYp OwpJbmRleDogU291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9XZWJDb3JlU3VwcG9ydC9tYWMvV2Vi RHJhZ0NsaWVudE1hYy5tbQo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNz L1dlYkNvcmVTdXBwb3J0L21hYy9XZWJEcmFnQ2xpZW50TWFjLm1tCShyZXZpc2lvbiAxMDcxMDIp CisrKyBTb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL1dlYkNvcmVTdXBwb3J0L21hYy9XZWJEcmFn Q2xpZW50TWFjLm1tCSh3b3JraW5nIGNvcHkpCkBAIC0zOSw2ICszOSw3IEBACiAjaW1wb3J0IDxX ZWJDb3JlL0ZyYW1lVmlldy5oPgogI2ltcG9ydCA8V2ViQ29yZS9HcmFwaGljc0NvbnRleHQuaD4K ICNpbXBvcnQgPFdlYkNvcmUvTGVnYWN5V2ViQXJjaGl2ZS5oPgorI2ltcG9ydCA8V2ViQ29yZS9Q YWdlLmg+CiAjaW1wb3J0IDxXZWJDb3JlL1JlbmRlckltYWdlLmg+CiAjaW1wb3J0IDxXZWJDb3Jl L1Jlc291cmNlSGFuZGxlLmg+CiAjaW1wb3J0IDxXZWJDb3JlL1N0cmluZ1RydW5jYXRvci5oPgpA QCAtNzcsOSArNzgsOSBAQCAtIChpZClpbml0V2l0aEltYWdlOihXZWJDb3JlOjpDYWNoZWRJbWFn CiAKIG5hbWVzcGFjZSBXZWJLaXQgewogCi1zdGF0aWMgUGFzc1JlZlB0cjxTaGFyZWFibGVCaXRt YXA+IGNvbnZlcnRJbWFnZVRvQml0bWFwKE5TSW1hZ2UgKmltYWdlKQorc3RhdGljIFBhc3NSZWZQ dHI8U2hhcmVhYmxlQml0bWFwPiBjb252ZXJ0SW1hZ2VUb0JpdG1hcChOU0ltYWdlICppbWFnZSwg SW50U2l6ZSYgc2l6ZSkKIHsKLSAgICBSZWZQdHI8U2hhcmVhYmxlQml0bWFwPiBiaXRtYXAgPSBT aGFyZWFibGVCaXRtYXA6OmNyZWF0ZVNoYXJlYWJsZShJbnRTaXplKFtpbWFnZSBzaXplXSksIFNo YXJlYWJsZUJpdG1hcDo6U3VwcG9ydHNBbHBoYSk7CisgICAgUmVmUHRyPFNoYXJlYWJsZUJpdG1h cD4gYml0bWFwID0gU2hhcmVhYmxlQml0bWFwOjpjcmVhdGVTaGFyZWFibGUoc2l6ZSwgU2hhcmVh YmxlQml0bWFwOjpTdXBwb3J0c0FscGhhKTsKICAgICBPd25QdHI8R3JhcGhpY3NDb250ZXh0PiBn cmFwaGljc0NvbnRleHQgPSBiaXRtYXAtPmNyZWF0ZUdyYXBoaWNzQ29udGV4dCgpOwogCiAgICAg UmV0YWluUHRyPE5TR3JhcGhpY3NDb250ZXh0PiBzYXZlZENvbnRleHQgPSBbTlNHcmFwaGljc0Nv bnRleHQgY3VycmVudENvbnRleHRdOwpAQCAtOTQsNyArOTUsOSBAQCBzdGF0aWMgUGFzc1JlZlB0 cjxTaGFyZWFibGVCaXRtYXA+IGNvbnZlCiAKIHZvaWQgV2ViRHJhZ0NsaWVudDo6c3RhcnREcmFn KFJldGFpblB0cjxOU0ltYWdlPiBpbWFnZSwgY29uc3QgSW50UG9pbnQmIHBvaW50LCBjb25zdCBJ bnRQb2ludCYsIENsaXBib2FyZCosIEZyYW1lKiBmcmFtZSwgYm9vbCBsaW5rRHJhZykKIHsKLSAg ICBSZWZQdHI8U2hhcmVhYmxlQml0bWFwPiBiaXRtYXAgPSBjb252ZXJ0SW1hZ2VUb0JpdG1hcChp bWFnZS5nZXQoKSk7CisgICAgSW50U2l6ZSBiaXRtYXBTaXplKFtpbWFnZS5nZXQoKSBzaXplXSk7 CisgICAgYml0bWFwU2l6ZS5zY2FsZShmcmFtZS0+cGFnZSgpLT5kZXZpY2VTY2FsZUZhY3Rvcigp KTsKKyAgICBSZWZQdHI8U2hhcmVhYmxlQml0bWFwPiBiaXRtYXAgPSBjb252ZXJ0SW1hZ2VUb0Jp dG1hcChpbWFnZS5nZXQoKSwgYml0bWFwU2l6ZSk7CiAgICAgU2hhcmVhYmxlQml0bWFwOjpIYW5k bGUgaGFuZGxlOwogICAgIGlmICghYml0bWFwLT5jcmVhdGVIYW5kbGUoaGFuZGxlKSkKICAgICAg ICAgcmV0dXJuOwo= 126399 2012-02-09 16:14:14 -0800 2012-02-09 16:24:02 -0800 Patch bug-67779-20120209161414.patch text/plain 1290 mdelaney7 SW5kZXg6IFNvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi S2l0Mi9DaGFuZ2VMb2cJKHJldmlzaW9uIDEwNzMwMikKKysrIFNvdXJjZS9XZWJLaXQyL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE1IEBACisyMDEyLTAyLTA5ICBNYXR0aGV3 IERlbGFuZXkgIDxtZGVsYW5leUBhcHBsZS5jb20+CisKKyAgICAgICAgSGlEUEk6IFdlYktpdDIn cyBkcmFnIGltYWdlcyBhcmUgYmx1cnJ5CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3Jn L3Nob3dfYnVnLmNnaT9pZD02Nzc3OQorCisgICAgICAgIFVzZSB0aGUgcHJvcGVyIGRldmljZVNj YWxlRmFjdG9yKCkgaW5zdGVhZCBvZiBhY2Nlc3NpbmcgX2ludHJpbnNpY0RldmljZVNjYWxlRmFj dG9yCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBV SVByb2Nlc3MvQVBJL21hYy9XS1ZpZXcubW06CisgICAgICAgICgtW1dLVmlldyBfc2V0RHJhZ0lt YWdlOmF0OmxpbmtEcmFnOl0pOgorCiAyMDEyLTAyLTA5ICBBbGV4ZXkgUHJvc2t1cnlha292ICA8 YXBAYXBwbGUuY29tPgogCiAgICAgICAgIFtXSzJdIEFsbG93IHJlYWRpbmcgc29tZSBkZWJ1Zy1v bmx5IHByZWZlcmVuY2UgZmlsZXMKSW5kZXg6IFNvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkv bWFjL1dLVmlldy5tbQo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJ L21hYy9XS1ZpZXcubW0JKHJldmlzaW9uIDEwNzI2NykKKysrIFNvdXJjZS9XZWJLaXQyL1VJUHJv Y2Vzcy9BUEkvbWFjL1dLVmlldy5tbQkod29ya2luZyBjb3B5KQpAQCAtMjU2Miw3ICsyNTYyLDcg QEAgLSAodm9pZClfc2V0RHJhZ0ltYWdlOihOU0ltYWdlICopaW1hZ2UgYQogICAgIAogICAgIF9k YXRhLT5fZHJhZ0hhc1N0YXJ0ZWQgPSBZRVM7CiAgICAgSW50U2l6ZSBzaXplKFtpbWFnZSBzaXpl XSk7Ci0gICAgc2l6ZS5zY2FsZSgxLjAgLyBbc2VsZiBfaW50cmluc2ljRGV2aWNlU2NhbGVGYWN0 b3JdKTsKKyAgICBzaXplLnNjYWxlKDEuMCAvIF9kYXRhLT5fcGFnZS0+ZGV2aWNlU2NhbGVGYWN0 b3IoKSk7CiAgICAgW2ltYWdlIHNldFNpemU6c2l6ZV07CiAgICAgCiAgICAgLy8gVGhlIGNhbGwg dG8gc3VwZXIgY291bGQgcmVsZWFzZSB0aGlzIFdLVmlldy4K