67778 2011-09-08 06:33:49 -0700 [Qt] Build fails with strict compiler 2011-09-08 06:51:13 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) All Linux RESOLVED FIXED Qt, QtTriaged P2 Normal --- 43191 1 abecsi abecsi jturcotte kbr kenneth ossy webkit.review.bot oldest_to_newest 464015 0 abecsi 2011-09-08 06:33:49 -0700 compiler/glslang_lex.cpp: In function ‘int yylex(YYSTYPE*, yyscan_t)’: compiler/glslang_lex.cpp:1693:5: error: ignoring return value of ‘size_t fwrite(const void*, size_t, size_t, FILE*)’, declared with attribute warn_unused_result [-Werror=unused-result] cc1plus: all warnings being treated as errors make[1]: *** [obj/release/glslang_lex.o] Error 1 make[1]: *** Waiting for unfinished jobs.... ../../../Source/WebCore/platform/graphics/TiledBackingStore.cpp: In member function ‘bool WebCore::TiledBackingStore::resizeEdgeTiles()’: ../../../Source/WebCore/platform/graphics/TiledBackingStore.cpp:343:13: error: variable ‘contentsRect’ set but not used [-Werror=unused-but-set-variable] cc1plus: all warnings being treated as errors glslang_lex.cpp needs an update, and the unused variable needs to be removed. 464016 1 106729 abecsi 2011-09-08 06:42:34 -0700 Created attachment 106729 proposed fix 464017 2 webkit.review.bot 2011-09-08 06:44:10 -0700 Attachment 106729 did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/ThirdParty/ANGLE/ChangeLog', u'Sour..." exit_code: 1 Source/ThirdParty/ANGLE/src/compiler/glslang_lex.cpp:862: Extra space before ( in function call [whitespace/parens] [4] Source/ThirdParty/ANGLE/src/compiler/glslang_lex.cpp:862: Extra space before ) [whitespace/parens] [2] Source/ThirdParty/ANGLE/src/compiler/glslang_lex.cpp:862: yyget_column is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4] Source/ThirdParty/ANGLE/src/compiler/glslang_lex.cpp:864: Missing space after , [whitespace/comma] [3] Source/ThirdParty/ANGLE/src/compiler/glslang_lex.cpp:864: Extra space before ( in function call [whitespace/parens] [4] Source/ThirdParty/ANGLE/src/compiler/glslang_lex.cpp:864: Extra space before ) [whitespace/parens] [2] Source/ThirdParty/ANGLE/src/compiler/glslang_lex.cpp:864: yyset_column is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4] Source/ThirdParty/ANGLE/src/compiler/glslang_lex.cpp:864: column_no is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4] Source/ThirdParty/ANGLE/src/compiler/glslang_lex.cpp:916: Extra space after ( in function call [whitespace/parens] [4] Source/ThirdParty/ANGLE/src/compiler/glslang_lex.cpp:916: Missing space inside { }. [whitespace/braces] [5] Source/ThirdParty/ANGLE/src/compiler/glslang_lex.cpp:927: Tab found; better to use spaces [whitespace/tab] [1] Total errors found: 11 in 3 files If any of these errors are false positives, please file a bug against check-webkit-style. 464018 3 106729 ossy 2011-09-08 06:46:41 -0700 Comment on attachment 106729 proposed fix r=me, but cq-, because commit queue doesn't like my name. :) 464019 4 abecsi 2011-09-08 06:48:45 -0700 Just for the record glslang_lex.cpp is a pre-generated file, that is why the style-bot fails. (In reply to comment #2) > Attachment 106729 [details] did not pass style-queue: 464020 5 106729 abecsi 2011-09-08 06:51:05 -0700 Comment on attachment 106729 proposed fix Clearing flags on attachment: 106729 Committed r94757: <http://trac.webkit.org/changeset/94757> 464021 6 abecsi 2011-09-08 06:51:13 -0700 All reviewed patches have been landed. Closing bug. 106729 2011-09-08 06:42:34 -0700 2011-09-08 06:51:05 -0700 proposed fix buildfix.patch text/plain 3267 abecsi ZGlmZiAtLWdpdCBhL1NvdXJjZS9UaGlyZFBhcnR5L0FOR0xFL0NoYW5nZUxvZyBiL1NvdXJjZS9U aGlyZFBhcnR5L0FOR0xFL0NoYW5nZUxvZwppbmRleCBmNWY0ZDVjLi5iNDU0NDVjIDEwMDY0NAot LS0gYS9Tb3VyY2UvVGhpcmRQYXJ0eS9BTkdMRS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1RoaXJk UGFydHkvQU5HTEUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTMgQEAKKzIwMTEtMDktMDggIEFuZHJh cyBCZWNzaSAgPGFuZHJhcy5iZWNzaUBub2tpYS5jb20+CisKKyAgICAgICAgW1F0XSBCdWlsZCBm YWlscyB3aXRoIHN0cmljdCBjb21waWxlcgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9y Zy9zaG93X2J1Zy5jZ2k/aWQ9Njc3NzgKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9P UFMhKS4KKworICAgICAgICAqIHNyYy9jb21waWxlci9nbHNsYW5nX2xleC5jcHA6IFJlZ2VuZXJh dGUgd2l0aCBnZW5lcmF0ZV9nbHNsYW5nX2xleGVyLnNoIHVzaW5nIGEgbmV3ZXIgZmxleAorICAg ICAgICB0byBzdXBwcmVzcyB3YXJuaW5nIGFuZCBmaXggdGhlIGJ1aWxkIHdoZW4gdXNpbmcgWy1X ZXJyb3I9dW51c2VkLXJlc3VsdF0KKwogMjAxMS0wOC0xMiAgTWFyayBSb3dlICA8bXJvd2VAYXBw bGUuY29tPgogCiAgICAgICAgIEJlIG1vcmUgZm9yd2FyZC1sb29raW5nIGluIHRoZSBjaG9pY2Ug b2YgY29tcGlsZXIuCmRpZmYgLS1naXQgYS9Tb3VyY2UvVGhpcmRQYXJ0eS9BTkdMRS9zcmMvY29t cGlsZXIvZ2xzbGFuZ19sZXguY3BwIGIvU291cmNlL1RoaXJkUGFydHkvQU5HTEUvc3JjL2NvbXBp bGVyL2dsc2xhbmdfbGV4LmNwcAppbmRleCA5ZDVmNTNmLi5mYTI4ZDQxIDEwMDY0NAotLS0gYS9T b3VyY2UvVGhpcmRQYXJ0eS9BTkdMRS9zcmMvY29tcGlsZXIvZ2xzbGFuZ19sZXguY3BwCisrKyBi L1NvdXJjZS9UaGlyZFBhcnR5L0FOR0xFL3NyYy9jb21waWxlci9nbHNsYW5nX2xleC5jcHAKQEAg LTg1OSw2ICs4NTksMTAgQEAgaW50IHl5Z2V0X2xpbmVubyAoeXlzY2FuX3QgeXlzY2FubmVyICk7 CiAKIHZvaWQgeXlzZXRfbGluZW5vIChpbnQgbGluZV9udW1iZXIgLHl5c2Nhbl90IHl5c2Nhbm5l ciApOwogCitpbnQgeXlnZXRfY29sdW1uICAoeXlzY2FuX3QgeXlzY2FubmVyICk7CisKK3ZvaWQg eXlzZXRfY29sdW1uIChpbnQgY29sdW1uX25vICx5eXNjYW5fdCB5eXNjYW5uZXIgKTsKKwogWVlT VFlQRSAqIHl5Z2V0X2x2YWwgKHl5c2Nhbl90IHl5c2Nhbm5lciApOwogCiB2b2lkIHl5c2V0X2x2 YWwgKFlZU1RZUEUgKiB5eWx2YWxfcGFyYW0gLHl5c2Nhbl90IHl5c2Nhbm5lciApOwpAQCAtOTA5 LDcgKzkxMyw3IEBAIHN0YXRpYyBpbnQgaW5wdXQgKHl5c2Nhbl90IHl5c2Nhbm5lciApOwogLyog VGhpcyB1c2VkIHRvIGJlIGFuIGZwdXRzKCksIGJ1dCBzaW5jZSB0aGUgc3RyaW5nIG1pZ2h0IGNv bnRhaW4gTlVMJ3MsCiAgKiB3ZSBub3cgdXNlIGZ3cml0ZSgpLgogICovCi0jZGVmaW5lIEVDSE8g ZndyaXRlKCB5eXRleHQsIHl5bGVuZywgMSwgeXlvdXQgKQorI2RlZmluZSBFQ0hPIGRvIHsgaWYg KGZ3cml0ZSggeXl0ZXh0LCB5eWxlbmcsIDEsIHl5b3V0ICkpIHt9IH0gd2hpbGUgKDApCiAjZW5k aWYKIAogLyogR2V0cyBpbnB1dCBhbmQgc3R1ZmZzIGl0IGludG8gImJ1ZiIuICBudW1iZXIgb2Yg Y2hhcmFjdGVycyByZWFkLCBvciBZWV9OVUxMLApAQCAtOTIwLDcgKzkyNCw3IEBAIHN0YXRpYyBp bnQgaW5wdXQgKHl5c2Nhbl90IHl5c2Nhbm5lciApOwogCWlmICggWVlfQ1VSUkVOVF9CVUZGRVJf TFZBTFVFLT55eV9pc19pbnRlcmFjdGl2ZSApIFwKIAkJeyBcCiAJCWludCBjID0gJyonOyBcCi0J CWludCBuOyBcCisJCXVuc2lnbmVkIG47IFwKIAkJZm9yICggbiA9IDA7IG4gPCBtYXhfc2l6ZSAm JiBcCiAJCQkgICAgIChjID0gZ2V0YyggeXlpbiApKSAhPSBFT0YgJiYgYyAhPSAnXG4nOyArK24g KSBcCiAJCQlidWZbbl0gPSAoY2hhcikgYzsgXApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUv Q2hhbmdlTG9nIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCmluZGV4IDBmNDc5OTUuLmYyMjU1 NTUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNiBAQAorMjAxMS0wOS0wOCAgQW5kcmFzIEJlY3Np ICA8YW5kcmFzLmJlY3NpQG5va2lhLmNvbT4KKworICAgICAgICBbUXRdIEJ1aWxkIGZhaWxzIHdp dGggc3RyaWN0IGNvbXBpbGVyCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3df YnVnLmNnaT9pZD02Nzc3OAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgor CisgICAgICAgIE5vIG5ldyB0ZXN0cyBuZWVkZWQuCisKKyAgICAgICAgKiBwbGF0Zm9ybS9ncmFw aGljcy9UaWxlZEJhY2tpbmdTdG9yZS5jcHA6CisgICAgICAgIChXZWJDb3JlOjpUaWxlZEJhY2tp bmdTdG9yZTo6cmVzaXplRWRnZVRpbGVzKTogUmVtb3ZlIHVudXNlZCBjb250ZW50c1JlY3QgdmFy aWFibGUKKyAgICAgICAgd2hpY2gncyB1c2FnZSB3YXMgcmVtb3ZlZCBpbiByOTQ2ODEgdG8gZml4 IHRoZSBidWlsZCB3aXRoIFstV2Vycm9yPXVudXNlZC1idXQtc2V0LXZhcmlhYmxlXS4KKwogMjAx MS0wOS0wOCAgU2hlcmlmZiBCb3QgIDx3ZWJraXQucmV2aWV3LmJvdEBnbWFpbC5jb20+CiAKICAg ICAgICAgVW5yZXZpZXdlZCwgcm9sbGluZyBvdXQgcjk0Njk1LgpkaWZmIC0tZ2l0IGEvU291cmNl L1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvVGlsZWRCYWNraW5nU3RvcmUuY3BwIGIvU291cmNl L1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvVGlsZWRCYWNraW5nU3RvcmUuY3BwCmluZGV4IDQ1 YzIwYmMuLmFkZmNlNzggMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBo aWNzL1RpbGVkQmFja2luZ1N0b3JlLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9n cmFwaGljcy9UaWxlZEJhY2tpbmdTdG9yZS5jcHAKQEAgLTM0MCw3ICszNDAsNiBAQCBJbnRSZWN0 IFRpbGVkQmFja2luZ1N0b3JlOjpjb21wdXRlQ292ZXJSZWN0KGNvbnN0IEludFJlY3QmIHZpc2li bGVSZWN0KSBjb25zdAogCiBib29sIFRpbGVkQmFja2luZ1N0b3JlOjpyZXNpemVFZGdlVGlsZXMo KQogewotICAgIEludFJlY3QgY29udGVudHNSZWN0ID0gdGhpcy0+Y29udGVudHNSZWN0KCk7CiAg ICAgYm9vbCB3YXNSZXNpemVkID0gZmFsc2U7CiAKICAgICBWZWN0b3I8VGlsZTo6Q29vcmRpbmF0 ZT4gdGlsZXNUb1JlbW92ZTsK