<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>67777</bug_id>
          
          <creation_ts>2011-09-08 06:04:44 -0700</creation_ts>
          <short_desc>new-run-webkit-tests does not support qt-arm results</short_desc>
          <delta_ts>2013-08-26 02:23:57 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>Tools / Tests</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>All</rep_platform>
          <op_sys>All</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>DUPLICATE</resolution>
          <dup_id>120207</dup_id>
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords>NRWT</keywords>
          <priority>P3</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          <dependson>120207</dependson>
          <blocked>88680</blocked>
    
    <blocked>89880</blocked>
          <everconfirmed>1</everconfirmed>
          <reporter name="Csaba Osztrogonác">ossy</reporter>
          <assigned_to name="Nobody">webkit-unassigned</assigned_to>
          <cc>abrhm</cc>
    
    <cc>dpranke</cc>
    
    <cc>eric</cc>
    
    <cc>kadam</cc>
    
    <cc>ossy</cc>
    
    <cc>rgabor</cc>
    
    <cc>zarvai</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>464008</commentid>
    <comment_count>0</comment_count>
    <who name="Csaba Osztrogonác">ossy</who>
    <bug_when>2011-09-08 06:04:44 -0700</bug_when>
    <thetext>.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>465756</commentid>
    <comment_count>1</comment_count>
    <who name="Eric Seidel (no email)">eric</who>
    <bug_when>2011-09-12 13:15:21 -0700</bug_when>
    <thetext>Do we have a qt-arm port?  Does it have results?</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>489438</commentid>
    <comment_count>2</comment_count>
    <who name="Eric Seidel (no email)">eric</who>
    <bug_when>2011-10-24 10:44:20 -0700</bug_when>
    <thetext>I guess I&apos;ll assume that&apos;s a no?  Please re-open if this is an issue.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>490768</commentid>
    <comment_count>3</comment_count>
    <who name="Csaba Osztrogonác">ossy</who>
    <bug_when>2011-10-26 05:43:02 -0700</bug_when>
    <thetext>Yes, we have.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>490769</commentid>
    <comment_count>4</comment_count>
    <who name="Csaba Osztrogonác">ossy</who>
    <bug_when>2011-10-26 05:43:39 -0700</bug_when>
    <thetext>And it has results and Skipped list too in LayoutTests/platform/qt-arm.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>491912</commentid>
    <comment_count>5</comment_count>
    <who name="Eric Seidel (no email)">eric</who>
    <bug_when>2011-10-27 13:56:48 -0700</bug_when>
    <thetext>OK.  Looks like qt-arm is just supposed to fall back to qt:

http://trac.webkit.org/browser/trunk/Tools/Scripts/old-run-webkit-tests#L2186

    } elsif ($platform =~ /^qt-/) {
        push @platforms, $platform;
        push @platforms, &quot;qt&quot;;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>491930</commentid>
    <comment_count>6</comment_count>
    <who name="Eric Seidel (no email)">eric</who>
    <bug_when>2011-10-27 14:07:36 -0700</bug_when>
    <thetext>It would be possible to hack this by adding he following to the end of Qt.__init__ in ports/qt.py:

        # FIXME: This is a total hack for the qt-arm port.
        if &apos;arm&apos; in platform.machine():
            self._name = &apos;qt-arm&apos;

But what really should happen is we should come up with some consisten vision for how fallback should work across Qt.  Right now qt-arm is a one-off (I don&apos;t believe it wishes to participate in normal version fallback, right?) and all of Qt fallback is different from Mac/Win which fall back from most-specific version to newer versions then to the base directory.  Qt, my understanding is falls back just to most-specific version then the base directory.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>491931</commentid>
    <comment_count>7</comment_count>
    <who name="Eric Seidel (no email)">eric</who>
    <bug_when>2011-10-27 14:08:23 -0700</bug_when>
    <thetext>I plan to leave qt-arm for someone in Qt to handle.  It&apos;s easy to hack-in as noted above, but I would advise understanding how we want fallback to work for Qt before adding arm support to NRWT.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>491951</commentid>
    <comment_count>8</comment_count>
    <who name="Eric Seidel (no email)">eric</who>
    <bug_when>2011-10-27 14:25:22 -0700</bug_when>
    <thetext>Moving this off of the &quot;move all bots&quot; bug, as I don&apos;t plan to do this before closing that bug and making NRWT default for all other ports.  qt-arm will remain on an explicit black-list of unsupported ports for now.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>659840</commentid>
    <comment_count>9</comment_count>
    <who name="Csaba Osztrogonác">ossy</who>
    <bug_when>2012-06-28 14:40:05 -0700</bug_when>
    <thetext>We should add qt-arm to baseline search paths, it is quite simple.
And we should find the python way for ARM architecture detection somehow.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>920928</commentid>
    <comment_count>10</comment_count>
    <who name="Csaba Osztrogonác">ossy</who>
    <bug_when>2013-08-26 02:23:57 -0700</bug_when>
    <thetext>bug120207 will solve this problem too.

*** This bug has been marked as a duplicate of bug 120207 ***</thetext>
  </long_desc>
      
      

    </bug>

</bugzilla>