67775 2011-09-08 05:24:36 -0700 [Qt] Fix "Unmatched parentheses are deprecated." warnings 2011-09-12 11:12:39 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) All All RESOLVED FIXED Qt, QtTriaged P2 Normal --- 1 ossy webkit-unassigned abecsi ossy webkit.review.bot zeno zherczeg oldest_to_newest 463996 0 ossy 2011-09-08 05:24:36 -0700 When you run build-webkit script, you always get this warning 6 times. (Reading /home/oszi/WebKit/Source/WebKit/qt/Api/DerivedSources.pro) ---> HEADER == /home/oszi/WebKit/Source/WebKit/qt/Api/qwebframe.h WARNING: /home/oszi/WebKit/Source/WebKit/qt/Api/DerivedSources.pro:59: Unmatched parentheses are deprecated. WARNING: /home/oszi/WebKit/Source/WebKit/qt/Api/DerivedSources.pro:59: Unmatched parentheses are deprecated. ---> HEADER == /home/oszi/WebKit/Source/WebKit/qt/Api/qwebview.h WARNING: /home/oszi/WebKit/Source/WebKit/qt/Api/DerivedSources.pro:59: Unmatched parentheses are deprecated. WARNING: /home/oszi/WebKit/Source/WebKit/qt/Api/DerivedSources.pro:59: Unmatched parentheses are deprecated. ---> HEADER == /home/oszi/WebKit/Source/WebKit/qt/Api/qwebpluginfactory.h WARNING: /home/oszi/WebKit/Source/WebKit/qt/Api/DerivedSources.pro:59: Unmatched parentheses are deprecated. WARNING: /home/oszi/WebKit/Source/WebKit/qt/Api/DerivedSources.pro:59: Unmatched parentheses are deprecated. It might be fixed in the pro file or it might be a qmake bug. 465547 1 zeno 2011-09-12 03:12:25 -0700 This is caused by reading header files that contain function declarations that spread over multiple lines using the cat() call in .pro files. The easiest workaround would be to write function declarations in the affected files always on a single line. For a proper fix we would need to add functionality to qmake. 465550 2 107035 ossy 2011-09-12 03:24:05 -0700 Created attachment 107035 proposed workaround 465551 3 webkit.review.bot 2011-09-12 03:26:31 -0700 Attachment 107035 did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit/qt/Api/qwebframe.h', u'Sourc..." exit_code: 1 Source/WebKit/qt/Api/qwebview.h:64: The parameter name "request" adds no information, so it should be removed. [readability/parameter_name] [5] Source/WebKit/qt/Api/qwebview.h:64: The parameter name "operation" adds no information, so it should be removed. [readability/parameter_name] [5] Source/WebKit/qt/Api/qwebframe.h:127: The parameter name "request" adds no information, so it should be removed. [readability/parameter_name] [5] Source/WebKit/qt/Api/qwebframe.h:127: The parameter name "operation" adds no information, so it should be removed. [readability/parameter_name] [5] Total errors found: 4 in 4 files If any of these errors are false positives, please file a bug against check-webkit-style. 465552 4 107035 zherczeg 2011-09-12 03:37:18 -0700 Comment on attachment 107035 proposed workaround The Qt API has a different style than WebKit, so the warnings of the style checker can be ignored. 465565 5 107035 webkit.review.bot 2011-09-12 04:37:15 -0700 Comment on attachment 107035 proposed workaround Rejecting attachment 107035 from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 1 Last 500 characters of output: e2f4da75c0181c0dbc27b418a51380b53ed09346 r94953 = e822bceff99dae95dd27fe318b2aebd379604f74 Done rebuilding .git/svn/refs/remotes/origin/master/.rev_map.268f45cc-cd09-0410-ab3c-d52691b4dbfc First, rewinding head to replay your work on top of it... Fast-forwarded master to refs/remotes/origin/master. Updating chromium port dependencies using gclient... ________ running '/usr/bin/python gyp_webkit' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium' Updating webkit projects from gyp files... Full output: http://queues.webkit.org/results/9634946 465688 6 ossy 2011-09-12 11:11:36 -0700 Landed in http://trac.webkit.org/changeset/94968 465689 7 ossy 2011-09-12 11:12:39 -0700 (In reply to comment #1) > This is caused by reading header files that contain function declarations that spread over multiple lines using the cat() call in .pro files. > The easiest workaround would be to write function declarations in the affected files always on a single line. > For a proper fix we would need to add functionality to qmake. Thanks, it works. 107035 2011-09-12 03:24:05 -0700 2011-09-12 11:11:52 -0700 proposed workaround 1.patch text/plain 3108 ossy ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvcXQvQXBpL3F3ZWJmcmFtZS5oIGIvU291cmNlL1dl YktpdC9xdC9BcGkvcXdlYmZyYW1lLmgKaW5kZXggNGZiNmYxYy4uMjYyZmU3ZCAxMDA2NDQKLS0t IGEvU291cmNlL1dlYktpdC9xdC9BcGkvcXdlYmZyYW1lLmgKKysrIGIvU291cmNlL1dlYktpdC9x dC9BcGkvcXdlYmZyYW1lLmgKQEAgLTEyNCw5ICsxMjQsNyBAQCBwdWJsaWM6CiAgICAgUVdlYlBh Z2UgKnBhZ2UoKSBjb25zdDsKIAogICAgIHZvaWQgbG9hZChjb25zdCBRVXJsICZ1cmwpOwotICAg IHZvaWQgbG9hZChjb25zdCBRTmV0d29ya1JlcXVlc3QgJnJlcXVlc3QsCi0gICAgICAgICAgICAg IFFOZXR3b3JrQWNjZXNzTWFuYWdlcjo6T3BlcmF0aW9uIG9wZXJhdGlvbiA9IFFOZXR3b3JrQWNj ZXNzTWFuYWdlcjo6R2V0T3BlcmF0aW9uLAotICAgICAgICAgICAgICBjb25zdCBRQnl0ZUFycmF5 ICZib2R5ID0gUUJ5dGVBcnJheSgpKTsKKyAgICB2b2lkIGxvYWQoY29uc3QgUU5ldHdvcmtSZXF1 ZXN0ICZyZXF1ZXN0LCBRTmV0d29ya0FjY2Vzc01hbmFnZXI6Ok9wZXJhdGlvbiBvcGVyYXRpb24g PSBRTmV0d29ya0FjY2Vzc01hbmFnZXI6OkdldE9wZXJhdGlvbiwgY29uc3QgUUJ5dGVBcnJheSAm Ym9keSA9IFFCeXRlQXJyYXkoKSk7CiAgICAgdm9pZCBzZXRIdG1sKGNvbnN0IFFTdHJpbmcgJmh0 bWwsIGNvbnN0IFFVcmwgJmJhc2VVcmwgPSBRVXJsKCkpOwogICAgIHZvaWQgc2V0Q29udGVudChj b25zdCBRQnl0ZUFycmF5ICZkYXRhLCBjb25zdCBRU3RyaW5nICZtaW1lVHlwZSA9IFFTdHJpbmco KSwgY29uc3QgUVVybCAmYmFzZVVybCA9IFFVcmwoKSk7CiAKZGlmZiAtLWdpdCBhL1NvdXJjZS9X ZWJLaXQvcXQvQXBpL3F3ZWJwbHVnaW5mYWN0b3J5LmggYi9Tb3VyY2UvV2ViS2l0L3F0L0FwaS9x d2VicGx1Z2luZmFjdG9yeS5oCmluZGV4IDRhMDZiNTkuLjI0MDg0ZmUgMTAwNjQ0Ci0tLSBhL1Nv dXJjZS9XZWJLaXQvcXQvQXBpL3F3ZWJwbHVnaW5mYWN0b3J5LmgKKysrIGIvU291cmNlL1dlYktp dC9xdC9BcGkvcXdlYnBsdWdpbmZhY3RvcnkuaApAQCAtNTQsMTAgKzU0LDcgQEAgcHVibGljOgog ICAgIHZpcnR1YWwgUUxpc3Q8UGx1Z2luPiBwbHVnaW5zKCkgY29uc3QgPSAwOwogICAgIHZpcnR1 YWwgdm9pZCByZWZyZXNoUGx1Z2lucygpOwogCi0gICAgdmlydHVhbCBRT2JqZWN0ICpjcmVhdGUo Y29uc3QgUVN0cmluZyYgbWltZVR5cGUsCi0gICAgICAgICAgICAgICAgICAgICAgICAgICAgY29u c3QgUVVybCYsCi0gICAgICAgICAgICAgICAgICAgICAgICAgICAgY29uc3QgUVN0cmluZ0xpc3Qm IGFyZ3VtZW50TmFtZXMsCi0gICAgICAgICAgICAgICAgICAgICAgICAgICAgY29uc3QgUVN0cmlu Z0xpc3QmIGFyZ3VtZW50VmFsdWVzKSBjb25zdCA9IDA7CisgICAgdmlydHVhbCBRT2JqZWN0ICpj cmVhdGUoY29uc3QgUVN0cmluZyYgbWltZVR5cGUsIGNvbnN0IFFVcmwmLCBjb25zdCBRU3RyaW5n TGlzdCYgYXJndW1lbnROYW1lcywgY29uc3QgUVN0cmluZ0xpc3QmIGFyZ3VtZW50VmFsdWVzKSBj b25zdCA9IDA7CiAKICAgICBlbnVtIEV4dGVuc2lvbiB7CiAgICAgfTsKZGlmZiAtLWdpdCBhL1Nv dXJjZS9XZWJLaXQvcXQvQXBpL3F3ZWJ2aWV3LmggYi9Tb3VyY2UvV2ViS2l0L3F0L0FwaS9xd2Vi dmlldy5oCmluZGV4IDhiMjhmNjIuLjcwZWUxZmEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQv cXQvQXBpL3F3ZWJ2aWV3LmgKKysrIGIvU291cmNlL1dlYktpdC9xdC9BcGkvcXdlYnZpZXcuaApA QCAtNjEsOSArNjEsNyBAQCBwdWJsaWM6CiAgICAgdm9pZCBzZXRQYWdlKFFXZWJQYWdlKiBwYWdl KTsKIAogICAgIHZvaWQgbG9hZChjb25zdCBRVXJsJiB1cmwpOwotICAgIHZvaWQgbG9hZChjb25z dCBRTmV0d29ya1JlcXVlc3QmIHJlcXVlc3QsCi0gICAgICAgICAgICAgIFFOZXR3b3JrQWNjZXNz TWFuYWdlcjo6T3BlcmF0aW9uIG9wZXJhdGlvbiA9IFFOZXR3b3JrQWNjZXNzTWFuYWdlcjo6R2V0 T3BlcmF0aW9uLAotICAgICAgICAgICAgICBjb25zdCBRQnl0ZUFycmF5ICZib2R5ID0gUUJ5dGVB cnJheSgpKTsKKyAgICB2b2lkIGxvYWQoY29uc3QgUU5ldHdvcmtSZXF1ZXN0JiByZXF1ZXN0LCBR TmV0d29ya0FjY2Vzc01hbmFnZXI6Ok9wZXJhdGlvbiBvcGVyYXRpb24gPSBRTmV0d29ya0FjY2Vz c01hbmFnZXI6OkdldE9wZXJhdGlvbiwgY29uc3QgUUJ5dGVBcnJheSAmYm9keSA9IFFCeXRlQXJy YXkoKSk7CiAgICAgdm9pZCBzZXRIdG1sKGNvbnN0IFFTdHJpbmcmIGh0bWwsIGNvbnN0IFFVcmwm IGJhc2VVcmwgPSBRVXJsKCkpOwogICAgIHZvaWQgc2V0Q29udGVudChjb25zdCBRQnl0ZUFycmF5 JiBkYXRhLCBjb25zdCBRU3RyaW5nJiBtaW1lVHlwZSA9IFFTdHJpbmcoKSwgY29uc3QgUVVybCYg YmFzZVVybCA9IFFVcmwoKSk7CiAKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvcXQvQ2hhbmdl TG9nIGIvU291cmNlL1dlYktpdC9xdC9DaGFuZ2VMb2cKaW5kZXggNzcwMmY0MC4uODg0ZmE1YiAx MDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9xdC9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktp dC9xdC9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNCBAQAorMjAxMS0wOS0xMiAgQ3NhYmEgT3N6dHJv Z29uw6FjICA8b3NzeUB3ZWJraXQub3JnPgorCisgICAgICAgIFtRdF0gRml4ICJVbm1hdGNoZWQg cGFyZW50aGVzZXMgYXJlIGRlcHJlY2F0ZWQuIiB3YXJuaW5ncworICAgICAgICBodHRwczovL2J1 Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9Njc3NzUKKworICAgICAgICBNb2RpZnkgZnVu Y3Rpb24gZGVjbGFyYXRpb25zIHRvIHNpbmdsZSBsaW5lIHRvIG1ha2UgcW1ha2UgaGFwcGllci4K KworICAgICAgICAqIEFwaS9xd2ViZnJhbWUuaDoKKyAgICAgICAgKiBBcGkvcXdlYnBsdWdpbmZh Y3RvcnkuaDoKKyAgICAgICAgKiBBcGkvcXdlYnZpZXcuaDoKKwogMjAxMS0wOS0xMCAgSmFycmVk IE5pY2hvbGxzICA8amFycmVkQHNlbmNoYS5jb20+CiAKICAgICAgICAgW1F0XSBRV2ViU2V0dGlu Z3M6OnNldFVzZXJTdHlsZVNoZWV0VXJsKCkgZG9lcyBub3Qgd29yayB3aXRoIHdpbmRvd3MgcGF0 aHMgdGhhdCBjb250YWluIGRyaXZlIGxldHRlcnMK