67767 2011-09-08 00:03:46 -0700 Crashed in WebCore::AppendNodeCommand::create(WTF::PassRefPtr<WebCore::ContainerNode>, WTF::PassRefPtr<WebCore::Node>) 2011-09-09 02:12:30 -0700 1 1 1 Unclassified WebKit HTML Editing 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 67668 0 shinyak webkit-unassigned jchaffraix rniwa shinyak tkent webkit.review.bot oldest_to_newest 463927 0 shinyak 2011-09-08 00:03:46 -0700 testcase <script> function runTest() { window.getSelection().setBaseAndExtent(start, 0, null, 0); document.execCommand("Indent"); } </script> <meta content="2"/><body onLoad="runTest();"> ><defs contenteditable="true" id="start"> <rt>AAAAAAA0A0AAAA00 464013 1 106728 shinyak 2011-09-08 06:21:13 -0700 Created attachment 106728 Patch 464068 2 106728 darin 2011-09-08 08:39:21 -0700 Comment on attachment 106728 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=106728&action=review This looks OK. It's a little strange to just do nothing if the node is not an element and the patch would be better if it explained why that is the correct thing to do, not just that it won’t crash. > LayoutTests/editing/execCommand/ident-crashes-topnode-is-text.html:9 > + document.writeln("This test ensures WebKit does not crash.<br><br>PASS"); The wording here is wrong. The test does not ensure that WebKit does not crash. The test has no effect on WebKit. It's good to say that the test has passed if it doesn’t crash, and also probably good to say as clearly as possible why there was a time when the test would crash. > LayoutTests/editing/execCommand/ident-crashes-topnode-is-text.html:12 > +<meta content="2"/><body onLoad="runTest();"> What is the significance of this "meta" element? 464679 3 106847 shinyak 2011-09-09 00:50:10 -0700 Created attachment 106847 Patch 464681 4 shinyak 2011-09-09 00:54:49 -0700 (In reply to comment #2) > (From update of attachment 106728 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=106728&action=review > > This looks OK. It's a little strange to just do nothing if the node is not an element and the patch would be better if it explained why that is the correct thing to do, not just that it won’t crash. I added some explanation in a test case. > > > LayoutTests/editing/execCommand/ident-crashes-topnode-is-text.html:9 > > + document.writeln("This test ensures WebKit does not crash.<br><br>PASS"); > > The wording here is wrong. The test does not ensure that WebKit does not crash. The test has no effect on WebKit. Fixed. > > It's good to say that the test has passed if it doesn’t crash, and also probably good to say as clearly as possible why there was a time when the test would crash. > > > LayoutTests/editing/execCommand/ident-crashes-topnode-is-text.html:12 > > +<meta content="2"/><body onLoad="runTest();"> > > What is the significance of this "meta" element? It did have no meaning. I removed it. 464683 5 tkent 2011-09-09 00:56:31 -0700 (In reply to comment #3) > Created an attachment (id=106847) [details] > Patch Your patch already had r+ by Darin. So you may land the updated patch without review if you'd like to do so. 1. Update "Reviewed by" lines in ChangeLog entries for the reviewer. Reviewed by Darin Adler. 2. Post the path to this bug. 3. Don't set "review?", set "commit-queue?" instead. 464685 6 106849 shinyak 2011-09-09 01:09:24 -0700 Created attachment 106849 Patch 464686 7 shinyak 2011-09-09 01:10:32 -0700 (In reply to comment #5) > (In reply to comment #3) > > Created an attachment (id=106847) [details] [details] > > Patch > > Your patch already had r+ by Darin. > So you may land the updated patch without review if you'd like to do so. > 1. Update "Reviewed by" lines in ChangeLog entries for the reviewer. > Reviewed by Darin Adler. > 2. Post the path to this bug. > 3. Don't set "review?", set "commit-queue?" instead. Thanks for telling me the process! I updated the 'Reviewed by' lines in ChangeLog, and set commit-queue? mark. 464694 8 106849 webkit.review.bot 2011-09-09 02:12:25 -0700 Comment on attachment 106849 Patch Clearing flags on attachment: 106849 Committed r94841: <http://trac.webkit.org/changeset/94841> 464695 9 webkit.review.bot 2011-09-09 02:12:30 -0700 All reviewed patches have been landed. Closing bug. 106728 2011-09-08 06:21:13 -0700 2011-09-09 00:50:01 -0700 Patch bug-67767-20110908222111.patch text/plain 3742 shinyak U3VidmVyc2lvbiBSZXZpc2lvbjogOTQ3NDEKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5n ZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxvZwppbmRleCAzYWEyMjNhZTRmMzYwYjIyZTM4YTdj MmY3YmExMzZjMmMyNDM2MTM1Li44Y2IwN2UzZTYzNDczODU5MWY0YjY3NjI5NTIwMjQyNGJhM2Vm MmIzIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKKysrIGIvTGF5b3V0VGVzdHMv Q2hhbmdlTG9nCkBAIC0xLDMgKzEsMTUgQEAKKzIwMTEtMDktMDggIFNoaW55YSBLYXdhbmFrYSAg PHNoaW55YWtAZ29vZ2xlLmNvbT4KKworICAgICAgICBDcmFzaGVzIGluIFdlYkNvcmU6OkFwcGVu ZE5vZGVDb21tYW5kOjpjcmVhdGUoKS4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcv c2hvd19idWcuY2dpP2lkPTY3NzY3CisKKyAgICAgICAgQWRkZWQgYSBjcmFzaCB0ZXN0IGNhc2Uu CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBlZGl0 aW5nL2V4ZWNDb21tYW5kL2lkZW50LWNyYXNoZXMtdG9wbm9kZS1pcy10ZXh0LWV4cGVjdGVkLnR4 dDogQWRkZWQuCisgICAgICAgICogZWRpdGluZy9leGVjQ29tbWFuZC9pZGVudC1jcmFzaGVzLXRv cG5vZGUtaXMtdGV4dC5odG1sOiBBZGRlZC4KKwogMjAxMS0wOS0wNyAgQWRhbSBCYXJ0aCAgPGFi YXJ0aEB3ZWJraXQub3JnPgogCiAgICAgICAgIFVwZGF0ZSBiYXNlbGluZXMgZm9yIHN2Zy9hcy1i YWNrZ3JvdW5kLWltYWdlLiAgVGhlc2UgcmVzdWx0cyBhbGwgYXBwZWFyCmRpZmYgLS1naXQgYS9M YXlvdXRUZXN0cy9lZGl0aW5nL2V4ZWNDb21tYW5kL2lkZW50LWNyYXNoZXMtdG9wbm9kZS1pcy10 ZXh0LWV4cGVjdGVkLnR4dCBiL0xheW91dFRlc3RzL2VkaXRpbmcvZXhlY0NvbW1hbmQvaWRlbnQt Y3Jhc2hlcy10b3Bub2RlLWlzLXRleHQtZXhwZWN0ZWQudHh0Cm5ldyBmaWxlIG1vZGUgMTAwNjQ0 CmluZGV4IDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAuLmMwN2M2NDEx ZDQwYzk3ZDRjOTJlODQzYWQyODE0NTlhZGY0MDc5ZjcKLS0tIC9kZXYvbnVsbAorKysgYi9MYXlv dXRUZXN0cy9lZGl0aW5nL2V4ZWNDb21tYW5kL2lkZW50LWNyYXNoZXMtdG9wbm9kZS1pcy10ZXh0 LWV4cGVjdGVkLnR4dApAQCAtMCwwICsxLDMgQEAKK1RoaXMgdGVzdCBlbnN1cmVzIFdlYktpdCBk b2VzIG5vdCBjcmFzaC4KKworUEFTUwpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvZWRpdGluZy9l eGVjQ29tbWFuZC9pZGVudC1jcmFzaGVzLXRvcG5vZGUtaXMtdGV4dC5odG1sIGIvTGF5b3V0VGVz dHMvZWRpdGluZy9leGVjQ29tbWFuZC9pZGVudC1jcmFzaGVzLXRvcG5vZGUtaXMtdGV4dC5odG1s Cm5ldyBmaWxlIG1vZGUgMTAwNjQ0CmluZGV4IDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAw MDAwMDAwMDAwMDAuLjU0ODU2NTViNjI5ZTE0NzJlZGVjNjRkNThlODdiYWFhMDE1ZDI4N2IKLS0t IC9kZXYvbnVsbAorKysgYi9MYXlvdXRUZXN0cy9lZGl0aW5nL2V4ZWNDb21tYW5kL2lkZW50LWNy YXNoZXMtdG9wbm9kZS1pcy10ZXh0Lmh0bWwKQEAgLTAsMCArMSwxNCBAQAorPHNjcmlwdD4KK2lm ICh3aW5kb3cubGF5b3V0VGVzdENvbnRyb2xsZXIpCisgICAgbGF5b3V0VGVzdENvbnRyb2xsZXIu ZHVtcEFzVGV4dCgpOworCitmdW5jdGlvbiBydW5UZXN0KCkgeworICAgIHdpbmRvdy5nZXRTZWxl Y3Rpb24oKS5zZXRCYXNlQW5kRXh0ZW50KHN0YXJ0LCAwLCBudWxsLCAwKTsKKyAgICBkb2N1bWVu dC5leGVjQ29tbWFuZCgiSW5kZW50Iik7CisKKyAgICBkb2N1bWVudC53cml0ZWxuKCJUaGlzIHRl c3QgZW5zdXJlcyBXZWJLaXQgZG9lcyBub3QgY3Jhc2guPGJyPjxicj5QQVNTIik7Cit9Cis8L3Nj cmlwdD4KKzxtZXRhIGNvbnRlbnQ9IjIiLz48Ym9keSBvbkxvYWQ9InJ1blRlc3QoKTsiPgorICAg ID48ZGVmcyBjb250ZW50ZWRpdGFibGU9InRydWUiIGlkPSJzdGFydCI+CisgICAgICAgIDxydD5B QUFBQUFBMEEwQUFBQTAwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cgYi9T b3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYzgzZTc5MTFmYWZkNDljYzk5ZGVjNzZhYTUy YTJjMTNjMTJiOGNlNC4uMzA1YjUxMjA5ZmUzMjY0NWUwYzM2ZTRhM2RjNmYxMDliOTVjNTI2ZCAx MDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJDb3Jl L0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDExLTA5LTA4ICBTaGlueWEgS2F3YW5ha2Eg IDxzaGlueWFrQGdvb2dsZS5jb20+CisKKyAgICAgICAgQ3Jhc2hlcyBpbiBXZWJDb3JlOjpBcHBl bmROb2RlQ29tbWFuZDo6Y3JlYXRlKCkuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3Jn L3Nob3dfYnVnLmNnaT9pZD02Nzc2NworCisgICAgICAgIEluIENvbXBvc2l0ZUVkaXRDb21tYW5k OjpjbG9zZVBhcmFncmFwaFVuZGVyTmV3RWxlbWVudCgpLCBsYXN0Tm9kZSBjb3VsZCBiZSBhIG5v biBFbGVtZW50IG5vZGUuCisgICAgICAgIFRoZSBjdXJyZW50IGNvZGUgYXNzdW1lcyBsYXN0Tm9k ZSBpcyBhbiBFbGVtZW50IG5vZGUuIFRoaXMgcGF0Y2ggY2hlY2tzIGl0LgorCisgICAgICAgIFJl dmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFRlc3Q6IGVkaXRpbmcvZXhlY0Nv bW1hbmQvaWRlbnQtY3Jhc2hlcy10b3Bub2RlLWlzLXRleHQuaHRtbAorCisgICAgICAgICogZWRp dGluZy9Db21wb3NpdGVFZGl0Q29tbWFuZC5jcHA6CisgICAgICAgIChXZWJDb3JlOjpDb21wb3Np dGVFZGl0Q29tbWFuZDo6Y2xvbmVQYXJhZ3JhcGhVbmRlck5ld0VsZW1lbnQpOiBBZGRlZCBhbiBl bGVtZW50IG5vZGUgY2hlY2suCisKIDIwMTEtMDktMDcgIEp1bGllbiBDaGFmZnJhaXggIDxqY2hh ZmZyYWl4QHdlYmtpdC5vcmc+CiAKICAgICAgICAgb2Zmc2V0RnJvbVJvb3Qgb3B0aW1pemF0aW9u IGlzIGRpc2FibGVkIGFmdGVyIHI5MzgzNwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvZWRp dGluZy9Db21wb3NpdGVFZGl0Q29tbWFuZC5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9lZGl0aW5nL0Nv bXBvc2l0ZUVkaXRDb21tYW5kLmNwcAppbmRleCA4YjAzOWFkMmRmODA1NmM5YTg1N2M4ZTZiY2E3 MGFlZmY5NjI4YzNlLi44MDRlZDEzYmE3ZDA3MDM0ZTg4MTE0YzUxNmZhZjFiZWY1NTJhMmQ3IDEw MDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9lZGl0aW5nL0NvbXBvc2l0ZUVkaXRDb21tYW5kLmNw cAorKysgYi9Tb3VyY2UvV2ViQ29yZS9lZGl0aW5nL0NvbXBvc2l0ZUVkaXRDb21tYW5kLmNwcApA QCAtODA4LDcgKzgwOCw3IEBAIHZvaWQgQ29tcG9zaXRlRWRpdENvbW1hbmQ6OmNsb25lUGFyYWdy YXBoVW5kZXJOZXdFbGVtZW50KFBvc2l0aW9uJiBzdGFydCwgUG9zaXRpCiAgICAgYXBwZW5kTm9k ZSh0b3BOb2RlLCBibG9ja0VsZW1lbnQpOwogICAgIFJlZlB0cjxOb2RlPiBsYXN0Tm9kZSA9IHRv cE5vZGU7CiAKLSAgICBpZiAoc3RhcnQuZGVwcmVjYXRlZE5vZGUoKSAhPSBvdXRlck5vZGUpIHsK KyAgICBpZiAoc3RhcnQuZGVwcmVjYXRlZE5vZGUoKSAhPSBvdXRlck5vZGUgJiYgbGFzdE5vZGUt PmlzRWxlbWVudE5vZGUoKSkgewogICAgICAgICBWZWN0b3I8UmVmUHRyPE5vZGU+ID4gYW5jZXN0 b3JzOwogICAgICAgICAKICAgICAgICAgLy8gSW5zZXJ0IGVhY2ggbm9kZSBmcm9tIGlubmVyTm9k ZSB0byBvdXRlck5vZGUgKGV4Y2x1ZGVkKSBpbiBhIGxpc3QuCg== 106847 2011-09-09 00:50:10 -0700 2011-09-09 01:09:16 -0700 Patch bug-67767-20110909165008.patch text/plain 3973 shinyak U3VidmVyc2lvbiBSZXZpc2lvbjogOTQ4MzIKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5n ZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxvZwppbmRleCAxNWI2Y2JjYjhiN2RjNTFmOWQwNjg3 YjVjYjQ1ZjE4MjlhMWExOWJiLi42ZDUxOTdmM2FkOGE0MjNkZGRiZDBiODMxZjg1ODQ3NmFjZGY5 MjY2IDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKKysrIGIvTGF5b3V0VGVzdHMv Q2hhbmdlTG9nCkBAIC0xLDMgKzEsMTUgQEAKKzIwMTEtMDktMDggIFNoaW55YSBLYXdhbmFrYSAg PHNoaW55YWtAZ29vZ2xlLmNvbT4KKworICAgICAgICBDcmFzaGVzIGluIFdlYkNvcmU6OkFwcGVu ZE5vZGVDb21tYW5kOjpjcmVhdGUoKS4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcv c2hvd19idWcuY2dpP2lkPTY3NzY3CisKKyAgICAgICAgQWRkZWQgYSBjcmFzaCB0ZXN0IGNhc2Uu CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBlZGl0 aW5nL2V4ZWNDb21tYW5kL2lkZW50LWNyYXNoZXMtdG9wbm9kZS1pcy10ZXh0LWV4cGVjdGVkLnR4 dDogQWRkZWQuCisgICAgICAgICogZWRpdGluZy9leGVjQ29tbWFuZC9pZGVudC1jcmFzaGVzLXRv cG5vZGUtaXMtdGV4dC5odG1sOiBBZGRlZC4KKwogMjAxMS0wOS0wOCAgQW5uaWUgU3VsbGl2YW4g IDxzdWxsaXZhbkBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgQ3Jhc2hlcyBpbiBXZWJDb3JlOjpJ bnNlcnROb2RlQmVmb3JlQ29tbWFuZCBjb25zdHJ1Y3Rvci4KZGlmZiAtLWdpdCBhL0xheW91dFRl c3RzL2VkaXRpbmcvZXhlY0NvbW1hbmQvaWRlbnQtY3Jhc2hlcy10b3Bub2RlLWlzLXRleHQtZXhw ZWN0ZWQudHh0IGIvTGF5b3V0VGVzdHMvZWRpdGluZy9leGVjQ29tbWFuZC9pZGVudC1jcmFzaGVz LXRvcG5vZGUtaXMtdGV4dC1leHBlY3RlZC50eHQKbmV3IGZpbGUgbW9kZSAxMDA2NDQKaW5kZXgg MDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMC4uOTViZDk4ZThmMWQ4M2U5 NjMxODgzNTA5ZWNjNjYwZDc0NjhmMmU3MQotLS0gL2Rldi9udWxsCisrKyBiL0xheW91dFRlc3Rz L2VkaXRpbmcvZXhlY0NvbW1hbmQvaWRlbnQtY3Jhc2hlcy10b3Bub2RlLWlzLXRleHQtZXhwZWN0 ZWQudHh0CkBAIC0wLDAgKzEsNCBAQAorZXhlY0NvbW1hbmQoIkluZGVudCIpIHdhcyBjcmFzaGlu ZyBpZiB0aGUgdG9wIGVsZW1lbnQgdG8gYmUgZm9ybWF0dGVkIGlzIGFjdHVhbGx5IG5vdCBhbiBl bGVtZW50LgorVGhlIHRlc3QgaGFzIHBhc3NlZCBpZiBpdCBkb2VzIG5vdCBjcmFzaC4KKworUEFT UwpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvZWRpdGluZy9leGVjQ29tbWFuZC9pZGVudC1jcmFz aGVzLXRvcG5vZGUtaXMtdGV4dC5odG1sIGIvTGF5b3V0VGVzdHMvZWRpdGluZy9leGVjQ29tbWFu ZC9pZGVudC1jcmFzaGVzLXRvcG5vZGUtaXMtdGV4dC5odG1sCm5ldyBmaWxlIG1vZGUgMTAwNjQ0 CmluZGV4IDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAuLjE1MjljZDBi MDc0ZGE0YjQyMTViNmI5YzBjZTkxZmVkMWI1NWYyNGIKLS0tIC9kZXYvbnVsbAorKysgYi9MYXlv dXRUZXN0cy9lZGl0aW5nL2V4ZWNDb21tYW5kL2lkZW50LWNyYXNoZXMtdG9wbm9kZS1pcy10ZXh0 Lmh0bWwKQEAgLTAsMCArMSwxNiBAQAorPHNjcmlwdD4KK2lmICh3aW5kb3cubGF5b3V0VGVzdENv bnRyb2xsZXIpCisgICAgbGF5b3V0VGVzdENvbnRyb2xsZXIuZHVtcEFzVGV4dCgpOworCitmdW5j dGlvbiBydW5UZXN0KCkgeworICAgIHdpbmRvdy5nZXRTZWxlY3Rpb24oKS5zZXRCYXNlQW5kRXh0 ZW50KHN0YXJ0LCAwLCBudWxsLCAwKTsKKyAgICBkb2N1bWVudC5leGVjQ29tbWFuZCgiSW5kZW50 Iik7CisKKyAgICBkb2N1bWVudC53cml0ZWxuKCdleGVjQ29tbWFuZCgiSW5kZW50Iikgd2FzIGNy YXNoaW5nIGlmIHRoZSB0b3AgZWxlbWVudCB0byBiZSBmb3JtYXR0ZWQgaXMgYWN0dWFsbHkgbm90 IGFuIGVsZW1lbnQuPGJyPicpOworICAgIGRvY3VtZW50LndyaXRlbG4oJ1RoZSB0ZXN0IGhhcyBw YXNzZWQgaWYgaXQgZG9lcyBub3QgY3Jhc2guPGJyPjxicj4nKQorICAgIGRvY3VtZW50LndyaXRl bG4oJ1BBU1MnKTsKK30KKzwvc2NyaXB0PgorPGJvZHkgb25Mb2FkPSJydW5UZXN0KCk7Ij4KKyAg ICA+PGRlZnMgY29udGVudGVkaXRhYmxlPSJ0cnVlIiBpZD0ic3RhcnQiPgorICAgICAgICA8cnQ+ QUFBQUFBQTBBMEFBQUEwMApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nIGIv U291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCmluZGV4IDRlZDhlZTliYWQzZmNiNmIyMzM3YTVlYmIw NDI0ODg0ZjI2NDlkZGEuLmM4MjYyMGIxNTc3NjA4ZDc3YmUzZjY2MzZmN2JmYWNkNTZlZGEyN2Qg MTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxOCBAQAorMjAxMS0wOS0wOCAgU2hpbnlhIEthd2FuYWth ICA8c2hpbnlha0Bnb29nbGUuY29tPgorCisgICAgICAgIENyYXNoZXMgaW4gV2ViQ29yZTo6QXBw ZW5kTm9kZUNvbW1hbmQ6OmNyZWF0ZSgpLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9y Zy9zaG93X2J1Zy5jZ2k/aWQ9Njc3NjcKKworICAgICAgICBJbiBDb21wb3NpdGVFZGl0Q29tbWFu ZDo6Y2xvc2VQYXJhZ3JhcGhVbmRlck5ld0VsZW1lbnQoKSwgbGFzdE5vZGUgY291bGQgYmUgYSBu b24gRWxlbWVudCBub2RlLgorICAgICAgICBUaGUgY3VycmVudCBjb2RlIGFzc3VtZXMgbGFzdE5v ZGUgaXMgYW4gRWxlbWVudCBub2RlLiBUaGlzIHBhdGNoIGNoZWNrcyBpdC4KKworICAgICAgICBS ZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBUZXN0OiBlZGl0aW5nL2V4ZWND b21tYW5kL2lkZW50LWNyYXNoZXMtdG9wbm9kZS1pcy10ZXh0Lmh0bWwKKworICAgICAgICAqIGVk aXRpbmcvQ29tcG9zaXRlRWRpdENvbW1hbmQuY3BwOgorICAgICAgICAoV2ViQ29yZTo6Q29tcG9z aXRlRWRpdENvbW1hbmQ6OmNsb25lUGFyYWdyYXBoVW5kZXJOZXdFbGVtZW50KTogQWRkZWQgYW4g ZWxlbWVudCBub2RlIGNoZWNrLgorCiAyMDExLTA5LTA4ICBBbm5pZSBTdWxsaXZhbiAgPHN1bGxp dmFuQGNocm9taXVtLm9yZz4KIAogICAgICAgICBDcmFzaGVzIGluIFdlYkNvcmU6Okluc2VydE5v ZGVCZWZvcmVDb21tYW5kIGNvbnN0cnVjdG9yLgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUv ZWRpdGluZy9Db21wb3NpdGVFZGl0Q29tbWFuZC5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9lZGl0aW5n L0NvbXBvc2l0ZUVkaXRDb21tYW5kLmNwcAppbmRleCA4YjAzOWFkMmRmODA1NmM5YTg1N2M4ZTZi Y2E3MGFlZmY5NjI4YzNlLi44MDRlZDEzYmE3ZDA3MDM0ZTg4MTE0YzUxNmZhZjFiZWY1NTJhMmQ3 IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9lZGl0aW5nL0NvbXBvc2l0ZUVkaXRDb21tYW5k LmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9lZGl0aW5nL0NvbXBvc2l0ZUVkaXRDb21tYW5kLmNw cApAQCAtODA4LDcgKzgwOCw3IEBAIHZvaWQgQ29tcG9zaXRlRWRpdENvbW1hbmQ6OmNsb25lUGFy YWdyYXBoVW5kZXJOZXdFbGVtZW50KFBvc2l0aW9uJiBzdGFydCwgUG9zaXRpCiAgICAgYXBwZW5k Tm9kZSh0b3BOb2RlLCBibG9ja0VsZW1lbnQpOwogICAgIFJlZlB0cjxOb2RlPiBsYXN0Tm9kZSA9 IHRvcE5vZGU7CiAKLSAgICBpZiAoc3RhcnQuZGVwcmVjYXRlZE5vZGUoKSAhPSBvdXRlck5vZGUp IHsKKyAgICBpZiAoc3RhcnQuZGVwcmVjYXRlZE5vZGUoKSAhPSBvdXRlck5vZGUgJiYgbGFzdE5v ZGUtPmlzRWxlbWVudE5vZGUoKSkgewogICAgICAgICBWZWN0b3I8UmVmUHRyPE5vZGU+ID4gYW5j ZXN0b3JzOwogICAgICAgICAKICAgICAgICAgLy8gSW5zZXJ0IGVhY2ggbm9kZSBmcm9tIGlubmVy Tm9kZSB0byBvdXRlck5vZGUgKGV4Y2x1ZGVkKSBpbiBhIGxpc3QuCg== 106849 2011-09-09 01:09:24 -0700 2011-09-09 02:12:25 -0700 Patch bug-67767-20110909170923.patch text/plain 3967 shinyak U3VidmVyc2lvbiBSZXZpc2lvbjogOTQ4MzIKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5n ZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxvZwppbmRleCAxNWI2Y2JjYjhiN2RjNTFmOWQwNjg3 YjVjYjQ1ZjE4MjlhMWExOWJiLi5lNmE2MjI4NzhjMDhlMWE4NWZkODczYzkxOTcyNTE0MGQwODU0 NDNkIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKKysrIGIvTGF5b3V0VGVzdHMv Q2hhbmdlTG9nCkBAIC0xLDMgKzEsMTUgQEAKKzIwMTEtMDktMDggIFNoaW55YSBLYXdhbmFrYSAg PHNoaW55YWtAZ29vZ2xlLmNvbT4KKworICAgICAgICBDcmFzaGVzIGluIFdlYkNvcmU6OkFwcGVu ZE5vZGVDb21tYW5kOjpjcmVhdGUoKS4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcv c2hvd19idWcuY2dpP2lkPTY3NzY3CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgRGFyaW4gQWRsZXIu CisKKyAgICAgICAgQWRkZWQgYSBjcmFzaCB0ZXN0IGNhc2UuCisKKyAgICAgICAgKiBlZGl0aW5n L2V4ZWNDb21tYW5kL2lkZW50LWNyYXNoZXMtdG9wbm9kZS1pcy10ZXh0LWV4cGVjdGVkLnR4dDog QWRkZWQuCisgICAgICAgICogZWRpdGluZy9leGVjQ29tbWFuZC9pZGVudC1jcmFzaGVzLXRvcG5v ZGUtaXMtdGV4dC5odG1sOiBBZGRlZC4KKwogMjAxMS0wOS0wOCAgQW5uaWUgU3VsbGl2YW4gIDxz dWxsaXZhbkBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgQ3Jhc2hlcyBpbiBXZWJDb3JlOjpJbnNl cnROb2RlQmVmb3JlQ29tbWFuZCBjb25zdHJ1Y3Rvci4KZGlmZiAtLWdpdCBhL0xheW91dFRlc3Rz L2VkaXRpbmcvZXhlY0NvbW1hbmQvaWRlbnQtY3Jhc2hlcy10b3Bub2RlLWlzLXRleHQtZXhwZWN0 ZWQudHh0IGIvTGF5b3V0VGVzdHMvZWRpdGluZy9leGVjQ29tbWFuZC9pZGVudC1jcmFzaGVzLXRv cG5vZGUtaXMtdGV4dC1leHBlY3RlZC50eHQKbmV3IGZpbGUgbW9kZSAxMDA2NDQKaW5kZXggMDAw MDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMC4uOTViZDk4ZThmMWQ4M2U5NjMx ODgzNTA5ZWNjNjYwZDc0NjhmMmU3MQotLS0gL2Rldi9udWxsCisrKyBiL0xheW91dFRlc3RzL2Vk aXRpbmcvZXhlY0NvbW1hbmQvaWRlbnQtY3Jhc2hlcy10b3Bub2RlLWlzLXRleHQtZXhwZWN0ZWQu dHh0CkBAIC0wLDAgKzEsNCBAQAorZXhlY0NvbW1hbmQoIkluZGVudCIpIHdhcyBjcmFzaGluZyBp ZiB0aGUgdG9wIGVsZW1lbnQgdG8gYmUgZm9ybWF0dGVkIGlzIGFjdHVhbGx5IG5vdCBhbiBlbGVt ZW50LgorVGhlIHRlc3QgaGFzIHBhc3NlZCBpZiBpdCBkb2VzIG5vdCBjcmFzaC4KKworUEFTUwpk aWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvZWRpdGluZy9leGVjQ29tbWFuZC9pZGVudC1jcmFzaGVz LXRvcG5vZGUtaXMtdGV4dC5odG1sIGIvTGF5b3V0VGVzdHMvZWRpdGluZy9leGVjQ29tbWFuZC9p ZGVudC1jcmFzaGVzLXRvcG5vZGUtaXMtdGV4dC5odG1sCm5ldyBmaWxlIG1vZGUgMTAwNjQ0Cmlu ZGV4IDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAuLjE1MjljZDBiMDc0 ZGE0YjQyMTViNmI5YzBjZTkxZmVkMWI1NWYyNGIKLS0tIC9kZXYvbnVsbAorKysgYi9MYXlvdXRU ZXN0cy9lZGl0aW5nL2V4ZWNDb21tYW5kL2lkZW50LWNyYXNoZXMtdG9wbm9kZS1pcy10ZXh0Lmh0 bWwKQEAgLTAsMCArMSwxNiBAQAorPHNjcmlwdD4KK2lmICh3aW5kb3cubGF5b3V0VGVzdENvbnRy b2xsZXIpCisgICAgbGF5b3V0VGVzdENvbnRyb2xsZXIuZHVtcEFzVGV4dCgpOworCitmdW5jdGlv biBydW5UZXN0KCkgeworICAgIHdpbmRvdy5nZXRTZWxlY3Rpb24oKS5zZXRCYXNlQW5kRXh0ZW50 KHN0YXJ0LCAwLCBudWxsLCAwKTsKKyAgICBkb2N1bWVudC5leGVjQ29tbWFuZCgiSW5kZW50Iik7 CisKKyAgICBkb2N1bWVudC53cml0ZWxuKCdleGVjQ29tbWFuZCgiSW5kZW50Iikgd2FzIGNyYXNo aW5nIGlmIHRoZSB0b3AgZWxlbWVudCB0byBiZSBmb3JtYXR0ZWQgaXMgYWN0dWFsbHkgbm90IGFu IGVsZW1lbnQuPGJyPicpOworICAgIGRvY3VtZW50LndyaXRlbG4oJ1RoZSB0ZXN0IGhhcyBwYXNz ZWQgaWYgaXQgZG9lcyBub3QgY3Jhc2guPGJyPjxicj4nKQorICAgIGRvY3VtZW50LndyaXRlbG4o J1BBU1MnKTsKK30KKzwvc2NyaXB0PgorPGJvZHkgb25Mb2FkPSJydW5UZXN0KCk7Ij4KKyAgICA+ PGRlZnMgY29udGVudGVkaXRhYmxlPSJ0cnVlIiBpZD0ic3RhcnQiPgorICAgICAgICA8cnQ+QUFB QUFBQTBBMEFBQUEwMApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nIGIvU291 cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCmluZGV4IDRlZDhlZTliYWQzZmNiNmIyMzM3YTVlYmIwNDI0 ODg0ZjI2NDlkZGEuLjUzMTM3ZmEwMDBlYmQxZWJiNDU1NTE4ODA0OTY2MGNmODUzZGQzYzggMTAw NjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cKQEAgLTEsMyArMSwxOCBAQAorMjAxMS0wOS0wOCAgU2hpbnlhIEthd2FuYWthICA8 c2hpbnlha0Bnb29nbGUuY29tPgorCisgICAgICAgIENyYXNoZXMgaW4gV2ViQ29yZTo6QXBwZW5k Tm9kZUNvbW1hbmQ6OmNyZWF0ZSgpLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9z aG93X2J1Zy5jZ2k/aWQ9Njc3NjcKKworICAgICAgICBSZXZpZXdlZCBieSBEYXJpbiBBZGxlci4K KworICAgICAgICBJbiBDb21wb3NpdGVFZGl0Q29tbWFuZDo6Y2xvc2VQYXJhZ3JhcGhVbmRlck5l d0VsZW1lbnQoKSwgbGFzdE5vZGUgY291bGQgYmUgYSBub24gRWxlbWVudCBub2RlLgorICAgICAg ICBUaGUgY3VycmVudCBjb2RlIGFzc3VtZXMgbGFzdE5vZGUgaXMgYW4gRWxlbWVudCBub2RlLiBU aGlzIHBhdGNoIGNoZWNrcyBpdC4KKworICAgICAgICBUZXN0OiBlZGl0aW5nL2V4ZWNDb21tYW5k L2lkZW50LWNyYXNoZXMtdG9wbm9kZS1pcy10ZXh0Lmh0bWwKKworICAgICAgICAqIGVkaXRpbmcv Q29tcG9zaXRlRWRpdENvbW1hbmQuY3BwOgorICAgICAgICAoV2ViQ29yZTo6Q29tcG9zaXRlRWRp dENvbW1hbmQ6OmNsb25lUGFyYWdyYXBoVW5kZXJOZXdFbGVtZW50KTogQWRkZWQgYW4gZWxlbWVu dCBub2RlIGNoZWNrLgorCiAyMDExLTA5LTA4ICBBbm5pZSBTdWxsaXZhbiAgPHN1bGxpdmFuQGNo cm9taXVtLm9yZz4KIAogICAgICAgICBDcmFzaGVzIGluIFdlYkNvcmU6Okluc2VydE5vZGVCZWZv cmVDb21tYW5kIGNvbnN0cnVjdG9yLgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvZWRpdGlu Zy9Db21wb3NpdGVFZGl0Q29tbWFuZC5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9lZGl0aW5nL0NvbXBv c2l0ZUVkaXRDb21tYW5kLmNwcAppbmRleCA4YjAzOWFkMmRmODA1NmM5YTg1N2M4ZTZiY2E3MGFl ZmY5NjI4YzNlLi44MDRlZDEzYmE3ZDA3MDM0ZTg4MTE0YzUxNmZhZjFiZWY1NTJhMmQ3IDEwMDY0 NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9lZGl0aW5nL0NvbXBvc2l0ZUVkaXRDb21tYW5kLmNwcAor KysgYi9Tb3VyY2UvV2ViQ29yZS9lZGl0aW5nL0NvbXBvc2l0ZUVkaXRDb21tYW5kLmNwcApAQCAt ODA4LDcgKzgwOCw3IEBAIHZvaWQgQ29tcG9zaXRlRWRpdENvbW1hbmQ6OmNsb25lUGFyYWdyYXBo VW5kZXJOZXdFbGVtZW50KFBvc2l0aW9uJiBzdGFydCwgUG9zaXRpCiAgICAgYXBwZW5kTm9kZSh0 b3BOb2RlLCBibG9ja0VsZW1lbnQpOwogICAgIFJlZlB0cjxOb2RlPiBsYXN0Tm9kZSA9IHRvcE5v ZGU7CiAKLSAgICBpZiAoc3RhcnQuZGVwcmVjYXRlZE5vZGUoKSAhPSBvdXRlck5vZGUpIHsKKyAg ICBpZiAoc3RhcnQuZGVwcmVjYXRlZE5vZGUoKSAhPSBvdXRlck5vZGUgJiYgbGFzdE5vZGUtPmlz RWxlbWVudE5vZGUoKSkgewogICAgICAgICBWZWN0b3I8UmVmUHRyPE5vZGU+ID4gYW5jZXN0b3Jz OwogICAgICAgICAKICAgICAgICAgLy8gSW5zZXJ0IGVhY2ggbm9kZSBmcm9tIGlubmVyTm9kZSB0 byBvdXRlck5vZGUgKGV4Y2x1ZGVkKSBpbiBhIGxpc3QuCg==