67747 2011-09-07 16:44:46 -0700 Add a script to create a monolithic script-test 2011-09-09 21:01:51 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 66357 1 ap ap abarth aroben eric mjs oldest_to_newest 463768 0 ap 2011-09-07 16:44:46 -0700 As I'm recommending against using split tests, Maciej raised a concern that it's difficult to create monolithic tests manually. Indeed, you need to find an existing script test, copy boilerplate, and fix the number of ".." path components. 463769 1 106673 ap 2011-09-07 16:45:54 -0700 Created attachment 106673 proposed patch 463794 2 106673 darin 2011-09-07 17:58:50 -0700 Comment on attachment 106673 proposed patch Seems like a good start. 465214 3 ap 2011-09-09 21:01:51 -0700 There was some disagreement on mailing list whether this is going to be useful. The discussion has dried out, and I guess that the only way to know that for sure is to land and try. Committed <http://trac.webkit.org/changeset/94899>. 106673 2011-09-07 16:45:54 -0700 2011-09-07 17:58:50 -0700 proposed patch CreateScriptTest.txt text/plain 5022 ap SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDk0NzI4KQorKysgVG9vbHMvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMg KzEsMTIgQEAKKzIwMTEtMDktMDcgIEFsZXhleSBQcm9za3VyeWFrb3YgIDxhcEBhcHBsZS5jb20+ CisKKyAgICAgICAgQWRkIGEgc2NyaXB0IHRvIGNyZWF0ZSBhIG1vbm9saXRoaWMgc2NyaXB0LXRl c3QKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTY3NzQ3 CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBTY3Jp cHRzL21ha2UtbmV3LXNjcmlwdC10ZXN0OiBBZGRlZC4KKwogMjAxMS0wOS0wNyAgQWRhbSBCYXJ0 aCAgPGFiYXJ0aEB3ZWJraXQub3JnPgogCiAgICAgICAgIHJlYmFzZWxpbmUgYnV0dG9uIGluIGdh cmRlbi1vLW1hdGljIGRldGFpbHMgdmlldyBzaG91bGQgd29yawpJbmRleDogVG9vbHMvU2NyaXB0 cy9tYWtlLW5ldy1zY3JpcHQtdGVzdAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9TY3JpcHRzL21ha2Ut bmV3LXNjcmlwdC10ZXN0CShyZXZpc2lvbiAwKQorKysgVG9vbHMvU2NyaXB0cy9tYWtlLW5ldy1z Y3JpcHQtdGVzdAkocmV2aXNpb24gMCkKQEAgLTAsMCArMSwxMjAgQEAKKyMhL3Vzci9iaW4vcGVy bCAtdworCisjIENvcHlyaWdodCAoQykgMjAxMSBBcHBsZSBJbmMuIEFsbCByaWdodHMgcmVzZXJ2 ZWQuCisjCisjIFJlZGlzdHJpYnV0aW9uIGFuZCB1c2UgaW4gc291cmNlIGFuZCBiaW5hcnkgZm9y bXMsIHdpdGggb3Igd2l0aG91dAorIyBtb2RpZmljYXRpb24sIGFyZSBwZXJtaXR0ZWQgcHJvdmlk ZWQgdGhhdCB0aGUgZm9sbG93aW5nIGNvbmRpdGlvbnMKKyMgYXJlIG1ldDoKKyMKKyMgMS4gIFJl ZGlzdHJpYnV0aW9ucyBvZiBzb3VyY2UgY29kZSBtdXN0IHJldGFpbiB0aGUgYWJvdmUgY29weXJp Z2h0CisjICAgICBub3RpY2UsIHRoaXMgbGlzdCBvZiBjb25kaXRpb25zIGFuZCB0aGUgZm9sbG93 aW5nIGRpc2NsYWltZXIuIAorIyAyLiAgUmVkaXN0cmlidXRpb25zIGluIGJpbmFyeSBmb3JtIG11 c3QgcmVwcm9kdWNlIHRoZSBhYm92ZSBjb3B5cmlnaHQKKyMgICAgIG5vdGljZSwgdGhpcyBsaXN0 IG9mIGNvbmRpdGlvbnMgYW5kIHRoZSBmb2xsb3dpbmcgZGlzY2xhaW1lciBpbiB0aGUKKyMgICAg IGRvY3VtZW50YXRpb24gYW5kL29yIG90aGVyIG1hdGVyaWFscyBwcm92aWRlZCB3aXRoIHRoZSBk aXN0cmlidXRpb24uIAorIworIyBUSElTIFNPRlRXQVJFIElTIFBST1ZJREVEIEJZIEFQUExFIElO Qy4gQU5EIElUUyBDT05UUklCVVRPUlMgIkFTIElTIiBBTkQgQU5ZCisjIEVYUFJFU1MgT1IgSU1Q TElFRCBXQVJSQU5USUVTLCBJTkNMVURJTkcsIEJVVCBOT1QgTElNSVRFRCBUTywgVEhFIElNUExJ RUQKKyMgV0FSUkFOVElFUyBPRiBNRVJDSEFOVEFCSUxJVFkgQU5EIEZJVE5FU1MgRk9SIEEgUEFS VElDVUxBUiBQVVJQT1NFIEFSRQorIyBESVNDTEFJTUVELiBJTiBOTyBFVkVOVCBTSEFMTCBBUFBM RSBPUiBJVFMgQ09OVFJJQlVUT1JTIEJFIExJQUJMRSBGT1IgQU5ZCisjIERJUkVDVCwgSU5ESVJF Q1QsIElOQ0lERU5UQUwsIFNQRUNJQUwsIEVYRU1QTEFSWSwgT1IgQ09OU0VRVUVOVElBTCBEQU1B R0VTCisjIChJTkNMVURJTkcsIEJVVCBOT1QgTElNSVRFRCBUTywgUFJPQ1VSRU1FTlQgT0YgU1VC U1RJVFVURSBHT09EUyBPUiBTRVJWSUNFUzsKKyMgTE9TUyBPRiBVU0UsIERBVEEsIE9SIFBST0ZJ VFM7IE9SIEJVU0lORVNTIElOVEVSUlVQVElPTikgSE9XRVZFUiBDQVVTRUQgQU5ECisjIE9OIEFO WSBUSEVPUlkgT0YgTElBQklMSVRZLCBXSEVUSEVSIElOIENPTlRSQUNULCBTVFJJQ1QgTElBQklM SVRZLCBPUiBUT1JUCisjIChJTkNMVURJTkcgTkVHTElHRU5DRSBPUiBPVEhFUldJU0UpIEFSSVNJ TkcgSU4gQU5ZIFdBWSBPVVQgT0YgVEhFIFVTRSBPRgorIyBUSElTIFNPRlRXQVJFLCBFVkVOIElG IEFEVklTRUQgT0YgVEhFIFBPU1NJQklMSVRZIE9GIFNVQ0ggREFNQUdFLgorCisjIFNjcmlwdCB0 byBjcmVhdGUgYSBuZXcgSFRNTCBmaWxlIGZvciBhIG1vbm9saXRoaWMgdGVzdCB1c2luZyBqcy10 ZXN0IG1hY2hpbmVyeS4KKwordXNlIHN0cmljdDsKKwordXNlIEZpbmRCaW47Cit1c2UgbGliICRG aW5kQmluOjpCaW47CisKK3VzZSBGaWxlOjpCYXNlbmFtZTsKK3VzZSBHZXRvcHQ6Okxvbmc7Cit1 c2Ugd2Via2l0ZGlyczsKKworc3ViIG1ha2VUZXN0UmVsYXRpdmVQYXRoVG9TaGFyZWRTb3VyY2Vz Oworc3ViIG9wZW5UZXN0SW5FZGl0b3I7CitzdWIgd3JpdGVUZXN0RmlsZTsKKworbXkgJHNob3dI ZWxwOworCitteSAkcmVzdWx0ID0gR2V0T3B0aW9ucygKKyAgICAiaGVscCIgICAgICAgPT4gXCRz aG93SGVscCwKKyk7CisKK2lmICghJHJlc3VsdCB8fCAkc2hvd0hlbHAgfHwgIXNjYWxhcihAQVJH VikgfHwgJEFSR1ZbMF0gIX4gbS9cLmh0bWwkLykgeworICAgIHByaW50IFNUREVSUiAiVXNhZ2U6 ICIgLiBiYXNlbmFtZSgkMCkgLiAiIFstaHwtLWhlbHBdIHBhdGhuYW1lXG4iOworICAgIHByaW50 IFNUREVSUiAiXG5FeGFtcGxlczpcbiI7CisgICAgcHJpbnQgU1RERVJSICIgICAgIiAuIGJhc2Vu YW1lKCQwKSAuICIgbmV3LXRlc3QuaHRtbCAod2lsbCBjcmVhdGUgdGhlIHRlc3QgaW4gY3VycmVu dCBkaXJlY3RvcnkpXG4iOworICAgIHByaW50IFNUREVSUiAiICAgICIgLiBiYXNlbmFtZSgkMCkg LiAiIGZhc3QvbG9hZGVyL25ldy10ZXN0Lmh0bWwgKGEgcmVsYXRpdmUgcGF0aCBpcyBhbHdheXMg ZnJvbSBMYXlvdXRUZXN0cyBkaXJlY3RvcnkpXG4iOworICAgIHByaW50IFNUREVSUiAiICAgICIg LiBiYXNlbmFtZSgkMCkgLiAiIC9Wb2x1bWVzL0RhdGEvV2ViS2l0L0xheW91dFRlc3RzL2Zhc3Qv bG9hZGVyL25ldy10ZXN0Lmh0bWxcbiI7CisgICAgZXhpdCAxOworfQorCitteSAkcHJvdmlkZWRQ YXRoID0gJEFSR1ZbMF07CisKK215ICR0ZXN0QWJzb2x1dGVQYXRoOworCisjIElmIG9ubHkgYSBm aWxlIG5hbWUgaXMgcHJvdmlkZWQsIGNyZWF0ZSB0aGUgdGVzdCBpbiBjdXJyZW50IGRpcmVjdG9y eS4KKyR0ZXN0QWJzb2x1dGVQYXRoID0gRmlsZTo6U3BlYy0+cmVsMmFicygkcHJvdmlkZWRQYXRo KSBpZiAoIShGaWxlOjpTcGVjLT5zcGxpdHBhdGgoJHByb3ZpZGVkUGF0aCkpWzFdKTsKKworIyBP dGhlcndpc2UsIGl0J3MgZWl0aGVyIGFic29sdXRlLCBvciByZWxhdGl2ZSB0byBMYXlvdXRUZXN0 cyBkaXJlY3RvcnkuCitjaGRpcldlYktpdCgpOworY2hkaXIgIkxheW91dFRlc3RzIjsKKyR0ZXN0 QWJzb2x1dGVQYXRoID0gRmlsZTo6U3BlYy0+cmVsMmFicygkcHJvdmlkZWRQYXRoKSBpZiAoISR0 ZXN0QWJzb2x1dGVQYXRoKTsKKword3JpdGVUZXN0RmlsZSgpOworCitwcmludCAiJHRlc3RBYnNv bHV0ZVBhdGhcbiI7CitvcGVuVGVzdEluRWRpdG9yKCk7CisKK2V4aXQgMDsKKworc3ViIG1ha2VU ZXN0UmVsYXRpdmVQYXRoVG9TaGFyZWRTb3VyY2VzCit7CisgICAgbXkgJGxheW91dFRlc3RzUGF0 aCA9IGdldGN3ZCgpOworICAgICR0ZXN0QWJzb2x1dGVQYXRoID1+IG0vXiRsYXlvdXRUZXN0c1Bh dGgvIG9yIGRpZSAiUGF0aCAkdGVzdEFic29sdXRlUGF0aCBpcyBub3QgaW4gTGF5b3V0VGVzdHMg ZGlyZWN0b3J5LlxuIjsKKyAgICBteSAkcmVzdWx0ID0gRmlsZTo6U3BlYy0+YWJzMnJlbCgiZmFz dC9qcy9yZXNvdXJjZXMvIiwgZGlybmFtZSgkdGVzdEFic29sdXRlUGF0aCkpOworICAgIHJldHVy biAkcmVzdWx0OworfQorCitzdWIgd3JpdGVUZXN0RmlsZQoreworICAgIGRpZSAiVGVzdCAkdGVz dEFic29sdXRlUGF0aCBhbHJlYWR5IGV4aXN0cy5cbiIgaWYgKC1lICR0ZXN0QWJzb2x1dGVQYXRo KTsKKworICAgIG15ICRyZWxhdGl2ZVBhdGhUb1NoYXJlZFNvdXJjZXMgPSBtYWtlVGVzdFJlbGF0 aXZlUGF0aFRvU2hhcmVkU291cmNlcygpOworCisgICAgb3BlbiBURVNULCAiPiIsICR7dGVzdEFi c29sdXRlUGF0aH0gb3IgZGllICJDYW5ub3QgY3JlYXRlIHRlc3QgZmlsZSBhdCAkdGVzdEFic29s dXRlUGF0aC5cbiI7CisgICAgcHJpbnQgVEVTVCA8PCAiRU9GIjsKKzwhRE9DVFlQRSBodG1sPgor PGh0bWw+Cis8aGVhZD4KKzxtZXRhIGNoYXJzZXQ9InV0Zi04Ij4KKzxsaW5rIHJlbD0ic3R5bGVz aGVldCIgaHJlZj0iJHJlbGF0aXZlUGF0aFRvU2hhcmVkU291cmNlcy9qcy10ZXN0LXN0eWxlLmNz cyI+Cis8c2NyaXB0IHNyYz0iJHJlbGF0aXZlUGF0aFRvU2hhcmVkU291cmNlcy9qcy10ZXN0LXBy ZS5qcyI+PC9zY3JpcHQ+Cis8dGl0bGU+PC90aXRsZT4KKzwvaGVhZD4KKzxib2R5PgorPHA+VEVT VCBERVNDUklQVElPTiBIRVJFPC9wPgorPGRpdiBpZD0iY29uc29sZSI+PC9kaXY+Cis8c2NyaXB0 PgorCisvLyBZb3VyIHRlc3Qgc2NyaXB0IGhlcmUuIEZlZWwgZnJlZSB0byBtb2RpZnkgc3Vycm91 bmRpbmcgSFRNTCBjb2RlIGlmIG5lY2Vzc2FyeS4KKwordmFyIHN1Y2Nlc3NmdWxseVBhcnNlZCA9 IHRydWU7CisKKzwvc2NyaXB0PgorPHNjcmlwdCBzcmM9IiRyZWxhdGl2ZVBhdGhUb1NoYXJlZFNv dXJjZXMvanMtdGVzdC1wb3N0LmpzIj48L3NjcmlwdD4KKzwvYm9keT4KKzwvaHRtbD4KK0VPRgor ICAgIGNsb3NlIFRFU1Q7Cit9CisKK3N1YiBvcGVuVGVzdEluRWRpdG9yKCkKK3sKKyAgICBteSAk ZWRpdG9yID0gJEVOVntFRElUT1J9OworICAgIGV4ZWMgKCRlZGl0b3IsICR0ZXN0QWJzb2x1dGVQ YXRoKSBpZiAoJGVkaXRvcik7Cit9CgpQcm9wZXJ0eSBjaGFuZ2VzIG9uOiBUb29scy9TY3JpcHRz L21ha2UtbmV3LXNjcmlwdC10ZXN0Cl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KQWRkZWQ6IHN2bjpleGVjdXRhYmxlCiAg ICsgKgoK