67745 2011-09-07 16:26:56 -0700 tables/mozilla/bugs/bug53690-1.html has never worked 2011-10-14 03:23:00 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 webkit.review.bot abarth abarth ap darin eric mitz oldest_to_newest 463757 0 webkit.review.bot 2011-09-07 16:26:56 -0700 tables/mozilla/bugs/bug53690-1.html has never worked Requested by abarth on #webkit. 463939 1 106705 abarth 2011-09-08 00:19:17 -0700 Created attachment 106705 Patch 464055 2 106705 eric 2011-09-08 08:10:57 -0700 Comment on attachment 106705 Patch Yay! 464218 3 mitz 2011-09-08 11:49:37 -0700 I am not sure it’s a good idea to remove this test. It is not easy to see how it is redundant. 464225 4 eric 2011-09-08 11:54:09 -0700 The test appears broken, all it was doing is printing this: CONSOLE MESSAGE: line 4: Uncaught TypeError: Cannot read property 'action' of undefined I don't think the test's intention was to document that document.forms[1] returns unsigned when there is only one form on the page. :) 464228 5 eric 2011-09-08 11:59:11 -0700 The original bug: https://bugzilla.mozilla.org/show_bug.cgi?id=53690 Original test: https://bug53690.bugzilla.mozilla.org/attachment.cgi?id=15971 The bug seems to be about table reflow. It's possible the test should just be modified to remove the action= part of the change, since all it seems to want to test is the document.write behavior. The test was noticed because Chromium "fails" the test due to differnet v8 messages (a long trail of tears). Adam removed it, seeking to remove always-broken tests. 464233 6 mitz 2011-09-08 12:02:48 -0700 (In reply to comment #4) > The test appears broken, all it was doing is printing this: > CONSOLE MESSAGE: line 4: Uncaught TypeError: Cannot read property 'action' of undefined Looking at platform/mac/tables/mozilla/bugs, I see that the test was producing a render tree dump and a pixel result. > I don't think the test's intention was to document that document.forms[1] returns unsigned when there is only one form on the page. :) Agreed. (In reply to comment #5) > The test was noticed because Chromium "fails" the test due to differnet v8 messages (a long trail of tears). Seems like a great test! We should have more test that uncover quirks and other problems, not fewer. 464234 7 eric 2011-09-08 12:04:12 -0700 (In reply to comment #6) > (In reply to comment #5) > > The test was noticed because Chromium "fails" the test due to differnet v8 messages (a long trail of tears). > > Seems like a great test! We should have more test that uncover quirks and other problems, not fewer. This is a well documented "quirk". :) If that were the only thing this test provided, it would not be a very good test for such. :) 464235 8 abarth 2011-09-08 12:06:21 -0700 > Seems like a great test! We should have more test that uncover quirks and other problems, not fewer. Fortunately (or unfortunately) we have lots of test coverage for that particular issue. :) 464236 9 abarth 2011-09-08 12:07:45 -0700 > It's possible the test should just be modified to remove the action= part of the change, since all it seems to want to test is the document.write behavior. Unfortunately, the document.write was never happening because the JavaScript threw an exception before it executed the write. We can change the test to do something else, but this test has never been testing anything, as far as I can tell. 464240 10 mitz 2011-09-08 12:15:56 -0700 (In reply to comment #9) > this test has never been testing anything, as far as I can tell. I have a render tree dump and an image saying otherwise. 464245 11 abarth 2011-09-08 12:19:49 -0700 (In reply to comment #10) > (In reply to comment #9) > > this test has never been testing anything, as far as I can tell. > > I have a render tree dump and an image saying otherwise. Can you explain what this test is testing? 464253 12 mitz 2011-09-08 12:33:36 -0700 (In reply to comment #11) > (In reply to comment #10) > > (In reply to comment #9) > > > this test has never been testing anything, as far as I can tell. > > > > I have a render tree dump and an image saying otherwise. > > Can you explain what this test is testing? It is testing (primarily table-) layout and rendering code. 464317 13 abarth 2011-09-08 13:47:24 -0700 > It is testing (primarily table-) layout and rendering code. Ok. If you're not interested in actually engaging in this discussion, we can leave this test in its useless state. 464347 14 mitz 2011-09-08 14:10:56 -0700 (In reply to comment #13) > > It is testing (primarily table-) layout and rendering code. > > Ok. If you're not interested in actually engaging in this discussion, we can leave this test in its useless state. While I’ll be happy with that result (leaving the test in its current state, which is not useless), I am sorry that you think that I am not interested in discussing this. Let me try again: detecting changes in behavior, which are possibly bugs, is one of the main reasons we have regression tests. Running the tests after making a code change often reveals an unanticipated, undesirable effect of the change on one ore more tests. It is not easy to determine that any unique test is redundant, in the sense that removing it will not allow an undesirable code change to sneak in; so in principle, the argument for removing a test should be more compelling than that it is not immediately obvious how a code change could cause it to fail without affecting any one of the remaining tests. 464369 15 abarth 2011-09-08 14:24:49 -0700 I assume you'll agree that this test is not intended to test HTML parsing. We have lots of test coverage for how the parser works in these situations. That means the important aspect is the DOM, which is the following: html body table tbody tr td table border=1 tbody tr td script td "x" which is almost identical to tables/mozilla/bugs/bug53690-2.html and a number of other table tests. The unique thing that this test was trying test was the interaction of document.writing a form in the middle of this process. However, because that was never happening, this test wasn't actually testing anything different than many other tests. 464443 16 mitz 2011-09-08 15:33:05 -0700 Can this be resolved by removing the content of the script element in this test? 464450 17 106705 abarth 2011-09-08 15:48:24 -0700 Comment on attachment 106705 Patch Sure. Thanks. 483846 18 110980 abarth 2011-10-14 01:41:03 -0700 Created attachment 110980 Patch 483849 19 110980 eric 2011-10-14 01:42:39 -0700 Comment on attachment 110980 Patch SGTM. 483889 20 110980 webkit.review.bot 2011-10-14 03:22:55 -0700 Comment on attachment 110980 Patch Clearing flags on attachment: 110980 Committed r97459: <http://trac.webkit.org/changeset/97459> 483890 21 webkit.review.bot 2011-10-14 03:23:00 -0700 All reviewed patches have been landed. Closing bug. 106705 2011-09-08 00:19:17 -0700 2011-10-14 01:40:59 -0700 Patch bug-67745-20110908001916.patch text/plain 8919 abarth SW5kZXg6IExheW91dFRlc3RzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9D aGFuZ2VMb2cJKHJldmlzaW9uIDk0NzQ2KQorKysgTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCSh3b3Jr aW5nIGNvcHkpCkBAIC0xLDMgKzEsMjcgQEAKKzIwMTEtMDktMDggIEFkYW0gQmFydGggIDxhYmFy dGhAd2Via2l0Lm9yZz4KKworICAgICAgICB0YWJsZXMvbW96aWxsYS9idWdzL2J1ZzUzNjkwLTEu aHRtbCBoYXMgbmV2ZXIgd29ya2VkCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3No b3dfYnVnLmNnaT9pZD02Nzc0NQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEp LgorCisgICAgICAgIFRoaXMgdGVzdCBuZXZlciByZWFsbHkgcmFuIGJlY2F1c2UgZG9jdW1lbnQu Zm9ybXNbMV0gaXNuJ3QgZGVmaW5lZC4gIFdlCisgICAgICAgIGNvdWxkIGFkZCBpbiBhIHZhbHVl IGZvciB0aGUgYWN0aW9uIGF0dHJpYnV0ZSwgYnV0IHRoaXMgdGVzdCBkb2Vzbid0CisgICAgICAg IGxvb2sgbGlrZSBpdCdzIHRlc3RpbmcgYW55dGhpbmcgcGFydGljdWxhcmx5IGludGVyZXN0aW5n IGFueXdheSwgc28gaXQKKyAgICAgICAgc2VlbXMgYmVzdCB0byBqdXN0IHJlbW92ZSBpdC4KKwor ICAgICAgICAqIHBsYXRmb3JtL2Nocm9taXVtLWxpbnV4L3RhYmxlcy9tb3ppbGxhL2J1Z3MvYnVn NTM2OTAtMS1leHBlY3RlZC5wbmc6IFJlbW92ZWQuCisgICAgICAgICogcGxhdGZvcm0vY2hyb21p dW0td2luL3RhYmxlcy9tb3ppbGxhL2J1Z3MvYnVnNTM2OTAtMS1leHBlY3RlZC5wbmc6IFJlbW92 ZWQuCisgICAgICAgICogcGxhdGZvcm0vY2hyb21pdW0td2luL3RhYmxlcy9tb3ppbGxhL2J1Z3Mv YnVnNTM2OTAtMS1leHBlY3RlZC50eHQ6IFJlbW92ZWQuCisgICAgICAgICogcGxhdGZvcm0vZ3Rr L3RhYmxlcy9tb3ppbGxhL2J1Z3MvYnVnNTM2OTAtMS1leHBlY3RlZC5wbmc6IFJlbW92ZWQuCisg ICAgICAgICogcGxhdGZvcm0vZ3RrL3RhYmxlcy9tb3ppbGxhL2J1Z3MvYnVnNTM2OTAtMS1leHBl Y3RlZC50eHQ6IFJlbW92ZWQuCisgICAgICAgICogcGxhdGZvcm0vbWFjLWxlb3BhcmQvdGFibGVz L21vemlsbGEvYnVncy9idWc1MzY5MC0xLWV4cGVjdGVkLnBuZzogUmVtb3ZlZC4KKyAgICAgICAg KiBwbGF0Zm9ybS9tYWMvdGFibGVzL21vemlsbGEvYnVncy9idWc1MzY5MC0xLWV4cGVjdGVkLnBu ZzogUmVtb3ZlZC4KKyAgICAgICAgKiBwbGF0Zm9ybS9tYWMvdGFibGVzL21vemlsbGEvYnVncy9i dWc1MzY5MC0xLWV4cGVjdGVkLnR4dDogUmVtb3ZlZC4KKyAgICAgICAgKiBwbGF0Zm9ybS9xdC90 YWJsZXMvbW96aWxsYS9idWdzL2J1ZzUzNjkwLTEtZXhwZWN0ZWQucG5nOiBSZW1vdmVkLgorICAg ICAgICAqIHBsYXRmb3JtL3F0L3RhYmxlcy9tb3ppbGxhL2J1Z3MvYnVnNTM2OTAtMS1leHBlY3Rl ZC50eHQ6IFJlbW92ZWQuCisgICAgICAgICogdGFibGVzL21vemlsbGEvYnVncy9idWc1MzY5MC0x Lmh0bWw6IFJlbW92ZWQuCisKIDIwMTEtMDktMDcgIEJlbiBXZWxscyAgPGJlbndlbGxzQGNocm9t aXVtLm9yZz4KIAogICAgICAgICBGaXggdHlwbyBpbiB0ZXN0X2V4cGVjdGF0aW9ucyBpbnRyb2R1 Y2VkIHdpdGggcjk0NzI1CkluZGV4OiBMYXlvdXRUZXN0cy9wbGF0Zm9ybS9jaHJvbWl1bS1saW51 eC90YWJsZXMvbW96aWxsYS9idWdzL2J1ZzUzNjkwLTEtZXhwZWN0ZWQucG5nCj09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0K Q2Fubm90IGRpc3BsYXk6IGZpbGUgbWFya2VkIGFzIGEgYmluYXJ5IHR5cGUuCnN2bjptaW1lLXR5 cGUgPSBpbWFnZS9wbmcKSW5kZXg6IExheW91dFRlc3RzL3BsYXRmb3JtL2Nocm9taXVtLXdpbi90 YWJsZXMvbW96aWxsYS9idWdzL2J1ZzUzNjkwLTEtZXhwZWN0ZWQucG5nCj09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KQ2Fu bm90IGRpc3BsYXk6IGZpbGUgbWFya2VkIGFzIGEgYmluYXJ5IHR5cGUuCnN2bjptaW1lLXR5cGUg PSBpbWFnZS9wbmcKSW5kZXg6IExheW91dFRlc3RzL3BsYXRmb3JtL2Nocm9taXVtLXdpbi90YWJs ZXMvbW96aWxsYS9idWdzL2J1ZzUzNjkwLTEtZXhwZWN0ZWQudHh0Cj09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIExh eW91dFRlc3RzL3BsYXRmb3JtL2Nocm9taXVtLXdpbi90YWJsZXMvbW96aWxsYS9idWdzL2J1ZzUz NjkwLTEtZXhwZWN0ZWQudHh0CShyZXZpc2lvbiA5NDc0NSkKKysrIExheW91dFRlc3RzL3BsYXRm b3JtL2Nocm9taXVtLXdpbi90YWJsZXMvbW96aWxsYS9idWdzL2J1ZzUzNjkwLTEtZXhwZWN0ZWQu dHh0CSh3b3JraW5nIGNvcHkpCkBAIC0xLDE3ICswLDAgQEAKLUNPTlNPTEUgTUVTU0FHRTogbGlu ZSA0OiBVbmNhdWdodCBUeXBlRXJyb3I6IENhbm5vdCByZWFkIHByb3BlcnR5ICdhY3Rpb24nIG9m IHVuZGVmaW5lZAotbGF5ZXIgYXQgKDAsMCkgc2l6ZSA4MDB4NjAwCi0gIFJlbmRlclZpZXcgYXQg KDAsMCkgc2l6ZSA4MDB4NjAwCi1sYXllciBhdCAoMCwwKSBzaXplIDgwMHg2MDAKLSAgUmVuZGVy QmxvY2sge0hUTUx9IGF0ICgwLDApIHNpemUgODAweDYwMAotICAgIFJlbmRlckJvZHkge0JPRFl9 IGF0ICg4LDgpIHNpemUgNzg0eDU4NAotICAgICAgUmVuZGVyVGFibGUge1RBQkxFfSBhdCAoMCww KSBzaXplIDMxeDI2Ci0gICAgICAgIFJlbmRlclRhYmxlU2VjdGlvbiB7VEJPRFl9IGF0ICgwLDAp IHNpemUgMzF4MjYKLSAgICAgICAgICBSZW5kZXJUYWJsZVJvdyB7VFJ9IGF0ICgwLDIpIHNpemUg MzF4MjIKLSAgICAgICAgICAgIFJlbmRlclRhYmxlQ2VsbCB7VER9IGF0ICgyLDcpIHNpemUgMTJ4 MTIgW3I9MCBjPTAgcnM9MSBjcz0xXQotICAgICAgICAgICAgICBSZW5kZXJUYWJsZSB7VEFCTEV9 IGF0ICgxLDEpIHNpemUgMTB4MTAgW2JvcmRlcjogKDFweCBvdXRzZXQgIzgwODA4MCldCi0gICAg ICAgICAgICAgICAgUmVuZGVyVGFibGVTZWN0aW9uIHtUQk9EWX0gYXQgKDEsMSkgc2l6ZSA4eDgK LSAgICAgICAgICAgICAgICAgIFJlbmRlclRhYmxlUm93IHtUUn0gYXQgKDAsMikgc2l6ZSA4eDQK LSAgICAgICAgICAgICAgICAgICAgUmVuZGVyVGFibGVDZWxsIHtURH0gYXQgKDIsMikgc2l6ZSA0 eDQgW2JvcmRlcjogKDFweCBpbnNldCAjODA4MDgwKV0gW3I9MCBjPTAgcnM9MSBjcz0xXQotICAg ICAgICAgICAgUmVuZGVyVGFibGVDZWxsIHtURH0gYXQgKDE2LDIpIHNpemUgMTN4MjIgW3I9MCBj PTEgcnM9MSBjcz0xXQotICAgICAgICAgICAgICBSZW5kZXJUZXh0IHsjdGV4dH0gYXQgKDEsMSkg c2l6ZSAxMXgxOQotICAgICAgICAgICAgICAgIHRleHQgcnVuIGF0ICgxLDEpIHdpZHRoIDExOiAi WCIKSW5kZXg6IExheW91dFRlc3RzL3BsYXRmb3JtL2d0ay90YWJsZXMvbW96aWxsYS9idWdzL2J1 ZzUzNjkwLTEtZXhwZWN0ZWQucG5nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KQ2Fubm90IGRpc3BsYXk6IGZpbGUgbWFy a2VkIGFzIGEgYmluYXJ5IHR5cGUuCnN2bjptaW1lLXR5cGUgPSBpbWFnZS9wbmcKSW5kZXg6IExh eW91dFRlc3RzL3BsYXRmb3JtL2d0ay90YWJsZXMvbW96aWxsYS9idWdzL2J1ZzUzNjkwLTEtZXhw ZWN0ZWQudHh0Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT0KLS0tIExheW91dFRlc3RzL3BsYXRmb3JtL2d0ay90YWJsZXMv bW96aWxsYS9idWdzL2J1ZzUzNjkwLTEtZXhwZWN0ZWQudHh0CShyZXZpc2lvbiA5NDc0NSkKKysr IExheW91dFRlc3RzL3BsYXRmb3JtL2d0ay90YWJsZXMvbW96aWxsYS9idWdzL2J1ZzUzNjkwLTEt ZXhwZWN0ZWQudHh0CSh3b3JraW5nIGNvcHkpCkBAIC0xLDE3ICswLDAgQEAKLUNPTlNPTEUgTUVT U0FHRTogbGluZSA0OiBUeXBlRXJyb3I6ICd1bmRlZmluZWQnIGlzIG5vdCBhbiBvYmplY3QgKGV2 YWx1YXRpbmcgJ2RvY3VtZW50LmZvcm1zWzFdLmFjdGlvbicpCi1sYXllciBhdCAoMCwwKSBzaXpl IDgwMHg2MDAKLSAgUmVuZGVyVmlldyBhdCAoMCwwKSBzaXplIDgwMHg2MDAKLWxheWVyIGF0ICgw LDApIHNpemUgODAweDYwMAotICBSZW5kZXJCbG9jayB7SFRNTH0gYXQgKDAsMCkgc2l6ZSA4MDB4 NjAwCi0gICAgUmVuZGVyQm9keSB7Qk9EWX0gYXQgKDgsOCkgc2l6ZSA3ODR4NTg0Ci0gICAgICBS ZW5kZXJUYWJsZSB7VEFCTEV9IGF0ICgwLDApIHNpemUgMzJ4MjUKLSAgICAgICAgUmVuZGVyVGFi bGVTZWN0aW9uIHtUQk9EWX0gYXQgKDAsMCkgc2l6ZSAzMngyNQotICAgICAgICAgIFJlbmRlclRh YmxlUm93IHtUUn0gYXQgKDAsMikgc2l6ZSAzMngyMQotICAgICAgICAgICAgUmVuZGVyVGFibGVD ZWxsIHtURH0gYXQgKDIsNikgc2l6ZSAxMngxMiBbcj0wIGM9MCBycz0xIGNzPTFdCi0gICAgICAg ICAgICAgIFJlbmRlclRhYmxlIHtUQUJMRX0gYXQgKDEsMSkgc2l6ZSAxMHgxMCBbYm9yZGVyOiAo MXB4IG91dHNldCAjODA4MDgwKV0KLSAgICAgICAgICAgICAgICBSZW5kZXJUYWJsZVNlY3Rpb24g e1RCT0RZfSBhdCAoMSwxKSBzaXplIDh4OAotICAgICAgICAgICAgICAgICAgUmVuZGVyVGFibGVS b3cge1RSfSBhdCAoMCwyKSBzaXplIDh4NAotICAgICAgICAgICAgICAgICAgICBSZW5kZXJUYWJs ZUNlbGwge1REfSBhdCAoMiwyKSBzaXplIDR4NCBbYm9yZGVyOiAoMXB4IGluc2V0ICM4MDgwODAp XSBbcj0wIGM9MCBycz0xIGNzPTFdCi0gICAgICAgICAgICBSZW5kZXJUYWJsZUNlbGwge1REfSBh dCAoMTYsMikgc2l6ZSAxNHgyMSBbcj0wIGM9MSBycz0xIGNzPTFdCi0gICAgICAgICAgICAgIFJl bmRlclRleHQgeyN0ZXh0fSBhdCAoMSwxKSBzaXplIDEyeDE5Ci0gICAgICAgICAgICAgICAgdGV4 dCBydW4gYXQgKDEsMSkgd2lkdGggMTI6ICJYIgpJbmRleDogTGF5b3V0VGVzdHMvcGxhdGZvcm0v bWFjLWxlb3BhcmQvdGFibGVzL21vemlsbGEvYnVncy9idWc1MzY5MC0xLWV4cGVjdGVkLnBuZwo9 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09CkNhbm5vdCBkaXNwbGF5OiBmaWxlIG1hcmtlZCBhcyBhIGJpbmFyeSB0eXBlLgpz dm46bWltZS10eXBlID0gaW1hZ2UvcG5nCkluZGV4OiBMYXlvdXRUZXN0cy9wbGF0Zm9ybS9tYWMv dGFibGVzL21vemlsbGEvYnVncy9idWc1MzY5MC0xLWV4cGVjdGVkLnBuZwo9PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09CkNh bm5vdCBkaXNwbGF5OiBmaWxlIG1hcmtlZCBhcyBhIGJpbmFyeSB0eXBlLgpzdm46bWltZS10eXBl ID0gaW1hZ2UvcG5nCkluZGV4OiBMYXlvdXRUZXN0cy9wbGF0Zm9ybS9tYWMvdGFibGVzL21vemls bGEvYnVncy9idWc1MzY5MC0xLWV4cGVjdGVkLnR4dAo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0 cy9wbGF0Zm9ybS9tYWMvdGFibGVzL21vemlsbGEvYnVncy9idWc1MzY5MC0xLWV4cGVjdGVkLnR4 dAkocmV2aXNpb24gOTQ3NDUpCisrKyBMYXlvdXRUZXN0cy9wbGF0Zm9ybS9tYWMvdGFibGVzL21v emlsbGEvYnVncy9idWc1MzY5MC0xLWV4cGVjdGVkLnR4dAkod29ya2luZyBjb3B5KQpAQCAtMSwx NyArMCwwIEBACi1DT05TT0xFIE1FU1NBR0U6IGxpbmUgNDogVHlwZUVycm9yOiAndW5kZWZpbmVk JyBpcyBub3QgYW4gb2JqZWN0IChldmFsdWF0aW5nICdkb2N1bWVudC5mb3Jtc1sxXS5hY3Rpb24n KQotbGF5ZXIgYXQgKDAsMCkgc2l6ZSA4MDB4NjAwCi0gIFJlbmRlclZpZXcgYXQgKDAsMCkgc2l6 ZSA4MDB4NjAwCi1sYXllciBhdCAoMCwwKSBzaXplIDgwMHg2MDAKLSAgUmVuZGVyQmxvY2sge0hU TUx9IGF0ICgwLDApIHNpemUgODAweDYwMAotICAgIFJlbmRlckJvZHkge0JPRFl9IGF0ICg4LDgp IHNpemUgNzg0eDU4NAotICAgICAgUmVuZGVyVGFibGUge1RBQkxFfSBhdCAoMCwwKSBzaXplIDMy eDI0Ci0gICAgICAgIFJlbmRlclRhYmxlU2VjdGlvbiB7VEJPRFl9IGF0ICgwLDApIHNpemUgMzJ4 MjQKLSAgICAgICAgICBSZW5kZXJUYWJsZVJvdyB7VFJ9IGF0ICgwLDIpIHNpemUgMzJ4MjAKLSAg ICAgICAgICAgIFJlbmRlclRhYmxlQ2VsbCB7VER9IGF0ICgyLDYpIHNpemUgMTJ4MTIgW3I9MCBj PTAgcnM9MSBjcz0xXQotICAgICAgICAgICAgICBSZW5kZXJUYWJsZSB7VEFCTEV9IGF0ICgxLDEp IHNpemUgMTB4MTAgW2JvcmRlcjogKDFweCBvdXRzZXQgIzgwODA4MCldCi0gICAgICAgICAgICAg ICAgUmVuZGVyVGFibGVTZWN0aW9uIHtUQk9EWX0gYXQgKDEsMSkgc2l6ZSA4eDgKLSAgICAgICAg ICAgICAgICAgIFJlbmRlclRhYmxlUm93IHtUUn0gYXQgKDAsMikgc2l6ZSA4eDQKLSAgICAgICAg ICAgICAgICAgICAgUmVuZGVyVGFibGVDZWxsIHtURH0gYXQgKDIsMikgc2l6ZSA0eDQgW2JvcmRl cjogKDFweCBpbnNldCAjODA4MDgwKV0gW3I9MCBjPTAgcnM9MSBjcz0xXQotICAgICAgICAgICAg UmVuZGVyVGFibGVDZWxsIHtURH0gYXQgKDE2LDIpIHNpemUgMTR4MjAgW3I9MCBjPTEgcnM9MSBj cz0xXQotICAgICAgICAgICAgICBSZW5kZXJUZXh0IHsjdGV4dH0gYXQgKDEsMSkgc2l6ZSAxMngx OAotICAgICAgICAgICAgICAgIHRleHQgcnVuIGF0ICgxLDEpIHdpZHRoIDEyOiAiWCIKSW5kZXg6 IExheW91dFRlc3RzL3BsYXRmb3JtL3F0L3RhYmxlcy9tb3ppbGxhL2J1Z3MvYnVnNTM2OTAtMS1l eHBlY3RlZC5wbmcKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PQpDYW5ub3QgZGlzcGxheTogZmlsZSBtYXJrZWQgYXMgYSBi aW5hcnkgdHlwZS4Kc3ZuOm1pbWUtdHlwZSA9IGltYWdlL3BuZwpJbmRleDogTGF5b3V0VGVzdHMv cGxhdGZvcm0vcXQvdGFibGVzL21vemlsbGEvYnVncy9idWc1MzY5MC0xLWV4cGVjdGVkLnR4dAo9 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9wbGF0Zm9ybS9xdC90YWJsZXMvbW96aWxsYS9idWdz L2J1ZzUzNjkwLTEtZXhwZWN0ZWQudHh0CShyZXZpc2lvbiA5NDc0NSkKKysrIExheW91dFRlc3Rz L3BsYXRmb3JtL3F0L3RhYmxlcy9tb3ppbGxhL2J1Z3MvYnVnNTM2OTAtMS1leHBlY3RlZC50eHQJ KHdvcmtpbmcgY29weSkKQEAgLTEsMTcgKzAsMCBAQAotQ09OU09MRSBNRVNTQUdFOiBsaW5lIDQ6 IFR5cGVFcnJvcjogJ3VuZGVmaW5lZCcgaXMgbm90IGFuIG9iamVjdCAoZXZhbHVhdGluZyAnZG9j dW1lbnQuZm9ybXNbMV0uYWN0aW9uJykKLWxheWVyIGF0ICgwLDApIHNpemUgODAweDYwMAotICBS ZW5kZXJWaWV3IGF0ICgwLDApIHNpemUgODAweDYwMAotbGF5ZXIgYXQgKDAsMCkgc2l6ZSA4MDB4 NjAwCi0gIFJlbmRlckJsb2NrIHtIVE1MfSBhdCAoMCwwKSBzaXplIDgwMHg2MDAKLSAgICBSZW5k ZXJCb2R5IHtCT0RZfSBhdCAoOCw4KSBzaXplIDc4NHg1ODQKLSAgICAgIFJlbmRlclRhYmxlIHtU QUJMRX0gYXQgKDAsMCkgc2l6ZSAzMngyOAotICAgICAgICBSZW5kZXJUYWJsZVNlY3Rpb24ge1RC T0RZfSBhdCAoMCwwKSBzaXplIDMyeDI4Ci0gICAgICAgICAgUmVuZGVyVGFibGVSb3cge1RSfSBh dCAoMCwyKSBzaXplIDMyeDI0Ci0gICAgICAgICAgICBSZW5kZXJUYWJsZUNlbGwge1REfSBhdCAo Miw4KSBzaXplIDEyeDEyIFtyPTAgYz0wIHJzPTEgY3M9MV0KLSAgICAgICAgICAgICAgUmVuZGVy VGFibGUge1RBQkxFfSBhdCAoMSwxKSBzaXplIDEweDEwIFtib3JkZXI6ICgxcHggb3V0c2V0ICM4 MDgwODApXQotICAgICAgICAgICAgICAgIFJlbmRlclRhYmxlU2VjdGlvbiB7VEJPRFl9IGF0ICgx LDEpIHNpemUgOHg4Ci0gICAgICAgICAgICAgICAgICBSZW5kZXJUYWJsZVJvdyB7VFJ9IGF0ICgw LDIpIHNpemUgOHg0Ci0gICAgICAgICAgICAgICAgICAgIFJlbmRlclRhYmxlQ2VsbCB7VER9IGF0 ICgyLDIpIHNpemUgNHg0IFtib3JkZXI6ICgxcHggaW5zZXQgIzgwODA4MCldIFtyPTAgYz0wIHJz PTEgY3M9MV0KLSAgICAgICAgICAgIFJlbmRlclRhYmxlQ2VsbCB7VER9IGF0ICgxNiwyKSBzaXpl IDE0eDI0IFtyPTAgYz0xIHJzPTEgY3M9MV0KLSAgICAgICAgICAgICAgUmVuZGVyVGV4dCB7I3Rl eHR9IGF0ICgxLDEpIHNpemUgMTJ4MjIKLSAgICAgICAgICAgICAgICB0ZXh0IHJ1biBhdCAoMSwx KSB3aWR0aCAxMjogIlgiCkluZGV4OiBMYXlvdXRUZXN0cy90YWJsZXMvbW96aWxsYS9idWdzL2J1 ZzUzNjkwLTEuaHRtbAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy90YWJsZXMvbW96aWxsYS9i dWdzL2J1ZzUzNjkwLTEuaHRtbAkocmV2aXNpb24gOTQ3NDUpCisrKyBMYXlvdXRUZXN0cy90YWJs ZXMvbW96aWxsYS9idWdzL2J1ZzUzNjkwLTEuaHRtbAkod29ya2luZyBjb3B5KQpAQCAtMSw3ICsw LDAgQEAKLTxIVE1MPjxCT0RZPjxUQUJMRT48VFI+PFREPgotIDxUQUJMRSBib3JkZXI9MT48VFI+ PFREPjxTQ1JJUFQgbGFuZ3VhZ2U9SmF2YVNjcmlwdD4KLQotZG9jdW1lbnQud3JpdGUoJzxmb3Jt IG1ldGhvZD1wb3N0IG5hbWUgPSAiRG9taW5vRm9ybTEiIGFjdGlvbj0iJyArIGRvY3VtZW50LmZv cm1zWzFdLmFjdGlvbiArICciPicpOwotCi08L1NDUklQVD4KLTwvVEQ+PC9UUj48L1RBQkxFPjwv VEQ+PFREPlg8L1REPjwvVFI+PC9UQUJMRT4K 110980 2011-10-14 01:41:03 -0700 2011-10-14 03:22:55 -0700 Patch bug-67745-20111014014101.patch text/plain 3665 abarth SW5kZXg6IExheW91dFRlc3RzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9D aGFuZ2VMb2cJKHJldmlzaW9uIDk3NDUxKQorKysgTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCSh3b3Jr aW5nIGNvcHkpCkBAIC0xLDMgKzEsMTkgQEAKKzIwMTEtMTAtMTQgIEFkYW0gQmFydGggIDxhYmFy dGhAd2Via2l0Lm9yZz4KKworICAgICAgICB0YWJsZXMvbW96aWxsYS9idWdzL2J1ZzUzNjkwLTEu aHRtbCBoYXMgbmV2ZXIgd29ya2VkCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3No b3dfYnVnLmNnaT9pZD02Nzc0NQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEp LgorCisgICAgICAgIFByZXZpb3VzbHksIHRoaXMgc2NyaXB0IGhhZCBqdXN0IGVycm9yZWQgb3V0 LiAgVGhpcyBwYXRjaCByZW1vdmVzIHRoZQorICAgICAgICBzY3JpcHQsIG1ha2luZyB0aGUgcmVz dWx0cyBtb3JlIHNhbmUuCisKKyAgICAgICAgKiBwbGF0Zm9ybS9jaHJvbWl1bS13aW4vdGFibGVz L21vemlsbGEvYnVncy9idWc1MzY5MC0xLWV4cGVjdGVkLnR4dDoKKyAgICAgICAgKiBwbGF0Zm9y bS9ndGsvdGFibGVzL21vemlsbGEvYnVncy9idWc1MzY5MC0xLWV4cGVjdGVkLnR4dDoKKyAgICAg ICAgKiBwbGF0Zm9ybS9tYWMvdGFibGVzL21vemlsbGEvYnVncy9idWc1MzY5MC0xLWV4cGVjdGVk LnR4dDoKKyAgICAgICAgKiBwbGF0Zm9ybS9xdC90YWJsZXMvbW96aWxsYS9idWdzL2J1ZzUzNjkw LTEtZXhwZWN0ZWQudHh0OgorICAgICAgICAqIHRhYmxlcy9tb3ppbGxhL2J1Z3MvYnVnNTM2OTAt MS5odG1sOgorCiAyMDExLTEwLTEzICBIYW5zIFdlbm5ib3JnICA8aGFuc0BjaHJvbWl1bS5vcmc+ CiAKICAgICAgICAgSW5kZXhlZERCOiBNYWtlIElEQkN1cnNvci52YWx1ZSgpIHJldHVybiBhbiBJ REJBbnkgb2JqZWN0CkluZGV4OiBMYXlvdXRUZXN0cy9wbGF0Zm9ybS9jaHJvbWl1bS13aW4vdGFi bGVzL21vemlsbGEvYnVncy9idWc1MzY5MC0xLWV4cGVjdGVkLnR4dAo9PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBM YXlvdXRUZXN0cy9wbGF0Zm9ybS9jaHJvbWl1bS13aW4vdGFibGVzL21vemlsbGEvYnVncy9idWc1 MzY5MC0xLWV4cGVjdGVkLnR4dAkocmV2aXNpb24gOTc0MzkpCisrKyBMYXlvdXRUZXN0cy9wbGF0 Zm9ybS9jaHJvbWl1bS13aW4vdGFibGVzL21vemlsbGEvYnVncy9idWc1MzY5MC0xLWV4cGVjdGVk LnR4dAkod29ya2luZyBjb3B5KQpAQCAtMSw0ICsxLDMgQEAKLUNPTlNPTEUgTUVTU0FHRTogbGlu ZSA0OiBVbmNhdWdodCBUeXBlRXJyb3I6IENhbm5vdCByZWFkIHByb3BlcnR5ICdhY3Rpb24nIG9m IHVuZGVmaW5lZAogbGF5ZXIgYXQgKDAsMCkgc2l6ZSA4MDB4NjAwCiAgIFJlbmRlclZpZXcgYXQg KDAsMCkgc2l6ZSA4MDB4NjAwCiBsYXllciBhdCAoMCwwKSBzaXplIDgwMHg2MDAKSW5kZXg6IExh eW91dFRlc3RzL3BsYXRmb3JtL2d0ay90YWJsZXMvbW96aWxsYS9idWdzL2J1ZzUzNjkwLTEtZXhw ZWN0ZWQudHh0Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT0KLS0tIExheW91dFRlc3RzL3BsYXRmb3JtL2d0ay90YWJsZXMv bW96aWxsYS9idWdzL2J1ZzUzNjkwLTEtZXhwZWN0ZWQudHh0CShyZXZpc2lvbiA5NzQzOSkKKysr IExheW91dFRlc3RzL3BsYXRmb3JtL2d0ay90YWJsZXMvbW96aWxsYS9idWdzL2J1ZzUzNjkwLTEt ZXhwZWN0ZWQudHh0CSh3b3JraW5nIGNvcHkpCkBAIC0xLDQgKzEsMyBAQAotQ09OU09MRSBNRVNT QUdFOiBsaW5lIDQ6IFR5cGVFcnJvcjogJ3VuZGVmaW5lZCcgaXMgbm90IGFuIG9iamVjdCAoZXZh bHVhdGluZyAnZG9jdW1lbnQuZm9ybXNbMV0uYWN0aW9uJykKIGxheWVyIGF0ICgwLDApIHNpemUg ODAweDYwMAogICBSZW5kZXJWaWV3IGF0ICgwLDApIHNpemUgODAweDYwMAogbGF5ZXIgYXQgKDAs MCkgc2l6ZSA4MDB4NjAwCkluZGV4OiBMYXlvdXRUZXN0cy9wbGF0Zm9ybS9tYWMvdGFibGVzL21v emlsbGEvYnVncy9idWc1MzY5MC0xLWV4cGVjdGVkLnR4dAo9PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRU ZXN0cy9wbGF0Zm9ybS9tYWMvdGFibGVzL21vemlsbGEvYnVncy9idWc1MzY5MC0xLWV4cGVjdGVk LnR4dAkocmV2aXNpb24gOTc0MzkpCisrKyBMYXlvdXRUZXN0cy9wbGF0Zm9ybS9tYWMvdGFibGVz L21vemlsbGEvYnVncy9idWc1MzY5MC0xLWV4cGVjdGVkLnR4dAkod29ya2luZyBjb3B5KQpAQCAt MSw0ICsxLDMgQEAKLUNPTlNPTEUgTUVTU0FHRTogbGluZSA0OiBUeXBlRXJyb3I6ICd1bmRlZmlu ZWQnIGlzIG5vdCBhbiBvYmplY3QgKGV2YWx1YXRpbmcgJ2RvY3VtZW50LmZvcm1zWzFdLmFjdGlv bicpCiBsYXllciBhdCAoMCwwKSBzaXplIDgwMHg2MDAKICAgUmVuZGVyVmlldyBhdCAoMCwwKSBz aXplIDgwMHg2MDAKIGxheWVyIGF0ICgwLDApIHNpemUgODAweDYwMApJbmRleDogTGF5b3V0VGVz dHMvcGxhdGZvcm0vcXQvdGFibGVzL21vemlsbGEvYnVncy9idWc1MzY5MC0xLWV4cGVjdGVkLnR4 dAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9wbGF0Zm9ybS9xdC90YWJsZXMvbW96aWxsYS9i dWdzL2J1ZzUzNjkwLTEtZXhwZWN0ZWQudHh0CShyZXZpc2lvbiA5NzQzOSkKKysrIExheW91dFRl c3RzL3BsYXRmb3JtL3F0L3RhYmxlcy9tb3ppbGxhL2J1Z3MvYnVnNTM2OTAtMS1leHBlY3RlZC50 eHQJKHdvcmtpbmcgY29weSkKQEAgLTEsNCArMSwzIEBACi1DT05TT0xFIE1FU1NBR0U6IGxpbmUg NDogVHlwZUVycm9yOiAndW5kZWZpbmVkJyBpcyBub3QgYW4gb2JqZWN0IChldmFsdWF0aW5nICdk b2N1bWVudC5mb3Jtc1sxXS5hY3Rpb24nKQogbGF5ZXIgYXQgKDAsMCkgc2l6ZSA4MDB4NjAwCiAg IFJlbmRlclZpZXcgYXQgKDAsMCkgc2l6ZSA4MDB4NjAwCiBsYXllciBhdCAoMCwwKSBzaXplIDgw MHg2MDAKSW5kZXg6IExheW91dFRlc3RzL3RhYmxlcy9tb3ppbGxhL2J1Z3MvYnVnNTM2OTAtMS5o dG1sCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT0KLS0tIExheW91dFRlc3RzL3RhYmxlcy9tb3ppbGxhL2J1Z3MvYnVnNTM2 OTAtMS5odG1sCShyZXZpc2lvbiA5NzQzOSkKKysrIExheW91dFRlc3RzL3RhYmxlcy9tb3ppbGxh L2J1Z3MvYnVnNTM2OTAtMS5odG1sCSh3b3JraW5nIGNvcHkpCkBAIC0xLDcgKzEsNCBAQAogPEhU TUw+PEJPRFk+PFRBQkxFPjxUUj48VEQ+CiAgPFRBQkxFIGJvcmRlcj0xPjxUUj48VEQ+PFNDUklQ VCBsYW5ndWFnZT1KYXZhU2NyaXB0PgotCi1kb2N1bWVudC53cml0ZSgnPGZvcm0gbWV0aG9kPXBv c3QgbmFtZSA9ICJEb21pbm9Gb3JtMSIgYWN0aW9uPSInICsgZG9jdW1lbnQuZm9ybXNbMV0uYWN0 aW9uICsgJyI+Jyk7Ci0KIDwvU0NSSVBUPgogPC9URD48L1RSPjwvVEFCTEU+PC9URD48VEQ+WDwv VEQ+PC9UUj48L1RBQkxFPgo=