67743 2011-09-07 15:35:07 -0700 AX: some popup buttons not announced by VoiceOver 2011-11-01 08:19:36 -0700 1 1 1 Unclassified WebKit Accessibility 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 cfleizach cfleizach oldest_to_newest 463706 0 cfleizach 2011-09-07 15:35:07 -0700 * STEPS TO REPRODUCE 1. http://public.yahoo.com/kloots/menu-button-test.html * RESULTS First two buttons behave as expected: "Options popup button" Second two buttons do not: "Options button" Expected "Options popup button" WebKit is exposing the first set as: AXRole: AXPopupButton AXHasPopup: YES WebKit is exposing the second set as: AXRole: AXButton AXHasPopup: YES 463707 1 cfleizach 2011-09-07 15:35:15 -0700 rdar://9244123 463713 2 106661 cfleizach 2011-09-07 15:42:00 -0700 Created attachment 106661 patch In the patch, I remove this block if (node && node->hasTagName(buttonTag)) because it's duplicated only a few lines above that. This is removed - if (cssBox && cssBox->isRenderButton()) - return toRenderButton(m_renderer)->text(); because it causes the text to be duplicated as the title. 491221 3 106661 cfleizach 2011-10-26 15:24:09 -0700 Comment on attachment 106661 patch View in context: https://bugs.webkit.org/attachment.cgi?id=106661&action=review > Source/WebCore/accessibility/AccessibilityRenderObject.cpp:1157 > if (isWebArea()) { This is where the AXValue of a button can be duplicated in the AXTitle if there's a value attribute used in the button 493647 4 106661 darin 2011-10-31 17:11:41 -0700 Comment on attachment 106661 patch View in context: https://bugs.webkit.org/attachment.cgi?id=106661&action=review > Source/WebCore/accessibility/AccessibilityRenderObject.cpp:3107 > + return (ariaHasPopup()) ? PopUpButtonRole : ButtonRole; Extra parentheses here that are not needed. 493908 5 cfleizach 2011-11-01 08:19:36 -0700 http://trac.webkit.org/changeset/98962 106661 2011-09-07 15:42:00 -0700 2011-10-31 17:11:41 -0700 patch patch.txt text/plain 7210 cfleizach SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDk0NzE5KQorKysgU291cmNlL1dlYkNvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDUgKzEsMjUgQEAKIDIwMTEtMDktMDcgIENocmlzIEZs ZWl6YWNoICA8Y2ZsZWl6YWNoQGFwcGxlLmNvbT4KIAorICAgICAgICBBWDogc29tZSBwb3B1cCBi dXR0b25zIG5vdCBhbm5vdW5jZWQgYnkgVm9pY2VPdmVyCisgICAgICAgIGh0dHBzOi8vYnVncy53 ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD02Nzc0MworCisgICAgICAgIFJldmlld2VkIGJ5IE5P Qk9EWSAoT09QUyEpLgorCisgICAgICAgIFdlIG5lZWQgdG8gYWxsb3cgbmF0aXZlIGJ1dHRvbnMg KDxpbnB1dD4gYW5kIDxidXR0b24+IHN0eWxlKSB0byBiZWNvbWUKKyAgICAgICAgcG9wdXAgYnV0 dG9ucyBpZiBBUklBIGRlZW1zIHRoZW0gc28uCisKKyAgICAgICAgVGhpcyBhbHNvIGV4cG9zZWQg YW4gaXNzdWUgd2hlcmUgdGhlIHRpdGxlIHRoZSB2YWx1ZSB3b3VsZCBiZSBkdXBsaWNhdGVkIGZv ciBhIAorICAgICAgICA8YnV0dG9uPiBzdHlsZSBidXR0b24uIEJvdGggaXNzdWVzIGFyZSBjYXB0 dXJlZCBpbiB0aGUgbGF5b3V0IHRlc3QuCisKKyAgICAgICAgVGVzdDogcGxhdGZvcm0vbWFjL2Fj Y2Vzc2liaWxpdHkvYXJpYS1wb3B1cC1idXR0b25zLW9uLW5hdGl2ZS1lbGVtZW50cy5odG1sCisK KyAgICAgICAgKiBhY2Nlc3NpYmlsaXR5L0FjY2Vzc2liaWxpdHlSZW5kZXJPYmplY3QuY3BwOgor ICAgICAgICAoV2ViQ29yZTo6QWNjZXNzaWJpbGl0eVJlbmRlck9iamVjdDo6c3RyaW5nVmFsdWUp OgorICAgICAgICAoV2ViQ29yZTo6QWNjZXNzaWJpbGl0eVJlbmRlck9iamVjdDo6dGl0bGUpOgor ICAgICAgICAoV2ViQ29yZTo6QWNjZXNzaWJpbGl0eVJlbmRlck9iamVjdDo6ZGV0ZXJtaW5lQWNj ZXNzaWJpbGl0eVJvbGUpOgorCisyMDExLTA5LTA3ICBDaHJpcyBGbGVpemFjaCAgPGNmbGVpemFj aEBhcHBsZS5jb20+CisKICAgICAgICAgQ2hhbmdlcyB0byBhcmlhLWhpZGRlbiBkb24ndCBjaGFu Z2UgVk8gbmF2aWdhdGlvbgogICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1 Zy5jZ2k/aWQ9Njc3MjIKIApJbmRleDogU291cmNlL1dlYkNvcmUvYWNjZXNzaWJpbGl0eS9BY2Nl c3NpYmlsaXR5UmVuZGVyT2JqZWN0LmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9h Y2Nlc3NpYmlsaXR5L0FjY2Vzc2liaWxpdHlSZW5kZXJPYmplY3QuY3BwCShyZXZpc2lvbiA5NDcx NikKKysrIFNvdXJjZS9XZWJDb3JlL2FjY2Vzc2liaWxpdHkvQWNjZXNzaWJpbGl0eVJlbmRlck9i amVjdC5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTExNTQsOSArMTE1NCw2IEBACiAgICAgaWYgKG1f cmVuZGVyZXItPmlzTGlzdE1hcmtlcigpKQogICAgICAgICByZXR1cm4gdG9SZW5kZXJMaXN0TWFy a2VyKG1fcmVuZGVyZXIpLT50ZXh0KCk7CiAgICAgCi0gICAgaWYgKGNzc0JveCAmJiBjc3NCb3gt PmlzUmVuZGVyQnV0dG9uKCkpCi0gICAgICAgIHJldHVybiB0b1JlbmRlckJ1dHRvbihtX3JlbmRl cmVyKS0+dGV4dCgpOwotCiAgICAgaWYgKGlzV2ViQXJlYSgpKSB7CiAgICAgICAgIC8vIEZJWE1F OiBXaHkgd291bGQgYSByZW5kZXJlciBleGlzdCB3aGVuIHRoZSBEb2N1bWVudCBpc24ndCBhdHRh Y2hlZCB0byBhIGZyYW1lPwogICAgICAgICBpZiAobV9yZW5kZXJlci0+ZnJhbWUoKSkKQEAgLTEy OTEsNyArMTI4OCw3IEBACiAKIFN0cmluZyBBY2Nlc3NpYmlsaXR5UmVuZGVyT2JqZWN0Ojp0aXRs ZSgpIGNvbnN0CiB7Ci0gICAgQWNjZXNzaWJpbGl0eVJvbGUgYXJpYVJvbGUgPSBhcmlhUm9sZUF0 dHJpYnV0ZSgpOworICAgIEFjY2Vzc2liaWxpdHlSb2xlIHJvbGUgPSByb2xlVmFsdWUoKTsKICAg ICAKICAgICBpZiAoIW1fcmVuZGVyZXIpCiAgICAgICAgIHJldHVybiBTdHJpbmcoKTsKQEAgLTEz MTEsMjQgKzEzMDgsMjkgQEAKICAgICAgICAgICAgIHJldHVybiBpbnB1dC0+dmFsdWUoKTsKICAg ICB9CiAgICAgCi0gICAgaWYgKGlzSW5wdXRUYWcgfHwgQWNjZXNzaWJpbGl0eU9iamVjdDo6aXNB UklBSW5wdXQoYXJpYVJvbGUpIHx8IGlzQ29udHJvbCgpKSB7CisgICAgaWYgKGlzSW5wdXRUYWcg fHwgQWNjZXNzaWJpbGl0eU9iamVjdDo6aXNBUklBSW5wdXQoYXJpYVJvbGVBdHRyaWJ1dGUoKSkg fHwgaXNDb250cm9sKCkpIHsKICAgICAgICAgSFRNTExhYmVsRWxlbWVudCogbGFiZWwgPSBsYWJl bEZvckVsZW1lbnQoc3RhdGljX2Nhc3Q8RWxlbWVudCo+KG5vZGUpKTsKICAgICAgICAgaWYgKGxh YmVsICYmICF0aXRsZVVJRWxlbWVudCgpKQogICAgICAgICAgICAgcmV0dXJuIGxhYmVsLT5pbm5l clRleHQoKTsKICAgICB9CiAgICAgCi0gICAgaWYgKHJvbGVWYWx1ZSgpID09IEJ1dHRvblJvbGUK LSAgICAgICAgfHwgYXJpYVJvbGUgPT0gTGlzdEJveE9wdGlvblJvbGUKLSAgICAgICAgfHwgYXJp YVJvbGUgPT0gTWVudUl0ZW1Sb2xlCi0gICAgICAgIHx8IGFyaWFSb2xlID09IE1lbnVCdXR0b25S b2xlCi0gICAgICAgIHx8IGFyaWFSb2xlID09IFJhZGlvQnV0dG9uUm9sZQotICAgICAgICB8fCBh cmlhUm9sZSA9PSBDaGVja0JveFJvbGUKLSAgICAgICAgfHwgYXJpYVJvbGUgPT0gVGFiUm9sZQot ICAgICAgICB8fCBhcmlhUm9sZSA9PSBQb3BVcEJ1dHRvblJvbGUKLSAgICAgICAgfHwgaXNIZWFk aW5nKCkKLSAgICAgICAgfHwgaXNMaW5rKCkpCisgICAgc3dpdGNoIChyb2xlKSB7CisgICAgY2Fz ZSBCdXR0b25Sb2xlOgorICAgIGNhc2UgTGlzdEJveE9wdGlvblJvbGU6CisgICAgY2FzZSBNZW51 SXRlbVJvbGU6CisgICAgY2FzZSBNZW51QnV0dG9uUm9sZToKKyAgICBjYXNlIFJhZGlvQnV0dG9u Um9sZToKKyAgICBjYXNlIENoZWNrQm94Um9sZToKKyAgICBjYXNlIFRhYlJvbGU6CisgICAgY2Fz ZSBQb3BVcEJ1dHRvblJvbGU6CiAgICAgICAgIHJldHVybiB0ZXh0VW5kZXJFbGVtZW50KCk7Cisg ICAgZGVmYXVsdDoKKyAgICAgICAgYnJlYWs7CisgICAgfQogICAgIAorICAgIGlmIChpc0hlYWRp bmcoKSB8fCBpc0xpbmsoKSkKKyAgICAgICAgcmV0dXJuIHRleHRVbmRlckVsZW1lbnQoKTsKKyAg ICAKICAgICByZXR1cm4gU3RyaW5nKCk7CiB9CiAKQEAgLTMxMDIsMTIgKzMxMDQsMTIgQEAKICAg ICBpZiAobV9yZW5kZXJlci0+aXNMaXN0TWFya2VyKCkpCiAgICAgICAgIHJldHVybiBMaXN0TWFy a2VyUm9sZTsKICAgICBpZiAobm9kZSAmJiBub2RlLT5oYXNUYWdOYW1lKGJ1dHRvblRhZykpCi0g ICAgICAgIHJldHVybiBCdXR0b25Sb2xlOworICAgICAgICByZXR1cm4gKGFyaWFIYXNQb3B1cCgp KSA/IFBvcFVwQnV0dG9uUm9sZSA6IEJ1dHRvblJvbGU7CiAgICAgaWYgKG1fcmVuZGVyZXItPmlz VGV4dCgpKQogICAgICAgICByZXR1cm4gU3RhdGljVGV4dFJvbGU7CiAgICAgaWYgKGNzc0JveCAm JiBjc3NCb3gtPmlzSW1hZ2UoKSkgewogICAgICAgICBpZiAobm9kZSAmJiBub2RlLT5oYXNUYWdO YW1lKGlucHV0VGFnKSkKLSAgICAgICAgICAgIHJldHVybiBCdXR0b25Sb2xlOworICAgICAgICAg ICAgcmV0dXJuIChhcmlhSGFzUG9wdXAoKSkgPyBQb3BVcEJ1dHRvblJvbGUgOiBCdXR0b25Sb2xl OwogICAgICAgICByZXR1cm4gSW1hZ2VSb2xlOwogICAgIH0KICAgICBpZiAobm9kZSAmJiBub2Rl LT5oYXNUYWdOYW1lKGNhbnZhc1RhZykpCkBAIC0zMTI5LDEyICszMTMxLDkgQEAKICAgICAgICAg aWYgKGlucHV0LT5pc1JhZGlvQnV0dG9uKCkpCiAgICAgICAgICAgICByZXR1cm4gUmFkaW9CdXR0 b25Sb2xlOwogICAgICAgICBpZiAoaW5wdXQtPmlzVGV4dEJ1dHRvbigpKQotICAgICAgICAgICAg cmV0dXJuIEJ1dHRvblJvbGU7CisgICAgICAgICAgICByZXR1cm4gKGFyaWFIYXNQb3B1cCgpKSA/ IFBvcFVwQnV0dG9uUm9sZSA6IEJ1dHRvblJvbGU7CiAgICAgfQogCi0gICAgaWYgKG5vZGUgJiYg bm9kZS0+aGFzVGFnTmFtZShidXR0b25UYWcpKQotICAgICAgICByZXR1cm4gQnV0dG9uUm9sZTsK LQogICAgIGlmIChpc0ZpbGVVcGxvYWRCdXR0b24oKSkKICAgICAgICAgcmV0dXJuIEJ1dHRvblJv bGU7CiAgICAgCkluZGV4OiBMYXlvdXRUZXN0cy9wbGF0Zm9ybS9tYWMvYWNjZXNzaWJpbGl0eS9h cmlhLXBvcHVwLWJ1dHRvbnMtb24tbmF0aXZlLWVsZW1lbnRzLWV4cGVjdGVkLnR4dAo9PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09Ci0tLSBMYXlvdXRUZXN0cy9wbGF0Zm9ybS9tYWMvYWNjZXNzaWJpbGl0eS9hcmlhLXBvcHVw LWJ1dHRvbnMtb24tbmF0aXZlLWVsZW1lbnRzLWV4cGVjdGVkLnR4dAkocmV2aXNpb24gMCkKKysr IExheW91dFRlc3RzL3BsYXRmb3JtL21hYy9hY2Nlc3NpYmlsaXR5L2FyaWEtcG9wdXAtYnV0dG9u cy1vbi1uYXRpdmUtZWxlbWVudHMtZXhwZWN0ZWQudHh0CShyZXZpc2lvbiAwKQpAQCAtMCwwICsx LDIyIEBACitPcHRpb25zIE9wdGlvbnMgIE9wdGlvbnMgCitUaGlzIHRlc3RzIHRoYXQgbmF0aXZl IHN0eWxlIGJ1dHRvbnMgd2l0aCBhcmlhLWhhc3BvcHVwIGFwcGVhciBhcyBwb3B1cCBidXR0b25z LgorCitPbiBzdWNjZXNzLCB5b3Ugd2lsbCBzZWUgYSBzZXJpZXMgb2YgIlBBU1MiIG1lc3NhZ2Vz LCBmb2xsb3dlZCBieSAiVEVTVCBDT01QTEVURSIuCisKKworUEFTUyBidXR0b24ucm9sZSBpcyAn QVhSb2xlOiBBWFBvcFVwQnV0dG9uJworUEFTUyBidXR0b24udGl0bGUgaXMgJ0FYVGl0bGU6IE9w dGlvbnMnCitQQVNTIGJ1dHRvbi5zdHJpbmdWYWx1ZSBpcyAnQVhWYWx1ZTogJworUEFTUyBidXR0 b24ucm9sZSBpcyAnQVhSb2xlOiBBWFBvcFVwQnV0dG9uJworUEFTUyBidXR0b24udGl0bGUgaXMg J0FYVGl0bGU6IE9wdGlvbnMnCitQQVNTIGJ1dHRvbi5zdHJpbmdWYWx1ZSBpcyAnQVhWYWx1ZTog JworUEFTUyBidXR0b24ucm9sZSBpcyAnQVhSb2xlOiBBWFBvcFVwQnV0dG9uJworUEFTUyBidXR0 b24udGl0bGUgaXMgJ0FYVGl0bGU6IE9wdGlvbnMnCitQQVNTIGJ1dHRvbi5zdHJpbmdWYWx1ZSBp cyAnQVhWYWx1ZTogJworUEFTUyBidXR0b24ucm9sZSBpcyAnQVhSb2xlOiBBWFBvcFVwQnV0dG9u JworUEFTUyBidXR0b24udGl0bGUgaXMgJ0FYVGl0bGU6IE9wdGlvbnMnCitQQVNTIGJ1dHRvbi5z dHJpbmdWYWx1ZSBpcyAnQVhWYWx1ZTogJworUEFTUyBzdWNjZXNzZnVsbHlQYXJzZWQgaXMgdHJ1 ZQorCitURVNUIENPTVBMRVRFCisKSW5kZXg6IExheW91dFRlc3RzL3BsYXRmb3JtL21hYy9hY2Nl c3NpYmlsaXR5L2FyaWEtcG9wdXAtYnV0dG9ucy1vbi1uYXRpdmUtZWxlbWVudHMuaHRtbAo9PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9wbGF0Zm9ybS9tYWMvYWNjZXNzaWJpbGl0eS9hcmlhLXBv cHVwLWJ1dHRvbnMtb24tbmF0aXZlLWVsZW1lbnRzLmh0bWwJKHJldmlzaW9uIDApCisrKyBMYXlv dXRUZXN0cy9wbGF0Zm9ybS9tYWMvYWNjZXNzaWJpbGl0eS9hcmlhLXBvcHVwLWJ1dHRvbnMtb24t bmF0aXZlLWVsZW1lbnRzLmh0bWwJKHJldmlzaW9uIDApCkBAIC0wLDAgKzEsNDQgQEAKKzwhRE9D VFlQRSBIVE1MIFBVQkxJQyAiLS8vSUVURi8vRFREIEhUTUwvL0VOIj4KKzxodG1sPgorPGhlYWQ+ Cis8bGluayByZWw9InN0eWxlc2hlZXQiIGhyZWY9Ii4uLy4uLy4uL2Zhc3QvanMvcmVzb3VyY2Vz L2pzLXRlc3Qtc3R5bGUuY3NzIj4KKzxzY3JpcHQ+Cit2YXIgc3VjY2Vzc2Z1bGx5UGFyc2VkID0g ZmFsc2U7Cis8L3NjcmlwdD4KKzxzY3JpcHQgc3JjPSIuLi8uLi8uLi9mYXN0L2pzL3Jlc291cmNl cy9qcy10ZXN0LXByZS5qcyI+PC9zY3JpcHQ+Cis8L2hlYWQ+Cis8Ym9keSBpZD0iYm9keSI+CisK KzxhIGlkPSJidXR0b24xIiB0YWJpbmRleD0iMCIgY2xhc3M9ImJ1dHRvbiIgaHJlZj0iIyIgYXJp YS1oYXNwb3B1cD0idHJ1ZSIgcm9sZT0iYnV0dG9uIj5PcHRpb25zPC9hPgorPHNwYW4gaWQ9ImJ1 dHRvbjIiIGNsYXNzPSJidXR0b24iIHRhYmluZGV4PSIwIiByb2xlPSJidXR0b24iIGFyaWEtaGFz cG9wdXA9InRydWUiPk9wdGlvbnM8L3NwYW4+CisKKzxidXR0b24gaWQ9ImJ1dHRvbjMiIHR5cGU9 ImJ1dHRvbiIgYXJpYS1oYXNwb3B1cD0idHJ1ZSI+T3B0aW9uczwvYnV0dG9uPgorPGlucHV0IGlk PSJidXR0b240IiB0eXBlPSJidXR0b24iIGFyaWEtaGFzcG9wdXA9InRydWUiIHZhbHVlPSJPcHRp b25zIj4KKworCis8cCBpZD0iZGVzY3JpcHRpb24iPjwvcD4KKzxkaXYgaWQ9ImNvbnNvbGUiPjwv ZGl2PgorCis8c2NyaXB0PgorICAgIGRlc2NyaXB0aW9uKCJUaGlzIHRlc3RzIHRoYXQgbmF0aXZl IHN0eWxlIGJ1dHRvbnMgd2l0aCBhcmlhLWhhc3BvcHVwIGFwcGVhciBhcyBwb3B1cCBidXR0b25z LiIpOworICAgIAorICAgIGlmICh3aW5kb3cuYWNjZXNzaWJpbGl0eUNvbnRyb2xsZXIpIHsKKwor ICAgICAgICBmb3IgKHZhciBrID0gMTsgayA8IDU7IGsrKykgeworCisgICAgICAgICAgIGRvY3Vt ZW50LmdldEVsZW1lbnRCeUlkKCJidXR0b24iICsgaykuZm9jdXMoKTsKKyAgICAgICAgICAgdmFy IGJ1dHRvbiA9IGFjY2Vzc2liaWxpdHlDb250cm9sbGVyLmZvY3VzZWRFbGVtZW50OworICAgICAg ICAgICBzaG91bGRCZSgiYnV0dG9uLnJvbGUiLCAiJ0FYUm9sZTogQVhQb3BVcEJ1dHRvbiciKTsg ICAgICAgIAorICAgICAgICAgICBzaG91bGRCZSgiYnV0dG9uLnRpdGxlIiwgIidBWFRpdGxlOiBP cHRpb25zJyIpOyAgICAgICAgCisKKyAgICAgICAgICAgLy8gVmVyaWZ5IHRoYXQgdGhlIHRpdGxl IGlzIG5vdCBkdXBsaWNhdGVkIGFzIHRoZSBBWFZhbHVlCisgICAgICAgICAgIHNob3VsZEJlKCJi dXR0b24uc3RyaW5nVmFsdWUiLCAiJ0FYVmFsdWU6ICciKTsgICAgICAgIAorICAgICAgICB9Cisg ICAgfQorICAgIAorICAgIHN1Y2Nlc3NmdWxseVBhcnNlZCA9IHRydWU7Cis8L3NjcmlwdD4KKwor PHNjcmlwdCBzcmM9Ii4uLy4uLy4uL2Zhc3QvanMvcmVzb3VyY2VzL2pzLXRlc3QtcG9zdC5qcyI+ PC9zY3JpcHQ+Cis8L2JvZHk+Cis8L2h0bWw+Cg==