67737 2011-09-07 15:06:06 -0700 Teach the PortFactory object how to pass along executive/user/filesystem to port objects (which fixes the failing rebaseline_test on bots) 2011-09-07 15:18:14 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 eric eric abarth oldest_to_newest 463685 0 eric 2011-09-07 15:06:06 -0700 Teach the PortFactory object how to pass along executive/user/filesystem to port objects (which fixes the failing rebaseline_test on bots) 463687 1 106653 eric 2011-09-07 15:08:30 -0700 Created attachment 106653 Patch 463694 2 eric 2011-09-07 15:18:14 -0700 Committed r94718: <http://trac.webkit.org/changeset/94718> 106653 2011-09-07 15:08:30 -0700 2011-09-07 15:17:40 -0700 Patch bug-67737-20110907150829.patch text/plain 6418 eric U3VidmVyc2lvbiBSZXZpc2lvbjogOTQ3MTcKZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBi L1Rvb2xzL0NoYW5nZUxvZwppbmRleCAzNTJkY2Q2YTFkNmU3N2JhZWFjNzYwYzJjYmU3MDI5MWZl YThlZmE4Li4wNWJiNzE0YzYzYTRhYWVlMGZkNzU0MmFlNWZjZGRmN2UwNmVkNzdmIDEwMDY0NAot LS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIvVG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDUgKzEsMjYg QEAKIDIwMTEtMDktMDcgIEVyaWMgU2VpZGVsICA8ZXJpY0B3ZWJraXQub3JnPgogCisgICAgICAg IFRlYWNoIHRoZSBQb3J0RmFjdG9yeSBvYmplY3QgaG93IHRvIHBhc3MgYWxvbmcgZXhlY3V0aXZl L3VzZXIvZmlsZXN5c3RlbSB0byBwb3J0IG9iamVjdHMgKHdoaWNoIGZpeGVzIHRoZSBmYWlsaW5n IHJlYmFzZWxpbmVfdGVzdCBvbiBib3RzKQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9y Zy9zaG93X2J1Zy5jZ2k/aWQ9Njc3MzcKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9P UFMhKS4KKworICAgICAgICBJIGdvdCBhIGxpdHRsZSBvdmVyLWVhZ2VyIHdoZW4gZGVwcmVjYXRp bmcgaG9zdC5wb3J0X2ZhY3RvcnkgaW4gdGhlIHByZXZpb3VzIGNvbW1pdC4KKyAgICAgICAgVHVy bnMgb3V0IHRoYXQgSG9zdC5wb3J0X2ZhY3Rvcnkgd2FzIGFscmVhZHkgdGhlICJtb2Rlcm4iIHBv cnQvZmFjdG9yeS5weQorICAgICAgICBpdCB3YXMganVzdCB0aGUgTW9kdWxlIG9iamVjdC4gIEkg dW4tZGVwcmVjYXRlZCB0aGUgdmFyaWFibGUsIGFuZCBjaGFuZ2VkIGl0IGZyb20KKyAgICAgICAg YmVpbmcgdGhlIG1vZHVsZSB0byBiZWluZyBhbiBhY3R1YWwgUG9ydEZhY3RvcnksIHBhc3Npbmcg aXQgYSBob3N0IG9iamVjdC4KKyAgICAgICAgSSBhbHNvIHRhdWdodCBQb3J0RmFjdG9yeSBob3cg dG8gc2V0IHVzZXIvZXhlY3V0aXZlL2ZpbGVzeXN0ZW0gaW4gdGhlIGt3YXJncworICAgICAgICB3 aGVuIGluc3RhbnRpYXRpbmcgYSBuZXcgUG9ydCBvYmplY3QuCisgICAgICAgIFRoaXMgbWFnaWNh bGx5IGZpeGVkIHRoZSB0ZXN0X3JlYmFzZWxpbmUgdGVzdCwgc2luY2UgaXRzIG5vdyBubyBsb25n ZXIgdGFsa2luZworICAgICAgICB0byB0aGUgcmVhbCBmaWxlc3lzdGVtLgorCisgICAgICAgICog U2NyaXB0cy93ZWJraXRweS9jb21tb24vaG9zdC5weToKKyAgICAgICAgKiBTY3JpcHRzL3dlYmtp dHB5L2xheW91dF90ZXN0cy9wb3J0L2ZhY3RvcnkucHk6CisgICAgICAgICogU2NyaXB0cy93ZWJr aXRweS90b29sL2NvbW1hbmRzL3F1ZXJpZXMucHk6CisgICAgICAgICogU2NyaXB0cy93ZWJraXRw eS90b29sL21vY2t0b29sLnB5OgorCisyMDExLTA5LTA3ICBFcmljIFNlaWRlbCAgPGVyaWNAd2Vi a2l0Lm9yZz4KKwogICAgICAgICBBZGQgYSBuZXcgUG9ydEZhY3RvcnkgY2xhc3MgZm9yIGNyZWF0 aW5nIG5ldy1zdHlsZSBwb3J0cyBhbmQgZGVwcmVjYXRlIHRoZSBvbGQgUG9ydEZhY3RvcnkKICAg ICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTY3NzM0CiAKZGlm ZiAtLWdpdCBhL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvY29tbW9uL2hvc3QucHkgYi9Ub29scy9T Y3JpcHRzL3dlYmtpdHB5L2NvbW1vbi9ob3N0LnB5CmluZGV4IGE3ZDhkNzZkMDAwNTJjNWFiYjkx YjUxYjQ1NjhiNGY1NWY2MjA4YTEuLjY1MWQxZjEzZGE5Y2E2NzdjYTk5NDczOWY3ZDcxMWM0YmE4 NDA5ZmUgMTAwNjQ0Ci0tLSBhL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvY29tbW9uL2hvc3QucHkK KysrIGIvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9jb21tb24vaG9zdC5weQpAQCAtMzYsNyArMzYs NyBAQCBmcm9tIHdlYmtpdHB5LmNvbW1vbi5uZXQgaW1wb3J0IGJ1Z3ppbGxhLCBidWlsZGJvdCwg c3RhdHVzc2VydmVyLCB3ZWIKIGZyb20gd2Via2l0cHkuY29tbW9uLm5ldC5idWlsZGJvdC5jaHJv bWl1bWJ1aWxkYm90IGltcG9ydCBDaHJvbWl1bUJ1aWxkQm90CiBmcm9tIHdlYmtpdHB5LmNvbW1v bi5uZXQuaXJjIGltcG9ydCBpcmNwcm94eQogZnJvbSB3ZWJraXRweS5jb21tb24uc3lzdGVtIGlt cG9ydCBleGVjdXRpdmUsIGZpbGVzeXN0ZW0sIHBsYXRmb3JtaW5mbywgdXNlciwgd29ya3NwYWNl Ci1mcm9tIHdlYmtpdHB5LmxheW91dF90ZXN0cyBpbXBvcnQgcG9ydAorZnJvbSB3ZWJraXRweS5s YXlvdXRfdGVzdHMucG9ydC5mYWN0b3J5IGltcG9ydCBQb3J0RmFjdG9yeQogCiAKIGNsYXNzIEhv c3Qob2JqZWN0KToKQEAgLTUzLDcgKzUzLDEwIEBAIGNsYXNzIEhvc3Qob2JqZWN0KToKICAgICAg ICAgc2VsZi5fc2NtID0gTm9uZQogICAgICAgICBzZWxmLl9jaGVja291dCA9IE5vbmUKICAgICAg ICAgc2VsZi5zdGF0dXNfc2VydmVyID0gc3RhdHVzc2VydmVyLlN0YXR1c1NlcnZlcigpCi0gICAg ICAgIHNlbGYuX2RlcHJlY2F0ZWRfcG9ydF9mYWN0b3J5ID0gcG9ydC5mYWN0b3J5CisgICAgICAg ICMgRklYTUU6IFVuZm9ydHVuYXRlbHkgUG9ydCBvYmplY3RzIGFyZSBjdXJyZW50bHkgdGhlIGNl bnRyYWwtZGlzcGF0Y2ggb2JqZWN0cyBvZiB0aGUgTlJXVCB3b3JsZC4KKyAgICAgICAgIyBJbiBv cmRlciB0byBpbnN0YW50aWF0ZSBhIHBvcnQgY29ycmVjdGx5LCB3ZSBoYXZlIHRvIHBhc3MgaXQg YXQgbGVhc3QgYW4gZXhlY3V0aXZlLCB1c2VyLCBzY20sIGFuZCBmaWxlc3lzdGVtCisgICAgICAg ICMgc28gZm9yIG5vdyB3ZSBqdXN0IHBhc3MgYWxvbmcgdGhlIHdob2xlIEhvc3Qgb2JqZWN0Lgor ICAgICAgICBzZWxmLnBvcnRfZmFjdG9yeSA9IFBvcnRGYWN0b3J5KHNlbGYpCiAgICAgICAgIHNl bGYucGxhdGZvcm0gPSBwbGF0Zm9ybWluZm8uUGxhdGZvcm1JbmZvKCkKIAogICAgIGRlZiBfaW5p dGlhbGl6ZV9zY20oc2VsZiwgcGF0Y2hfZGlyZWN0b3JpZXM9Tm9uZSk6CmRpZmYgLS1naXQgYS9U b29scy9TY3JpcHRzL3dlYmtpdHB5L2xheW91dF90ZXN0cy9wb3J0L2ZhY3RvcnkucHkgYi9Ub29s cy9TY3JpcHRzL3dlYmtpdHB5L2xheW91dF90ZXN0cy9wb3J0L2ZhY3RvcnkucHkKaW5kZXggZDQz MjU4ZTMyYzQ5YzY5ZWI3YjEyNTk2NDhmMDkxZTdiNzE1YjI5My4uYTc3MWIwYTI2YzU1ODAxMzgx ZjMxOWRiMWI5NWZiZGIzZDQzZjMyZCAxMDA2NDQKLS0tIGEvVG9vbHMvU2NyaXB0cy93ZWJraXRw eS9sYXlvdXRfdGVzdHMvcG9ydC9mYWN0b3J5LnB5CisrKyBiL1Rvb2xzL1NjcmlwdHMvd2Via2l0 cHkvbGF5b3V0X3Rlc3RzL3BvcnQvZmFjdG9yeS5weQpAQCAtNDMsNyArNDMsNiBAQCBjbGFzcyBC dWlsZGVyT3B0aW9ucyhvYmplY3QpOgogCiBjbGFzcyBQb3J0RmFjdG9yeShvYmplY3QpOgogICAg IGRlZiBfX2luaXRfXyhzZWxmLCBob3N0PU5vbmUpOgotICAgICAgICAjIEZJWE1FOiBBbGwgY2Fs bGVycyBzaG91bGQgcGFzcyBhIHBvcnQuCiAgICAgICAgIHNlbGYuX2hvc3QgPSBob3N0CiAKICAg ICBkZWYgX3BvcnRfbmFtZV9mcm9tX2FyZ3VtZW50c19hbmRfb3B0aW9ucyhzZWxmLCAqKmt3YXJn cyk6CkBAIC0xMDksNiArMTA4LDE1IEBAIGNsYXNzIFBvcnRGYWN0b3J5KG9iamVjdCk6CiAgICAg ICAgICAgICBtYWtlciA9IGdvb2dsZV9jaHJvbWUuR2V0R29vZ2xlQ2hyb21lUG9ydAogICAgICAg ICBlbHNlOgogICAgICAgICAgICAgcmFpc2UgTm90SW1wbGVtZW50ZWRFcnJvcigndW5zdXBwb3J0 ZWQgcG9ydDogJXMnICUgcG9ydF90b191c2UpCisKKyAgICAgICAgIyBNYWtlIHN1cmUgdGhhdCBh bnkgUG9ydHMgY3JlYXRlZCBieSB0aGlzIGZhY3RvcnkgaW5oZXJpdAorICAgICAgICAjIHRoZSBl eGVjdXRpdmUvdXNlci9maWxlc3lzdGVtIGZyb20gdGhlIHByb3ZpZGVkIGhvc3QuCisgICAgICAg ICMgRklYTUU6IEV2ZW50dWFsbHkgTlJXVCB3aWxsIHVzZSBhIEhvc3Qgb2JqZWN0IGFuZCBQb3J0 IHdpbGwgbm8gbG9uZ2VyIHN0b3JlIHRoZXNlIHBvaW50ZXJzLgorICAgICAgICBpZiBzZWxmLl9o b3N0OgorICAgICAgICAgICAga3dhcmdzLnNldGRlZmF1bHQoJ2V4ZWN1dGl2ZScsIHNlbGYuX2hv c3QuZXhlY3V0aXZlKQorICAgICAgICAgICAga3dhcmdzLnNldGRlZmF1bHQoJ3VzZXInLCBzZWxm Ll9ob3N0LnVzZXIpCisgICAgICAgICAgICBrd2FyZ3Muc2V0ZGVmYXVsdCgnZmlsZXN5c3RlbScs IHNlbGYuX2hvc3QuZmlsZXN5c3RlbSkKKwogICAgICAgICByZXR1cm4gbWFrZXIoKiprd2FyZ3Mp CiAKICAgICBkZWYgYWxsX3BvcnRfbmFtZXMoc2VsZik6CmRpZmYgLS1naXQgYS9Ub29scy9TY3Jp cHRzL3dlYmtpdHB5L3Rvb2wvY29tbWFuZHMvcXVlcmllcy5weSBiL1Rvb2xzL1NjcmlwdHMvd2Vi a2l0cHkvdG9vbC9jb21tYW5kcy9xdWVyaWVzLnB5CmluZGV4IDM5YzdiNDkxNDIzOWQ5YTdjNDQx ZWUzMDQ1NzY1ZmQ4NjEyYmM3NzIuLjdmN2UyMjdhNWFhOGRhYzgxZDA1YzM4YzZiOWRmMTFlOTU4 NjA5OWQgMTAwNjQ0Ci0tLSBhL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvdG9vbC9jb21tYW5kcy9x dWVyaWVzLnB5CisrKyBiL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvdG9vbC9jb21tYW5kcy9xdWVy aWVzLnB5CkBAIC0zODcsNyArMzg3LDcgQEAgb3V0IHdoYXQgcG9ydHMgYXJlIHNraXBwaW5nIHRo ZSB0ZXN0KHMpLiBDYXRlZ29yaWVzIGFyZSB0YWtlbiBpbiBhY2NvdW50IHRvby4iIiIKIAogICAg IGRlZiBleGVjdXRlKHNlbGYsIG9wdGlvbnMsIGFyZ3MsIHRvb2wpOgogICAgICAgICByZXN1bHRz ID0gZGljdChbKHRlc3RfbmFtZSwgW10pIGZvciB0ZXN0X25hbWUgaW4gYXJnc10pCi0gICAgICAg IGZvciBwb3J0X25hbWUsIHBvcnRfb2JqZWN0IGluIHRvb2wuX2RlcHJlY2F0ZWRfcG9ydF9mYWN0 b3J5LmdldF9hbGwoKS5pdGVyaXRlbXMoKToKKyAgICAgICAgZm9yIHBvcnRfbmFtZSwgcG9ydF9v YmplY3QgaW4gdG9vbC5wb3J0X2ZhY3RvcnkuZ2V0X2FsbCgpLml0ZXJpdGVtcygpOgogICAgICAg ICAgICAgZm9yIHRlc3RfbmFtZSBpbiBhcmdzOgogICAgICAgICAgICAgICAgIGlmIHBvcnRfb2Jq ZWN0LnNraXBzX2xheW91dF90ZXN0KHRlc3RfbmFtZSk6CiAgICAgICAgICAgICAgICAgICAgIHJl c3VsdHNbdGVzdF9uYW1lXS5hcHBlbmQocG9ydF9uYW1lKQpkaWZmIC0tZ2l0IGEvVG9vbHMvU2Ny aXB0cy93ZWJraXRweS90b29sL21vY2t0b29sLnB5IGIvVG9vbHMvU2NyaXB0cy93ZWJraXRweS90 b29sL21vY2t0b29sLnB5CmluZGV4IDhlYTZiZDY1YWMxMTVkMjNhNjVmNWQ0YWE5YjgxMjY4ZWYx MGE5NGYuLjllODliODllZWI1NGQwZWI0NzlhZjEwNDFmYzFhMTAxYmY4NDFkNGEgMTAwNjQ0Ci0t LSBhL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvdG9vbC9tb2NrdG9vbC5weQorKysgYi9Ub29scy9T Y3JpcHRzL3dlYmtpdHB5L3Rvb2wvbW9ja3Rvb2wucHkKQEAgLTc5MCwxOSArNzkwLDE2IEBAIGNs YXNzIE1vY2tQb3J0KG9iamVjdCk6CiAKIAogY2xhc3MgTW9ja1Rlc3RQb3J0MShvYmplY3QpOgot CiAgICAgZGVmIHNraXBzX2xheW91dF90ZXN0KHNlbGYsIHRlc3RfbmFtZSk6CiAgICAgICAgIHJl dHVybiB0ZXN0X25hbWUgaW4gWyJtZWRpYS9mb28vYmFyLmh0bWwiLCAiZm9vIl0KIAogCiBjbGFz cyBNb2NrVGVzdFBvcnQyKG9iamVjdCk6Ci0KICAgICBkZWYgc2tpcHNfbGF5b3V0X3Rlc3Qoc2Vs ZiwgdGVzdF9uYW1lKToKICAgICAgICAgcmV0dXJuIHRlc3RfbmFtZSA9PSAibWVkaWEvZm9vL2Jh ci5odG1sIgogCiAKLWNsYXNzIE1vY2tEZXByZWNhdGVkUG9ydEZhY3Rvcnkob2JqZWN0KToKLQor Y2xhc3MgTW9ja1BvcnRGYWN0b3J5KG9iamVjdCk6CiAgICAgZGVmIGdldF9hbGwoc2VsZiwgb3B0 aW9ucz1Ob25lKToKICAgICAgICAgcmV0dXJuIHsidGVzdF9wb3J0MSI6IE1vY2tUZXN0UG9ydDEo KSwgInRlc3RfcG9ydDIiOiBNb2NrVGVzdFBvcnQyKCl9CiAKQEAgLTgyNiw3ICs4MjMsNiBAQCBj bGFzcyBNb2NrV2ViKG9iamVjdCk6CiAKIAogY2xhc3MgTW9ja1Rvb2wob2JqZWN0KToKLQogICAg IGRlZiBfX2luaXRfXyhzZWxmLCBsb2dfZXhlY3V0aXZlPUZhbHNlKToKICAgICAgICAgc2VsZi53 YWtldXBfZXZlbnQgPSB0aHJlYWRpbmcuRXZlbnQoKQogICAgICAgICBzZWxmLmJ1Z3MgPSBNb2Nr QnVnemlsbGEoKQpAQCAtODQ1LDcgKzg0MSw3IEBAIGNsYXNzIE1vY2tUb29sKG9iamVjdCk6CiAg ICAgICAgIHNlbGYuX2NoZWNrb3V0ID0gTW9ja0NoZWNrb3V0KCkKICAgICAgICAgc2VsZi5zdGF0 dXNfc2VydmVyID0gTW9ja1N0YXR1c1NlcnZlcigpCiAgICAgICAgIHNlbGYuaXJjX3Bhc3N3b3Jk ID0gIk1PQ0sgaXJjIHBhc3N3b3JkIgotICAgICAgICBzZWxmLl9kZXByZWNhdGVkX3BvcnRfZmFj dG9yeSA9IE1vY2tEZXByZWNhdGVkUG9ydEZhY3RvcnkoKQorICAgICAgICBzZWxmLnBvcnRfZmFj dG9yeSA9IE1vY2tQb3J0RmFjdG9yeSgpCiAgICAgICAgIHNlbGYucGxhdGZvcm0gPSBNb2NrUGxh dGZvcm1JbmZvKCkKIAogICAgIGRlZiBzY20oc2VsZik6Cg==