67733 2011-09-07 14:25:51 -0700 [Chromium] Separate WebKit initialization and V8 initialization in chromium port 2011-09-19 09:39:12 -0700 1 1 1 Unclassified WebKit WebKit Misc. 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 dslomov dslomov abarth dglazkov fishd tonyg webkit.review.bot oldest_to_newest 463653 0 dslomov 2011-09-07 14:25:51 -0700 Adding V8 initialization to WebKit::initialize had an unfortunate side effect that V8 is initialized in Chromium browser process. V8 initialization should be factored out of WebKit initialization. 463668 1 106643 dslomov 2011-09-07 14:47:56 -0700 Created attachment 106643 This patch adds initializeV8 function 463675 2 abarth 2011-09-07 14:52:09 -0700 +fishd for WebKit API review. 463928 3 106643 fishd 2011-09-08 00:07:56 -0700 Comment on attachment 106643 This patch adds initializeV8 function Hmm, this could also be addressed by adding a way to pass options to the "initialize" method. Had you considered that approach instead? The current solution has the side-effect that it makes it possible to do work after webkit is initialized but before v8 is initialized. Do we require that kind of flexibility? 464141 4 dslomov 2011-09-08 10:32:58 -0700 (In reply to comment #3) > (From update of attachment 106643 [details]) > Hmm, this could also be addressed by adding a way to pass options to the "initialize" method. Had you considered that approach instead? I did - I do not have a strong opinion, but I feel this way we will have a nice separation of concerns. WebKit and V8 are (semi) independent subsystems. > > The current solution has the side-effect that it makes it possible to do work after webkit is initialized but before v8 is initialized. Do we require that kind of flexibility? We do not require it at the moment, but WenKit is certainly usable and useful without initialized V8, and we might find a need to lazily initialize V8 in some scenarios. Why do you think having an option on initialize method is preferable? 464842 5 fishd 2011-09-09 09:40:58 -0700 (In reply to comment #4) > Why do you think having an option on initialize method is preferable? I'm concerned that callers will forget to initialize V8. I'd prefer a mechanism that forces callers to opt-in to not initializing V8 as that seems like the uncommon case. 464961 6 106896 dslomov 2011-09-09 12:01:35 -0700 Created attachment 106896 This patch adds a parameter to WebKit::initialize instead. What do you think about this variant? I have added an overload with the old signature too (that initialized V8 by default). This other overload is needed anyway until corresponding changes in chromium are done. After that it can be kept or removed. I am leaning towards keeping it and using non-default only in special cases, but then we'll have an equivalent of a parameter with default argument, which is not good. What do you think is the right call? 464966 7 106899 dslomov 2011-09-09 12:07:59 -0700 Created attachment 106899 Obsolete sig removed 464978 8 106899 webkit.review.bot 2011-09-09 12:32:54 -0700 Comment on attachment 106899 Obsolete sig removed Attachment 106899 did not pass cr-mac-ews (chromium): Output: http://queues.webkit.org/results/9625740 465005 9 106912 dslomov 2011-09-09 13:40:44 -0700 Created attachment 106912 Fixed botched build. 465118 10 106912 abarth 2011-09-09 17:05:59 -0700 Comment on attachment 106912 Fixed botched build. View in context: https://bugs.webkit.org/attachment.cgi?id=106912&action=review > Source/WebKit/chromium/public/WebKit.h:42 > + INITIALIZE_V8, > + DO_NOT_INITIALIZE_V8 These names should be in CamelCase. > Source/WebKit/chromium/public/WebKit.h:53 > +// INITIALIZE_V8 should be passed if V8 is planned to be used. > +WEBKIT_EXPORT void initialize(WebKitPlatformSupport*, InitializeV8); > + > +// Version of initialize function that initializes V8. > WEBKIT_EXPORT void initialize(WebKitPlatformSupport*); Why not use a default value for the argument? That seems more self-documenting. 465747 11 dslomov 2011-09-12 12:59:27 -0700 (In reply to comment #10) > (From update of attachment 106912 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=106912&action=review > > > Source/WebKit/chromium/public/WebKit.h:42 > > + INITIALIZE_V8, > > + DO_NOT_INITIALIZE_V8 > > These names should be in CamelCase. > > > Source/WebKit/chromium/public/WebKit.h:53 > > +// INITIALIZE_V8 should be passed if V8 is planned to be used. > > +WEBKIT_EXPORT void initialize(WebKitPlatformSupport*, InitializeV8); > > + > > +// Version of initialize function that initializes V8. > > WEBKIT_EXPORT void initialize(WebKitPlatformSupport*); > > Why not use a default value for the argument? That seems more self-documenting. My understanding was that the use of default arguments is frowned upon, but I certainly agree. 465762 12 abarth 2011-09-12 13:27:12 -0700 > My understanding was that the use of default arguments is frowned upon, but I certainly agree. I believe they are frowned upon in Google style but not in WebKit style. The Chromium WebKit API uses WebKit style. 465778 13 107080 dslomov 2011-09-12 13:54:09 -0700 Created attachment 107080 Default argument instead if overloads 465780 14 107080 abarth 2011-09-12 13:56:09 -0700 Comment on attachment 107080 Default argument instead if overloads View in context: https://bugs.webkit.org/attachment.cgi?id=107080&action=review > Source/WebKit/chromium/public/WebKit.h:49 > +// INITIALIZE_V8 should be passed if V8 is planned to be used. nit: INITIALIZE_V8 => InitializeV8. LGTM, but we'll need fishd to review. 465781 15 webkit.review.bot 2011-09-12 13:57:19 -0700 Attachment 107080 did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit/chromium/ChangeLog', u'Sourc..." exit_code: 1 Source/WebKit/chromium/public/WebKit.h:50: The parameter name "initializeV8" adds no information, so it should be removed. [readability/parameter_name] [5] Total errors found: 1 in 3 files If any of these errors are false positives, please file a bug against check-webkit-style. 466364 16 dslomov 2011-09-13 10:15:43 -0700 (In reply to comment #12) > > My understanding was that the use of default arguments is frowned upon, but I certainly agree. > > I believe they are frowned upon in Google style but not in WebKit style. The Chromium WebKit API uses WebKit style. Right - I was worried that since WebKit API is exposed to chromium, folks will not be happy about it. Apparently this is not the case :) 466423 17 107202 dslomov 2011-09-13 11:39:07 -0700 Created attachment 107202 Style 466806 18 107202 fishd 2011-09-13 20:43:29 -0700 Comment on attachment 107202 Style View in context: https://bugs.webkit.org/attachment.cgi?id=107202&action=review > Source/WebKit/chromium/public/WebKit.h:40 > +enum ShouldInitializeV8 { nit: We use a specific naming convention for enums in the WebKit API: enum Foo { FooA, FooB }; The values are prefixed with the type name in other words. Also, we prefix types with "Web" unless they are defined within a class. However, this suggests something fairly awkward (WebKitV8InitializationOptions), which makes me sad. Perhaps a better function is to have two functions: WEBKIT_EXPORT void initialize(WebKitPlatformSupport*); WEBKIT_EXPORT void initializeWithoutV8(WebKitPlatformSupport*); Then, in the implementation we can have initialize call initializeWithoutV8 followed by the code to actually initialize V8. 467077 19 dslomov 2011-09-14 09:34:43 -0700 (In reply to comment #18) > (From update of attachment 107202 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=107202&action=review > Perhaps a better function is to have two functions: > > WEBKIT_EXPORT void initialize(WebKitPlatformSupport*); > WEBKIT_EXPORT void initializeWithoutV8(WebKitPlatformSupport*); > > Then, in the implementation we can have initialize call initializeWithoutV8 followed by the code > to actually initialize V8. Hmm if we have another subsystem with optional initialization (let's call it Veder), how will this scale? initialize initializeWithoutV8 initializeWithoutV8andVeder initializeWithoutV8AndVeder ? I'd rather go with flags, even if that means WebKitV8InitializationOptions. Thoughts? 468338 20 fishd 2011-09-15 23:48:06 -0700 (In reply to comment #19) > (In reply to comment #18) > > (From update of attachment 107202 [details] [details]) > > View in context: https://bugs.webkit.org/attachment.cgi?id=107202&action=review > > > Perhaps a better function is to have two functions: > > > > WEBKIT_EXPORT void initialize(WebKitPlatformSupport*); > > WEBKIT_EXPORT void initializeWithoutV8(WebKitPlatformSupport*); > > > > Then, in the implementation we can have initialize call initializeWithoutV8 followed by the code > > to actually initialize V8. > > Hmm if we have another subsystem with optional initialization (let's call it Veder), how will this scale? > initialize > initializeWithoutV8 > initializeWithoutV8andVeder > initializeWithoutV8AndVeder We can change this when that becomes true, no? When that becomes true, I would prefer that we have an Options struct (e.g., WebURLLoaderOptions). > I'd rather go with flags, even if that means WebKitV8InitializationOptions. Thoughts? But that flags type is not extensible. It only deals with the V8. I would go with initializeWithoutV8 for now, and worry about extensibility later when it matters. 468515 21 dslomov 2011-09-16 08:55:20 -0700 > But that flags type is not extensible. It only deals with the V8. I would go with initializeWithoutV8 for now, and worry about extensibility later when it matters. If you say so sir :) 468689 22 107697 dslomov 2011-09-16 12:05:33 -0700 Created attachment 107697 CR feedback 468822 23 107697 fishd 2011-09-16 14:53:03 -0700 Comment on attachment 107697 CR feedback R=me 468823 24 fishd 2011-09-16 14:54:19 -0700 (In reply to comment #21) > > But that flags type is not extensible. It only deals with the V8. I would go with initializeWithoutV8 for now, and worry about extensibility later when it matters. > > If you say so sir :) It sounds like I didn't convince you? My intention is not to strong-arm you. 468831 25 dslomov 2011-09-16 15:07:55 -0700 (In reply to comment #24) > (In reply to comment #21) > > > But that flags type is not extensible. It only deals with the V8. I would go with initializeWithoutV8 for now, and worry about extensibility later when it matters. > > > > If you say so sir :) > > It sounds like I didn't convince you? My intention is not to strong-arm you. Well I think it is better to put the right and sustainable pattern into the code upfront, so I'd rather go with flags or even the whole options struct. But I really just want to move on with this patch 469029 26 107697 webkit.review.bot 2011-09-16 22:29:21 -0700 Comment on attachment 107697 CR feedback Clearing flags on attachment: 107697 Committed r95368: <http://trac.webkit.org/changeset/95368> 469030 27 webkit.review.bot 2011-09-16 22:29:27 -0700 All reviewed patches have been landed. Closing bug. 469031 28 fishd 2011-09-16 22:32:17 -0700 (In reply to comment #25) > > It sounds like I didn't convince you? My intention is not to strong-arm you. > > Well I think it is better to put the right and sustainable pattern into the code upfront, so I'd rather go with flags or even the whole options struct. But I really just want to move on with this patch Yeah... it is just common practice in WebKit to generalization until it is necessary or foresee-ably necessary. We don't know what other options we might need if ever. 469034 29 abarth 2011-09-16 22:38:39 -0700 Maciej affectionally calls this the "you ain't gonna need it" principle: http://en.wikipedia.org/wiki/You_ain't_gonna_need_it 469451 30 dslomov 2011-09-19 09:39:12 -0700 (In reply to comment #29) > Maciej affectionally calls this the "you ain't gonna need it" principle: > > http://en.wikipedia.org/wiki/You_ain't_gonna_need_it I respectfully disagree - I do already need initialization options, I might as well get them right from the start, and not leave the debt to whoever comes next. 106643 2011-09-07 14:47:56 -0700 2011-09-09 12:01:35 -0700 This patch adds initializeV8 function 67733.patch text/plain 2364 dslomov ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nIGIvU291cmNlL1dl YktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cKaW5kZXggYjZlOTJmNy4uYzQ4MjE5NCAxMDA2NDQKLS0t IGEvU291cmNlL1dlYktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdC9j aHJvbWl1bS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNyBAQAorMjAxMS0wOS0wNyAgRG1pdHJ5IExv bW92ICA8ZHNsb21vdkBnb29nbGUuY29tPgorCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQu b3JnL3Nob3dfYnVnLmNnaT9pZD02NzczMworICAgICAgICBbQ2hyb21pdW1dIFNlcGFyYXRlIFdl YktpdCBpbml0aWFsaXphdGlvbiBhbmQgVjggaW5pdGlhbGl6YXRpb24gaW4gY2hyb21pdW0gcG9y dC4KKyAgICAgICAgVGhpcyBwYXRjaCBhZGRzIGFuIFdlYktpdDo6aW5pdGlhbGl6ZVY4IGZ1bmN0 aW9uLiBBZnRlciBjb29yZGluYXRlZCBjaHJvbWl1bSBjaGFuZ2VzCisgICAgICAgIGFyZSBkb25l LCBhY3R1YWwgaW5pdGlhbGl6YXRpb24gc2hvdWxkIGJlIG1vdmVkIHRvIGluaXRpYWxpemVWOC4K KworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIHB1Ymxp Yy9XZWJLaXQuaDoKKyAgICAgICAgKiBzcmMvV2ViS2l0LmNwcDoKKyAgICAgICAgKFdlYktpdDo6 aW5pdGlhbGl6ZSk6CisgICAgICAgIChXZWJLaXQ6OmluaXRpYWxpemVWOCk6CisKIDIwMTEtMDkt MDcgIEVyaWMgQm9yZW4gIDxib3JlbmV0QGdtYWlsLmNvbT4KIAogICAgICAgICBbQ2hyb21pdW1d IE1vZGlmeSBXZWJUb3VjaEV2ZW50IHN0cnVjdHVyZSB0byBtYXRjaCBXZWJDb3JlOjpUb3VjaEV2 ZW50CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3B1YmxpYy9XZWJLaXQuaCBi L1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vcHVibGljL1dlYktpdC5oCmluZGV4IDllOWIyN2QuLjMz Yjk3YzAgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vcHVibGljL1dlYktpdC5o CisrKyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vcHVibGljL1dlYktpdC5oCkBAIC00Miw2ICs0 Miw5IEBAIGNsYXNzIFdlYktpdFBsYXRmb3JtU3VwcG9ydDsKIC8vIG5vbi1udWxsIGFuZCBtdXN0 IHJlbWFpbiB2YWxpZCB1bnRpbCB0aGUgY3VycmVudCB0aHJlYWQgY2FsbHMgc2h1dGRvd24uCiBX RUJLSVRfRVhQT1JUIHZvaWQgaW5pdGlhbGl6ZShXZWJLaXRQbGF0Zm9ybVN1cHBvcnQqKTsKIAor Ly8gTXVzdCBiZSBjYWxsZWQgb24gYSBtYWluIFdlYktpdCB0aHJlYWQgYmVmb3JlIGFueSBWOCBB UElzIGFyZSBhY2Nlc3NlZC4KK1dFQktJVF9FWFBPUlQgdm9pZCBpbml0aWFsaXplVjgoKTsKKwog Ly8gT25jZSBzaHV0ZG93biwgdGhlIFdlYktpdFBsYXRmb3JtU3VwcG9ydCBwYXNzZWQgdG8gaW5p dGlhbGl6ZSB3aWxsIG5vIGxvbmdlcgogLy8gYmUgYWNjZXNzZWQuIE5vIG90aGVyIFdlYktpdCBv YmplY3RzIHNob3VsZCBiZSBpbiB1c2Ugd2hlbiB0aGlzIGZ1bmN0aW9uIGlzCiAvLyBjYWxsZWQu IEFueSBiYWNrZ3JvdW5kIHRocmVhZHMgY3JlYXRlZCBieSBXZWJLaXQgYXJlIHByb21pc2VkIHRv IGJlCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3NyYy9XZWJLaXQuY3BwIGIv U291cmNlL1dlYktpdC9jaHJvbWl1bS9zcmMvV2ViS2l0LmNwcAppbmRleCA2YTRkN2Q0Li5jN2Y1 YTNmIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3NyYy9XZWJLaXQuY3BwCisr KyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vc3JjL1dlYktpdC5jcHAKQEAgLTg4LDExICs4OCwx NyBAQCB2b2lkIGluaXRpYWxpemUoV2ViS2l0UGxhdGZvcm1TdXBwb3J0KiB3ZWJLaXRQbGF0Zm9y bVN1cHBvcnQpCiAgICAgLy8gdGhpcywgaW5pdGlhbGl6aW5nIHRoaXMgbGF6aWx5IHByb2JhYmx5 IGRvZXNuJ3QgYnV5IHVzIG11Y2guCiAgICAgV2ViQ29yZTo6VVRGOEVuY29kaW5nKCk7CiAKKyAg ICAvLyBGSVhNRTogVGhlIGJlbG93IHNob3VsZCBiZSBtb3ZlZCB0byBXZWJLaXQ6OmluaXRpYWxp emVWOCBvbmNlIHJlbGF0ZWQgY2hhbmdlcyAKKyAgICAvLyBvbiBjaHJvbWl1bSBzaWRlIGFyZSBk b25lLgogICAgIHY4OjpWODo6U2V0RW50cm9weVNvdXJjZSgmZ2VuZXJhdGVFbnRyb3B5KTsKICAg ICB2ODo6Vjg6OkluaXRpYWxpemUoKTsKICAgICBXZWJDb3JlOjpWOEJpbmRpbmdQZXJJc29sYXRl RGF0YTo6ZW5zdXJlSW5pdGlhbGl6ZWQodjg6Oklzb2xhdGU6OkdldEN1cnJlbnQoKSk7CiB9CiAK K3ZvaWQgaW5pdGlhbGl6ZVY4KCkgCit7Cit9CisKIHZvaWQgc2h1dGRvd24oKQogewogICAgIHNf d2ViS2l0UGxhdGZvcm1TdXBwb3J0ID0gMDsK 106896 2011-09-09 12:01:35 -0700 2011-09-09 12:07:59 -0700 This patch adds a parameter to WebKit::initialize instead. 67733.patch text/plain 3141 dslomov ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nIGIvU291cmNlL1dl YktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cKaW5kZXggNThkNWUxYy4uMWZiMTZlZCAxMDA2NDQKLS0t IGEvU291cmNlL1dlYktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdC9j aHJvbWl1bS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNSBAQAorMjAxMS0wOS0wOSAgRG1pdHJ5IExv bW92ICA8ZHNsb21vdkBnb29nbGUuY29tPgorCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQu b3JnL3Nob3dfYnVnLmNnaT9pZD02NzczMworICAgICAgICBbQ2hyb21pdW1dIFNlcGFyYXRlIFdl YktpdCBpbml0aWFsaXphdGlvbiBhbmQgVjggaW5pdGlhbGl6YXRpb24gaW4gY2hyb21pdW0gcG9y dC4KKyAgICAgICAgVGhpcyBwYXRjaCBhZGRzIGFuIGluaXRpYWxpemVWOCBhcmd1bWVudCB0byBX ZWJLaXQ6OmluaXRpYWxpemUgZnVuY3Rpb24uCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZ IChPT1BTISkuCisKKyAgICAgICAgKiBwdWJsaWMvV2ViS2l0Lmg6CisgICAgICAgICogc3JjL1dl YktpdC5jcHA6CisgICAgICAgIChXZWJLaXQ6OmluaXRpYWxpemUpOgorCiAyMDExLTA5LTA5ICBI YW8gWmhlbmcgIDx6aGVuZ2hhb0BjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgW2Nocm9taXVtXSBJ bXBsZW1lbnQgRFJUIHN1cHBvcnQgZm9yIEFuZHJvaWQuCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2Vi S2l0L2Nocm9taXVtL3B1YmxpYy9XZWJLaXQuaCBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vcHVi bGljL1dlYktpdC5oCmluZGV4IDllOWIyN2QuLjhmZGE0YzkgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9X ZWJLaXQvY2hyb21pdW0vcHVibGljL1dlYktpdC5oCisrKyBiL1NvdXJjZS9XZWJLaXQvY2hyb21p dW0vcHVibGljL1dlYktpdC5oCkBAIC0zNywxMCArMzcsMjIgQEAgbmFtZXNwYWNlIFdlYktpdCB7 CiAKIGNsYXNzIFdlYktpdFBsYXRmb3JtU3VwcG9ydDsKIAorZW51bSBJbml0aWFsaXplVjggewor ICAgIElOSVRJQUxJWkVfdjgsCisgICAgRE9fTk9UX0lOSVRJQUxJWkVfVjgKK30KIC8vIE11c3Qg YmUgY2FsbGVkIG9uIHRoZSB0aHJlYWQgdGhhdCB3aWxsIGJlIHRoZSBtYWluIFdlYktpdCB0aHJl YWQgYmVmb3JlCiAvLyB1c2luZyBhbnkgb3RoZXIgV2ViS2l0IEFQSXMuIFRoZSBwcm92aWRlZCBX ZWJLaXRQbGF0Zm9ybVN1cHBvcnQ7IG11c3QgYmUKIC8vIG5vbi1udWxsIGFuZCBtdXN0IHJlbWFp biB2YWxpZCB1bnRpbCB0aGUgY3VycmVudCB0aHJlYWQgY2FsbHMgc2h1dGRvd24uCi1XRUJLSVRf RVhQT1JUIHZvaWQgaW5pdGlhbGl6ZShXZWJLaXRQbGF0Zm9ybVN1cHBvcnQqKTsKKy8vCisvLyBJ TklUSUFMSVpFX1Y4IHNob3VsZCBiZSBwYXNzZWQgaWYgVjggaXMgcGxhbm5lZCB0byBiZSB1c2Vk LgorV0VCS0lUX0VYUE9SVCB2b2lkIGluaXRpYWxpemUoV2ViS2l0UGxhdGZvcm1TdXBwb3J0Kiwg SW5pdGlhbGl6ZVY4KTsKKworLy8gVmVyc2lvbiBvZiBpbml0aWFsaXplIGZ1bmN0aW9uIHRoYXQg aW5pdGlhbGl6ZXMgVjguCitXRUJLSVRfRVhQT1JUIHZvaWQgaW50aXRhbGl6ZShXZWJLaXRQbGF0 Zm9ybVN1cHBvcnQqKTsKKworLy8gTXVzdCBiZSBjYWxsZWQgb24gYSBtYWluIFdlYktpdCB0aHJl YWQgYmVmb3JlIGFueSBWOCBBUElzIGFyZSBhY2Nlc3NlZC4KK1dFQktJVF9FWFBPUlQgdm9pZCBp bml0aWFsaXplVjgoKTsKIAogLy8gT25jZSBzaHV0ZG93biwgdGhlIFdlYktpdFBsYXRmb3JtU3Vw cG9ydCBwYXNzZWQgdG8gaW5pdGlhbGl6ZSB3aWxsIG5vIGxvbmdlcgogLy8gYmUgYWNjZXNzZWQu IE5vIG90aGVyIFdlYktpdCBvYmplY3RzIHNob3VsZCBiZSBpbiB1c2Ugd2hlbiB0aGlzIGZ1bmN0 aW9uIGlzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3NyYy9XZWJLaXQuY3Bw IGIvU291cmNlL1dlYktpdC9jaHJvbWl1bS9zcmMvV2ViS2l0LmNwcAppbmRleCA2YTRkN2Q0Li42 OGEwMTc1IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3NyYy9XZWJLaXQuY3Bw CisrKyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vc3JjL1dlYktpdC5jcHAKQEAgLTY2LDcgKzY2 LDcgQEAgc3RhdGljIGJvb2wgZ2VuZXJhdGVFbnRyb3B5KHVuc2lnbmVkIGNoYXIqIGJ1ZmZlciwg c2l6ZV90IGxlbmd0aCkKICAgICByZXR1cm4gZmFsc2U7CiB9CiAKLXZvaWQgaW5pdGlhbGl6ZShX ZWJLaXRQbGF0Zm9ybVN1cHBvcnQqIHdlYktpdFBsYXRmb3JtU3VwcG9ydCkKK3ZvaWQgaW5pdGlh bGl6ZShXZWJLaXRQbGF0Zm9ybVN1cHBvcnQqIHdlYktpdFBsYXRmb3JtU3VwcG9ydCwgSW5pdGlh bGl6ZVY4IGluaXRpYWxpemVWOCkKIHsKICAgICBBU1NFUlQoIXNfd2ViS2l0SW5pdGlhbGl6ZWQp OwogICAgIHNfd2ViS2l0SW5pdGlhbGl6ZWQgPSB0cnVlOwpAQCAtODgsOSArODgsMTYgQEAgdm9p ZCBpbml0aWFsaXplKFdlYktpdFBsYXRmb3JtU3VwcG9ydCogd2ViS2l0UGxhdGZvcm1TdXBwb3J0 KQogICAgIC8vIHRoaXMsIGluaXRpYWxpemluZyB0aGlzIGxhemlseSBwcm9iYWJseSBkb2Vzbid0 IGJ1eSB1cyBtdWNoLgogICAgIFdlYkNvcmU6OlVURjhFbmNvZGluZygpOwogCi0gICAgdjg6OlY4 OjpTZXRFbnRyb3B5U291cmNlKCZnZW5lcmF0ZUVudHJvcHkpOwotICAgIHY4OjpWODo6SW5pdGlh bGl6ZSgpOwotICAgIFdlYkNvcmU6OlY4QmluZGluZ1Blcklzb2xhdGVEYXRhOjplbnN1cmVJbml0 aWFsaXplZCh2ODo6SXNvbGF0ZTo6R2V0Q3VycmVudCgpKTsKKyAgICBpZiAoaW5pdGlhbGl6ZVY4 ID09IElOSVRJQUxJWkVfVjgpIHsKKyAgICAgICAgdjg6OlY4OjpTZXRFbnRyb3B5U291cmNlKCZn ZW5lcmF0ZUVudHJvcHkpOworICAgICAgICB2ODo6Vjg6OkluaXRpYWxpemUoKTsKKyAgICAgICAg V2ViQ29yZTo6VjhCaW5kaW5nUGVySXNvbGF0ZURhdGE6OmVuc3VyZUluaXRpYWxpemVkKHY4OjpJ c29sYXRlOjpHZXRDdXJyZW50KCkpOworICAgIH0KK30KKwordm9pZCBpbml0aWFsaXplKFdlYktp dFBsYXRmb3JtU3VwcG9ydCogd2ViS2l0UGxhdGZvcm1TdXBwb3J0KQoreworICAgIGluaXRpYWxp emUod2ViS2l0UGxhZm9ybVN1cHBvcnQsIElOSVRJQUxJWkVfVjgpOwogfQogCiB2b2lkIHNodXRk b3duKCkK 106899 2011-09-09 12:07:59 -0700 2011-09-09 13:40:44 -0700 Obsolete sig removed 67733.patch text/plain 3027 dslomov ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nIGIvU291cmNlL1dl YktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cKaW5kZXggNThkNWUxYy4uMWZiMTZlZCAxMDA2NDQKLS0t IGEvU291cmNlL1dlYktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdC9j aHJvbWl1bS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNSBAQAorMjAxMS0wOS0wOSAgRG1pdHJ5IExv bW92ICA8ZHNsb21vdkBnb29nbGUuY29tPgorCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQu b3JnL3Nob3dfYnVnLmNnaT9pZD02NzczMworICAgICAgICBbQ2hyb21pdW1dIFNlcGFyYXRlIFdl YktpdCBpbml0aWFsaXphdGlvbiBhbmQgVjggaW5pdGlhbGl6YXRpb24gaW4gY2hyb21pdW0gcG9y dC4KKyAgICAgICAgVGhpcyBwYXRjaCBhZGRzIGFuIGluaXRpYWxpemVWOCBhcmd1bWVudCB0byBX ZWJLaXQ6OmluaXRpYWxpemUgZnVuY3Rpb24uCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZ IChPT1BTISkuCisKKyAgICAgICAgKiBwdWJsaWMvV2ViS2l0Lmg6CisgICAgICAgICogc3JjL1dl YktpdC5jcHA6CisgICAgICAgIChXZWJLaXQ6OmluaXRpYWxpemUpOgorCiAyMDExLTA5LTA5ICBI YW8gWmhlbmcgIDx6aGVuZ2hhb0BjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgW2Nocm9taXVtXSBJ bXBsZW1lbnQgRFJUIHN1cHBvcnQgZm9yIEFuZHJvaWQuCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2Vi S2l0L2Nocm9taXVtL3B1YmxpYy9XZWJLaXQuaCBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vcHVi bGljL1dlYktpdC5oCmluZGV4IDllOWIyN2QuLmFhYWIxMTggMTAwNjQ0Ci0tLSBhL1NvdXJjZS9X ZWJLaXQvY2hyb21pdW0vcHVibGljL1dlYktpdC5oCisrKyBiL1NvdXJjZS9XZWJLaXQvY2hyb21p dW0vcHVibGljL1dlYktpdC5oCkBAIC0zNywxMCArMzcsMTkgQEAgbmFtZXNwYWNlIFdlYktpdCB7 CiAKIGNsYXNzIFdlYktpdFBsYXRmb3JtU3VwcG9ydDsKIAorZW51bSBJbml0aWFsaXplVjggewor ICAgIElOSVRJQUxJWkVfdjgsCisgICAgRE9fTk9UX0lOSVRJQUxJWkVfVjgKK30KIC8vIE11c3Qg YmUgY2FsbGVkIG9uIHRoZSB0aHJlYWQgdGhhdCB3aWxsIGJlIHRoZSBtYWluIFdlYktpdCB0aHJl YWQgYmVmb3JlCiAvLyB1c2luZyBhbnkgb3RoZXIgV2ViS2l0IEFQSXMuIFRoZSBwcm92aWRlZCBX ZWJLaXRQbGF0Zm9ybVN1cHBvcnQ7IG11c3QgYmUKIC8vIG5vbi1udWxsIGFuZCBtdXN0IHJlbWFp biB2YWxpZCB1bnRpbCB0aGUgY3VycmVudCB0aHJlYWQgY2FsbHMgc2h1dGRvd24uCi1XRUJLSVRf RVhQT1JUIHZvaWQgaW5pdGlhbGl6ZShXZWJLaXRQbGF0Zm9ybVN1cHBvcnQqKTsKKy8vCisvLyBJ TklUSUFMSVpFX1Y4IHNob3VsZCBiZSBwYXNzZWQgaWYgVjggaXMgcGxhbm5lZCB0byBiZSB1c2Vk LgorV0VCS0lUX0VYUE9SVCB2b2lkIGluaXRpYWxpemUoV2ViS2l0UGxhdGZvcm1TdXBwb3J0Kiwg SW5pdGlhbGl6ZVY4KTsKKworLy8gVmVyc2lvbiBvZiBpbml0aWFsaXplIGZ1bmN0aW9uIHRoYXQg aW5pdGlhbGl6ZXMgVjguCitXRUJLSVRfRVhQT1JUIHZvaWQgaW50aXRhbGl6ZShXZWJLaXRQbGF0 Zm9ybVN1cHBvcnQqKTsKIAogLy8gT25jZSBzaHV0ZG93biwgdGhlIFdlYktpdFBsYXRmb3JtU3Vw cG9ydCBwYXNzZWQgdG8gaW5pdGlhbGl6ZSB3aWxsIG5vIGxvbmdlcgogLy8gYmUgYWNjZXNzZWQu IE5vIG90aGVyIFdlYktpdCBvYmplY3RzIHNob3VsZCBiZSBpbiB1c2Ugd2hlbiB0aGlzIGZ1bmN0 aW9uIGlzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3NyYy9XZWJLaXQuY3Bw IGIvU291cmNlL1dlYktpdC9jaHJvbWl1bS9zcmMvV2ViS2l0LmNwcAppbmRleCA2YTRkN2Q0Li42 OGEwMTc1IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3NyYy9XZWJLaXQuY3Bw CisrKyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vc3JjL1dlYktpdC5jcHAKQEAgLTY2LDcgKzY2 LDcgQEAgc3RhdGljIGJvb2wgZ2VuZXJhdGVFbnRyb3B5KHVuc2lnbmVkIGNoYXIqIGJ1ZmZlciwg c2l6ZV90IGxlbmd0aCkKICAgICByZXR1cm4gZmFsc2U7CiB9CiAKLXZvaWQgaW5pdGlhbGl6ZShX ZWJLaXRQbGF0Zm9ybVN1cHBvcnQqIHdlYktpdFBsYXRmb3JtU3VwcG9ydCkKK3ZvaWQgaW5pdGlh bGl6ZShXZWJLaXRQbGF0Zm9ybVN1cHBvcnQqIHdlYktpdFBsYXRmb3JtU3VwcG9ydCwgSW5pdGlh bGl6ZVY4IGluaXRpYWxpemVWOCkKIHsKICAgICBBU1NFUlQoIXNfd2ViS2l0SW5pdGlhbGl6ZWQp OwogICAgIHNfd2ViS2l0SW5pdGlhbGl6ZWQgPSB0cnVlOwpAQCAtODgsOSArODgsMTYgQEAgdm9p ZCBpbml0aWFsaXplKFdlYktpdFBsYXRmb3JtU3VwcG9ydCogd2ViS2l0UGxhdGZvcm1TdXBwb3J0 KQogICAgIC8vIHRoaXMsIGluaXRpYWxpemluZyB0aGlzIGxhemlseSBwcm9iYWJseSBkb2Vzbid0 IGJ1eSB1cyBtdWNoLgogICAgIFdlYkNvcmU6OlVURjhFbmNvZGluZygpOwogCi0gICAgdjg6OlY4 OjpTZXRFbnRyb3B5U291cmNlKCZnZW5lcmF0ZUVudHJvcHkpOwotICAgIHY4OjpWODo6SW5pdGlh bGl6ZSgpOwotICAgIFdlYkNvcmU6OlY4QmluZGluZ1Blcklzb2xhdGVEYXRhOjplbnN1cmVJbml0 aWFsaXplZCh2ODo6SXNvbGF0ZTo6R2V0Q3VycmVudCgpKTsKKyAgICBpZiAoaW5pdGlhbGl6ZVY4 ID09IElOSVRJQUxJWkVfVjgpIHsKKyAgICAgICAgdjg6OlY4OjpTZXRFbnRyb3B5U291cmNlKCZn ZW5lcmF0ZUVudHJvcHkpOworICAgICAgICB2ODo6Vjg6OkluaXRpYWxpemUoKTsKKyAgICAgICAg V2ViQ29yZTo6VjhCaW5kaW5nUGVySXNvbGF0ZURhdGE6OmVuc3VyZUluaXRpYWxpemVkKHY4OjpJ c29sYXRlOjpHZXRDdXJyZW50KCkpOworICAgIH0KK30KKwordm9pZCBpbml0aWFsaXplKFdlYktp dFBsYXRmb3JtU3VwcG9ydCogd2ViS2l0UGxhdGZvcm1TdXBwb3J0KQoreworICAgIGluaXRpYWxp emUod2ViS2l0UGxhZm9ybVN1cHBvcnQsIElOSVRJQUxJWkVfVjgpOwogfQogCiB2b2lkIHNodXRk b3duKCkK 106912 2011-09-09 13:40:44 -0700 2011-09-12 13:54:09 -0700 Fixed botched build. 67733.patch text/plain 2894 dslomov ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nIGIvU291cmNlL1dl YktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cKaW5kZXggNThkNWUxYy4uMWZiMTZlZCAxMDA2NDQKLS0t IGEvU291cmNlL1dlYktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdC9j aHJvbWl1bS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNSBAQAorMjAxMS0wOS0wOSAgRG1pdHJ5IExv bW92ICA8ZHNsb21vdkBnb29nbGUuY29tPgorCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQu b3JnL3Nob3dfYnVnLmNnaT9pZD02NzczMworICAgICAgICBbQ2hyb21pdW1dIFNlcGFyYXRlIFdl YktpdCBpbml0aWFsaXphdGlvbiBhbmQgVjggaW5pdGlhbGl6YXRpb24gaW4gY2hyb21pdW0gcG9y dC4KKyAgICAgICAgVGhpcyBwYXRjaCBhZGRzIGFuIGluaXRpYWxpemVWOCBhcmd1bWVudCB0byBX ZWJLaXQ6OmluaXRpYWxpemUgZnVuY3Rpb24uCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZ IChPT1BTISkuCisKKyAgICAgICAgKiBwdWJsaWMvV2ViS2l0Lmg6CisgICAgICAgICogc3JjL1dl YktpdC5jcHA6CisgICAgICAgIChXZWJLaXQ6OmluaXRpYWxpemUpOgorCiAyMDExLTA5LTA5ICBI YW8gWmhlbmcgIDx6aGVuZ2hhb0BjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgW2Nocm9taXVtXSBJ bXBsZW1lbnQgRFJUIHN1cHBvcnQgZm9yIEFuZHJvaWQuCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2Vi S2l0L2Nocm9taXVtL3B1YmxpYy9XZWJLaXQuaCBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vcHVi bGljL1dlYktpdC5oCmluZGV4IDllOWIyN2QuLmZlZjRhOWQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9X ZWJLaXQvY2hyb21pdW0vcHVibGljL1dlYktpdC5oCisrKyBiL1NvdXJjZS9XZWJLaXQvY2hyb21p dW0vcHVibGljL1dlYktpdC5oCkBAIC0zNyw5ICszNywxOSBAQCBuYW1lc3BhY2UgV2ViS2l0IHsK IAogY2xhc3MgV2ViS2l0UGxhdGZvcm1TdXBwb3J0OwogCitlbnVtIEluaXRpYWxpemVWOCB7Cisg ICAgSU5JVElBTElaRV9WOCwKKyAgICBET19OT1RfSU5JVElBTElaRV9WOAorfTsKKwogLy8gTXVz dCBiZSBjYWxsZWQgb24gdGhlIHRocmVhZCB0aGF0IHdpbGwgYmUgdGhlIG1haW4gV2ViS2l0IHRo cmVhZCBiZWZvcmUKIC8vIHVzaW5nIGFueSBvdGhlciBXZWJLaXQgQVBJcy4gVGhlIHByb3ZpZGVk IFdlYktpdFBsYXRmb3JtU3VwcG9ydDsgbXVzdCBiZQogLy8gbm9uLW51bGwgYW5kIG11c3QgcmVt YWluIHZhbGlkIHVudGlsIHRoZSBjdXJyZW50IHRocmVhZCBjYWxscyBzaHV0ZG93bi4KKy8vCisv LyBJTklUSUFMSVpFX1Y4IHNob3VsZCBiZSBwYXNzZWQgaWYgVjggaXMgcGxhbm5lZCB0byBiZSB1 c2VkLgorV0VCS0lUX0VYUE9SVCB2b2lkIGluaXRpYWxpemUoV2ViS2l0UGxhdGZvcm1TdXBwb3J0 KiwgSW5pdGlhbGl6ZVY4KTsKKworLy8gVmVyc2lvbiBvZiBpbml0aWFsaXplIGZ1bmN0aW9uIHRo YXQgaW5pdGlhbGl6ZXMgVjguCiBXRUJLSVRfRVhQT1JUIHZvaWQgaW5pdGlhbGl6ZShXZWJLaXRQ bGF0Zm9ybVN1cHBvcnQqKTsKIAogLy8gT25jZSBzaHV0ZG93biwgdGhlIFdlYktpdFBsYXRmb3Jt U3VwcG9ydCBwYXNzZWQgdG8gaW5pdGlhbGl6ZSB3aWxsIG5vIGxvbmdlcgpkaWZmIC0tZ2l0IGEv U291cmNlL1dlYktpdC9jaHJvbWl1bS9zcmMvV2ViS2l0LmNwcCBiL1NvdXJjZS9XZWJLaXQvY2hy b21pdW0vc3JjL1dlYktpdC5jcHAKaW5kZXggNmE0ZDdkNC4uOTNjNzI4NSAxMDA2NDQKLS0tIGEv U291cmNlL1dlYktpdC9jaHJvbWl1bS9zcmMvV2ViS2l0LmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0 L2Nocm9taXVtL3NyYy9XZWJLaXQuY3BwCkBAIC02Niw3ICs2Niw3IEBAIHN0YXRpYyBib29sIGdl bmVyYXRlRW50cm9weSh1bnNpZ25lZCBjaGFyKiBidWZmZXIsIHNpemVfdCBsZW5ndGgpCiAgICAg cmV0dXJuIGZhbHNlOwogfQogCi12b2lkIGluaXRpYWxpemUoV2ViS2l0UGxhdGZvcm1TdXBwb3J0 KiB3ZWJLaXRQbGF0Zm9ybVN1cHBvcnQpCit2b2lkIGluaXRpYWxpemUoV2ViS2l0UGxhdGZvcm1T dXBwb3J0KiB3ZWJLaXRQbGF0Zm9ybVN1cHBvcnQsIEluaXRpYWxpemVWOCBpbml0aWFsaXplVjgp CiB7CiAgICAgQVNTRVJUKCFzX3dlYktpdEluaXRpYWxpemVkKTsKICAgICBzX3dlYktpdEluaXRp YWxpemVkID0gdHJ1ZTsKQEAgLTg4LDkgKzg4LDE2IEBAIHZvaWQgaW5pdGlhbGl6ZShXZWJLaXRQ bGF0Zm9ybVN1cHBvcnQqIHdlYktpdFBsYXRmb3JtU3VwcG9ydCkKICAgICAvLyB0aGlzLCBpbml0 aWFsaXppbmcgdGhpcyBsYXppbHkgcHJvYmFibHkgZG9lc24ndCBidXkgdXMgbXVjaC4KICAgICBX ZWJDb3JlOjpVVEY4RW5jb2RpbmcoKTsKIAotICAgIHY4OjpWODo6U2V0RW50cm9weVNvdXJjZSgm Z2VuZXJhdGVFbnRyb3B5KTsKLSAgICB2ODo6Vjg6OkluaXRpYWxpemUoKTsKLSAgICBXZWJDb3Jl OjpWOEJpbmRpbmdQZXJJc29sYXRlRGF0YTo6ZW5zdXJlSW5pdGlhbGl6ZWQodjg6Oklzb2xhdGU6 OkdldEN1cnJlbnQoKSk7CisgICAgaWYgKGluaXRpYWxpemVWOCA9PSBJTklUSUFMSVpFX1Y4KSB7 CisgICAgICAgIHY4OjpWODo6U2V0RW50cm9weVNvdXJjZSgmZ2VuZXJhdGVFbnRyb3B5KTsKKyAg ICAgICAgdjg6OlY4OjpJbml0aWFsaXplKCk7CisgICAgICAgIFdlYkNvcmU6OlY4QmluZGluZ1Bl cklzb2xhdGVEYXRhOjplbnN1cmVJbml0aWFsaXplZCh2ODo6SXNvbGF0ZTo6R2V0Q3VycmVudCgp KTsKKyAgICB9Cit9CisKK3ZvaWQgaW5pdGlhbGl6ZShXZWJLaXRQbGF0Zm9ybVN1cHBvcnQqIHdl YktpdFBsYXRmb3JtU3VwcG9ydCkKK3sKKyAgICBpbml0aWFsaXplKHdlYktpdFBsYXRmb3JtU3Vw cG9ydCwgSU5JVElBTElaRV9WOCk7CiB9CiAKIHZvaWQgc2h1dGRvd24oKQo= 107080 2011-09-12 13:54:09 -0700 2011-09-13 11:39:07 -0700 Default argument instead if overloads 67733.patch text/plain 2860 dslomov ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nIGIvU291cmNlL1dl YktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cKaW5kZXggMzc5ZjlkNS4uMDg0NWYxMyAxMDA2NDQKLS0t IGEvU291cmNlL1dlYktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdC9j aHJvbWl1bS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNSBAQAorMjAxMS0wOS0wOSAgRG1pdHJ5IExv bW92ICA8ZHNsb21vdkBnb29nbGUuY29tPgorCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQu b3JnL3Nob3dfYnVnLmNnaT9pZD02NzczMworICAgICAgICBbQ2hyb21pdW1dIFNlcGFyYXRlIFdl YktpdCBpbml0aWFsaXphdGlvbiBhbmQgVjggaW5pdGlhbGl6YXRpb24gaW4gY2hyb21pdW0gcG9y dC4KKyAgICAgICAgVGhpcyBwYXRjaCBhZGRzIGFuIGluaXRpYWxpemVWOCBhcmd1bWVudCB0byBX ZWJLaXQ6OmluaXRpYWxpemUgZnVuY3Rpb24uCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZ IChPT1BTISkuCisKKyAgICAgICAgKiBwdWJsaWMvV2ViS2l0Lmg6CisgICAgICAgICogc3JjL1dl YktpdC5jcHA6CisgICAgICAgIChXZWJLaXQ6OmluaXRpYWxpemUpOgorCiAyMDExLTA5LTA4ICBO YXQgRHVjYSAgPG5kdWNhQGNocm9taXVtLm9yZz4KIAogICAgICAgICBbY2hyb21pdW1dIEFkZCBH cmFwaGljc0NvbnRleHQzRFByaXZhdGU6Y3JlYXRlR3JhcGhpY3NDb250ZXh0Rm9yQW5vdGhlclRo cmVhZApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9jaHJvbWl1bS9wdWJsaWMvV2ViS2l0Lmgg Yi9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3B1YmxpYy9XZWJLaXQuaAppbmRleCA5ZTliMjdkLi5m NmFiMmY0IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3B1YmxpYy9XZWJLaXQu aAorKysgYi9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3B1YmxpYy9XZWJLaXQuaApAQCAtMzcsMTAg KzM3LDE3IEBAIG5hbWVzcGFjZSBXZWJLaXQgewogCiBjbGFzcyBXZWJLaXRQbGF0Zm9ybVN1cHBv cnQ7CiAKK2VudW0gU2hvdWxkSW5pdGlhbGl6ZVY4IHsKKyAgICBJbml0aWFsaXplVjgsCisgICAg RG9Ob3RJbml0aWFsaXplVjgKK307CisKIC8vIE11c3QgYmUgY2FsbGVkIG9uIHRoZSB0aHJlYWQg dGhhdCB3aWxsIGJlIHRoZSBtYWluIFdlYktpdCB0aHJlYWQgYmVmb3JlCiAvLyB1c2luZyBhbnkg b3RoZXIgV2ViS2l0IEFQSXMuIFRoZSBwcm92aWRlZCBXZWJLaXRQbGF0Zm9ybVN1cHBvcnQ7IG11 c3QgYmUKIC8vIG5vbi1udWxsIGFuZCBtdXN0IHJlbWFpbiB2YWxpZCB1bnRpbCB0aGUgY3VycmVu dCB0aHJlYWQgY2FsbHMgc2h1dGRvd24uCi1XRUJLSVRfRVhQT1JUIHZvaWQgaW5pdGlhbGl6ZShX ZWJLaXRQbGF0Zm9ybVN1cHBvcnQqKTsKKy8vCisvLyBJTklUSUFMSVpFX1Y4IHNob3VsZCBiZSBw YXNzZWQgaWYgVjggaXMgcGxhbm5lZCB0byBiZSB1c2VkLgorV0VCS0lUX0VYUE9SVCB2b2lkIGlu aXRpYWxpemUoV2ViS2l0UGxhdGZvcm1TdXBwb3J0KiwgU2hvdWxkSW5pdGlhbGl6ZVY4IGluaXRp YWxpemVWOCA9IEluaXRpYWxpemVWOCk7CiAKIC8vIE9uY2Ugc2h1dGRvd24sIHRoZSBXZWJLaXRQ bGF0Zm9ybVN1cHBvcnQgcGFzc2VkIHRvIGluaXRpYWxpemUgd2lsbCBubyBsb25nZXIKIC8vIGJl IGFjY2Vzc2VkLiBObyBvdGhlciBXZWJLaXQgb2JqZWN0cyBzaG91bGQgYmUgaW4gdXNlIHdoZW4g dGhpcyBmdW5jdGlvbiBpcwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9jaHJvbWl1bS9zcmMv V2ViS2l0LmNwcCBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vc3JjL1dlYktpdC5jcHAKaW5kZXgg NmE0ZDdkNC4uMmU0ODc2ZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9jaHJvbWl1bS9zcmMv V2ViS2l0LmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3NyYy9XZWJLaXQuY3BwCkBA IC02Niw3ICs2Niw3IEBAIHN0YXRpYyBib29sIGdlbmVyYXRlRW50cm9weSh1bnNpZ25lZCBjaGFy KiBidWZmZXIsIHNpemVfdCBsZW5ndGgpCiAgICAgcmV0dXJuIGZhbHNlOwogfQogCi12b2lkIGlu aXRpYWxpemUoV2ViS2l0UGxhdGZvcm1TdXBwb3J0KiB3ZWJLaXRQbGF0Zm9ybVN1cHBvcnQpCit2 b2lkIGluaXRpYWxpemUoV2ViS2l0UGxhdGZvcm1TdXBwb3J0KiB3ZWJLaXRQbGF0Zm9ybVN1cHBv cnQsIFNob3VsZEluaXRpYWxpemVWOCBpbml0aWFsaXplVjgpCiB7CiAgICAgQVNTRVJUKCFzX3dl YktpdEluaXRpYWxpemVkKTsKICAgICBzX3dlYktpdEluaXRpYWxpemVkID0gdHJ1ZTsKQEAgLTg4 LDkgKzg4LDExIEBAIHZvaWQgaW5pdGlhbGl6ZShXZWJLaXRQbGF0Zm9ybVN1cHBvcnQqIHdlYktp dFBsYXRmb3JtU3VwcG9ydCkKICAgICAvLyB0aGlzLCBpbml0aWFsaXppbmcgdGhpcyBsYXppbHkg cHJvYmFibHkgZG9lc24ndCBidXkgdXMgbXVjaC4KICAgICBXZWJDb3JlOjpVVEY4RW5jb2Rpbmco KTsKIAotICAgIHY4OjpWODo6U2V0RW50cm9weVNvdXJjZSgmZ2VuZXJhdGVFbnRyb3B5KTsKLSAg ICB2ODo6Vjg6OkluaXRpYWxpemUoKTsKLSAgICBXZWJDb3JlOjpWOEJpbmRpbmdQZXJJc29sYXRl RGF0YTo6ZW5zdXJlSW5pdGlhbGl6ZWQodjg6Oklzb2xhdGU6OkdldEN1cnJlbnQoKSk7CisgICAg aWYgKGluaXRpYWxpemVWOCA9PSBJbml0aWFsaXplVjgpIHsKKyAgICAgICAgdjg6OlY4OjpTZXRF bnRyb3B5U291cmNlKCZnZW5lcmF0ZUVudHJvcHkpOworICAgICAgICB2ODo6Vjg6OkluaXRpYWxp emUoKTsKKyAgICAgICAgV2ViQ29yZTo6VjhCaW5kaW5nUGVySXNvbGF0ZURhdGE6OmVuc3VyZUlu aXRpYWxpemVkKHY4OjpJc29sYXRlOjpHZXRDdXJyZW50KCkpOworICAgIH0KIH0KIAogdm9pZCBz aHV0ZG93bigpCg== 107202 2011-09-13 11:39:07 -0700 2011-09-16 12:05:33 -0700 Style 67733.patch text/plain 2846 dslomov ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nIGIvU291cmNlL1dl YktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cKaW5kZXggMzc5ZjlkNS4uMDg0NWYxMyAxMDA2NDQKLS0t IGEvU291cmNlL1dlYktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdC9j aHJvbWl1bS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNSBAQAorMjAxMS0wOS0wOSAgRG1pdHJ5IExv bW92ICA8ZHNsb21vdkBnb29nbGUuY29tPgorCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQu b3JnL3Nob3dfYnVnLmNnaT9pZD02NzczMworICAgICAgICBbQ2hyb21pdW1dIFNlcGFyYXRlIFdl YktpdCBpbml0aWFsaXphdGlvbiBhbmQgVjggaW5pdGlhbGl6YXRpb24gaW4gY2hyb21pdW0gcG9y dC4KKyAgICAgICAgVGhpcyBwYXRjaCBhZGRzIGFuIGluaXRpYWxpemVWOCBhcmd1bWVudCB0byBX ZWJLaXQ6OmluaXRpYWxpemUgZnVuY3Rpb24uCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZ IChPT1BTISkuCisKKyAgICAgICAgKiBwdWJsaWMvV2ViS2l0Lmg6CisgICAgICAgICogc3JjL1dl YktpdC5jcHA6CisgICAgICAgIChXZWJLaXQ6OmluaXRpYWxpemUpOgorCiAyMDExLTA5LTA4ICBO YXQgRHVjYSAgPG5kdWNhQGNocm9taXVtLm9yZz4KIAogICAgICAgICBbY2hyb21pdW1dIEFkZCBH cmFwaGljc0NvbnRleHQzRFByaXZhdGU6Y3JlYXRlR3JhcGhpY3NDb250ZXh0Rm9yQW5vdGhlclRo cmVhZApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9jaHJvbWl1bS9wdWJsaWMvV2ViS2l0Lmgg Yi9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3B1YmxpYy9XZWJLaXQuaAppbmRleCA5ZTliMjdkLi4x MDViNzQxIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3B1YmxpYy9XZWJLaXQu aAorKysgYi9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3B1YmxpYy9XZWJLaXQuaApAQCAtMzcsMTAg KzM3LDE3IEBAIG5hbWVzcGFjZSBXZWJLaXQgewogCiBjbGFzcyBXZWJLaXRQbGF0Zm9ybVN1cHBv cnQ7CiAKK2VudW0gU2hvdWxkSW5pdGlhbGl6ZVY4IHsKKyAgICBJbml0aWFsaXplVjgsCisgICAg RG9Ob3RJbml0aWFsaXplVjgKK307CisKIC8vIE11c3QgYmUgY2FsbGVkIG9uIHRoZSB0aHJlYWQg dGhhdCB3aWxsIGJlIHRoZSBtYWluIFdlYktpdCB0aHJlYWQgYmVmb3JlCiAvLyB1c2luZyBhbnkg b3RoZXIgV2ViS2l0IEFQSXMuIFRoZSBwcm92aWRlZCBXZWJLaXRQbGF0Zm9ybVN1cHBvcnQ7IG11 c3QgYmUKIC8vIG5vbi1udWxsIGFuZCBtdXN0IHJlbWFpbiB2YWxpZCB1bnRpbCB0aGUgY3VycmVu dCB0aHJlYWQgY2FsbHMgc2h1dGRvd24uCi1XRUJLSVRfRVhQT1JUIHZvaWQgaW5pdGlhbGl6ZShX ZWJLaXRQbGF0Zm9ybVN1cHBvcnQqKTsKKy8vCisvLyBJbml0aWFsaXplVjggc2hvdWxkIGJlIHBh c3NlZCBpZiBWOCBpcyBwbGFubmVkIHRvIGJlIHVzZWQuCitXRUJLSVRfRVhQT1JUIHZvaWQgaW5p dGlhbGl6ZShXZWJLaXRQbGF0Zm9ybVN1cHBvcnQqLCBTaG91bGRJbml0aWFsaXplVjggPSBJbml0 aWFsaXplVjgpOwogCiAvLyBPbmNlIHNodXRkb3duLCB0aGUgV2ViS2l0UGxhdGZvcm1TdXBwb3J0 IHBhc3NlZCB0byBpbml0aWFsaXplIHdpbGwgbm8gbG9uZ2VyCiAvLyBiZSBhY2Nlc3NlZC4gTm8g b3RoZXIgV2ViS2l0IG9iamVjdHMgc2hvdWxkIGJlIGluIHVzZSB3aGVuIHRoaXMgZnVuY3Rpb24g aXMKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vc3JjL1dlYktpdC5jcHAgYi9T b3VyY2UvV2ViS2l0L2Nocm9taXVtL3NyYy9XZWJLaXQuY3BwCmluZGV4IDZhNGQ3ZDQuLjJlNDg3 NmQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vc3JjL1dlYktpdC5jcHAKKysr IGIvU291cmNlL1dlYktpdC9jaHJvbWl1bS9zcmMvV2ViS2l0LmNwcApAQCAtNjYsNyArNjYsNyBA QCBzdGF0aWMgYm9vbCBnZW5lcmF0ZUVudHJvcHkodW5zaWduZWQgY2hhciogYnVmZmVyLCBzaXpl X3QgbGVuZ3RoKQogICAgIHJldHVybiBmYWxzZTsKIH0KIAotdm9pZCBpbml0aWFsaXplKFdlYktp dFBsYXRmb3JtU3VwcG9ydCogd2ViS2l0UGxhdGZvcm1TdXBwb3J0KQordm9pZCBpbml0aWFsaXpl KFdlYktpdFBsYXRmb3JtU3VwcG9ydCogd2ViS2l0UGxhdGZvcm1TdXBwb3J0LCBTaG91bGRJbml0 aWFsaXplVjggaW5pdGlhbGl6ZVY4KQogewogICAgIEFTU0VSVCghc193ZWJLaXRJbml0aWFsaXpl ZCk7CiAgICAgc193ZWJLaXRJbml0aWFsaXplZCA9IHRydWU7CkBAIC04OCw5ICs4OCwxMSBAQCB2 b2lkIGluaXRpYWxpemUoV2ViS2l0UGxhdGZvcm1TdXBwb3J0KiB3ZWJLaXRQbGF0Zm9ybVN1cHBv cnQpCiAgICAgLy8gdGhpcywgaW5pdGlhbGl6aW5nIHRoaXMgbGF6aWx5IHByb2JhYmx5IGRvZXNu J3QgYnV5IHVzIG11Y2guCiAgICAgV2ViQ29yZTo6VVRGOEVuY29kaW5nKCk7CiAKLSAgICB2ODo6 Vjg6OlNldEVudHJvcHlTb3VyY2UoJmdlbmVyYXRlRW50cm9weSk7Ci0gICAgdjg6OlY4OjpJbml0 aWFsaXplKCk7Ci0gICAgV2ViQ29yZTo6VjhCaW5kaW5nUGVySXNvbGF0ZURhdGE6OmVuc3VyZUlu aXRpYWxpemVkKHY4OjpJc29sYXRlOjpHZXRDdXJyZW50KCkpOworICAgIGlmIChpbml0aWFsaXpl VjggPT0gSW5pdGlhbGl6ZVY4KSB7CisgICAgICAgIHY4OjpWODo6U2V0RW50cm9weVNvdXJjZSgm Z2VuZXJhdGVFbnRyb3B5KTsKKyAgICAgICAgdjg6OlY4OjpJbml0aWFsaXplKCk7CisgICAgICAg IFdlYkNvcmU6OlY4QmluZGluZ1Blcklzb2xhdGVEYXRhOjplbnN1cmVJbml0aWFsaXplZCh2ODo6 SXNvbGF0ZTo6R2V0Q3VycmVudCgpKTsKKyAgICB9CiB9CiAKIHZvaWQgc2h1dGRvd24oKQo= 107697 2011-09-16 12:05:33 -0700 2011-09-16 22:29:21 -0700 CR feedback 67773.patch text/plain 2832 dslomov ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nIGIvU291cmNlL1dl YktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cKaW5kZXggZjA2N2Y2My4uYjhmNmNjNiAxMDA2NDQKLS0t IGEvU291cmNlL1dlYktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdC9j aHJvbWl1bS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNSBAQAorMjAxMS0wOS0wOSAgRG1pdHJ5IExv bW92ICA8ZHNsb21vdkBnb29nbGUuY29tPgorCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQu b3JnL3Nob3dfYnVnLmNnaT9pZD02NzczMworICAgICAgICBbQ2hyb21pdW1dIFNlcGFyYXRlIFdl YktpdCBpbml0aWFsaXphdGlvbiBhbmQgVjggaW5pdGlhbGl6YXRpb24gaW4gY2hyb21pdW0gcG9y dC4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIHB1 YmxpYy9XZWJLaXQuaDoKKyAgICAgICAgKiBzcmMvV2ViS2l0LmNwcDoKKyAgICAgICAgKFdlYktp dDo6aW5pdGlhbGl6ZSk6CisgICAgICAgIChXZWJLaXQ6OmluaXRpYWxpemVXaXRob3V0VjgpOgor CiAyMDExLTA5LTE1ICBFcmljIFNlaWRlbCAgPGVyaWNAd2Via2l0Lm9yZz4KIAogICAgICAgICBS ZW1vdmUgRU5BQkxFKFNWR19BU19JTUFHRSkgc2luY2UgYWxsIG1ham9yIHBvcnRzIGhhdmUgaXQg b24gYnkgZGVmYXVsdApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9jaHJvbWl1bS9wdWJsaWMv V2ViS2l0LmggYi9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3B1YmxpYy9XZWJLaXQuaAppbmRleCA5 ZTliMjdkLi45OTFkNTQzIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3B1Ymxp Yy9XZWJLaXQuaAorKysgYi9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3B1YmxpYy9XZWJLaXQuaApA QCAtNDIsNiArNDIsMTMgQEAgY2xhc3MgV2ViS2l0UGxhdGZvcm1TdXBwb3J0OwogLy8gbm9uLW51 bGwgYW5kIG11c3QgcmVtYWluIHZhbGlkIHVudGlsIHRoZSBjdXJyZW50IHRocmVhZCBjYWxscyBz aHV0ZG93bi4KIFdFQktJVF9FWFBPUlQgdm9pZCBpbml0aWFsaXplKFdlYktpdFBsYXRmb3JtU3Vw cG9ydCopOwogCisvLyBNdXN0IGJlIGNhbGxlZCBvbiB0aGUgdGhyZWFkIHRoYXQgd2lsbCBiZSB0 aGUgbWFpbiBXZWJLaXQgdGhyZWFkIGJlZm9yZQorLy8gdXNpbmcgYW55IG90aGVyIFdlYktpdCBB UElzLiBUaGUgcHJvdmlkZWQgV2ViS2l0UGxhdGZvcm1TdXBwb3J0OyBtdXN0IGJlCisvLyBub24t bnVsbCBhbmQgbXVzdCByZW1haW4gdmFsaWQgdW50aWwgdGhlIGN1cnJlbnQgdGhyZWFkIGNhbGxz IHNodXRkb3duLgorLy8KKy8vIFRoaXMgaXMgYSBzcGVjaWFsIHZhcmlhbnQgb2YgaW5pdGlhbGl6 ZSB0aGF0IGRvZXMgbm90IGludGl0aWFsaXplIFY4LgorV0VCS0lUX0VYUE9SVCB2b2lkIGluaXRp YWxpemVXaXRob3V0VjgoV2ViS2l0UGxhdGZvcm1TdXBwb3J0Kik7CisKIC8vIE9uY2Ugc2h1dGRv d24sIHRoZSBXZWJLaXRQbGF0Zm9ybVN1cHBvcnQgcGFzc2VkIHRvIGluaXRpYWxpemUgd2lsbCBu byBsb25nZXIKIC8vIGJlIGFjY2Vzc2VkLiBObyBvdGhlciBXZWJLaXQgb2JqZWN0cyBzaG91bGQg YmUgaW4gdXNlIHdoZW4gdGhpcyBmdW5jdGlvbiBpcwogLy8gY2FsbGVkLiBBbnkgYmFja2dyb3Vu ZCB0aHJlYWRzIGNyZWF0ZWQgYnkgV2ViS2l0IGFyZSBwcm9taXNlZCB0byBiZQpkaWZmIC0tZ2l0 IGEvU291cmNlL1dlYktpdC9jaHJvbWl1bS9zcmMvV2ViS2l0LmNwcCBiL1NvdXJjZS9XZWJLaXQv Y2hyb21pdW0vc3JjL1dlYktpdC5jcHAKaW5kZXggNmE0ZDdkNC4uNDIzYzQ1YSAxMDA2NDQKLS0t IGEvU291cmNlL1dlYktpdC9jaHJvbWl1bS9zcmMvV2ViS2l0LmNwcAorKysgYi9Tb3VyY2UvV2Vi S2l0L2Nocm9taXVtL3NyYy9XZWJLaXQuY3BwCkBAIC02OCw2ICs2OCwxNSBAQCBzdGF0aWMgYm9v bCBnZW5lcmF0ZUVudHJvcHkodW5zaWduZWQgY2hhciogYnVmZmVyLCBzaXplX3QgbGVuZ3RoKQog CiB2b2lkIGluaXRpYWxpemUoV2ViS2l0UGxhdGZvcm1TdXBwb3J0KiB3ZWJLaXRQbGF0Zm9ybVN1 cHBvcnQpCiB7CisgICAgaW5pdGlhbGl6ZVdpdGhvdXRWOCh3ZWJLaXRQbGF0Zm9ybVN1cHBvcnQp OworCisgICAgdjg6OlY4OjpTZXRFbnRyb3B5U291cmNlKCZnZW5lcmF0ZUVudHJvcHkpOworICAg IHY4OjpWODo6SW5pdGlhbGl6ZSgpOworICAgIFdlYkNvcmU6OlY4QmluZGluZ1Blcklzb2xhdGVE YXRhOjplbnN1cmVJbml0aWFsaXplZCh2ODo6SXNvbGF0ZTo6R2V0Q3VycmVudCgpKTsKK30KKwor dm9pZCBpbml0aWFsaXplV2l0aG91dFY4KFdlYktpdFBsYXRmb3JtU3VwcG9ydCogd2ViS2l0UGxh dGZvcm1TdXBwb3J0KQorewogICAgIEFTU0VSVCghc193ZWJLaXRJbml0aWFsaXplZCk7CiAgICAg c193ZWJLaXRJbml0aWFsaXplZCA9IHRydWU7CiAKQEAgLTg4LDExICs5NywxMCBAQCB2b2lkIGlu aXRpYWxpemUoV2ViS2l0UGxhdGZvcm1TdXBwb3J0KiB3ZWJLaXRQbGF0Zm9ybVN1cHBvcnQpCiAg ICAgLy8gdGhpcywgaW5pdGlhbGl6aW5nIHRoaXMgbGF6aWx5IHByb2JhYmx5IGRvZXNuJ3QgYnV5 IHVzIG11Y2guCiAgICAgV2ViQ29yZTo6VVRGOEVuY29kaW5nKCk7CiAKLSAgICB2ODo6Vjg6OlNl dEVudHJvcHlTb3VyY2UoJmdlbmVyYXRlRW50cm9weSk7Ci0gICAgdjg6OlY4OjpJbml0aWFsaXpl KCk7Ci0gICAgV2ViQ29yZTo6VjhCaW5kaW5nUGVySXNvbGF0ZURhdGE6OmVuc3VyZUluaXRpYWxp emVkKHY4OjpJc29sYXRlOjpHZXRDdXJyZW50KCkpOworIAogfQogCisKIHZvaWQgc2h1dGRvd24o KQogewogICAgIHNfd2ViS2l0UGxhdGZvcm1TdXBwb3J0ID0gMDsK