67711 2011-09-07 08:44:41 -0700 Web Inspector: [REGRESSION] Clear console shortcut Ctrl + L broken 2011-09-27 09:39:50 -0700 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 apavlov apavlov apavlov bweinstein joepeck keishi loislo mamacdon pfeldman pmuellr rik timothy yurys oldest_to_newest 463368 0 apavlov 2011-09-07 08:44:41 -0700 This was regressed in r93769. Patch to follow 463374 1 apavlov 2011-09-07 09:08:56 -0700 Upstreaming http://code.google.com/p/chromium/issues/detail?id=95495 463376 2 106590 apavlov 2011-09-07 09:10:00 -0700 Created attachment 106590 [PATCH] Suggested fix 463913 3 106590 yurys 2011-09-07 23:44:27 -0700 Comment on attachment 106590 [PATCH] Suggested fix View in context: https://bugs.webkit.org/attachment.cgi?id=106590&action=review > Source/WebCore/inspector/front-end/ConsoleView.js:495 > this._shortcuts[shortcutK.key].isMacOnly = true; I'd suggest you get rid of the isMacOnly flag and set this handler only if current platform is Mac, this way you'll be able to share the handler. 463920 4 apavlov 2011-09-07 23:59:21 -0700 (In reply to comment #3) > (From update of attachment 106590 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=106590&action=review > > > Source/WebCore/inspector/front-end/ConsoleView.js:495 > > this._shortcuts[shortcutK.key].isMacOnly = true; > > I'd suggest you get rid of the isMacOnly flag and set this handler only if current platform is Mac, this way you'll be able to share the handler. Does it make sense to have the isMacOnly flag at all? Can't believe it's the only instance of its usage... 463958 5 106712 apavlov 2011-09-08 02:10:51 -0700 Created attachment 106712 [PATCH] Comments addressed 464022 6 apavlov 2011-09-08 06:57:42 -0700 Committed r94758: <http://trac.webkit.org/changeset/94758> 473993 7 pfeldman 2011-09-27 09:39:50 -0700 *** Bug 68907 has been marked as a duplicate of this bug. *** 106590 2011-09-07 09:10:00 -0700 2011-09-08 02:10:51 -0700 [PATCH] Suggested fix clearconsole.patch text/plain 2634 apavlov Y29tbWl0IGYxZjU0Y2ZiOWMxN2E4OGQ2ZDY4YTBiODM3MDkzYmM0ZDI3NzQ0N2EKQXV0aG9yOiBB bGV4YW5kZXIgUGF2bG92IDxhcGF2bG92QGNocm9taXVtLm9yZz4KRGF0ZTogICBXZWQgU2VwIDcg MTk6NDk6MDIgMjAxMSArMDQwMAoKICAgIEZpeAoKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3Jl L0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCBiNGExMmE3Li5mYjNj NzNlIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dl YkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDUgKzEsMTYgQEAKIDIwMTEtMDktMDcgIEFsZXhhbmRlciBQ YXZsb3YgIDxhcGF2bG92QGNocm9taXVtLm9yZz4KIAorICAgICAgICBXZWIgSW5zcGVjdG9yOiBD bGVhciBjb25zb2xlIHNob3J0Y3V0IEN0cmwgKyBMIGJyb2tlbgorICAgICAgICBodHRwczovL2J1 Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9Njc3MTEKKworICAgICAgICBSZXZpZXdlZCBi eSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIGluc3BlY3Rvci9mcm9udC1lbmQvQ29uc29s ZVZpZXcuanM6CisgICAgICAgIChXZWJJbnNwZWN0b3IuQ29uc29sZVZpZXcucHJvdG90eXBlLl9j b25zb2xlQ2xlYXJlZCk6CisgICAgICAgIChXZWJJbnNwZWN0b3IuQ29uc29sZVZpZXcucHJvdG90 eXBlLl9yZWdpc3RlclNob3J0Y3V0cyk6CisKKzIwMTEtMDktMDcgIEFsZXhhbmRlciBQYXZsb3Yg IDxhcGF2bG92QGNocm9taXVtLm9yZz4KKwogICAgICAgICBXZWIgSW5zcGVjdG9yOiBJbXBsZW1l bnQgY2lyY3VsYXIgdGFiYmluZyB0aHJvdWdoIHRoZSBTdHlsZXMgc2lkZWJhciBwYW5lIGNvbnRl bnRzCiAgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD02NzEy NwogCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQtZW5kL0NvbnNv bGVWaWV3LmpzIGIvU291cmNlL1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250LWVuZC9Db25zb2xlVmll dy5qcwppbmRleCBkMzg0ZGZkLi4yYTQxZDY0IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9p bnNwZWN0b3IvZnJvbnQtZW5kL0NvbnNvbGVWaWV3LmpzCisrKyBiL1NvdXJjZS9XZWJDb3JlL2lu c3BlY3Rvci9mcm9udC1lbmQvQ29uc29sZVZpZXcuanMKQEAgLTI5OSw3ICsyOTksNyBAQCBXZWJJ bnNwZWN0b3IuQ29uc29sZVZpZXcucHJvdG90eXBlID0gewogCiAgICAgICAgIGRlbGV0ZSB0aGlz LmNvbW1hbmRTaW5jZVByZXZpb3VzTWVzc2FnZTsKICAgICAgICAgZGVsZXRlIHRoaXMucHJldmlv dXNNZXNzYWdlOwotICAgICAgICAKKwogICAgICAgICB0aGlzLmRpc3BhdGNoRXZlbnRUb0xpc3Rl bmVycyhXZWJJbnNwZWN0b3IuQ29uc29sZVZpZXcuRXZlbnRzLkNvbnNvbGVDbGVhcmVkKTsKICAg ICB9LAogCkBAIC00OTAsMTMgKzQ5MCwxMiBAQCBXZWJJbnNwZWN0b3IuQ29uc29sZVZpZXcucHJv dG90eXBlID0gewogCiAgICAgICAgIHZhciBzaG9ydGN1dCA9IFdlYkluc3BlY3Rvci5LZXlib2Fy ZFNob3J0Y3V0OwogICAgICAgICB2YXIgc2hvcnRjdXRLID0gc2hvcnRjdXQubWFrZURlc2NyaXB0 b3IoImsiLCBXZWJJbnNwZWN0b3IuS2V5Ym9hcmRTaG9ydGN1dC5Nb2RpZmllcnMuTWV0YSk7Ci0g ICAgICAgIC8vIFRoaXMgY2FzZSByZXF1aXJlcyBhIHNlcGFyYXRlIGJvdW5kIGZ1bmN0aW9uIGFz IGl0cyBpc01hY09ubHkgcHJvcGVydHkgc2hvdWxkIG5vdCBiZSBzaGFyZWQgYW1vbmcgZGlmZmVy ZW50IHNob3J0Y3V0IGhhbmRsZXJzLgotICAgICAgICB2YXIgY2xlYXJDb25zb2xlSGFuZGxlciA9 IHRoaXMuX3JlcXVlc3RDbGVhck1lc3NhZ2VzLmJpbmQodGhpcyk7Ci0gICAgICAgIHRoaXMuX3No b3J0Y3V0c1tzaG9ydGN1dEsua2V5XSA9IGNsZWFyQ29uc29sZUhhbmRsZXI7CisgICAgICAgIC8v IEJVRzY3NzExOiBETyBOT1QgRVhUUkFDVCBMT0NBTCBWQVJJQUJMRSBGT1IgdGhpcy5fcmVxdWVz dENsZWFyTWVzc2FnZXMuYmluZCh0aGlzKSAtLSBCUkVBS1MgQ3RybC1MIE9OIE5PTi1NQUNTLgor ICAgICAgICB0aGlzLl9zaG9ydGN1dHNbc2hvcnRjdXRLLmtleV0gPSB0aGlzLl9yZXF1ZXN0Q2xl YXJNZXNzYWdlcy5iaW5kKHRoaXMpOwogICAgICAgICB0aGlzLl9zaG9ydGN1dHNbc2hvcnRjdXRL LmtleV0uaXNNYWNPbmx5ID0gdHJ1ZTsKIAogICAgICAgICB2YXIgc2hvcnRjdXRMID0gc2hvcnRj dXQubWFrZURlc2NyaXB0b3IoImwiLCBXZWJJbnNwZWN0b3IuS2V5Ym9hcmRTaG9ydGN1dC5Nb2Rp ZmllcnMuQ3RybCk7Ci0gICAgICAgIHRoaXMuX3Nob3J0Y3V0c1tzaG9ydGN1dEwua2V5XSA9IGNs ZWFyQ29uc29sZUhhbmRsZXI7CisgICAgICAgIHRoaXMuX3Nob3J0Y3V0c1tzaG9ydGN1dEwua2V5 XSA9IHRoaXMuX3JlcXVlc3RDbGVhck1lc3NhZ2VzLmJpbmQodGhpcyk7CiAKICAgICAgICAgdmFy IHNlY3Rpb24gPSBXZWJJbnNwZWN0b3Iuc2hvcnRjdXRzU2NyZWVuLnNlY3Rpb24oV2ViSW5zcGVj dG9yLlVJU3RyaW5nKCJDb25zb2xlIikpOwogICAgICAgICB2YXIga2V5cyA9IFdlYkluc3BlY3Rv ci5pc01hYygpID8gWyBzaG9ydGN1dEsubmFtZSwgc2hvcnRjdXRMLm5hbWUgXSA6IFsgc2hvcnRj dXRMLm5hbWUgXTsK 106712 2011-09-08 02:10:51 -0700 2011-09-08 06:57:04 -0700 [PATCH] Comments addressed clearconsole.patch text/plain 3224 apavlov Y29tbWl0IGM5OWM5YWJjY2FmOWQxNTVhNzYzYTMzODU4MWQ5MDYxYWZmZTA0YzkKQXV0aG9yOiBB bGV4YW5kZXIgUGF2bG92IDxhcGF2bG92QGNocm9taXVtLm9yZz4KRGF0ZTogICBXZWQgU2VwIDcg MTk6NDk6MDIgMjAxMSArMDQwMAoKICAgIEZpeAoKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3Jl L0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCBiNGExMmE3Li5hYWQ2 MWIzIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dl YkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTUgQEAKKzIwMTEtMDktMDggIEFsZXhhbmRlciBQ YXZsb3YgIDxhcGF2bG92QGNocm9taXVtLm9yZz4KKworICAgICAgICBXZWIgSW5zcGVjdG9yOiBb UkVHUkVTU0lPTl0gQ2xlYXIgY29uc29sZSBzaG9ydGN1dCBDdHJsICsgTCBicm9rZW4KKyAgICAg ICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTY3NzExCisKKyAgICAg ICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBpbnNwZWN0b3IvZnJv bnQtZW5kL0NvbnNvbGVWaWV3LmpzOgorICAgICAgICAoV2ViSW5zcGVjdG9yLkNvbnNvbGVWaWV3 LnByb3RvdHlwZS5fY29uc29sZUNsZWFyZWQpOgorICAgICAgICAoV2ViSW5zcGVjdG9yLkNvbnNv bGVWaWV3LnByb3RvdHlwZS5fcmVnaXN0ZXJTaG9ydGN1dHMpOgorICAgICAgICAoV2ViSW5zcGVj dG9yLkNvbnNvbGVWaWV3LnByb3RvdHlwZS5fcHJvbXB0S2V5RG93bik6CisKIDIwMTEtMDktMDcg IEFsZXhhbmRlciBQYXZsb3YgIDxhcGF2bG92QGNocm9taXVtLm9yZz4KIAogICAgICAgICBXZWIg SW5zcGVjdG9yOiBJbXBsZW1lbnQgY2lyY3VsYXIgdGFiYmluZyB0aHJvdWdoIHRoZSBTdHlsZXMg c2lkZWJhciBwYW5lIGNvbnRlbnRzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0 b3IvZnJvbnQtZW5kL0NvbnNvbGVWaWV3LmpzIGIvU291cmNlL1dlYkNvcmUvaW5zcGVjdG9yL2Zy b250LWVuZC9Db25zb2xlVmlldy5qcwppbmRleCBkMzg0ZGZkLi41ZmQzZDhmIDEwMDY0NAotLS0g YS9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQtZW5kL0NvbnNvbGVWaWV3LmpzCisrKyBi L1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9mcm9udC1lbmQvQ29uc29sZVZpZXcuanMKQEAgLTI5 OSw3ICsyOTksNyBAQCBXZWJJbnNwZWN0b3IuQ29uc29sZVZpZXcucHJvdG90eXBlID0gewogCiAg ICAgICAgIGRlbGV0ZSB0aGlzLmNvbW1hbmRTaW5jZVByZXZpb3VzTWVzc2FnZTsKICAgICAgICAg ZGVsZXRlIHRoaXMucHJldmlvdXNNZXNzYWdlOwotICAgICAgICAKKwogICAgICAgICB0aGlzLmRp c3BhdGNoRXZlbnRUb0xpc3RlbmVycyhXZWJJbnNwZWN0b3IuQ29uc29sZVZpZXcuRXZlbnRzLkNv bnNvbGVDbGVhcmVkKTsKICAgICB9LAogCkBAIC00ODksMTQgKzQ4OSwxNCBAQCBXZWJJbnNwZWN0 b3IuQ29uc29sZVZpZXcucHJvdG90eXBlID0gewogICAgICAgICB0aGlzLl9zaG9ydGN1dHMgPSB7 fTsKIAogICAgICAgICB2YXIgc2hvcnRjdXQgPSBXZWJJbnNwZWN0b3IuS2V5Ym9hcmRTaG9ydGN1 dDsKLSAgICAgICAgdmFyIHNob3J0Y3V0SyA9IHNob3J0Y3V0Lm1ha2VEZXNjcmlwdG9yKCJrIiwg V2ViSW5zcGVjdG9yLktleWJvYXJkU2hvcnRjdXQuTW9kaWZpZXJzLk1ldGEpOwotICAgICAgICAv LyBUaGlzIGNhc2UgcmVxdWlyZXMgYSBzZXBhcmF0ZSBib3VuZCBmdW5jdGlvbiBhcyBpdHMgaXNN YWNPbmx5IHByb3BlcnR5IHNob3VsZCBub3QgYmUgc2hhcmVkIGFtb25nIGRpZmZlcmVudCBzaG9y dGN1dCBoYW5kbGVycy4KLSAgICAgICAgdmFyIGNsZWFyQ29uc29sZUhhbmRsZXIgPSB0aGlzLl9y ZXF1ZXN0Q2xlYXJNZXNzYWdlcy5iaW5kKHRoaXMpOwotICAgICAgICB0aGlzLl9zaG9ydGN1dHNb c2hvcnRjdXRLLmtleV0gPSBjbGVhckNvbnNvbGVIYW5kbGVyOwotICAgICAgICB0aGlzLl9zaG9y dGN1dHNbc2hvcnRjdXRLLmtleV0uaXNNYWNPbmx5ID0gdHJ1ZTsKKworICAgICAgICBpZiAoV2Vi SW5zcGVjdG9yLmlzTWFjKCkpIHsKKyAgICAgICAgICAgIHZhciBzaG9ydGN1dEsgPSBzaG9ydGN1 dC5tYWtlRGVzY3JpcHRvcigiayIsIFdlYkluc3BlY3Rvci5LZXlib2FyZFNob3J0Y3V0Lk1vZGlm aWVycy5NZXRhKTsKKyAgICAgICAgICAgIHRoaXMuX3Nob3J0Y3V0c1tzaG9ydGN1dEsua2V5XSA9 IHRoaXMuX3JlcXVlc3RDbGVhck1lc3NhZ2VzLmJpbmQodGhpcyk7CisgICAgICAgIH0KIAogICAg ICAgICB2YXIgc2hvcnRjdXRMID0gc2hvcnRjdXQubWFrZURlc2NyaXB0b3IoImwiLCBXZWJJbnNw ZWN0b3IuS2V5Ym9hcmRTaG9ydGN1dC5Nb2RpZmllcnMuQ3RybCk7Ci0gICAgICAgIHRoaXMuX3No b3J0Y3V0c1tzaG9ydGN1dEwua2V5XSA9IGNsZWFyQ29uc29sZUhhbmRsZXI7CisgICAgICAgIHRo aXMuX3Nob3J0Y3V0c1tzaG9ydGN1dEwua2V5XSA9IHRoaXMuX3JlcXVlc3RDbGVhck1lc3NhZ2Vz LmJpbmQodGhpcyk7CiAKICAgICAgICAgdmFyIHNlY3Rpb24gPSBXZWJJbnNwZWN0b3Iuc2hvcnRj dXRzU2NyZWVuLnNlY3Rpb24oV2ViSW5zcGVjdG9yLlVJU3RyaW5nKCJDb25zb2xlIikpOwogICAg ICAgICB2YXIga2V5cyA9IFdlYkluc3BlY3Rvci5pc01hYygpID8gWyBzaG9ydGN1dEsubmFtZSwg c2hvcnRjdXRMLm5hbWUgXSA6IFsgc2hvcnRjdXRMLm5hbWUgXTsKQEAgLTUzNywxMSArNTM3LDkg QEAgV2ViSW5zcGVjdG9yLkNvbnNvbGVWaWV3LnByb3RvdHlwZSA9IHsKICAgICAgICAgdmFyIHNo b3J0Y3V0ID0gV2ViSW5zcGVjdG9yLktleWJvYXJkU2hvcnRjdXQubWFrZUtleUZyb21FdmVudChl dmVudCk7CiAgICAgICAgIHZhciBoYW5kbGVyID0gdGhpcy5fc2hvcnRjdXRzW3Nob3J0Y3V0XTsK ICAgICAgICAgaWYgKGhhbmRsZXIpIHsKLSAgICAgICAgICAgIGlmICghdGhpcy5fc2hvcnRjdXRz W3Nob3J0Y3V0XS5pc01hY09ubHkgfHwgV2ViSW5zcGVjdG9yLmlzTWFjKCkpIHsKLSAgICAgICAg ICAgICAgICBoYW5kbGVyKCk7Ci0gICAgICAgICAgICAgICAgZXZlbnQucHJldmVudERlZmF1bHQo KTsKLSAgICAgICAgICAgICAgICByZXR1cm47Ci0gICAgICAgICAgICB9CisgICAgICAgICAgICBo YW5kbGVyKCk7CisgICAgICAgICAgICBldmVudC5wcmV2ZW50RGVmYXVsdCgpOworICAgICAgICAg ICAgcmV0dXJuOwogICAgICAgICB9CiAgICAgfSwKIAo=