67677 2011-09-06 15:14:01 -0700 offsetFromRoot optimization is disabled after r93837 2011-09-07 18:37:43 -0700 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 jchaffraix jchaffraix jamesr simon.fraser webkit.review.bot oldest_to_newest 462892 0 jchaffraix 2011-09-06 15:14:01 -0700 I perf-tested a previous patch (which prompted the importance of passing the argument to computeRepaintRect) but the patch that landed disabled the optimization! This mistake basically re-introduce a O(n^2) in updateLayerPositions that the optimization was preventing. 462935 1 106502 jchaffraix 2011-09-06 15:40:38 -0700 Created attachment 106502 Trivial fix: Readd the parameter (that should NEVER have gone), unfortunately no test. 463599 2 106502 jchaffraix 2011-09-07 13:08:42 -0700 Comment on attachment 106502 Trivial fix: Readd the parameter (that should NEVER have gone), unfortunately no test. Thanks Simon! 463806 3 jchaffraix 2011-09-07 18:37:43 -0700 Committed r94741: <http://trac.webkit.org/changeset/94741> 106502 2011-09-06 15:40:38 -0700 2011-09-07 13:08:42 -0700 Trivial fix: Readd the parameter (that should NEVER have gone), unfortunately no test. bug-67677-20110906154037.patch text/plain 4124 jchaffraix U3VidmVyc2lvbiBSZXZpc2lvbjogOTQ1NzIKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCBkOWZhYjBiOGNkN2IzMmJk NDIyODQ4MTI5NzZjOGVlZWYyMGE4NzFlLi4yMjlhZTE4MWU0MDg1ZjVmY2UzOTNjYzUwMjk0MjFj Nzg3MTQyZTFmIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvU291 cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjMgQEAKKzIwMTEtMDktMDYgIEp1bGll biBDaGFmZnJhaXggIDxqY2hhZmZyYWl4QHdlYmtpdC5vcmc+CisKKyAgICAgICAgb2Zmc2V0RnJv bVJvb3Qgb3B0aW1pemF0aW9uIGlzIGRpc2FibGVkIGFmdGVyIHI5MzgzNworICAgICAgICBodHRw czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9Njc2NzcKKworICAgICAgICBSZXZp ZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBVbmZvcnR1bmF0ZWx5IG5vdCBjb3Zl cmVkIGJ5IGFueSB0ZXN0IGFzIGl0IGRvZXMgbm90IGNoYW5nZSB1cGRhdGVMYXllclBvc2l0aW9u IGNvbXBsZXhpdHkgKGl0IGlzIHN0aWxsIE8obl4yKQorICAgICAgICBiZWNhdXNlIG9mIGNsaXBw ZWRPdmVyZmxvd1JlY3RGb3JSZXBhaW50KS4gSG93ZXZlciBpdCBpcyBhIG5vdGljZWFibGUgc2xv d2Rvd24gb24gc29tZSB1c2UgY2FzZXMgYnV0IHdlIGRvbid0CisgICAgICAgIGhhdmUgYSBnb29k IHRlc3QgaGFybmVzcyB0byBjb3ZlciBzdWNoIHNsb3dkb3duLgorCisgICAgICAgICogcmVuZGVy aW5nL1JlbmRlckxheWVyLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlJlbmRlckxheWVyOjp1cGRh dGVMYXllclBvc2l0aW9ucyk6IFBhc3Mgb2Zmc2V0RnJvbVJvb3QgYXMgbm90IGRvaW5nIHNvIG1l YW5zIHRoYXQgd2UgbWlzcworICAgICAgICB0aGUgb3B0aW1pemF0aW9uIGFsdG9nZXRoZXIuCisK KyAgICAgICAgKFdlYkNvcmU6OlJlbmRlckxheWVyOjpjb21wdXRlUmVwYWludFJlY3RzKToKKyAg ICAgICAgKFdlYkNvcmU6OlJlbmRlckxheWVyOjp1cGRhdGVMYXllclBvc2l0aW9uc0FmdGVyU2Ny b2xsKToKKyAgICAgICAgKiByZW5kZXJpbmcvUmVuZGVyTGF5ZXIuaDoKKyAgICAgICAgUmVuYW1l ZCB8Y2FjaGVkT2Zmc2V0fCB0byB8b2Zmc2V0RnJvbVJvb3R8IHRvIGJlIGNvbnNpc3RlbnQgd2l0 aCBvdXIgbGF0ZXN0IHJlbmFtaW5nLgorCiAyMDExLTA5LTA1ICBQYXZlbCBQb2Rpdmlsb3YgIDxw b2Rpdmlsb3ZAY2hyb21pdW0ub3JnPgogCiAgICAgICAgIFdlYiBJbnNwZWN0b3I6IHJlLWltcGxl bWVudCBSYXdTb3VyY2VDb2RlLgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5n L1JlbmRlckxheWVyLmNwcCBiL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJMYXllci5j cHAKaW5kZXggOWUwNDE0NjkwYTk0ZGNhYWQwNmNkZmE3NzIxY2Y4MDUxMGY4YzY1ZC4uNzcyMjZi ZTc2ZGRmMzZkOTkxZGJhNGUyNjNjMzQwYmEyMTg3NjcxOCAxMDA2NDQKLS0tIGEvU291cmNlL1dl YkNvcmUvcmVuZGVyaW5nL1JlbmRlckxheWVyLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9yZW5k ZXJpbmcvUmVuZGVyTGF5ZXIuY3BwCkBAIC0zNDEsNyArMzQxLDcgQEAgdm9pZCBSZW5kZXJMYXll cjo6dXBkYXRlTGF5ZXJQb3NpdGlvbnMoTGF5b3V0UG9pbnQqIG9mZnNldEZyb21Sb290LCBVcGRh dGVMYXllclAKICAgICAgICAgUmVuZGVyQm94TW9kZWxPYmplY3QqIHJlcGFpbnRDb250YWluZXIg PSByZW5kZXJlcigpLT5jb250YWluZXJGb3JSZXBhaW50KCk7CiAgICAgICAgIEludFJlY3Qgb2xk UmVwYWludFJlY3QgPSBtX3JlcGFpbnRSZWN0OwogICAgICAgICBJbnRSZWN0IG9sZE91dGxpbmVC b3ggPSBtX291dGxpbmVCb3g7Ci0gICAgICAgIGNvbXB1dGVSZXBhaW50UmVjdHMoKTsKKyAgICAg ICAgY29tcHV0ZVJlcGFpbnRSZWN0cyhvZmZzZXRGcm9tUm9vdCk7CiAgICAgICAgIC8vIEZJWE1F OiBTaG91bGQgQVNTRVJUIHRoYXQgdmFsdWUgY2FsY3VsYXRlZCBmb3IgbV9vdXRsaW5lQm94IHVz aW5nIHRoZSBjYWNoZWQgb2Zmc2V0IGlzIHRoZSBzYW1lCiAgICAgICAgIC8vIGFzIHRoZSB2YWx1 ZSBub3QgdXNpbmcgdGhlIGNhY2hlZCBvZmZzZXQsIGJ1dCB3ZSBjYW4ndCBkdWUgdG8gaHR0cHM6 Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTM3MDQ4CiAgICAgICAgIGlmIChmbGFn cyAmIENoZWNrRm9yUmVwYWludCkgewpAQCAtMzk3LDE0ICszOTcsMTQgQEAgTGF5b3V0UmVjdCBS ZW5kZXJMYXllcjo6cmVwYWludFJlY3RJbmNsdWRpbmdEZXNjZW5kYW50cygpIGNvbnN0CiAgICAg cmV0dXJuIHJlcGFpbnRSZWN0OwogfQogCi12b2lkIFJlbmRlckxheWVyOjpjb21wdXRlUmVwYWlu dFJlY3RzKEludFBvaW50KiBjYWNoZWRPZmZzZXQpCit2b2lkIFJlbmRlckxheWVyOjpjb21wdXRl UmVwYWludFJlY3RzKEludFBvaW50KiBvZmZzZXRGcm9tUm9vdCkKIHsKICAgICBBU1NFUlQobV9o YXNWaXNpYmxlQ29udGVudCk7CiAgICAgQVNTRVJUKCFtX3Zpc2libGVDb250ZW50U3RhdHVzRGly dHkpOwogCiAgICAgUmVuZGVyQm94TW9kZWxPYmplY3QqIHJlcGFpbnRDb250YWluZXIgPSByZW5k ZXJlcigpLT5jb250YWluZXJGb3JSZXBhaW50KCk7CiAgICAgbV9yZXBhaW50UmVjdCA9IHJlbmRl cmVyKCktPmNsaXBwZWRPdmVyZmxvd1JlY3RGb3JSZXBhaW50KHJlcGFpbnRDb250YWluZXIpOwot ICAgIG1fb3V0bGluZUJveCA9IHJlbmRlcmVyKCktPm91dGxpbmVCb3VuZHNGb3JSZXBhaW50KHJl cGFpbnRDb250YWluZXIsIGNhY2hlZE9mZnNldCk7CisgICAgbV9vdXRsaW5lQm94ID0gcmVuZGVy ZXIoKS0+b3V0bGluZUJvdW5kc0ZvclJlcGFpbnQocmVwYWludENvbnRhaW5lciwgb2Zmc2V0RnJv bVJvb3QpOwogfQogCiB2b2lkIFJlbmRlckxheWVyOjpjbGVhclJlcGFpbnRSZWN0cygpCkBAIC00 MjksNyArNDI5LDcgQEAgdm9pZCBSZW5kZXJMYXllcjo6dXBkYXRlTGF5ZXJQb3NpdGlvbnNBZnRl clNjcm9sbChib29sIGZpeGVkKQogICAgIHVwZGF0ZUxheWVyUG9zaXRpb24oKTsKIAogICAgIGlm IChmaXhlZCB8fCByZW5kZXJlcigpLT5zdHlsZSgpLT5wb3NpdGlvbigpID09IEZpeGVkUG9zaXRp b24pIHsKLSAgICAgICAgLy8gRklYTUU6IElzIGl0IHdvcnRoIHBhc3NpbmcgdGhlIGNhY2hlZE9m ZnNldCBhcm91bmQgbGlrZSBpbiB1cGRhdGVMYXllclBvc2l0aW9ucz8KKyAgICAgICAgLy8gRklY TUU6IElzIGl0IHdvcnRoIHBhc3NpbmcgdGhlIG9mZnNldEZyb21Sb290IGFyb3VuZCBsaWtlIGlu IHVwZGF0ZUxheWVyUG9zaXRpb25zPwogICAgICAgICBjb21wdXRlUmVwYWludFJlY3RzKCk7CiAg ICAgICAgIGZpeGVkID0gdHJ1ZTsKICAgICB9IGVsc2UgaWYgKHJlbmRlcmVyKCktPmhhc1RyYW5z Zm9ybSgpICYmICFyZW5kZXJlcigpLT5pc1JlbmRlclZpZXcoKSkgewpkaWZmIC0tZ2l0IGEvU291 cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckxheWVyLmggYi9Tb3VyY2UvV2ViQ29yZS9yZW5k ZXJpbmcvUmVuZGVyTGF5ZXIuaAppbmRleCA2NGZiOTZiNjQ4NGM4MjA1YjdiODg0YTdjZTI4YjNl MzNhMzZhZWJkLi5mNTU5N2NkOTNjMWViYjA0MzAxZWZiZDNiMDc4NjlkNTk1ZWRjNmY2IDEwMDY0 NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyTGF5ZXIuaAorKysgYi9Tb3Vy Y2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyTGF5ZXIuaApAQCAtNDY3LDcgKzQ2Nyw3IEBAIHB1 YmxpYzoKICAgICB2b2lkIHNldENvbnRhaW5zRGlydHlPdmVybGF5U2Nyb2xsYmFycyhib29sIGRp cnR5U2Nyb2xsYmFycykgeyBtX2NvbnRhaW5zRGlydHlPdmVybGF5U2Nyb2xsYmFycyA9IGRpcnR5 U2Nyb2xsYmFyczsgfQogCiBwcml2YXRlOgotICAgIHZvaWQgY29tcHV0ZVJlcGFpbnRSZWN0cyhJ bnRQb2ludCogY2FjaGVkT2Zmc2V0ID0gMCk7CisgICAgdm9pZCBjb21wdXRlUmVwYWludFJlY3Rz KEludFBvaW50KiBvZmZzZXRGcm9tUm9vdCA9IDApOwogICAgIHZvaWQgY2xlYXJSZXBhaW50UmVj dHMoKTsKIAogICAgIC8vIFRoZSBub3JtYWwgb3BlcmF0b3IgbmV3IGlzIGRpc2FsbG93ZWQgb24g YWxsIHJlbmRlciBvYmplY3RzLgo=